From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4865C41BE9; Mon, 6 Feb 2023 11:06:25 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2342B40FAE; Mon, 6 Feb 2023 11:06:25 +0100 (CET) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id 93E2D40A7A; Mon, 6 Feb 2023 11:06:22 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1675677982; x=1707213982; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=l4HoJweVo0XaAVO6Kv5hD2XrDuX7R3ZNuEfTqtdcrDs=; b=MlUUbwboTadMZyyFK+t2NO1Tthhp9j+4suFAQ1bwXoxxLlRRiB64y+EV cqYkVqPsr9rT3Bv1h1ce5qlH7LVvbCWqIFOTf9XtjwQQEVUK4e6AzWnk+ VCguwqQVE6k0ld10+hOyLyCHMBjmR24x7vQfjSgeP7KWyw++bXCODVHPn r76ixW/qW5HeeT0YKGHweGsUxiTDeunngUcOZifH6BTIoMwI67hzOgvLt l8AVvdAA7ItYIbm3AIt2ifNockjoCkuJ3yNbOE5Iv1Kh4/bBt6Ap6NAIy Xh50sGTLQEDBRgBjFZeVDrtYQY7sjKtlccXtdXi02DNK0dpA3kQncYCMm Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10612"; a="331305521" X-IronPort-AV: E=Sophos;i="5.97,276,1669104000"; d="scan'208";a="331305521" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Feb 2023 02:06:21 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10612"; a="668371927" X-IronPort-AV: E=Sophos;i="5.97,276,1669104000"; d="scan'208";a="668371927" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga007.fm.intel.com with ESMTP; 06 Feb 2023 02:06:21 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Mon, 6 Feb 2023 02:06:20 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Mon, 6 Feb 2023 02:06:20 -0800 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.171) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Mon, 6 Feb 2023 02:06:20 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iVAG2Og5jM91FRQp/tWtRBDb4TyF7+CdDtzPIbPGIsEIRYUwTrzJW8InhAZANH7mghyrXZBKAUg+x0YOv0+5j5WR/Sni/qmftaxlG1cR6gKNMo616Hk14DUf4WHrLINj77KMS5smk+Q9zuCARzRWFxlcPat3m6VJpj+S7lv6g37wPMvEHpXxETa96RVbZf0neLlPnwdFSjRDTs07TPH3hqcRMhvrtGpasEVKF5lysGfzti3ozHy9pNPx4/IL2Xh3XTrCrYaM7VzemHGx56mevoWPBJ+LGC8/F2kmZDlvfd3dcpHNIm1egobsZwWxwQ1E+sKuiY8jDbBWydvA96gcUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=l4HoJweVo0XaAVO6Kv5hD2XrDuX7R3ZNuEfTqtdcrDs=; b=WMy6j/8+HgFNUiVj+8wllHtPEaDwQNirJF4olnFJ6UWUdmbk9C/tK+dpeijUFJvpu2Jy3pjowJouZ0IAFz3yFL1rjAHjFrlfkLEXnsbVfj3p4NFq0nkmbjEnAIZJrYOtExZbV+aUMET+OHhTbMUkqDvdE/nswiddA0gubox/6ie0ER8BTUw6QN3TjEPwmT3rN2zPhkTF9AjiFhUZ5t1jb+jPLhIMgdrRW9/Js1f9g7EBhujkc8KC23t6c82Mu4HoCoB9B/pAmyUgYwH9GdxMuLyUybjn+rYQPz2CkOVq65oNIUBKI/1ThySZGZT82pwyfLB3lWqYoHufgE8i1DxHMA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SN7PR11MB7139.namprd11.prod.outlook.com (2603:10b6:806:2a2::14) by SJ0PR11MB4798.namprd11.prod.outlook.com (2603:10b6:a03:2d5::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.34; Mon, 6 Feb 2023 10:06:19 +0000 Received: from SN7PR11MB7139.namprd11.prod.outlook.com ([fe80::3c5d:f1d4:5462:8976]) by SN7PR11MB7139.namprd11.prod.outlook.com ([fe80::3c5d:f1d4:5462:8976%5]) with mapi id 15.20.6064.027; Mon, 6 Feb 2023 10:06:19 +0000 From: "Ye, MingjinX" To: Thomas Monjalon CC: "dev@dpdk.org" , "stable@dpdk.org" , "Zhou, YidingX" , "Yang, Qiming" , "Zhang, Qi Z" , "david.marchand@redhat.com" , "ferruh.yigit@amd.com" Subject: RE: [PATCH] net/ice: fix get link status timeout Thread-Topic: [PATCH] net/ice: fix get link status timeout Thread-Index: AQHZOfPYHi0nFR/HqkG0w+uLlcBBr67Bg9wAgAACDvCAAB1mAIAAA/NA Date: Mon, 6 Feb 2023 10:06:18 +0000 Message-ID: References: <20230206062239.1042172-1-mingjinx.ye@intel.com> <13196161.dW097sEU6C@thomas> <3175550.aV6nBDHxoP@thomas> In-Reply-To: <3175550.aV6nBDHxoP@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SN7PR11MB7139:EE_|SJ0PR11MB4798:EE_ x-ms-office365-filtering-correlation-id: 5b92aa35-f06b-48fa-6719-08db0829caae x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 0gbGr92IAG54dpTkzFy4z9preYW0uApmad+GvdkXVtlhXqI/yxOhXCyEeOZ+n3+wYa4x3sB1l0edUkvxhG8MNXJKRH75gWcfJhFdm16T0iSk+k75LXyF2T92Ov5k+YmHudIalLLuHQ4r3ZINprG3r9Ln+iFrQC7gKwysOARZpDIHVTl+8itymqa5B811dtrVczS7fkKf84TneaV7T0+fAQjEF44tLY9LYuL0F7YjHTUMFastLyJL+6dlTMqLEPe5gHC0h3Jn+U6XFNgMK+fLQXpUBAt0gGF3o5n+daNwnqKezC13QGW8wgxcelqGlcrZaTpvT6/OpuXPfA9VovVrfWJcRhzdgYwwDZhYmMbY0H9nxpqszaD35vDJKvjb7WwlyQVvkjBcYtV+G5HCHkK8gTh9KlvHQ/lQB7AVmBGNgR/3OEgdnilRi1oFb44tIjY0sG/e0rJGLDMoDYT2NqBEz2cge6JML5Jxaa4xJZg6kSXzOCNuLdpq4TvTcSPMLyYBhqdmsBSGuBR1fE61CO7T7kJcQ8iaHranzh03CGjIw4NJz5B2fS32XzYNZi98MBqGEPtfFme4RQttvtO0U6cOAhh691fy8mv5Ap+JdTRTH9SJQn8NnH/YU2SaLE6IRUmMLL4NLwYE2YmpDOhNGEwe7xeI2DO5vPwpwnZ3Z4xCKVnOXtfhli7lCyrNrYFTM4L0gDNEYwVqMo1g6SOFT1U8kw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN7PR11MB7139.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(39860400002)(346002)(366004)(396003)(376002)(136003)(451199018)(66476007)(76116006)(82960400001)(122000001)(38070700005)(83380400001)(66946007)(52536014)(38100700002)(5660300002)(8936002)(4326008)(41300700001)(6916009)(8676002)(66556008)(66446008)(2906002)(64756008)(9686003)(6506007)(53546011)(478600001)(186003)(26005)(54906003)(316002)(33656002)(7696005)(71200400001)(55016003)(86362001)(3714002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-2022-jp?B?dkhyRGRhbngrZXR3UXd5a2JDbVhSeDRIY2JJRWlnZUQ4Qm91TGhmL0Mw?= =?iso-2022-jp?B?Tlp3MFRxR1FpRVJ3RG15MzZoa1BVbk1PZXNmdFJEa1NleEtHQW53V2tT?= =?iso-2022-jp?B?Tjg0Z0xLays4MWc0emdIaHpTZUNsZ3pla0g5NGd2SVlRMWRxOUtiR3pl?= =?iso-2022-jp?B?S2JHVVJqVGNKamc5L0gvVW1PYnM4WWZiYjE0VWZpdVMwd0ZiRkUySm16?= =?iso-2022-jp?B?NU1pSnYrSGJFVkFheE5nbEo2SUdNTEFZNS9TSEc5OFhabnUwOUpjODMr?= =?iso-2022-jp?B?VzJZS01VRzNqNzJZWXBDa2FKRVBnN0pvd0pNS0hBc05pSmxiTWRXTHE5?= =?iso-2022-jp?B?RFJjNHovUVh2eXFRTmVlMDhjSXNWUllRUVVlelRIRTNhNFVvQmdHbFZz?= =?iso-2022-jp?B?WmdoYXlYaGNBUmhiNXc0VkJyajJiZnNXS1lONmVGU2U3YlQvaUpNYzVi?= =?iso-2022-jp?B?bmFvRFpUWDdibWFjMmRKa08venR4UzV5MHMrdVp3dzB1eCs0eEFuQVlF?= =?iso-2022-jp?B?WDFiVGtsYWlrdXhVM3pFblBINUNXTmpNQy9rRnJCbzB4Q25kVU96K1Yv?= =?iso-2022-jp?B?aE0vSVZ5V04yTGNRVW5COVNNNVFlU1lvRDFyQTVIQU5xTVkvZXB4cTk4?= =?iso-2022-jp?B?QmlaNk1KY3prOGtBSnZ1dXYvTmZCOG5VSjlCa3dZaWE2blkzRGZCQTNj?= =?iso-2022-jp?B?b0NOWWNoVDFIalZsTXpNVXFabHZvQTJlYlhoZEp4ajl6RGVPNlM3a0pr?= =?iso-2022-jp?B?L2hGcWo3Si9nZlg4K25YenplQXJ5TEZocDJXVS9ISnhsWFVVanY1RXJn?= =?iso-2022-jp?B?MzU2Q3BCVmZTcEVJMklaNkF1b2VWYStodEVPR2xqVTB3L1R1YTdHQmJB?= =?iso-2022-jp?B?QnRRS2dlaENITlkrQVJHcUhGajNGamRIamdhWGZzeFBvMlZmNjJOYm83?= =?iso-2022-jp?B?NTExOCsremtRWU0yY3JaYmRCYUp5VXBtb01TYjZHeGJNaCthQzVGWUx6?= =?iso-2022-jp?B?QUUyWk1jMUJpUm50akM0aHhOd0FxdW0vR0JWU2d6QTVaUDZRZE9JOEQy?= =?iso-2022-jp?B?Q2tlUGIzbTBrV0pLVS8zTzdKWW9samNJK2xlVGhSZmxmWjJJQUNnZGJk?= =?iso-2022-jp?B?dkkxZjA1TDlUUVJxSHpaNW9IVzVZazZ5WkZ2c0VjM3AwRVFWZDZ4M0E1?= =?iso-2022-jp?B?VldwOVp1Mlo2bGVkelQ3d1pWNnhlQmFiV3paWjhlcklBS2tPMVBwdjAx?= =?iso-2022-jp?B?a1g0bGdHVjI1VmdmelROWmJRZWpySnhYOGtadDJnRE0ybU45MDg0aUNo?= =?iso-2022-jp?B?YWk3THNWcnBsL3J2ZERxcGlKN3gzQkFJYlp6aVRVdlJ3TXRaZHh6TDZi?= =?iso-2022-jp?B?TFVsS1dOSmloZVhBcVo3bzFrY0VweE1jaUlaVlNvU2Jva0IzUEhFUXRn?= =?iso-2022-jp?B?dWY1V3pwdlpVZWJtQjFkeEVpcG94eTZ1dVZsc2lOUXIwVEZMSGFMTEZZ?= =?iso-2022-jp?B?ZGZIYXhNZUZmUG9MNVF1VmFuVUhSU2k2U05GWXpLZi96MjEwKzJpU0lH?= =?iso-2022-jp?B?TkpmZDNoVXNrVjNXSjRrc2ZVc3o3RmVtV0xwaG83bkR5TXlUb1ErVm9z?= =?iso-2022-jp?B?MmFDbjhFWWVHUGRWenFOejZycmk3WmFNeDFtaXlpLzNYYzlsS0h4SUls?= =?iso-2022-jp?B?Nk84SjhmdkUzMWFLd2RXcWVDMHFqaGM0cGdqMXhRU2tGS0ZSNEZSQ3Bs?= =?iso-2022-jp?B?dXF2c1BYRW1oNnNPbnd1SGloT05ORmdhUy9FdGduWGNCbVRMNm5Yb0dl?= =?iso-2022-jp?B?NFNxVXBoRFdoTHNGWXN4VHVZTEFodkx2cloxZnQ2Q1lkQlhNd3RrSW5q?= =?iso-2022-jp?B?RlVVSzU5QTBHdE40Nk9CbTlWaTltdU1pdVA3U0dJU0pZaXgvYW9OcFFE?= =?iso-2022-jp?B?WFFKNDQ2UDh0eC90N3VlSUhTQVU5d0YzSDhVUnlGYzVtNFE5WmxNRHgw?= =?iso-2022-jp?B?bVluQ3plekZhU2NobUdtTkF1VUVtSnlweVMrVUI5dmRvMHMzc0tsajlm?= =?iso-2022-jp?B?VHN2ZTQzS0NkMzZuQ2hNUjhTclloU0RveEdDbmJVSmdBdXEvYzhTQkpk?= =?iso-2022-jp?B?bjg2cUlDVnM4SDBtNHRFM05vOG95SWFueWluc052YnNHK0lSYWdsOFd6?= =?iso-2022-jp?B?M0k5ZWpzOWNoUklEQjRRVWpBWFYrVUcyd0xhOGhvSVlYZmNjZldDVWdW?= =?iso-2022-jp?B?VldTdEd0UkdQWlZGVlJRS2lncU5wNEVVMTFqWlJUQ2granBSODZwRm45?= =?iso-2022-jp?B?RDRLdQ==?= Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN7PR11MB7139.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5b92aa35-f06b-48fa-6719-08db0829caae X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Feb 2023 10:06:18.9852 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 7sjeJ2ZCcKTf81l7kkDrhoHzstfOEq1CsMc753NB4UJRFkTiUmxaVaXAfSRjxd81uChhmQojjHWp8FU7tSOkkg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB4798 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Thomas Monjalon > Sent: 2023=1B$BG/=1B(B2=1B$B7n=1B(B6=1B$BF|=1B(B 17:16 > To: Ye, MingjinX > Cc: dev@dpdk.org; stable@dpdk.org; Zhou, YidingX > ; Yang, Qiming ; Zhang, > Qi Z ; david.marchand@redhat.com; > ferruh.yigit@amd.com > Subject: Re: [PATCH] net/ice: fix get link status timeout >=20 > 06/02/2023 09:14, Ye, MingjinX: > > From: Thomas Monjalon > > > 06/02/2023 07:22, Mingjin Ye: > > > > When hw is just started, it will immediately obtain the link > > > > status, and the longest attempt is 1 second. Some NICs are slow to > > > > initialize, which make it fails to obtain the link status. > > > > > > > > The patch fixes this issue by modifying the longest attempt to 5 se= conds. > > > > > > What is the consequence? > > > > DPDK could not get link status. At this point, the link status > > obtained through the pmd API is wrong. > > > > > In which case, DPDK application would be blocked during 5 seconds? > > > > When the dpdk application startup port is used, it will be blocked for > > up to 5 seconds to ensure that the connection status can be obtained. >=20 > I mean what is the consequence of the increase? There will be no side effects.=20 > For example, if the port is not connected (no wire), are we going to wait= 5 > seconds? This will cause a wait of up to 5 seconds. >=20 > I guess it's OK because it won't wait at all if using rte_eth_link_get_no= wait. > It may be interesting to note in the commit message. The reason for pushing this patch is that the E823 NIC needs about 2 second= s to get the link up state when the port is started, so the waiting time need= s to be extended.=20 Modified to 5 seconds, consistent with other timeouts of DPDK. >=20