From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 09E1C42814; Wed, 29 Mar 2023 03:06:18 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EF78C40F18; Wed, 29 Mar 2023 03:06:17 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id 2808340EE7; Wed, 29 Mar 2023 03:06:15 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1680051976; x=1711587976; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=D8G1ewokAEv9Dir+bOeKNG4cuc3my/Ajg8Q35SpFCUk=; b=gJl1wTh3pc7luZAw+uDnq2DYvV8949f0wUDMP43rwNTKTM09QD+C7blc jxP40cRdcT1+iVZNycidGVu75vbXbLkQeIO+WqemB3/hZAwQjHpLn/THM nh+6bybJspbYeIZKXs5+c1htJKEw+dyW88ibs05lc19i4/v4gYHNv27Fx 78CUGCeGOUZgj91x+80yQ3nBfjB368bi/MwWAdgCUaodQpgf42HD0j8+b dOQAO60fcDhFtnhp+kE1UkNx5rmZJrTVJywu5Qr6VuzhzC3T0Dcb6Ru5d gt640TGdFOUeCKyeVaDqjJmWs4dC7mIx0tPr0Pw6rM4Oi8oKld6s6eT7x g==; X-IronPort-AV: E=McAfee;i="6600,9927,10663"; a="324639259" X-IronPort-AV: E=Sophos;i="5.98,299,1673942400"; d="scan'208";a="324639259" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Mar 2023 18:06:14 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10663"; a="661405158" X-IronPort-AV: E=Sophos;i="5.98,299,1673942400"; d="scan'208";a="661405158" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga006.jf.intel.com with ESMTP; 28 Mar 2023 18:06:14 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Tue, 28 Mar 2023 18:06:13 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Tue, 28 Mar 2023 18:06:12 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21 via Frontend Transport; Tue, 28 Mar 2023 18:06:12 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.169) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.21; Tue, 28 Mar 2023 18:05:48 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=C0VsbvHQdg0JqGm3fDViNOjDx1BoODjtMLY6CXBx/RrMH4Rn4rb95JqzHukXMsDssn0y4n/+plu82gZYcAH/jUZTO6Gx54eA4CHrCIuU4URTysgp0oqT3HYWablIEKj3v/JhP3d0X8BN3vgzfaj2kPQM+DvIA8lCbvdTmwYBgL5761154pKv81snqqcUZBjKb1tl0ihsxpxfYBkE8871xSI3TzFCdVluH46bHnDHNa858utiRdMTjFSF1yq840Nov7ONz+ZXmdFJ2dY90tx+tVmsa7oGvQ7F1fenGaCkXtaFBnYlUm+yccQauY32yZQH9qKI66Eq7bFjKlRJZV4Zag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=D8G1ewokAEv9Dir+bOeKNG4cuc3my/Ajg8Q35SpFCUk=; b=F6s9eGla2NoY5Zhkr10NNSQrHvDhv079ZCt+oMT5e+/1YhCs4d5qlrT+0AJmxDqTuIxfkjBE1I43qYcWTDAFPTFbruxJIlb1mxRSWrMXm/r6OsB7KzACMhIGfNhk8ajGuwSQ+vjoowUucL65gBBM4IpXlFDUQ3EYaIqGRxeWEBKLudLmV+sLg2AFNcCPPqBVQPDBHNiBYCrWpefdz1JtYgXeKmb9GTWiCKPkpLYSl6RpmbvFpejbdCPPsa5yBrxF1xCM8HNED50tklaGqjSyo4SIh1MXZAoA0VOuoreiK2Ezi9A8Oiz35l6OCv96MWPGroBTz3gKDCe/VcPbH7MvrQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SN7PR11MB7491.namprd11.prod.outlook.com (2603:10b6:806:349::8) by CY8PR11MB7135.namprd11.prod.outlook.com (2603:10b6:930:61::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.38; Wed, 29 Mar 2023 01:05:44 +0000 Received: from SN7PR11MB7491.namprd11.prod.outlook.com ([fe80::b387:46ee:603e:2534]) by SN7PR11MB7491.namprd11.prod.outlook.com ([fe80::b387:46ee:603e:2534%3]) with mapi id 15.20.6178.038; Wed, 29 Mar 2023 01:05:44 +0000 From: "Lu, Wenzhuo" To: mschmidt , "dev@dpdk.org" CC: "Richardson, Bruce" , Konstantin Ananyev , "Wu, Jingjing" , "Xing, Beilei" , "Rong, Leyi" , "stable@dpdk.org" Subject: RE: [PATCH] net/iavf: fix VLAN offload with AVX512 Thread-Topic: [PATCH] net/iavf: fix VLAN offload with AVX512 Thread-Index: AQHZYJQTscICsYgPlEWGUldV/W9Umq8Q89ZQ Date: Wed, 29 Mar 2023 01:05:43 +0000 Message-ID: References: <20230327100750.448859-1-mschmidt@redhat.com> In-Reply-To: <20230327100750.448859-1-mschmidt@redhat.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SN7PR11MB7491:EE_|CY8PR11MB7135:EE_ x-ms-office365-filtering-correlation-id: d2201c15-ff8f-429a-24b7-08db2ff1b8ad x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ntFyjah7N/eLscG7rZZxU/StqKbBLmsIJRhRh2RGLqSw/wjQQAJ9LOXWpmoXs+7JOwzw/xaifzx7RPtNsi2URu2p838lwU3qcidx8VGw9WZVnmCsHq01al9j3NnmNuFroxr6vLumxy5TFP5H9vl1VCWxdOS0V7pJbXTWcMMhYVimhP+a3npxfVk6CxIGPS+PHenxBGJYl2cAUFmMGR3igC0DXwD617ur2ZNSQsereMG/vDfLXvFfwLQehM2OPXCtc3JnxmjzB5E3BreJuaujDZ+/SrEGlHpAjjqf+tXgz1rxf3YNgDFY291JOSzx5W/Cg1R+raP8s1hnwLE/5+dErxqTkzirZQa+Uuw9xCgVMN9uGYYsuFzWMMxp3Q74gVT4GqqkH0GgeGNo8z9r7mpdInKccFNgcrXVvj0ySwgqBRX9UZThOTFEwY1X7qTeqn1Zl1c0THwUr4tQkMoGcw1bEHn7KDFSjWfm5zzlbLLi8Mm8Y4NmxQRQCmQ4wzCPP5MC6imQL4uZjBGGw5pdsUVYe+rlt8rZpfuUNLBVd98/zJraycp+MurtJBUIckwxEfcMrQaQR42XF2CmZl/j8qHPlOuFakhQqJgRzV1VdLJ2BCWGtLXLVvgGRiIhuoJ88ROY x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN7PR11MB7491.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(366004)(346002)(376002)(396003)(136003)(39860400002)(451199021)(4326008)(66446008)(53546011)(66556008)(7696005)(86362001)(26005)(71200400001)(122000001)(9686003)(52536014)(83380400001)(66476007)(478600001)(33656002)(82960400001)(2906002)(8936002)(186003)(6506007)(54906003)(8676002)(38100700002)(64756008)(55016003)(38070700005)(41300700001)(5660300002)(76116006)(66946007)(110136005)(316002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?rNaAAK8y5dKqhss61s8QLMpVet7LdPlZhxQMISp40Z6YOkInCO5V0vL3yp72?= =?us-ascii?Q?yalqvieI60Rq2/K1Z/GI1YC8OqTewMoeZ0Px+WLJqCW5QIpm85fxuGXKh6XY?= =?us-ascii?Q?9qygwSjpjCUQFpPfKyQ5j2huzKE480VTyiCJvWBLsvxebyLROJvZ+AZkeCye?= =?us-ascii?Q?BtdJVJavrNhis5pnTp2n7GEqYEEkv44UMENd+LpGtj3ajhzFgVxuDMj0v9ZW?= =?us-ascii?Q?mPwaPXjKBPoAH4856ws0LuGEWQOskiLRQz+ewyd+ZTW2tgAwzAg+1thtPAZY?= =?us-ascii?Q?CHtLIRVIePdjdRplslAmGR+I5z7sjpYSgKv0zWVgofL7jtENVu0ZSCZ0lAPQ?= =?us-ascii?Q?UNfcQ+cO+a0x+lXC3p9p0gABGCPVnIOhQdrfm0/WZlhATW6T10ZdtjpN9ssQ?= =?us-ascii?Q?8iBv2kA7IUKpGWwI8zRiq+o4cnk5652TG3lCf6s+AjL7AvZQf1ovaHOdV+Vk?= =?us-ascii?Q?sm3MEqE3rZYD2+U9uce3NRbRF7q4bWU+UGr5wUubD+Mh+PWuWY+NTCn50C1Q?= =?us-ascii?Q?1myqFpSkFsvBNux/Xkkg7l/oI5cgg1cbUvz788B8Uhz5EyOGgoPxgRw09Fhc?= =?us-ascii?Q?j/cLFTme2TiE9+AblrZvEoh1mV9o/QkBUZorDEYi7ff+DtC4aNgmehbO7fdQ?= =?us-ascii?Q?vDPDKx2ygn38OX3NIbxHALBovcb+8NB3q3VqAa0BkzdGCnD5AoNoZuIc9JJA?= =?us-ascii?Q?VstPUcDwV5VjzXYdsVWJHux4PI3z0a7a+tanI6G01/ywYXt8BgGfCVI6jDg5?= =?us-ascii?Q?X1x4E1hvM9JhOfLBvqQ+7xAr9CJw5yIBrG6o5RvxxVDTf7U8FkRpYzSz/xwb?= =?us-ascii?Q?pqMe0gkpIcfs+wcKuPLRO2dBxbCYtFu6RBEDBAYDe9lDjpI7wS2SD4huwmgB?= =?us-ascii?Q?cxo2cP6BCEthW49eRpLtr51ux0m1g6fTpUkulqMjf2Tti+dkfU5Dur36qccV?= =?us-ascii?Q?sN0C9++JE3IEQKkjYJFm1St8vQ6euyDAZiuHh2evoBo2Hic52e35Ud3jLiYp?= =?us-ascii?Q?u3eb4ClH7rWVmUK6hydsROQCU14fUa2IOnzDDeW+KmV3FwcJnlSJW3mwMA2n?= =?us-ascii?Q?qe305N2gYUkRknMySZjBUx0IDYZwkSzxTl0CH+lbUgyYUT4tlkoCw10JvGed?= =?us-ascii?Q?j9MBW0P3XfSIQZU+FlyaJ9DrIdxYacDkk77iRbr6k+bhPTBUiF8nJESj3t9D?= =?us-ascii?Q?DzP9XgqTwEo8gJwH6kqhZVpeCcImV+u1+anaH5lnUWPstO7mVEK1/kK2/kIX?= =?us-ascii?Q?WL0WtUfhotr3Hj7PBvZzHcMI+6A4ItGg3KFmMJkG3VODMpJcyi0h30x5W6SL?= =?us-ascii?Q?CzDzORGdQtexKmI+FFoKpGu1B8Alu+d0sY1CEOPqPiAGmQz3LsMu30OnNtcp?= =?us-ascii?Q?E3lSsrsSR1StZxKpG8fz97HLgTBsy0Y8iTHyUHQVpNEtMB57rVGWbGUYsxHk?= =?us-ascii?Q?vlEJuPOmHcL5rOQ4hS6cBgWiFSYzZD4UnbWPqTRz5rGHepxyy1P01YQDgFaA?= =?us-ascii?Q?FoihrdZgNOFLCsZ0DOy8YGKQBJIg7iXmk/QW7ecFMqOFJZMh/qpYPtGupa9i?= =?us-ascii?Q?lIJoGGcguh46tq4NUfhb6v5sJ3YB+aUcB/5TsjbI?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN7PR11MB7491.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d2201c15-ff8f-429a-24b7-08db2ff1b8ad X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Mar 2023 01:05:43.4410 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 8P23mNlXP5QjHwsJccb68F+KsEXXE7yFWItLu9U+3g4kcji18zW32lev4ijz2y8IQXofcDmkm9NAF3SKLudH7A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR11MB7135 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Michal Schmidt > Sent: Monday, March 27, 2023 6:08 PM > To: dev@dpdk.org > Cc: Richardson, Bruce ; Konstantin Ananyev > ; Wu, Jingjing ; > Xing, Beilei ; Rong, Leyi ; L= u, > Wenzhuo ; stable@dpdk.org > Subject: [PATCH] net/iavf: fix VLAN offload with AVX512 >=20 > It has been observed that mbufs of some received VLAN packets had the VLA= N > tag correctly set in vlan_tci, but ol_flags were missing the VLAN-indicat= ing > flags. >=20 > _mm256_shuffle_epi8 operates as two independent 128-bit operations, not a= s > a single 256-bit operation. To have the RTE_MBUF_F_RX_VLAN* flags reflect= ed > in the resulting vlan_flags for all 8 rx descriptors, the input l2tag2_fl= ags_shuf > must contain the required pattern in both 128-bit halves. >=20 > This fix is for the AVX512 Rx path. The same bug in AVX2 was fixed by com= mit > eb24917428a1 ("net/iavf: fix VLAN offload with AVX2"). >=20 > Fixes: 4b64ccb328c9 ("net/iavf: fix VLAN extraction in AVX512 path") > Cc: stable@dpdk.org >=20 > Signed-off-by: Michal Schmidt Acked-by: Wenzhuo Lu