RE: [PATCH v6 1/5] ci: replace IPsec-mb package install

["Power, Ciara" <ciara.power@intel.com>]

> -----Original Message-----
> From: David Marchand <david.marchand@redhat.com>
> Sent: Tuesday, March 12, 2024 4:05 PM
> To: Dooley, Brian <brian.dooley@intel.com>
> Cc: Aaron Conole <aconole@redhat.com>; Michael Santana
> <maicolgabriel@hotmail.com>; dev@dpdk.org; gakhil@marvell.com; De Lara
> Guarch, Pablo <pablo.de.lara.guarch@intel.com>; probb@iol.unh.edu;
> wathsala.vithanage@arm.com; Power, Ciara <ciara.power@intel.com>
> Subject: Re: [PATCH v6 1/5] ci: replace IPsec-mb package install
> 
> On Tue, Mar 12, 2024 at 2:50 PM Brian Dooley <brian.dooley@intel.com>
> wrote:
> > @@ -187,11 +193,18 @@ jobs:
> >        run: docker exec -i dpdk dnf update -y
> >      - name: Install packages
> >        if: steps.image_cache.outputs.cache-hit != 'true'
> > -      run: docker exec -i dpdk dnf install -y ccache intel-ipsec-mb-devel
> > +      run: docker exec -i dpdk dnf install -y ccache
> 
> Removing ipsec-mb means we lose build coverage for those crypto drivers on
> Fedora.
> 
> 
> >          isa-l-devel jansson-devel libarchive-devel libatomic libbsd-devel
> >          libbpf-devel libfdt-devel libpcap-devel libxdp-devel ninja-build
> >          numactl-devel openssl-devel python3-pip python3-pyelftools
> >          python3-setuptools python3-wheel rdma-core-devel zlib-devel
> > +    - name: Install ipsec-mb library
> > +      if: steps.image_cache.outputs.cache-hit != 'true'
> > +      run: |
> > +        wget "https://launchpad.net/ubuntu/+archive/primary/+files/libipsec-
> mb-dev_1.4-3_amd64.deb"
> > +        wget "https://launchpad.net/ubuntu/+archive/primary/+files/libipsec-
> mb1_1.4-3_amd64.deb"
> > +        sudo dpkg -i libipsec-mb1_1.4-3_amd64.deb
> > +        sudo dpkg -i libipsec-mb-dev_1.4-3_amd64.deb
> 
> And this hunk is useless.
> This installs the deb in the Ubuntu "host", not in the Fedora container.

Thanks, yes, good catch.

This patch isn't needed anymore as per the discussion in the other patch, no version bump for 24.03.

Thanks,
Ciara