From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 47B9842B2C; Wed, 17 May 2023 17:45:45 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2ADBA406B7; Wed, 17 May 2023 17:45:45 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id 8195C40041 for ; Wed, 17 May 2023 17:45:42 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1684338342; x=1715874342; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=2STuuFBAQe8aAKXkzVLY+BUoAnZgpfxudhgiBgItC6g=; b=c2BgE2VETLGcCeJBirHwsJWO3OXe8jhY9mNi2LGlcn3DsTzJB0s1ZrvU lSqmFzTjtne+R+8ftqS+OBkddnZMet/FjAB6aQ/6fiw5aTEBqXiz6GxaZ mdLU3SRrBztOt3G8e60WD4sWNw/Z8U1U2WRiYoRdupskW3cSncluKDunk 2XszJFOPvdkHndbCfRSAvdQl8Xudi0qeHTDismM1Z/Tssvw0aDkql5oYl S1rVQLfjGZmBE/YjziZzinfzPAMzksW4+OmBHrJRiIVVn74xvqEnLKBpr eQnbQrGkSmTx2BBMoq8JrNsVwnrRDioaPLIX6hKUgsRQFUbGdlF5G6f7+ A==; X-IronPort-AV: E=McAfee;i="6600,9927,10713"; a="332156579" X-IronPort-AV: E=Sophos;i="5.99,282,1677571200"; d="scan'208";a="332156579" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 May 2023 08:44:06 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10713"; a="732471458" X-IronPort-AV: E=Sophos;i="5.99,282,1677571200"; d="scan'208";a="732471458" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga008.jf.intel.com with ESMTP; 17 May 2023 08:44:06 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Wed, 17 May 2023 08:44:06 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Wed, 17 May 2023 08:44:06 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.101) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Wed, 17 May 2023 08:44:05 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=f0/sSWYtJCt0Ggit8aceLBge8x8HmyHYGqVxxwtI/HwgrgOb8OY95MZf/HawiXkagFzp6nFbNKOLLyi0wFFohnvvSevERl2Cs6nbj6QgYQvJofm4Hqi5ebVLVCzI4iZSQA54Ej/4s5XIJP2JZpUwVXg0HCk93EjpxwWf1Ghu3XfFdQW1zrLwgMevO5GqoZ9eeAh//F9Co/E5jXF+9CvD01oCOsM/HwF29hpj8IClYo1MoqFa97nSGl+OLpAmdMDj42LjGTBHdjmi7JWg4neLNmH45NRHgHjGgfxWfJjU9Aikk5b7nWlOZCfp2LiWJxfA2g+KTsa+C77FtkOLmFedHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2STuuFBAQe8aAKXkzVLY+BUoAnZgpfxudhgiBgItC6g=; b=Cx3rQtLiKZxo/NEJ/YXMcK3LtXoSDTdWLtdDSG9z6wepVJohc5Ms4f/60pbcgyzFFQPZlJfVQOftkuwFeGr7Y7e55f6CKggw8hnsF4ihbRkJTqCcWaI/1ZwKiYLUrpmzR4yYxzTrV4dUAbZkXeNwNyH88S/oEuCKngU4Xzrh+caOtANECuKmFpRORyYqyNRToGrEmzFGYT6dNuHiwH0d42BT8vSx+gcaaHjcFStWF3KIYUj7fQKHUqLv/JTJNk7dGORkm1QuxlDHT/mL+I2ZPBVQyxyByCdwjA/+MtitM9HyOY/Is9WwdwuqKTX06N3Bie2aT1KgHmDs10DddUim3w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SN7PR11MB7639.namprd11.prod.outlook.com (2603:10b6:806:32a::14) by IA0PR11MB7329.namprd11.prod.outlook.com (2603:10b6:208:437::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.17; Wed, 17 May 2023 15:44:04 +0000 Received: from SN7PR11MB7639.namprd11.prod.outlook.com ([fe80::43d0:7481:a8c4:76a0]) by SN7PR11MB7639.namprd11.prod.outlook.com ([fe80::43d0:7481:a8c4:76a0%4]) with mapi id 15.20.6387.032; Wed, 17 May 2023 15:44:04 +0000 From: "Power, Ciara" To: Anoob Joseph , Akhil Goyal , "Fan Zhang" CC: Hemant Agrawal , Jerin Jacob , Tejasree Kondoj , "dev@dpdk.org" Subject: RE: [PATCH v2] test/crypto: free memory in error and skip paths Thread-Topic: [PATCH v2] test/crypto: free memory in error and skip paths Thread-Index: AQHZiK4pyMJgXkbSlEaO6kfR2VzixK9em01g Date: Wed, 17 May 2023 15:44:03 +0000 Message-ID: References: <20230512140946.195-1-anoobj@marvell.com> <20230517105529.405-1-anoobj@marvell.com> In-Reply-To: <20230517105529.405-1-anoobj@marvell.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SN7PR11MB7639:EE_|IA0PR11MB7329:EE_ x-ms-office365-filtering-correlation-id: 03dea044-4a62-4478-7a36-08db56ed8adb x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: hcQW4RjmqXrhGtt4NA9VE+F6mYohJZ2hOQSG8+UIQsykUdqlBG/Y+ie/xWHSu3TA89siVeZ29RZMoh9Wdf6CKRz+e9sNIQa3uIOBgAmhO/+RX8+Qn5VoeeF+mz4xk12kJRhIZD79Yl1oTh2bOqBfHXHCGBDBzVio8MkgXcc6IkMC1ge8H9kNdERyj7ArB8x6VUBlIClGb3EbSjSgiV3F2AZNjQhUltHqqYL7DQl3xpVkH5N7e5YwRBNuxq6A5/zO68zhlPJIA6qGZIXdN1lokrDxK6klY5ol/0T5UVUN2Evea7m1G4bOZEyJTqzn12UTdxiv8H8m8pEeR3eluoEGhwskpVPPw5uYsch7XiKAqb2w5hNLH8xnaitUb6DD8E6AkEhnR3iNRKlnSmuZO2DhCUwiYv5Q4dK0EDNHTOl6uuDcdgBPGGTmm3YuQEE0I7vIpnGQjcZxBRNWAzqSUz/yZWDXQRn+FBhJ+CVjliTvlri3Yig/eaZPh1OgNaFHYpCAGRhx5qoKNdSGD/5N/iruQgv0T+8QKeBgypDAzSKK5TbxlasZcTwnuB5UkJHHAzsyGJglk2pA/H0R/mQlykhNGJjyQXjzHxyE+mHEeBGe2sI9MSZX5nlPdau6mQ8bhisX x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN7PR11MB7639.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(39860400002)(136003)(376002)(396003)(366004)(346002)(451199021)(83380400001)(122000001)(82960400001)(33656002)(41300700001)(8676002)(5660300002)(8936002)(52536014)(55016003)(86362001)(316002)(38070700005)(4744005)(66476007)(38100700002)(66556008)(4326008)(66946007)(66446008)(64756008)(76116006)(2906002)(9686003)(6506007)(26005)(186003)(53546011)(478600001)(7696005)(110136005)(54906003)(71200400001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?RW/dVC4OKv8i5YhchIc2bxnNwCJZzrGP+ZHwxuJLSbi4eui0evmbCTGlIZKH?= =?us-ascii?Q?C5Em093UxuL30zrwxVunHuzAxVq36skjEKTSEjZeYUOoi1sH4Vv8REOGS0S0?= =?us-ascii?Q?/i4UiSmiLCkhwENDqjQXUHlkojUX92ypT5659yfSIxUyhKBKC6US9769xMxY?= =?us-ascii?Q?g+ytNSej3xnTFC6EmngLHwomsdgiaYHm7miIg1smFX5BuQ+oRqizAWzxnggB?= =?us-ascii?Q?T9erXU6u7lmCRKcoPf4kmzctqpSH8KnP8LEDy1rz3v8YC2qSeClm5hdLkKyl?= =?us-ascii?Q?osuXMkzk5X00hYycnigq+0Bh9ypjAhEXLRZn3mafHUMwXA3CqUR0+b5hWQLC?= =?us-ascii?Q?7eF+t6cNiX7Ztsa6HGPRBZJYmspCpugRQZJh/2RyCsU0n7jGj7jEgi1DxuZU?= =?us-ascii?Q?asMSyClMW/Ff5+qDquP+ZHqbc4h0hlJCkWPOKdMPOK00W8zqLHmOtk7lYBzC?= =?us-ascii?Q?m0g5xiVzRSKXLwnB3XpWRCdiBXFpqjeW7iX71U8WdHd+6lqgHfvaycFLFHFp?= =?us-ascii?Q?MfpSBMi36/syM1n66Wo5UcniXELDeK5/U+dJj+7Kn0F2s+f07iP2Zfp2dj6P?= =?us-ascii?Q?rt0rMf+AcnKaRAmL7m7bfHAi34U3QXo/lzC2iK/gs/9eH23QLswMPULBbHJv?= =?us-ascii?Q?3ozzn3lHgFB+pvu0EBU+M9KAz0o6d0glQZp5hfWuGXnoK0EumZIIRQzbUKvO?= =?us-ascii?Q?kUmxUy8GwCshcCWp0j4drtHbQTDAdcifhHhZ2znVxTunuecb338Ml/Hs99q2?= =?us-ascii?Q?NIrEEDuBJZWfwq7iQd0msp56N9Vqt0OVZ16YjvC2ywKfqSOPWGUWgu/ffyph?= =?us-ascii?Q?IrcrMuXD1aFKO0L81gPDo2FB881ugaIM/tMbhXtcC/44jufgD7OzdFdLEBWd?= =?us-ascii?Q?1JlKoK7Ku8jZ/QgEtoe4PbJToR8BAfM289zE/tUXfQvmXPgCsYhVKN5+Uazn?= =?us-ascii?Q?h2Nt29Da8QFaMubFHhkd6NsII7GPqTDLP51x+KJJ6q2MzuifwHveni6+JPFT?= =?us-ascii?Q?XqErEW/Oq/OmLjd7TK8T5i02F9jLiUclFNRKSHDbWX64AjsX+eoYQPmCAO5N?= =?us-ascii?Q?sWxpx4Ay2i3s6TD01XaaM0sZK5yC7H0tAF+vcN7RN+dA3/hjQzNZpxxHL+/C?= =?us-ascii?Q?eoNUvIXcn5KXLnOg+wC1b2pzrvFBjkzR0zSNO0rjTZD9d4eW8oM9nI7RNKCs?= =?us-ascii?Q?Z7R04/4V9Ppyvg8Fx04crJhGQFINQMpqLIK0gpSYx49mjst6ogYHqAqIEl24?= =?us-ascii?Q?kMXLL03R+IhV8qFd6KiWaLE0gTeZP2K3fPi7s2ECKCvjNO/vzVHQaieh5tK0?= =?us-ascii?Q?VZ2SwNFFJyJlTp2Wrrqo3y3tiTAkDSu0uHv0D2Co8zVxkUbWmhLQwgP9y8TP?= =?us-ascii?Q?IJW0Y1hs+NRn/iyDUltnYiyamz/+sddB+y5//rzn8ddjk9en6BTpi0xRFMOB?= =?us-ascii?Q?1liKW/BLRw3mRpIFPxYMWe1WQczDhisp6aFBANlvGtFttnNkvO3mdPt16+bb?= =?us-ascii?Q?ZQk0uE8aXN7DZwiMz3yU5uA+WcmrG4GciJMrNh4ia/86k15Kb5OGIVYMtZ9N?= =?us-ascii?Q?v1tAa8pPFxO77FSkf43avWP2Jdpi+ve7pSV7S4y/?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN7PR11MB7639.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 03dea044-4a62-4478-7a36-08db56ed8adb X-MS-Exchange-CrossTenant-originalarrivaltime: 17 May 2023 15:44:03.9608 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 2HfxXUQ4BEaluDoBseu65J/xXhzlejI/4jyiMeeU/CSjZCQIW4iwpenS73CQV/rGdEyiJCoNvh2ZWYlUi3VxAg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR11MB7329 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Anoob Joseph > Sent: Wednesday 17 May 2023 11:55 > To: Akhil Goyal ; Fan Zhang > ; Power, Ciara > Cc: Hemant Agrawal ; Jerin Jacob > ; Tejasree Kondoj ; > dev@dpdk.org > Subject: [PATCH v2] test/crypto: free memory in error and skip paths >=20 > In multi session tests, multiple sessions get created. So the handling in > ut_teardown won't guard against any memory that is not freed by the test > case. Test case should free sessions as well as local memory that was use= d to > save session pointers both in case of unsupported cases as well as operat= ion > failures. >=20 > Signed-off-by: Anoob Joseph > --- > v2: > * Moved 'ASSERT' to the end to allow cleanup in all cases. > --- Acked-by: Ciara Power