From: "Power, Ciara" <ciara.power@intel.com>
To: "Kusztal, ArkadiuszX" <arkadiuszx.kusztal@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "gakhil@marvell.com" <gakhil@marvell.com>, "Ji, Kai" <kai.ji@intel.com>
Subject: RE: [PATCH 1/4] app/test: remove testsuite calls from ut setup
Date: Thu, 25 May 2023 15:18:21 +0000 [thread overview]
Message-ID: <SN7PR11MB76391451A3B9A168EBBE7DC7E6469@SN7PR11MB7639.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20230517211900.926163-2-arkadiuszx.kusztal@intel.com>
Hi Arek,
> -----Original Message-----
> From: Kusztal, ArkadiuszX <arkadiuszx.kusztal@intel.com>
> Sent: Wednesday 17 May 2023 22:19
> To: dev@dpdk.org
> Cc: gakhil@marvell.com; Ji, Kai <kai.ji@intel.com>; Power, Ciara
> <ciara.power@intel.com>; Kusztal, ArkadiuszX <arkadiuszx.kusztal@intel.com>
> Subject: [PATCH 1/4] app/test: remove testsuite calls from ut setup
>
> Unit test setup should be responsible for setting unit test parateres only,
Small typo: parameters
> analogous rules should apply to ut teardown function.
> Cryptodev start/stop functions should be used once - during setting the
> testsuite.
>
> Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
> ---
> app/test/test_cryptodev_asym.c | 310 ++++++++++++++-------------------
> 1 file changed, 130 insertions(+), 180 deletions(-)
>
> diff --git a/app/test/test_cryptodev_asym.c b/app/test/test_cryptodev_asym.c
> index 9236817650..026fa48c9e 100644
> --- a/app/test/test_cryptodev_asym.c
> +++ b/app/test/test_cryptodev_asym.c
<snip>
Acked-by: Ciara Power <ciara.power@intel.com>
next prev parent reply other threads:[~2023-05-25 15:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-17 21:18 [PATCH 0/4] Replace obsolote test cases Arek Kusztal
2023-05-17 21:18 ` [PATCH 1/4] app/test: remove testsuite calls from ut setup Arek Kusztal
2023-05-25 15:18 ` Power, Ciara [this message]
2023-05-17 21:18 ` [PATCH 2/4] app/test: refactor mod exp test case Arek Kusztal
2023-05-26 14:32 ` Power, Ciara
2023-05-17 21:18 ` [PATCH 3/4] app/test: refactor mod inv tests Arek Kusztal
2023-05-26 14:47 ` Power, Ciara
2023-05-17 21:19 ` [PATCH 4/4] app/test: add rsa kat and pwct tests Arek Kusztal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SN7PR11MB76391451A3B9A168EBBE7DC7E6469@SN7PR11MB7639.namprd11.prod.outlook.com \
--to=ciara.power@intel.com \
--cc=arkadiuszx.kusztal@intel.com \
--cc=dev@dpdk.org \
--cc=gakhil@marvell.com \
--cc=kai.ji@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).