From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B6DD8425D7; Mon, 18 Sep 2023 17:10:28 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9EA4240633; Mon, 18 Sep 2023 17:10:28 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id 842844025D for ; Mon, 18 Sep 2023 17:10:26 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1695049826; x=1726585826; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=MveddPnnKT8R8VMFd9ANlcZTIb0sZY3i8XPghZIjEg0=; b=Kc7t4hxdywMsW+Jc2tZOe5tqcxxMcG1wdJ9qpAumI4q9q65+E+uE5gNF b9/fQvWN4B/VWCIbEyjEBSgbHD0gHlGuFmvuKf5JBuv/RVh7s7D7m1x4Y CscEssaOkoD142Uk5x9bjM0x8Y3PsFrDLY5ZIHCY9aMcCGcZcH5udsMFh QgiPnBw3SYdsxRl5rQ65Pxe3obRfmIKr18H4NKr5WRq0kYU9T1raubh52 G9Qojt9gyfzZVY2akhQtA/yDKI8J457z9yrIQ+NgaJO8nQUX1rtSwuVQM gKaItNPfs//UXog/FM+1biettH3WXg5DsFP3f4wZNg18HdIm0tPUzXCjb Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10837"; a="359931587" X-IronPort-AV: E=Sophos;i="6.02,156,1688454000"; d="scan'208";a="359931587" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Sep 2023 08:07:54 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10837"; a="695540952" X-IronPort-AV: E=Sophos;i="6.02,156,1688454000"; d="scan'208";a="695540952" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga003.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 18 Sep 2023 08:07:22 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Mon, 18 Sep 2023 08:07:21 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Mon, 18 Sep 2023 08:07:21 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32 via Frontend Transport; Mon, 18 Sep 2023 08:07:21 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.107) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.32; Mon, 18 Sep 2023 08:07:21 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oadZfNdsI7W/Gty3g4E2qnKAkIUpdphB+8E3dJyQDG+6EaraCLtWCFRPvZlTm/Qncb+0UtGNLBTmo/2xdQ3C4kvgcUR9T6srVM49WlW2ahnsreTivsr0Y+AwyWUjTZ1JDdMXDWvNHhav/+PmktFQgFl7jFOm5CQRUNpGNkl0R6hlMLJrA9bpCEyqwEAm9/arNkMTaXjSKwRJbjdENucOpy2es/nXaURlvfUHskWcWJRql4uM7y5doeoAyxVzKw4MYfcaSDy+Vt9gdzI5fJI4tv2Vk1+G9g2RCW8C/EwtA59+x/nSMp1pWMxo1Y+iN2xcVmCGZ7/1mk7rHidp2dFkbg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JdPCqnzWz3k+vrY2AjgVB0sGQBDvIKcSdK2DGe3M8RU=; b=JhYi566LT2SBrL7bVPR1nkWIqknVqP9EI1MM7BWi8Bm/o14VnDDATUdCj9CJWWgoNydd0eSB9vOF6SkqIYhblRxm6qjirha9ppEfpBY9kgUyUAOhRnp/oVOZMCHxzDRPZABuDyTuSuPcYVqSrjPiOH2CXf1XYWMShekgctfwObVfabZq2n+nko3TtA0+lhkzAwL3WEudoe/uGAh1AomM3kFCeIqXZceabZAXkhqYilQLCgZw0GP68OJoiGnqOlKlLQokMfs1W2YmZNi2/xxrvAtWwAgV3JBXeLueXV9H2WKb5pB+AxhI6hu6RqzKcL9VExiyMQw3UdPxyF0XzUiCKA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SN7PR11MB7639.namprd11.prod.outlook.com (2603:10b6:806:32a::14) by MW3PR11MB4649.namprd11.prod.outlook.com (2603:10b6:303:5b::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6792.24; Mon, 18 Sep 2023 15:07:19 +0000 Received: from SN7PR11MB7639.namprd11.prod.outlook.com ([fe80::4986:f7d2:4c49:b31b]) by SN7PR11MB7639.namprd11.prod.outlook.com ([fe80::4986:f7d2:4c49:b31b%6]) with mapi id 15.20.6792.026; Mon, 18 Sep 2023 15:07:19 +0000 From: "Power, Ciara" To: "Kusztal, ArkadiuszX" , "dev@dpdk.org" CC: "gakhil@marvell.com" , "Ji, Kai" Subject: RE: [PATCH 1/3] common/qat: limit configuration to the primary process Thread-Topic: [PATCH 1/3] common/qat: limit configuration to the primary process Thread-Index: AQHZ6X8SZaIzbJnj+UqiyPYea/Mc1rAgr8Ww Date: Mon, 18 Sep 2023 15:07:19 +0000 Message-ID: References: <20230917154258.3509805-1-arkadiuszx.kusztal@intel.com> In-Reply-To: <20230917154258.3509805-1-arkadiuszx.kusztal@intel.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SN7PR11MB7639:EE_|MW3PR11MB4649:EE_ x-ms-office365-filtering-correlation-id: 5a0277f7-6f19-4641-2122-08dbb858f43e x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: SV8EOyRZz8FySpwKuqYRpxuLNKfspttVn6FTiBnhjNM4KifsbsMKYPyznS3uJhUNBTotZFQIBYu+KmTWfrU7hwb2RvYTHtzi0M3YRS5cb2L4uEV/kQ/+AxV4NTdbj3E5MWFpHtTdWaWpS5hMLBj510OrcclHL1jOKzy3iWjpSDMmG7OcupE5tfwiL07Kd6Wz7P9VZ+UgrZaGRX9hJ/Q+EmI09HjR9Uxk470lpKU0XY09zVeMIJKHfTvu820sKzLWe1+AZXJqrkP0n5pgikO560pncMBf6P4MrcK01yxHzp/d/npuTGxjXvlWh2qKZOLPuQ175ty5uPuemiEYao3qc0phTDfLChM+aoUqI/eqmmcxtLvQcmJoxbX0WTROAEKt6AMGusM1vI0Fa0ihmXn37/rdFCxfJvW9L2m/ZrX7+xfiWGonQHSOhOgHD6wFTRpJCIa8aQ1v2oYnZvmMCe4n6qKRLmBYMdclvS9wzTK4qzfpWYMrhx6dwokwqIoRd8Vy4qvjAIWGUCFOeasuJxtjsvmQlObTgBNNoZmcJz7YQB1m0BTS+F7kNYHvwruX9Ft/tGz7rHtBx6L3vDjwAVhiQ0nk03I4fUy65RNZ+F4cqJ4= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN7PR11MB7639.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(396003)(136003)(376002)(366004)(39860400002)(346002)(1800799009)(186009)(451199024)(76116006)(66946007)(66476007)(122000001)(316002)(8676002)(4326008)(41300700001)(52536014)(53546011)(6506007)(7696005)(9686003)(478600001)(71200400001)(83380400001)(110136005)(8936002)(38100700002)(107886003)(26005)(2906002)(86362001)(33656002)(82960400001)(5660300002)(38070700005)(55016003)(54906003)(66446008)(64756008)(66556008); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?FahN9x+SvI+sd9lbWGidt45R//vTzcO4jSi5x63/WZb3Eb33wLqMLXzlI2OE?= =?us-ascii?Q?rCYARr/kkp39jHkOL1AIyEZJkMh7ccMBWhY2Yn2eBUCVDpjZxY9f3KUoI+eB?= =?us-ascii?Q?p67E079LxFRV8VCaPKqjaAWJNokYU4pXk5Pg4ruS8L8MSMGUoylChvj77aTN?= =?us-ascii?Q?Cbto8weuFsp/x3pduv6KzIs0AxYYWESE8hY9/77QN3rfkE8c4EkUKvxaaPz1?= =?us-ascii?Q?SHEDri4bjDzLYHTsy4bfpiGCQsFFxL6InFXLQVIKPoWmCy9EVluSHJzDrCSa?= =?us-ascii?Q?7h/cGDzmEJfnBQuAIV6pXlFE5oq9EZgfPigHXlzyStRiEkaaS3ne7XU5nqqh?= =?us-ascii?Q?Tds6eRjZZ1dYlh7mOaH4v8iY9DrtzTjioyHBe8yD8pQdIKB5G8G3FKT3pRD6?= =?us-ascii?Q?1OdxqiKAHzbj9h7TjKPeJ14P+2e8zvxmiUDY0yTseeu1RNbxBzBf5ftV6l6e?= =?us-ascii?Q?2mCbl/hysTkmjRaFvo/y7AfjxRja06uJwivYfKMyQW18OrneE1HtgT2mEzR/?= =?us-ascii?Q?jeq0Ti7T13Mz/0AFE2Q0/fTgh03IhdGp0v1VIUo27sSI5AqNwjlO1s4WWS7w?= =?us-ascii?Q?+zZe2fF5RZJytBF5QdedrR4SoarvxWDq5bnQZzkRO+vBLnpRUiIOHkXaqTQ4?= =?us-ascii?Q?8srov2PiF9p/cNAF2eKUsnfxsD9VDdSfpVBLzE5aeDB4aCqLCBqRqJji3cWu?= =?us-ascii?Q?OPPMmRwR2HHjMh6Q6KzP3dHh17LtrSTf/sev/Eqa9HBnALwJPb0tABWlXEOZ?= =?us-ascii?Q?zpF1nAEuP8EmmPk2+Atzbj8lxzWTPNaubtQVKNHXCgXx8ahEW3ireqnNpxsN?= =?us-ascii?Q?PuPbEt3qxTDMuE/6Iuqt3r/+jC39eQ/jcf6iTwkIuSrr7gV+qV3JVk9TOL9k?= =?us-ascii?Q?PnfE2HIBnfzn6bqTJt48KTv7zqIznu9Jb94EayokrkHjK2FC2y6/4edR2ktA?= =?us-ascii?Q?aIg4zJgPz0J9F9cR/RDjQj+fSxEzuSVPUY6qtgChKAlQcKb+GtJlDhKCznYG?= =?us-ascii?Q?KBAIc8DKvkMgaRI+BlcmT12vMLK9xcxImBOOdqvaz25AfMEG5TYQCvZypW3i?= =?us-ascii?Q?IJ3ViQawAJTDqsTQlXdo8Wff4wAwUgyROr4QRx3IXV19sENc0H/2wQCAnBgS?= =?us-ascii?Q?ppRPhQwg3YJVkgU5Ux7QQTNGfKJtx0s8iGw9tCWp9/E/u1hGrsGb8CNjEuIK?= =?us-ascii?Q?SzWi83hQsnmlGmsi6we6VV8WMElmk1kuXBk8/tZLbYcpdK5htWoisXqVe9Yg?= =?us-ascii?Q?fqrwIln08gsa17akWNpyr+OKEjCCnXd2t83msFmUm4cRVyU3oAp+T29Zgrsh?= =?us-ascii?Q?+4fn5I/gBjZ91qWt63uecZHTcZbpOyR+BNStndgpNCviuCMu431vI9/5VcQy?= =?us-ascii?Q?y+oH5Q35Rb3tCTNekxqginVdFTb3lSB1odvK1UCbEGPwxz3x6c5pedqGbSMv?= =?us-ascii?Q?P20p/kW99X8b0TGCawTagGJPTMnn+yIZuWg1Mx1uneAgpQr0q9Vj+WRacboj?= =?us-ascii?Q?YxX1+VZoCX0M3Z+kbmaq2F4auM0HwvFe7DjOKYwY88cujwAkU/HcBFsVXraF?= =?us-ascii?Q?QB7UUhxyR7u7aNRoCYVk7NOvQd+rEg6l5m5/I+as?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN7PR11MB7639.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5a0277f7-6f19-4641-2122-08dbb858f43e X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Sep 2023 15:07:19.7132 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: CT9br4mv5DQ1Jk7k2eWZysaie7QEnVeWpCyojV6FOmydzPNfJH7t2SLsM8Q/MIMfwDC1yZz05+hKi4iwGyzcZQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR11MB4649 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Arek, > -----Original Message----- > From: Kusztal, ArkadiuszX > Sent: Sunday, September 17, 2023 4:43 PM > To: dev@dpdk.org > Cc: gakhil@marvell.com; Ji, Kai ; Power, Ciara > ; Kusztal, ArkadiuszX > > Subject: [PATCH 1/3] common/qat: limit configuration to the primary proce= ss >=20 > This change prevents certain configuration functions from being called by= the > secondary process. >=20 > Signed-off-by: Arkadiusz Kusztal > --- > drivers/common/qat/qat_device.c | 113 +++++++++++++++++++++++------- > ---------- > drivers/common/qat/qat_device.h | 2 + > 2 files changed, 66 insertions(+), 49 deletions(-) >=20 > +static enum qat_device_gen > +pick_gen(struct rte_pci_device *pci_dev) { > + switch (pci_dev->id.device_id) { > + case 0x0443: > + return QAT_GEN1; > + case 0x37c9: > + case 0x19e3: > + case 0x6f55: > + case 0x18ef: > + return QAT_GEN2; > + case 0x18a1: > + return QAT_GEN3; > + case 0x4941: > + case 0x4943: > + return QAT_GEN4; > + default: > + QAT_LOG(ERR, "Invalid dev_id, can't determine generation"); > + return QAT_N_GENS; > + } > +} > + > struct qat_pci_device * > qat_pci_device_allocate(struct rte_pci_device *pci_dev, > struct qat_dev_cmd_param *qat_dev_cmd_param) @@ - > 187,24 +218,8 @@ qat_pci_device_allocate(struct rte_pci_device *pci_dev, > rte_pci_device_name(&pci_dev->addr, name, sizeof(name)); > snprintf(name+strlen(name), QAT_DEV_NAME_MAX_LEN- > strlen(name), "_qat"); >=20 > - switch (pci_dev->id.device_id) { > - case 0x0443: > - qat_dev_gen =3D QAT_GEN1; > - break; > - case 0x37c9: > - case 0x19e3: > - case 0x6f55: > - case 0x18ef: > - qat_dev_gen =3D QAT_GEN2; > - break; > - case 0x18a1: > - qat_dev_gen =3D QAT_GEN3; > - break; > - case 0x4941: > - case 0x4943: > - qat_dev_gen =3D QAT_GEN4; > - break; > - default: > + qat_dev_gen =3D pick_gen(pci_dev); > + if (qat_dev_gen =3D=3D QAT_N_GENS) { > QAT_LOG(ERR, "Invalid dev_id, can't determine generation"); > return NULL; > } The above log is duplicated, once in pick_gen() and once here. > @@ -261,20 +276,15 @@ qat_pci_device_allocate(struct rte_pci_device > *pci_dev, > qat_dev->dev_private =3D qat_dev + 1; > strlcpy(qat_dev->name, name, QAT_DEV_NAME_MAX_LEN); > qat_dev->qat_dev_id =3D qat_dev_id; > - qat_pci_devs[qat_dev_id].pci_dev =3D pci_dev; > qat_dev->qat_dev_gen =3D qat_dev_gen; >=20 > ops_hw =3D qat_dev_hw_spec[qat_dev->qat_dev_gen]; > - if (ops_hw->qat_dev_get_misc_bar =3D=3D NULL) { > - QAT_LOG(ERR, "qat_dev_get_misc_bar function pointer not > set"); > - rte_memzone_free(qat_dev_mz); > - return NULL; > - } > + NOT_NULL(ops_hw->qat_dev_reset_ring_pairs, goto error, > + "QAT internal error! qat_dev_get_misc_bar function not set"); This check should be for ops_hw->qat_dev_get_misc_bar as mentioned in log. Thanks, Ciara