From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E2FC44331B; Mon, 13 Nov 2023 10:12:10 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B4B42402AE; Mon, 13 Nov 2023 10:12:10 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id 370CA4026C; Mon, 13 Nov 2023 10:12:09 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1699866729; x=1731402729; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=MkEEaBW/xzZ/xeGIuc3fZc7QuVdZSTmqox+R3VtgJNA=; b=lgUdf34dR8+NxBDBUj9xDQYcAeIbsjWJ0weYh+9MP2/VRiWuMJHHuRqM ATs2Cu+pcbL5kjRE/Y7aVtCNPhddWxv+efVmo85G27/7E/tW45eSW3upH C0L0Pb2q2tdfhSyOevh6CR1fRn6yNXYG0/SM8mfVon9dbZOOfoNVbb9tt 6AMWGLmzbMyXh0n39BwvLopRLppXBVixs4jMddZp9Frl4jbZOiGa0+rDW qHr2i4KyXIbzRit/Ow39yPXzvvpsIxFaZN+QXvcF4M5oRqjWLsDb8JVCv TL8POD8XZj8LtB7d01KgOGp9zCzaBariX++Hw+RwteqNEZ/y/FqnGSYcZ g==; X-IronPort-AV: E=McAfee;i="6600,9927,10892"; a="375427827" X-IronPort-AV: E=Sophos;i="6.03,299,1694761200"; d="scan'208";a="375427827" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Nov 2023 01:12:08 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10892"; a="937690618" X-IronPort-AV: E=Sophos;i="6.03,299,1694761200"; d="scan'208";a="937690618" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga005.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 13 Nov 2023 01:12:08 -0800 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Mon, 13 Nov 2023 01:12:08 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Mon, 13 Nov 2023 01:12:07 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34 via Frontend Transport; Mon, 13 Nov 2023 01:12:07 -0800 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.101) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.34; Mon, 13 Nov 2023 01:12:07 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nxcEnlcKRl/FMY773znqlchjSvYxuiL0Wx+ckwLW4GF3FIkIzeuTTORF+CCs4UlSO5m1iB2g0qNUM3WYWGWnsxhpp4Kt6t5TmG6x+RiOsQ5iD4bMWgTEz4DpVSgjeg37MUH23ZiNI8M1o8DNXxN/wOVq4hIS9DVpaVupeKSHituzOYxkAKIQSKg8RRS/at4OjsY+2XUYx710oT+vpTA0w9Ri+QSOaE2braJO4I0DZkFTbx8MXd6BrA9EeLl9MJlw1sOM8RPfFGobRcOGBv6VIOIoAL48Ttu0DAZVf2zBs0OLx8fDhVae8GAsvSE7ucljTX9tnsy7CN8GVAmxWYw3aQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MkEEaBW/xzZ/xeGIuc3fZc7QuVdZSTmqox+R3VtgJNA=; b=n2DK6yF2KRUiSb9lHsYAfPR3K9vMqRVW561PWv2ygyp0JVkOrzCYde2k6HcTwOd+feLbbwN6nTtL1TUSJ/Kz3yNqbS8pvwlAhSars1qpQgpAB3mkDVd6mOgU+lSWpo8N7ETD1wGweEgh1BbDxZzFWLIwvscrwhJz25pvEbdqNB7WbTRRaSV6WV+3gjSfWrH0NgOLd+ZRFA0ToB+jBlYJUvYexTNmtxrKCfGa6xFYa2RA4Ls4qkhvBqU0Xtwp5ovc08SRiPEY16R1I0Idp0a0VgL1i5I+CD+IlCMg159w92s5ODF8hu8z3OdUVUJJXcdeX//9GdqqMdQlxLEoG0dl/A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SN7PR11MB7639.namprd11.prod.outlook.com (2603:10b6:806:32a::14) by CYYPR11MB8332.namprd11.prod.outlook.com (2603:10b6:930:be::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6977.19; Mon, 13 Nov 2023 09:12:05 +0000 Received: from SN7PR11MB7639.namprd11.prod.outlook.com ([fe80::809d:52ab:dc3b:8a10]) by SN7PR11MB7639.namprd11.prod.outlook.com ([fe80::809d:52ab:dc3b:8a10%6]) with mapi id 15.20.6977.029; Mon, 13 Nov 2023 09:12:05 +0000 From: "Power, Ciara" To: "Karas, Krzysztof" , "Ji, Kai" , "De Lara Guarch, Pablo" , "Cornu, Marcel D" CC: "dev@dpdk.org" , "stable@dpdk.org" Subject: RE: [PATCH v2] crypto/ipsec_mb: do not dequeue ops after flush Thread-Topic: [PATCH v2] crypto/ipsec_mb: do not dequeue ops after flush Thread-Index: AQHaFggMZOkEN6hKdEWkubGmPFFkTrB39rXw Date: Mon, 13 Nov 2023 09:12:05 +0000 Message-ID: References: <20231113080158.3872440-1-krzysztof.karas@intel.com> In-Reply-To: <20231113080158.3872440-1-krzysztof.karas@intel.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SN7PR11MB7639:EE_|CYYPR11MB8332:EE_ x-ms-office365-filtering-correlation-id: ad18c2f6-4206-4c9d-4625-08dbe4289b05 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: aU0iohW2ocRtlWkwHz5CTqTAkx8p36z5N36jCHlXm2ho2SVZQQM1r3EQUwQVeiax+ec7Sk6hCAEsuDIgNi6h647hVWE+pYC9fZvDfQf9NUgqotntQnL2ZPD5gCz6uuJAngy/6+KOMf1ms0M5BD4T7Dc3ufqIORWOCod1k3OppFQ43eRrdPxCqyREbRE1RNkoWTeCPacI2KyQZgqnQu6aQ/yfsCmdK1RXRAivqnvBZ0XIvxkGHkle7HC8f82gfkD7jLyY5QRxdZHTplLTi+/ChtLMbSvoE3AbOh3HQA0qICtnGgXz8lsthHG6TLETJtobn4j89QaTcBHUJwH8qzxKlSsNLFSLqaBTCga7CLfzavIZQwYbVgrCQlAfLQ9Dqh1xzU+ypUT4wF3gc5c95SDRVIWEYq041YYinozXwLr2oEe6h/L5KzCkLKkibxsTH8xvZ+XJ9+pp5ses+D4Urzjk1dMh56sH2S5pg0dxSqQ5SbrHz7BefPA+ZRVUhh4hDp1dJNpl6qs9Hn2CNYXbdDkxpqNnxvPZ7CpLYbIcveDrYD6G/Q+9V4qg7Pt5w+Uw+swWqn1iLqS1PPWtQR3S0paOtvaJTEN6kU6gXhkTwFL3Iv4= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN7PR11MB7639.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(396003)(376002)(39860400002)(366004)(346002)(136003)(230922051799003)(1800799009)(451199024)(186009)(64100799003)(33656002)(38070700009)(86362001)(9686003)(5660300002)(8936002)(8676002)(55016003)(71200400001)(4326008)(53546011)(6506007)(52536014)(2906002)(7696005)(82960400001)(4744005)(64756008)(26005)(66446008)(54906003)(6636002)(66556008)(66946007)(66476007)(76116006)(316002)(83380400001)(110136005)(450100002)(478600001)(38100700002)(122000001)(41300700001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?C6HZwVMmpHDmQ1DnpdJZNxuSBWoXw8ZQJpEIu1xyNJ5pRnCjAR6oMML3ol+C?= =?us-ascii?Q?/PwQNgIsR5EFiSRS2i/zGaJqxKWvTecCFyDYEd+a294Fq0s4MDIEgl6lO17j?= =?us-ascii?Q?ZwswFSbP3biacANS/AnMwJ8V9Tufp9p9wM1hhBUSI7PXV9b3wlQR68vf4cLG?= =?us-ascii?Q?x3ELaetgxMc1Iw6xfj07Wl7oIaIe+M6Z4hu5pWVkx5KmbBHJRh+KveHtYQgo?= =?us-ascii?Q?NpiMyeAKXojAA8dKj0/7cMxLjyxUEvkceQISDaHPMijifPv9jzTbmbDfPks7?= =?us-ascii?Q?EyYLJKuwqGZPKYsic/BZoN1pmwb0JvOVyeWd7WGcf4/sF9xgVibZOy8X+3+N?= =?us-ascii?Q?CIiauFi7YW3b9FylXEWYheiKMlhm/LgkipXnTklL0EF97JNJ97VMoXV4g0pw?= =?us-ascii?Q?amWqXjbCyKvqijTts36dIdjCtl0fVIFcHAq9YO5WeGBAAbYF5p6v+xmDLrWL?= =?us-ascii?Q?LAW8w9SX3CZpxEGP964oAgbrkM/PSbX91Om1lO4iWM8FtcXKigQ+0sRxPppz?= =?us-ascii?Q?AJRpgU8v+Qrs9b+VHd5p6B4C7TdF/gxCiURKW5sfKR6msJH90i7IXlwGwOen?= =?us-ascii?Q?9O9HKzDNEEsLH8wUiIkkowmCJc0pW8un+hH3d69GmA14St+B1GRIJcCnG8Sp?= =?us-ascii?Q?3sGiTQNyA9rnC9kTP4YEEWh+NtZehnZnXOSkD363kp4yVDtsIQYQG7rWUuCB?= =?us-ascii?Q?KnMDJacyOuTTbIVXrOTxlNLsNuSB9IoTGdWt8+qF0V0Y2PZ6Y0V2yoaVAK8I?= =?us-ascii?Q?IxxAwcr+atGZnRDKjTv0RcN+OzWA8x+omXapEMqduzlvNPRgjLkgjTnE09a6?= =?us-ascii?Q?I8zKPXqvk3cnPZqi/3gGrAYG+6EGdlnSJ39dkNhlZSKEqSwGEA/3ATVfJVIS?= =?us-ascii?Q?aEOxnrq0ZFdA7XnQEOTBoXIAHIZ1XSMcL1YitJjKEbXIfwMhllh7NHlV2Ycf?= =?us-ascii?Q?BZ4Hlmmmyq2Qy/kZuRcbB4sdozLmBd3xE78J6SWbF41WTgbrckgyHBElmrmc?= =?us-ascii?Q?+iKGxrIWSk1S8CASbEw/W/+4hAW7tegosU+deJRf++DYZLBP0fvuI1dam/VG?= =?us-ascii?Q?J59a3SG5UEiQxgJoPQwS/a1I+gY3JFcKaugBFcyh1aHVywkzO+pnaPBlPRvX?= =?us-ascii?Q?5LzDt48eXx0bl+UKAkal1X+ghXl1IuWeq47v+bdp+ePyEZBjMOQaiB/p80EH?= =?us-ascii?Q?1opgfl74NoytpD4ombfGILvmh1KKmrSprOUvF/ueB4yCDnLruNVELX965xSN?= =?us-ascii?Q?9ulQ2hLLFiAeswmLd0MOAymLnBRoBOsT152gwHXK+pT1PTdb4phrVkJvd2AL?= =?us-ascii?Q?se6WSKgjqHm5hC+jKjUMAnJovudfn3KqBdQVHh2DAS9vcoXFQiu0IQ8YkVho?= =?us-ascii?Q?mQrTIUgFSHlolZ6IIjW5XOJfP1Ciu6jy0ycuxpDjSx2eHos6RGHPuPX7jQt2?= =?us-ascii?Q?TrU4O/OhhAG8WadUmRCyKdOzesWcLXM7um/LWMjKXtzLuYP34o2t5pObtTNY?= =?us-ascii?Q?iZCHCwvngrd94UNzHiMkzuZqmAPlcSMPdGUtxyB7/+PYSNuffp1Qza+b2iMJ?= =?us-ascii?Q?tEVvb7va8I+CI8SfL2M6W/oF8YeOWCP3IF66KGzt?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN7PR11MB7639.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ad18c2f6-4206-4c9d-4625-08dbe4289b05 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Nov 2023 09:12:05.3256 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: UBeEbHeqOgnhhDU11mMGXqdf8zvgP1wpDgQVXZFobEvqJebP/Sj76dx9M50sV1K3fW1lwf8WAlzO4X8Tf02pmw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CYYPR11MB8332 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Karas, Krzysztof > Sent: Monday, November 13, 2023 8:02 AM > To: Ji, Kai ; De Lara Guarch, Pablo > ; Cornu, Marcel D > ; Power, Ciara > Cc: dev@dpdk.org; Karas, Krzysztof ; > stable@dpdk.org > Subject: [PATCH v2] crypto/ipsec_mb: do not dequeue ops after flush >=20 > Previously it was possible to increment `processed_jobs` to a value great= er > than requested `nb_ops`, because after flushing at most `nb_ops` jobs the > while loop continued, so `processed_jobs` could still be incremented and = it > was possible for this variable to be greater than `nb_ops`. If `ops` prov= ided to > the function were only `nb_ops` long, then the `aesni_mb_dequeue_burst()` > would write to the memory outside of `ops` array. >=20 > Fixes: b50b8b5b38f8 ("crypto/ipsec_mb: use burst API in AESNI") > Cc: stable@dpdk.org >=20 > Signed-off-by: Krzysztof Karas Acked-by: Ciara Power