From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4611443C59; Wed, 6 Mar 2024 12:12:41 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C90EB42DBD; Wed, 6 Mar 2024 12:12:40 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.18]) by mails.dpdk.org (Postfix) with ESMTP id 39E694027C for ; Wed, 6 Mar 2024 12:12:38 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1709723558; x=1741259558; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=w98DU3dat1lEnFoL3y85yVmmR1JDENA1ooGSszDCOi8=; b=Q6TyVfkHFDOubtAaefTqq7RMHdyrigVi5kjXfN/azFMij/0kHCDr6c4E rknusmRNZy8ORCr7vUgY9eH3cHHze+Txc3Uokqe0l8/wjZ0FYjhODCP9X OAM6ntKpCwPja6rvOKZI4j3ktqxwr/EB0+IfiYUaAKAcOaSchyvVu2obT kODEBL9UFz/vt/fLE1IbwHSkE9u9wGtv0ub5N1kyTf7Bbz2QyOsAmtlVx SvnC3RdMfe2QenVRgEwcRiDkowHfNIsDHfmk58N9RxWkiYzPlsXIZ8HnB z/oaByzewcEmZkSrrHQGU2gPTV+B2/oLXiGmkLXlRnt/wQJR+QPhx+HC4 A==; X-IronPort-AV: E=McAfee;i="6600,9927,11004"; a="4444095" X-IronPort-AV: E=Sophos;i="6.06,208,1705392000"; d="scan'208";a="4444095" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by orvoesa110.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Mar 2024 03:12:32 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.06,208,1705392000"; d="scan'208";a="47239745" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orviesa001.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 06 Mar 2024 03:12:32 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Wed, 6 Mar 2024 03:12:31 -0800 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Wed, 6 Mar 2024 03:12:30 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Wed, 6 Mar 2024 03:12:30 -0800 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.168) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Wed, 6 Mar 2024 03:12:30 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MwyolVCYxgC3DgjHHemLXjLw3Evh6eCAudCVxEzHE9gu4BpaTqGgDXZNQymI9ZMb0DmDnZQGO/qvrT/ToWi7SCQmsLUWiCSg7XmTuD8l4U7KWLV8xx6EEaeYLPz0Gt1ivle1Q/SXXaNbZroK3P8j2S7CkI1pLeTHsNBTVL0Tdf31/inxwqmVmbyt9HHHJEctNggTO1QkaGlijuKXGGVHpsKvv15Wd28dF3ZvVNX/eUgbEGdkE3SS/w/O0dyqygvx6BEZRanF+7weyyOcuXC7t9LUiDjqJ3YyaID1BWxbDp+06F1Qh8p99KpfnQ+5G8zl9e/NSO5zgEolN4F23xa88g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mvZnRtRPQoqSl5oyphS5C9Va4EZ3Xux5cTwGOiK97rQ=; b=m7bnTAsur89PnwS3T1Gp8jrfOzVqXPNVIM7RKVqcC9yNTCVG+H8L9EgThAxejkEekAPEsIsNCA6DhbhodKsN6sgEvvb7JjEhJpb1t2l0sKgz2OeidG2s5M8mIzMpVKs/WI8GucMHVOxcxh3Ve+d49umZ0qeSabufvwxkWczxpudP1IZIL45j1793d/VfUbHfF9aAw5apXle6SLvCEDZe+cU81Iay2aWQdwlCCDCIQRyCvj/bYqU1wRdDhLH2zpA0icNuY5wzNNcaUzKI+bdHeCfrtb9A1+Ro+HNoRstO2yKa7k5hwNapCemHf8VwI0jJ7agaFUTJgiwStZHg23RA/Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SN7PR11MB7639.namprd11.prod.outlook.com (2603:10b6:806:32a::14) by DM4PR11MB7301.namprd11.prod.outlook.com (2603:10b6:8:10a::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7362.23; Wed, 6 Mar 2024 11:12:27 +0000 Received: from SN7PR11MB7639.namprd11.prod.outlook.com ([fe80::656e:3d48:9daa:7110]) by SN7PR11MB7639.namprd11.prod.outlook.com ([fe80::656e:3d48:9daa:7110%4]) with mapi id 15.20.7362.019; Wed, 6 Mar 2024 11:12:27 +0000 From: "Power, Ciara" To: Akhil Goyal , "Dooley, Brian" , "Ji, Kai" , "De Lara Guarch, Pablo" , Patrick Robb , Aaron Conole CC: "dev@dpdk.org" , "Sivaramakrishnan, VenkatX" , Wathsala Vithanage , "thomas@monjalon.net" , "Marchand, David" Subject: RE: [EXTERNAL] [PATCH v5 1/4] crypto/ipsec_mb: bump minimum IPsec Multi-buffer version Thread-Topic: [EXTERNAL] [PATCH v5 1/4] crypto/ipsec_mb: bump minimum IPsec Multi-buffer version Thread-Index: AQHabyST1igUllyiWUyREP4Zqv910LEpg5IAgAEJClA= Date: Wed, 6 Mar 2024 11:12:26 +0000 Message-ID: References: <20231212153640.1561504-1-brian.dooley@intel.com> <20240305174227.1785111-1-brian.dooley@intel.com> In-Reply-To: Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SN7PR11MB7639:EE_|DM4PR11MB7301:EE_ x-ms-office365-filtering-correlation-id: 4e4b83a5-4f15-4d51-4b8c-08dc3dce4e89 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: vC26DFDgeVVGlXI73YzDw0DpJYPqFsBmtG6FFJfMAKo9jakVkfJ6X0QwBhVayxwlC6j5j9DO1oEqCFUWbFk6Mtqx7yjOeeMcG0mxCIn0Nafc3MWYGKSslK03LL5wXyNdJGuALumQu+/r8rwdy7iH0Ockt//JiO2Uzr3qiVK5oGA9m4l2uq14hRDNE1MFkH9S+jSfEcBDkWKoeBrEAsbvRkPk553AJm45tx3Y9tF98ooJl9zKZqeWmx3J1WIN2D/qd1cBD9yEkXBMosvUTLc4dyHC6+hlTyWq9qfahyybyi0Nklgl/wI2R98IPG//F3LwdPH2xhr2iNHRoLuKerdXf251R8tqTI4oQdcBIHW9rqGahD8PKkZLDqXpfxgwS50JkLgG6S29WW4aseCsCWVRGvDUvvPKNg8guX/jb5p67HsXCZTPHZ5n5ekl98UIRUJqbwuKvmyvfWZjG183WFQ1yr+/xnSn5a6t5F0PewKqBomEA7T2HeaN2IJGih8ZGntdKqPZCk2W6NCT+CdD/abzaD4St5K2xNBFuXbKPl0RKUWfG193yOHDVGYaVG0wlwniBTcOrWlTkrDxvtSIiJLj2Hfx5px73uBZu8nc+DnfFrM2IsPUPvxfdOSlc4Sr1UqNpwnJMufT1Yf66YdnO8xVaRgkmOM1ZxWSShXiSn42GkTG6iBiM46s1nSxclxrNHAZ x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN7PR11MB7639.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376005)(38070700009); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?D49GPgGWCMQT3z6S2cdsqMKtySPdM9Gtj0Rivt/q0QUVg+lQ9zF7Jqa9Lh3M?= =?us-ascii?Q?zJxLuAIWLIKPWtS9Uuipa/26lLpXwADkquo4bGgfHyUAE7GiBwmUzNrsFJLe?= =?us-ascii?Q?k5f67kWnUoF6ZrW0eIOPgNUgVpy8PmPBDSUPQup27xMeNR01y9n8kSxkK0Th?= =?us-ascii?Q?HbdWzi31RyKcW5gUTDlakgWCqNjPN+yC08FY/Tv7FkG/u+MrUVhNJEsCwBST?= =?us-ascii?Q?7d1oZ+mZrQ/MSP8WPZHxHAw1XBjlzRAbGLuFL09HIuuSg1bjawHhVQ3NSHKm?= =?us-ascii?Q?amYUVhM4Gs6ekxmyTwQzGjcLVBNr4eAApWz/khD/brVnSVpSsLB8LQ6QZ+7u?= =?us-ascii?Q?KRpOPjL8vXEwmEpPK3cOFkzAmlT8eIZlrz48fl7uVQZvlrwJnsCo8QEbl9wu?= =?us-ascii?Q?JqTqUPg8OzyY1kE0tu+Vxq0H6Iol6QdPbCBteGq26f6GMYrK1uF1jaObz0U5?= =?us-ascii?Q?u0YI/mxeFUX5hzVcExDybBu31OuU9XLtEi8CO3bIOvr5t5EQzjnWSpLJx9T4?= =?us-ascii?Q?oJwYI1FdaJUWDauVmHHdbMwkdK2iR87rF95W1mO/e3YyFW//oeNOE6AxYISH?= =?us-ascii?Q?K/gmUMqqmnTR4BYkAqi6z/guot33h5b91ul9Moi+b6DbQYdcSnh5u9kZo81n?= =?us-ascii?Q?LWIUFwftq0OqtpvtDXwJsRwzoCrLa5s+fmPHjkl5vF7+BwfeM/kv6X6V2muv?= =?us-ascii?Q?BBZR7pV76+4Plzt2r/iQOgl6Wx6M8klmMyyrtY3QT0kbzZBucEwg6syM2DJ3?= =?us-ascii?Q?4NNQhX5SNFO0XYHMRsjQfK1S9OR3z8OcIf8iG8tXAJakDdz0jEjOcGtnXmDB?= =?us-ascii?Q?7szR5Q3CCBG4buQ2qtY+Ztlc4SP87gW+L3UPAyHNBp/xdv0pJgQcHfeYNJVC?= =?us-ascii?Q?8ucNH9YDI+utaH95TTf9u/FTkJ59Ni87vTd2Z1K6n0nNi6rxHOxaU0Qf0eR6?= =?us-ascii?Q?O6w1ejgwM0l1/Mvc8NxsFquqQwk0lW+pSTZ9S4Q3T3GJr2crJZCBsIrcUZoE?= =?us-ascii?Q?X8USEvt2h+nHCwwPm+uavo7Sm85pwpNBkXVLvLe+QMPt3sQ5hqWcIpamzwMT?= =?us-ascii?Q?BFYFBWvQ63GXUrwIJ2lf7x/AKWSc8EBAsl42EEWZmY6se5P5mVqDp7YLfQXD?= =?us-ascii?Q?kPqnHHKTri8ozGEZPMIaQII6/S81gaJN7E25hMdd3tS0A7yFaxnJvK3axVeU?= =?us-ascii?Q?k62ICvL33setBNZBzUvP9L/GT5VRO84jFaB6YBIZ3oikbiDUJhl65TOR5FOn?= =?us-ascii?Q?8rtjQiZc0+99AGnUq8eY0jfIWqUHgAex6wdeAhnDpANPcodG1f9hysRpy5PG?= =?us-ascii?Q?kHHVGscvnWYcrPkW/e0Vv6ZmOSyGfEHrDzdk7J8uHzqTHSHDp1SKhmXkWQSG?= =?us-ascii?Q?nZ3CdJj5Pfo025SI7f4W7HO+DqQshYY3Nx9w3n8nm5SYeInSuFY+soYUuiHJ?= =?us-ascii?Q?SLbp4YBqXgRqLQVubKECtQDFHKGOSq4tJ0nXs8HqEOSKJoOvHQeQ88jULTFM?= =?us-ascii?Q?c71a68tx++gpBICz7BUsaOcPyVPfakF7yTB8KTUvQNCgXm3kFgpT70Ix4IWJ?= =?us-ascii?Q?u7VYBMxwEg6txy9EmVpIbOSP17XDAeu0D1gGheRm?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN7PR11MB7639.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4e4b83a5-4f15-4d51-4b8c-08dc3dce4e89 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Mar 2024 11:12:26.9607 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: M+/XofSVpdHOW28acmq1UXdXtWoCACUNwq7sX2m0x3Zq6VSCkGClXsdiPGmprUrtPe7BL62nR99v6xdGYx06iQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB7301 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Akhil Goyal > Sent: Tuesday, March 5, 2024 7:12 PM > To: Dooley, Brian ; Ji, Kai ; D= e Lara > Guarch, Pablo ; Patrick Robb > ; Aaron Conole > Cc: dev@dpdk.org; Sivaramakrishnan, VenkatX > ; Power, Ciara ; > Wathsala Vithanage ; thomas@monjalon.net; > Marchand, David > Subject: RE: [EXTERNAL] [PATCH v5 1/4] crypto/ipsec_mb: bump minimum IPse= c > Multi-buffer version >=20 > > Subject: [EXTERNAL] [PATCH v5 1/4] crypto/ipsec_mb: bump minimum IPsec > > Multi-buffer version > > > > From: Sivaramakrishnan Venkat > > > > SW PMDs increment IPsec Multi-buffer version to 1.4. > > A minimum IPsec Multi-buffer version of 1.4 or greater is now required. > > > > Signed-off-by: Sivaramakrishnan Venkat > > > > Acked-by: Ciara Power > > Acked-by: Pablo de Lara > > Acked-by: Wathsala Vithanage > please check these: > https://github.com/ovsrobot/dpdk/actions/runs/8160942783/job/223086396 > 70#step:19:19411 > Error: cannot find librte_crypto_ipsec_mb.so.24.0 in install You need to = get this > fixed or else CI would fail for every patch once this series is applied. I am having trouble reproducing this one. I have run these commands that I saw in the CI log, before the patches, and= then after the patches are applied - with ipsec-mb v1.2 on system as in CI= . meson configure build -Denable_docs=3Dtrue -Dexamples=3Dall -Dplatform=3Dg= eneric -Ddefault_library=3Dshared -Dbuildtype=3Ddebug -Dcheck_includes=3Dtr= ue -Dlibdir=3Dlib -Dwerror=3Dtrue meson install -C build ninja -C build It compiles ok both times, first time it compiles ipsec-mb PMDs, after the = patches applied, it skips compiling the PMDs as expected. I am wondering, could this error be to do with the ABI reference/install co= mparison? Maybe reference has the ipsec_mb.so file from a build that supported it, an= d it can't find the equivalent in the new install, because it's not compile= d anymore: + devtools/check-abi.sh reference install Error: cannot find librte_crypto_ipsec_mb.so.24.0 in install Aaron, could that be the case? Or, maybe my steps to reproduce the build setup are incorrect? > And this is also failing http://mails.dpdk.org/archives/test-report/2024- > March/601301.html > These need to be fixed in CI infra. This function that throws the error is available in the recently tagged 1.4= equivalent Arm repo, so I am unsure why it can't find it. Could there be some old installed ipsec-mb version in the environment that = is being picked up by DPDK? Sometimes the meson configure step will pick up the correct ipsec-mb versio= n, but then ninja step links to an older version that still exists and hadn= 't been uninstalled previously. Not sure if that could be the case for the CI container though - Patrick ma= ybe you can verify there are no 1.3 or less versions on system that could b= e being picked up: I usually use something like: find /usr -name libIPSec_MB.so\* Thanks for the help, Ciara