From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0AE944333A; Wed, 15 Nov 2023 17:24:59 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 81F16402B7; Wed, 15 Nov 2023 17:24:58 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id C812B402B0; Wed, 15 Nov 2023 17:24:55 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1700065496; x=1731601496; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=J78+CYC+TbxQvzz7hPma54Ud7SLq7r+9szziFP4TbQg=; b=Xj/8Aws13tDvJEyljU6SJLNsbsp3KgW4++o19bAYnvV34O7q50c0fpYs +VR81w1XLmyUDvP4wTnzAaVNrmr08xmO1BGuYkvF3uCAJjTqIDpinnr+0 cZGHfxCG9hSQarPoYfIsVJtiKZJvBUUR2mmhRxwTq2e5zr2+SGdKfEh3U jMchIBMmaujD+5MvSJhAvKthl5zvh3vglwvZv6PgW5CX7f/KLU/shKBI8 EaneycIKzwgVfv4hCBDxCQRiA39IthWe7A+JIbT5TyM6SAzt8dBDqHxAu xHpeG1ez7guPrsmB5hr9jBmJvEU6kTft4yEc04/TzlCR7f+k8SUDRMr2i g==; X-IronPort-AV: E=McAfee;i="6600,9927,10895"; a="389756968" X-IronPort-AV: E=Sophos;i="6.03,305,1694761200"; d="scan'208";a="389756968" Received: from orviesa002.jf.intel.com ([10.64.159.142]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Nov 2023 08:24:54 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.03,305,1694761200"; d="scan'208";a="6215353" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orviesa002.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 15 Nov 2023 08:24:54 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Wed, 15 Nov 2023 08:24:53 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34 via Frontend Transport; Wed, 15 Nov 2023 08:24:53 -0800 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.100) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.34; Wed, 15 Nov 2023 08:24:52 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KjjNAXgNedwDvV/k6TvWJFd2GKkEZdLjp4VWVliQLWxL4x8wlnybZfIqVojCnO3D6XjOymAT4zRz2v8cAwT+krmYElqNO+HOJXvJugk1kGMiexXSLngVT/xKTHWu6AQFh3umIwwcJqERvWUIOBoW1jGumsQdvSExPq7nq5MwyVqIfn+iBrQGXEQbJe8VQHKk8ys5naorQT9y6uoSx05u6EVBFvqE7aMElo7to+x/0J/ejk1JH7Y9HtdbQ/WbegQWPyBLq1JytO58gWaHApvMttA3ybru80VDjQqT0Qzl9ppUp6DyKZvKFktRkMjaNoydBGW+yxC4N99QueVNkyX4DQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=J78+CYC+TbxQvzz7hPma54Ud7SLq7r+9szziFP4TbQg=; b=EIbbCzZuRjcJm+yFmJDLKWFhJp8tDW68ZGRIw3BdxbbwXPmcAJhtUdXCwpNCiaLp1eDXT7YwlW4igAVuWbZ+mujYGa10GfQBJ26oVCHGeQ3McTYO3LWBm6Z5wR0z4YWOa1zgril5szHTNJnv4zwxbyX1EpZVBuXY5Z0e+jcJS5ZwItqIZ+x8JfgwVPDH2fujXh5X+F7qVM3Au+MsFf8IOgNHLEjuRuIf80WtsWov7ww0VwkjJKET6BHadolacxegS3iAkkCgX5gHOp8D11XO2pwYUf1Pu73KScM/HapGAwTtN4wXwiUAi/YWlu0GCdue79eJRKuoWWGudTVj1ed0YA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SN7PR11MB7639.namprd11.prod.outlook.com (2603:10b6:806:32a::14) by SN7PR11MB7090.namprd11.prod.outlook.com (2603:10b6:806:299::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7002.17; Wed, 15 Nov 2023 16:24:50 +0000 Received: from SN7PR11MB7639.namprd11.prod.outlook.com ([fe80::809d:52ab:dc3b:8a10]) by SN7PR11MB7639.namprd11.prod.outlook.com ([fe80::809d:52ab:dc3b:8a10%6]) with mapi id 15.20.6977.029; Wed, 15 Nov 2023 16:24:50 +0000 From: "Power, Ciara" To: "Dooley, Brian" , "dev@dpdk.org" CC: "Dooley, Brian" , "sergio.gonzalez.monroy@intel.com" , "stable@dpdk.org" , "Nicolau, Radu" , Akhil Goyal Subject: RE: [PATCH] examples/ipsec-secgw: fix partial overflow Thread-Topic: [PATCH] examples/ipsec-secgw: fix partial overflow Thread-Index: AQHaF7+tRrEfOAUrJ0OLeYM2q5Uan7B7kOiQ Date: Wed, 15 Nov 2023 16:24:50 +0000 Message-ID: References: <20231115123101.2377544-1-brian.dooley@intel.com> In-Reply-To: <20231115123101.2377544-1-brian.dooley@intel.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SN7PR11MB7639:EE_|SN7PR11MB7090:EE_ x-ms-office365-filtering-correlation-id: 48e959f5-b812-4409-2f77-08dbe5f76454 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Q2UT/z+Ox98yQk1OJF1cFxdkFa29kPxOtZoQaXxu+1u9kySskR0o6QRH0xeEtBEI4uD5fhQW8K+Z3bkk/56JgkkDTncMUL9cuwHxZxXozT7/guK9NfWORiePb2lUlPlen4TCz0Vnr1RfDZSRwkq3vN2Q6A3F8JGPIWltjKV0aH2k/Xe/ordR9dCL1nQ2Pt9shncP8pIR2IlKnefkLDg0276j2Wj2GmZm12dJaTo0FBG4m4zfc1eYKRHH0ZMvHsknWW7D64gpSLdDZrk9OFEgW5a3IjN1Wr0lZOZR8brhcLiOZWX1uyP48NllI57j05bPQW28BEhZV3AQWvMH95nklp1PoP8D12R5RPozCrSOw94CtdV7d8pJHVCR6NPJZstBF5puyUpQTJXzwka3VCLXT85JzE4sRvGdzTUFTR9Z3nC8CA4dxoT9+n5DAz1CzULkynIp6cK/bNog5BMAWvKf3MyntyvPU6+mskSfVNhhnhSL7u+LFmVag4LdgnJswJV5gIXlqQ6+j1s9qOoztGDZclOXtEdDbHAHLQ79bLTuat0q4jpe8+gLBTAOD/WipuB9K9cSorRxXMfQ/Ihb4GCjz4CWOja/fRzmb84c1w4Zasa+LHFR4CfQhJkYRgIP5w4k x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN7PR11MB7639.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(366004)(376002)(39860400002)(396003)(136003)(346002)(230922051799003)(64100799003)(451199024)(1800799009)(186009)(66476007)(66556008)(54906003)(66446008)(55016003)(66946007)(5660300002)(478600001)(316002)(76116006)(64756008)(8676002)(71200400001)(8936002)(110136005)(6506007)(52536014)(7696005)(9686003)(4326008)(86362001)(41300700001)(82960400001)(33656002)(83380400001)(26005)(38070700009)(53546011)(38100700002)(122000001)(4744005)(2906002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?kBK/jMdWjGXjiNgPBs4vW9W3c5/dtAE1TqTtyeZicYA8C39k7Alyl4Ufu5D7?= =?us-ascii?Q?1My0Ip2gfvuW4Mz5pNHzsRxazTVxTQEek4lvF/L/Ur8wKxatr27DrKVjd1Wd?= =?us-ascii?Q?DFhxhJaPClEFXMsEl3lTKzuYix8Lxl/tGI9YSe9QepKkWSVr0HOYj1u9sxXx?= =?us-ascii?Q?Z6ZDjhhZVg4fZnKG7KOnpQ5A8eCY+EMarPb1V2c+Hsr9PLkNaJyNwhgqzEtE?= =?us-ascii?Q?dovIlLZSxeFeOK84qQX5EyBJTYsWoKrEmS0BUY23lJK8f4taa3XW5SJAM+Xd?= =?us-ascii?Q?I/EUpX0jUW+DPMzMrJTyj0MQh8R3c4CMb6EgYhs/ZorKPi/U1G12rpMlgip5?= =?us-ascii?Q?chi8CjGMAeS19rlkoQbwDO8iV6l0SZpRzLL58RtzUmUmvEq8aFSzzlOGLnQM?= =?us-ascii?Q?aMK6mxAlSYTAHWar4iaMk4cTc+qUqIUpmM9Zt/JR2SEupymhNJXn9p/PnFIN?= =?us-ascii?Q?ZXndm3HlCpBINskQRzMPjX0h49fkxyvheLOUcNz0n3TofTtWDdiwoNThRkHL?= =?us-ascii?Q?ZDcnfWSYkgW7JpUS8sZQIcpyGpNSDBu9dfaE00XiCs8rgLZ1Ddtn8giy7A/v?= =?us-ascii?Q?8QhLNKxrubkunS/ajH3ndzO2aMjTiTvg4Ua1bAtNpZiWCBDCD6HdI3PlKH//?= =?us-ascii?Q?EUo36KD3+AIBSTbAi0wT7Io3qodjKxPamRqEQ5MbUdBTIaIE7dTuK661HCb1?= =?us-ascii?Q?sranT99nxucVZHS80AJvmcpggf8OPdkYNfzs0MMFR09JSon3G3554gLe7aCQ?= =?us-ascii?Q?VyjN3rdVjiNAMNWqgcgYPknam9CfbRP7r6excrxFksGuvMEa2VdHQzFo3WIr?= =?us-ascii?Q?m5ALpgtYlPam+UJiydIVORLveUx0dLQWVX6HpaVKLZ2xUnUc5mqjvpIdLdSh?= =?us-ascii?Q?PprxXkGanJaEreqKVQY0rYlhBMT0KWP8dYWIFlQEjq2a7OWx95JZrfY51fS0?= =?us-ascii?Q?eGSmY0IQsGfTBVGYuwP+1+LuMtfCD+X356aD3Cw2JrYH3jAWHSHawxenNCvr?= =?us-ascii?Q?skhuOH/EsN+Z3yzTD2nbhO3i0f2EHEOGXBMKgA6EQoAUhxpIFbehMe5r4PEI?= =?us-ascii?Q?BCnzbZ6I9G4PMdrRokT9hnCTjPEM3D78jKAyT+pP+Xx8s47AEuoOMZnY9xFC?= =?us-ascii?Q?Fdl69otftS7dK5B6k5FlXJSQdvXAWB3Hq+TeitsuTQtHSTeSG1TSFwSiErno?= =?us-ascii?Q?ggbvtkoeeSqVy90OPVrJ5smbQdPPOEuwWnascSGAn2Hm6iuF+5ytoqgTRol0?= =?us-ascii?Q?gMbmi5NJzOR/8wq1qAwaCZ/HSjse4LwEDxbxh4apOjxQ55H9sQu9xB5XCD37?= =?us-ascii?Q?651HiV5ceWUmG9d1QzLQoo1Fr9SVXn9jjVW20zInSG3pQIzy8jW7VmWaQ0v0?= =?us-ascii?Q?caXM3tqHr7+pMYWtf5vCPH5piBytHmMjHaDYx+unZSnJqBYDZNn+JdGyS/OP?= =?us-ascii?Q?aw+FMzzTnEki3leJjXVvz5d5VsiAcjttILb2HrGvv1aMhNe3syrTIjM1zrLN?= =?us-ascii?Q?F5kbQbUTuSucTVZ4hTfydfn4iBHNwq7unFeYAuKmWAsvSSJ4K17el/ytzZ7r?= =?us-ascii?Q?HSRlJN5s6Ig7PUqm0Iu9UQxQ8T76zGZLjEdxm6Ek?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN7PR11MB7639.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 48e959f5-b812-4409-2f77-08dbe5f76454 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Nov 2023 16:24:50.5418 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: DTWtm3CDDZ3eHeettSTV4tO6sxDzbIsFEA8OYtWTfZwN+fKb5iujLiUHupayD1P1J/6OXydeOfAzAkv8JtauOA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB7090 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Brian Dooley > Sent: Wednesday, November 15, 2023 12:31 PM > To: dev@dpdk.org > Cc: Dooley, Brian ; > sergio.gonzalez.monroy@intel.com; stable@dpdk.org; Nicolau, Radu > ; Akhil Goyal > Subject: [PATCH] examples/ipsec-secgw: fix partial overflow >=20 > Case of partial overflow detected with ASan. Added extra padding to cdev_= key > structure. >=20 > This structure is used for the key in hash table. > Padding is added to force the struct to use 8 bytes, to ensure memory is > notread past this structs boundary (the hash key calculation reads 8 byte= s if > this struct is size 5 bytes). > The padding should be zeroed. > If fields are modified in this struct, the padding must be updated to ens= ure > multiple of 8 bytes size overall. >=20 > Fixes: d299106e8e31 ("examples/ipsec-secgw: add IPsec sample application"= ) > Cc: sergio.gonzalez.monroy@intel.com > Cc: stable@dpdk.org >=20 > Signed-off-by: Brian Dooley Acked-by: Ciara Power