From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E606C43279; Fri, 3 Nov 2023 12:39:04 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BB27D4027F; Fri, 3 Nov 2023 12:39:04 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.9]) by mails.dpdk.org (Postfix) with ESMTP id 5FA8640273 for ; Fri, 3 Nov 2023 12:39:03 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1699011544; x=1730547544; h=from:to:cc:subject:date:message-id:references: content-transfer-encoding:mime-version; bh=w0YMFKywGAYoO0aYKBRGt4WWbNl97yKnFWPKmmpq608=; b=l5PZB+0zj9B7CgaxE1OtnPHuPJ8INle1uXWSaLlip3V/NIdcbkCFYWrJ 5eYHYrbAqgfeRq+I2sz0HkBKzR0GSkm873gEdGIDsyrFHc2+rEjhyY9Ov +QWyBBbRtVv0TgXWS51eNYvidtqEJMngPil1Qok+WVlWf7EkcUYSm7sLM YVHX+ZYt5ei8sku4jaYizf5yiAIC+lryZ7/1BtXxLw+6lMD53uUPFWNtg SKzW4X1zKM1wc+r+Bbocu0WrQh6nB92THR2C9Byz70FMKvPPEWIK7w6nH JMoVw1aF1I2ChK3pVThiRwQofjAXIGWbxw3mvPVK2ieCCrbGN7sU8w65l A==; X-IronPort-AV: E=McAfee;i="6600,9927,10882"; a="7567287" X-IronPort-AV: E=Sophos;i="6.03,273,1694761200"; d="scan'208";a="7567287" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Nov 2023 04:39:02 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10882"; a="885206710" X-IronPort-AV: E=Sophos;i="6.03,273,1694761200"; d="scan'208";a="885206710" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga004.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 03 Nov 2023 04:39:02 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Fri, 3 Nov 2023 04:39:01 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34 via Frontend Transport; Fri, 3 Nov 2023 04:39:01 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.101) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.34; Fri, 3 Nov 2023 04:39:01 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iKr5XSxJo4C2kBJ3QsrQL0bgGmVr++XyZMYPni/nr9qONAOrVeBck+KBeZo45M/Klx/AioNzAYvgtRt3fPPh4iEXIgnVCcWE2rlwAfBuciLU6KAgEsVWDn96tdEcFizeqXhZpJY83X/r2VUf1vw3OoGv58OJjawkUnRnWcNCpQ3Daz0k2KABs0rHCQC/BK5bPMWqojwBfGG6X+GFh/2d1xhowpFrU1g+zaT7+7WRjx57yaoJ3CWn2l4Or1h806+ABLsqMt7SoCeLq18o/XirH60U7kufRbvEZ1FBKiuQ6f62ULWWYKybQ0YELNiYQVw2mqIqty1bZRGZvTDhLcsfYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FBakJulYJcxCIG825VS8f9aE9Oy8qGYSprfkA+vPgX0=; b=kQch6njaAs6JPUh9yzrFGfVwZKKYLiyLnt/JPypg0mDzTx9GdJTY8bZWr1lO78c9MhSCkwqzkgOPU4ncXOMdh8IkA2ZpS9AyCwxz4SddLOTFpY4rUg8cfbq8t2dXRn5rOLMB3CNukm63t87WLR61e2jUoFK1QE6IkAFxmjL3mat6DhaYu8i9QucPxhfd4mIK5h87lV7nm4Z8X7hco3oAFHX9EbAx+GP2KXq/8xlrfOZRvSO1XisTrWIhCMUtKlFeF1OpeUi/qvhrdHZYsMH+vvvOrKSjXoANeh4TzmtTKPLMp6I/d3IuMDOriVbmD5GxiEBS0WxMs4B81trP6Dluvg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SN7PR11MB7639.namprd11.prod.outlook.com (2603:10b6:806:32a::14) by CO1PR11MB4802.namprd11.prod.outlook.com (2603:10b6:303:94::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6954.21; Fri, 3 Nov 2023 11:38:59 +0000 Received: from SN7PR11MB7639.namprd11.prod.outlook.com ([fe80::809d:52ab:dc3b:8a10]) by SN7PR11MB7639.namprd11.prod.outlook.com ([fe80::809d:52ab:dc3b:8a10%6]) with mapi id 15.20.6954.021; Fri, 3 Nov 2023 11:38:58 +0000 From: "Power, Ciara" To: Gowrishankar Muthukrishnan , "dev@dpdk.org" CC: "anoobj@marvell.com" , Akhil Goyal , "Ji, Kai" Subject: RE: [PATCH v2] crypto/openssl: fix memory leaks in asym ops Thread-Topic: [PATCH v2] crypto/openssl: fix memory leaks in asym ops Thread-Index: AQHaDd3Hs0lNfRylrkOWRZO52yg3JbBoWuRAgAAdglA= Date: Fri, 3 Nov 2023 11:38:58 +0000 Message-ID: References: <20230919130412.284-1-gmuthukrishn@marvell.com> <83522013646bcd96b2420b3f69b74255981b3a20.1698913776.git.gmuthukrishn@marvell.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SN7PR11MB7639:EE_|CO1PR11MB4802:EE_ x-ms-office365-filtering-correlation-id: 7aecda00-f9f6-496f-578f-08dbdc617814 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: IZEZ1B/a6yA2Hu2e0Df6f/iQlGVHAecAII7Celt0LR90fysqIV2scV5FFGN4D1B5nHgA45/p2kdqJwyibl6ELPgkk4ZbjVqhKFqZ63qyQyIF5gLHR7ilEV+mfkNJuTPPjoRp+B2Np6F4+jyl7TaFGR3wxzW2eKiHwHiMY3kU0MPIUbLUHQpFBG8IaDgAU7kzgbQyUg+s/qFVSt/OMGLQ3f12vscFLdQrTb1dbEoImrCSzXseYutOuwveCrM1pRGxt60gaFkZetrTazO/zgayhOa3/17trNnUTOGNNWAiqGWtf1lcGTwIVz/gl1dBLlhQ5rnkuFjDAFqbVlMOVcauKva9XLjmLlxUGaaLGUjwLxitSPtFNQTFiQHDYlD+nBmABi34GivwaFA5ibfd5BYfHdFstuCVaX47yIVTgOMwl88sW6nVW3iW9p/mB0o9ejB51YWOmZfeOAEjD0Hy0mV1BkhoSpBnJ+ADPBn+zv3Z4/SPhb2ezKo8C0qE2+KfRFmyizQxo5wgUHyZfWlhUON9pc71ovG3my6c4gL9RGOUQA0JYuI2VtrRVm9os4pHVfPbYwTsoJ/bSpPEq8UDUZTxc9gCM8g2YPVM30tdFfTyOl72subLGfmYFaRhojLw3Y7C x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN7PR11MB7639.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(346002)(136003)(366004)(396003)(376002)(39860400002)(230922051799003)(1800799009)(451199024)(186009)(64100799003)(7696005)(107886003)(53546011)(9686003)(38070700009)(6506007)(83380400001)(26005)(5660300002)(76116006)(82960400001)(122000001)(33656002)(66946007)(52536014)(316002)(66556008)(66476007)(110136005)(66446008)(54906003)(86362001)(64756008)(55016003)(2906002)(71200400001)(38100700002)(8676002)(8936002)(41300700001)(478600001)(4326008); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?FUUzCs5Hojr7T+qnRBe6ja7+FZu8QhP2UkO0gMoZ4rnUd8cr+qNj+LcLINp/?= =?us-ascii?Q?yjrXiCYEfgxg/AhjzLgOAxKpNpxT8yx77dWV06mIYeaf5nX5VMz3Vznk6IC4?= =?us-ascii?Q?MLKiJdUXlLYPSO6qGH4lNu35ShweAUM3RDzceUAvAVBt03eyQFk1WS35LDOf?= =?us-ascii?Q?uAomcUen0g2+Y3KuEsevGsjyu6u8DEm4RMDL9kO9lfrvYVUP+mEyit8KT68s?= =?us-ascii?Q?vwgExGv29ENmmNpUkbgQDEesXcMHP74joYBYO0+wKpOZWznLOnESuNIkO0Ig?= =?us-ascii?Q?Q8gbZ1sMm/3574LjaV3/G1m0Iswq/Bl2xmoCOa297Z7lghrswt9JGYB3FO+G?= =?us-ascii?Q?yoe2zgq5VTn7MgrOKhuDva/j0qcd6ukpfYuSO3vr28zhj1Utq3R0WX6nrLyk?= =?us-ascii?Q?dXL3Bw8NFYpPvMeZwx3IQSFJo6rw66451mI3JopveuxOfWmH0yx7ZxoUJjpx?= =?us-ascii?Q?b4v+KAqXeFHq8JOcbogkfqU3IbiJpis0FA+fYTpIliC+Y7NNPQxxiODWxMjO?= =?us-ascii?Q?ibvvCzWUlwrfQofDYtekHm0eb6quNaEds+b9QctzYGoL9QlSfBpmrPL/B+BB?= =?us-ascii?Q?DYblfycxOMBm9cvCXLEzGrJeYLUjtmVbNkIGceMA9Vj33FO4RVHBTGo3hHRf?= =?us-ascii?Q?QUMP/I01DAc4KSMJa/Zh/So5mymfufo2ZIBfSVtGqqlQS3Jl4FZOodMZZ0Hr?= =?us-ascii?Q?KnSpTgzifdS7OaWicUkJxtcMRF9eL05R/avCBOyd3ndIe6E839GKqbR/bxDE?= =?us-ascii?Q?WPHBflT18CRMj6+D0EZ3sYHh8mxLHybbNxHusEACOcaqEfk737wdKKJVZEE8?= =?us-ascii?Q?eNRjJHjvt3Ow0NaG9a/gX22h3M3CC7KQzKEm70EU/z0UQQF81tj6hNZAFYbF?= =?us-ascii?Q?ak71Lo7KY58sLC3pkVEuVDud1AYL8Ty68o6IEChxIGqjRu1a0ZXwEg/OHjFt?= =?us-ascii?Q?EcEZ3hxprxrWbk7mfy32VXx8NJ38xZauTz7cVLvVwEDbANJVOL/F41WtNAd5?= =?us-ascii?Q?S4OC7Qqq0egaNoUzzNQJI0kW+j5pz2/ILf582Q2ugPHTfox5M0UsDCZ8vjKj?= =?us-ascii?Q?56kjGharKJ0T0EgvOISCxyfVzq5OUj5Lc+C/9yL5dKQApx8hmrPrl86cGyOd?= =?us-ascii?Q?mG1YL3RSPAU1GXS0PAwAL5uwTi/14nsptkXtfTRQqMfIquWO6vzD7uw44DNm?= =?us-ascii?Q?5KxNKp+03mx4J/+0z4IE3tRa1q4KLDhVzfy23Z4HJ4Oqhj4MW1ys2+2aunjX?= =?us-ascii?Q?01sINHqoYI7gunuNgFVsOvL9C1fQdCt/uJWa2Wf98x3Xf3c3YEAWcyfU5UiY?= =?us-ascii?Q?LjLzLhMb/FNx2qwTfZGW0GU0iwNTXsO3hb6/0q1QcRHyGtLrBo7sxc2hGhFO?= =?us-ascii?Q?m4LHWjgG2iVwJstYpmL6aLpOX8/FvJ/FNMVhREUDd6nRLZ+RoPxTJdBCj6M3?= =?us-ascii?Q?7tl0PBOTQKHeurhpWJm7UiZYiEnlgLRiJ4VAJSKodNBvNqS9IeXY+ZxpJMIk?= =?us-ascii?Q?YLWxWWEo7OzOJQbp8dyaUrf57ITrSMgV+z10ioAC3XVyjEJ8F9AvnEMAPLLy?= =?us-ascii?Q?Az9lLhuR2EUk5zX3tPRwBDIgcAuL87bz+S5j/rgD?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN7PR11MB7639.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7aecda00-f9f6-496f-578f-08dbdc617814 X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Nov 2023 11:38:58.7370 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: HCc5IvnaTS/VEN8FIpzZlzoZ7lGPz7AlqKsXTYhtTalODoEEzTBrZ1l1wMzbyPCH6vRKJfOlvZqaQagiCu+Rvg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB4802 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Power, Ciara > Sent: Friday, November 3, 2023 10:18 AM > To: Gowrishankar Muthukrishnan ; > dev@dpdk.org > Cc: anoobj@marvell.com; Akhil Goyal ; Ji, Kai > > Subject: RE: [PATCH v2] crypto/openssl: fix memory leaks in asym ops >=20 > Hi Gowrishankar, >=20 > > -----Original Message----- > > From: Gowrishankar Muthukrishnan > > Sent: Thursday, November 2, 2023 10:04 AM > > To: dev@dpdk.org > > Cc: anoobj@marvell.com; Akhil Goyal ; Ji, Kai > > ; Power, Ciara ; Gowrishankar > > Muthukrishnan > > Subject: [PATCH v2] crypto/openssl: fix memory leaks in asym ops > > > > Fix memory leaks in Asymmetric ops, as reported by valgrind. > > > > Signed-off-by: Gowrishankar Muthukrishnan > > --- > > v2: > > - added more fixes. > > --- > > drivers/crypto/openssl/rte_openssl_pmd.c | 38 ++++++++++++++------ > > drivers/crypto/openssl/rte_openssl_pmd_ops.c | 15 ++++++-- > > 2 files changed, 39 insertions(+), 14 deletions(-) > > > > > case RTE_CRYPTO_ASYM_OP_VERIFY: > > { > > - unsigned char signbuf[128] =3D {0}; > > BIGNUM *r =3D NULL, *s =3D NULL; > > - EVP_MD_CTX *md_ctx =3D NULL; > > - ECDSA_SIG *ec_sign; > > - EVP_MD *check_md; > > + unsigned char *signbuf; > > size_t signlen; > > > > kctx =3D EVP_PKEY_CTX_new_from_name(NULL, "SM2", > NULL); @@ -2857,13 > > +2862,18 @@ process_openssl_sm2_op_evp(struct rte_crypto_op *cop, > > r =3D NULL; > > s =3D NULL; > > > > - signlen =3D i2d_ECDSA_SIG(ec_sign, (unsigned char > > **)&signbuf); > > - if (signlen <=3D 0) > > + signlen =3D i2d_ECDSA_SIG(ec_sign, 0); > > + signbuf =3D rte_malloc(NULL, signlen, 0); > > + signlen =3D i2d_ECDSA_SIG(ec_sign, &signbuf); > > + if (signlen <=3D 0) { > > + rte_free(signbuf); > > goto err_sm2; > > + } > > > > if (!EVP_DigestVerifyFinal(md_ctx, signbuf, signlen)) > > goto err_sm2; > > > > + rte_free(signbuf); >=20 > I am seeing some issues with this line: > =3D=3D1788670=3D=3DERROR: AddressSanitizer: heap-buffer-overflow on addre= ss > 0x7f78bfe4d337 at pc 0x55bd318866c2 bp 0x7ffc91e02420 sp > 0x7ffc91e02410 READ of size 1 at 0x7f78bfe4d337 thread T0 > #0 0x55bd318866c1 in malloc_elem_from_data > ../lib/eal/common/malloc_elem.h:315 > #1 0x55bd31886bc7 in mem_free ../lib/eal/common/rte_malloc.c:37 > #2 0x55bd31886c6c in rte_free ../lib/eal/common/rte_malloc.c:44 > #3 0x55bd37795665 in process_openssl_sm2_op_evp > ../drivers/crypto/openssl/rte_openssl_pmd.c:2890 > #4 0x55bd37795c7b in process_asym_op > ../drivers/crypto/openssl/rte_openssl_pmd.c:3088 > #5 0x55bd377ac886 in openssl_pmd_enqueue_burst > ../drivers/crypto/openssl/rte_openssl_pmd.c:3213 > #6 0x55bd3011788a in rte_cryptodev_enqueue_burst > ../lib/cryptodev/rte_cryptodev.h:2038 > #7 0x55bd30125331 in test_sm2_sign > ../app/test/test_cryptodev_asym.c:1976 >=20 > Address 0x7f78bfe4d337 is a wild pointer. > SUMMARY: AddressSanitizer: heap-buffer-overflow > ../lib/eal/common/malloc_elem.h:315 in malloc_elem_from_data >=20 >=20 Quickly looked into this - seem i2d_ECDSA_SIG changes the pointer passed in= , so signbuf no longer points to the allocated memory afterwards. Temp pointer is needed here, something like: +++ b/drivers/crypto/openssl/rte_openssl_pmd.c @@ -2814,7 +2814,7 @@ process_openssl_sm2_op_evp(struct rte_crypto_op *cop, case RTE_CRYPTO_ASYM_OP_VERIFY: { BIGNUM *r =3D NULL, *s =3D NULL; - unsigned char *signbuf; + unsigned char *signbuf, *signbuf_tmp=3D NULL; size_t signlen; =20 kctx =3D EVP_PKEY_CTX_new_from_name(NULL, "SM2", NU= LL); @@ -2869,7 +2869,8 @@ process_openssl_sm2_op_evp(struct rte_crypto_op *cop, =20 signlen =3D i2d_ECDSA_SIG(ec_sign, 0); signbuf =3D rte_malloc(NULL, signlen, 0); - signlen =3D i2d_ECDSA_SIG(ec_sign, &signbuf); + signbuf_tmp =3D signbuf; + signlen =3D i2d_ECDSA_SIG(ec_sign, &signbuf_tmp); if (signlen <=3D 0) { rte_free(signbuf); goto err_sm2; Thanks, Ciara >=20 >=20 > > BN_free(r); > > BN_free(s); > > ECDSA_SIG_free(ec_sign); > > @@ -2880,6 +2890,12 @@ process_openssl_sm2_op_evp(struct > rte_crypto_op > > *cop, > > ret =3D 0; > > cop->status =3D RTE_CRYPTO_OP_STATUS_SUCCESS; > > err_sm2: > > + if (check_md) > > + EVP_MD_free(check_md); > > + > > + if (md_ctx) > > + EVP_MD_CTX_free(md_ctx); > > + > > if (kctx) > > EVP_PKEY_CTX_free(kctx); > > > > diff --git a/drivers/crypto/openssl/rte_openssl_pmd_ops.c > > b/drivers/crypto/openssl/rte_openssl_pmd_ops.c > > index 2862c294a9..98450f36cf 100644 > > --- a/drivers/crypto/openssl/rte_openssl_pmd_ops.c > > +++ b/drivers/crypto/openssl/rte_openssl_pmd_ops.c > > @@ -958,9 +958,11 @@ static int openssl_set_asym_session_parameters( > > rsa_ctx =3D EVP_PKEY_CTX_new(pkey, NULL); > > asym_session->xfrm_type =3D > > RTE_CRYPTO_ASYM_XFORM_RSA; > > asym_session->u.r.ctx =3D rsa_ctx; > > + EVP_PKEY_free(pkey); > > EVP_PKEY_CTX_free(key_ctx); > > + OSSL_PARAM_BLD_free(param_bld); > > OSSL_PARAM_free(params); > > - break; > > + ret =3D 0; > > #else > > RSA *rsa =3D RSA_new(); > > if (rsa =3D=3D NULL) > > @@ -1030,7 +1032,7 @@ static int openssl_set_asym_session_parameters( > > } > > asym_session->u.r.rsa =3D rsa; > > asym_session->xfrm_type =3D > > RTE_CRYPTO_ASYM_XFORM_RSA; > > - break; > > + ret =3D 0; > > #endif > > err_rsa: > > BN_clear_free(n); > > @@ -1042,7 +1044,7 @@ static int openssl_set_asym_session_parameters( > > BN_clear_free(dmq1); > > BN_clear_free(iqmp); > > > > - return -1; > > + return ret; > > } > > case RTE_CRYPTO_ASYM_XFORM_MODEX: > > { > > @@ -1228,6 +1230,7 @@ static int openssl_set_asym_session_parameters( > > } > > asym_session->xfrm_type =3D > > RTE_CRYPTO_ASYM_XFORM_DSA; > > asym_session->u.s.param_bld =3D param_bld; > > + BN_free(pub_key); >=20 > This pub_key doesn't seem to be used in this " case > RTE_CRYPTO_ASYM_XFORM_DSA:" > Could we just remove it completely? >=20 > In addition to the fixes here, I have more ASAN fixes that showed up for = me. > Will send that patch, and all issues should then be fixed between our two > patches. >=20 > Thanks, > Ciara >=20 >=20