DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Power, Ciara" <ciara.power@intel.com>
To: Akhil Goyal <gakhil@marvell.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Ji, Kai" <kai.ji@intel.com>
Subject: RE: [EXT] [PATCH 3/3] app/test: add more cryptodev tests to meson suite
Date: Tue, 7 Mar 2023 17:32:27 +0000	[thread overview]
Message-ID: <SN7PR11MB7639AB3C00FD5BC1EF9BA240E6B79@SN7PR11MB7639.namprd11.prod.outlook.com> (raw)
In-Reply-To: <CO6PR18MB448473CEB80C286A6257F9ECD8B79@CO6PR18MB4484.namprd18.prod.outlook.com>

Hi Akhil,

> -----Original Message-----
> From: Akhil Goyal <gakhil@marvell.com>
> Sent: Tuesday 7 March 2023 17:23
> To: Power, Ciara <ciara.power@intel.com>; dev@dpdk.org
> Cc: Ji, Kai <kai.ji@intel.com>
> Subject: RE: [EXT] [PATCH 3/3] app/test: add more cryptodev tests to meson
> suite
> 
> > Subject: [EXT] [PATCH 3/3] app/test: add more cryptodev tests to meson
> > suite
> >
> > The meson driver-tests suite did not include some ipsec_mb SW Crypto
> > PMD tests, and QAT tests. These are now added to avoid them being
> > missed if the user runs tests only using the meson suite infrastructure.
> >
> > Signed-off-by: Ciara Power <ciara.power@intel.com>
> > ---
> This patch is ok for now, but it is not scalable.
> We should look for a way to consolidate all cryptodev autotests under one
> name.

I actually had started out to add all the missing cryptodev tests (bcmfs, caam_jr, ccp, nitrox etc.),
But the docs mention it's up to the maintainer/developer to decide whether the tests should be included in the meson test suite or not.
So, because I was unaware of the reasoning behind leaving them out, I just stuck to adding QAT + ipsec_mb ones in.

I guess, if we have them all under one name, it would remove that level of granularity for which tests are added.
Not sure if that is needed or not?

Thanks,
Ciara

  reply	other threads:[~2023-03-07 17:32 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-07 17:17 [PATCH 0/3] cryptodev test improvements Ciara Power
2023-03-07 17:17 ` [PATCH 1/3] test/crypto: fix skip condition for CPU crypto SGL Ciara Power
2023-03-07 17:43   ` Ji, Kai
2023-03-07 17:17 ` [PATCH 2/3] test/crypto: skip asym test if driver or device missing Ciara Power
2023-03-07 17:17 ` [PATCH 3/3] app/test: add more cryptodev tests to meson suite Ciara Power
2023-03-07 17:23   ` [EXT] " Akhil Goyal
2023-03-07 17:32     ` Power, Ciara [this message]
2023-03-07 17:42       ` Akhil Goyal
2023-03-07 17:43 ` [PATCH 0/3] cryptodev test improvements Ji, Kai
2023-03-16 18:16   ` Akhil Goyal
2023-03-07 17:46 ` Ji, Kai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=SN7PR11MB7639AB3C00FD5BC1EF9BA240E6B79@SN7PR11MB7639.namprd11.prod.outlook.com \
    --to=ciara.power@intel.com \
    --cc=dev@dpdk.org \
    --cc=gakhil@marvell.com \
    --cc=kai.ji@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).