RE: [PATCH 2/2] test/crypto: specify correct parameters with null algos

["Power, Ciara" <ciara.power@intel.com>]

Hi Anoob,

> -----Original Message-----
> From: Anoob Joseph <anoobj@marvell.com>
> Sent: Friday 12 May 2023 06:34
> To: Akhil Goyal <gakhil@marvell.com>; Fan Zhang
> <fanzhang.oss@gmail.com>; Power, Ciara <ciara.power@intel.com>
> Cc: Hemant Agrawal <hemant.agrawal@nxp.com>; Jerin Jacob
> <jerinj@marvell.com>; Tejasree Kondoj <ktejasree@marvell.com>;
> dev@dpdk.org
> Subject: [PATCH 2/2] test/crypto: specify correct parameters with null algos
> 
> Keys are not required for NULL algorithms. Same way IV, digest lengths
> should also be set to 0. The values are invalid and any PMD which validates
> such parameters would return "-ENOTSUP" for such cases which would result
> in false skipping of tests.
> 
> Signed-off-by: Anoob Joseph <anoobj@marvell.com>
> ---
>  app/test/test_cryptodev_aes_test_vectors.h   | 114 ++++++-------------
>  app/test/test_cryptodev_hash_test_vectors.h  |  19 +---
> app/test/test_cryptodev_mixed_test_vectors.h |  92 +++++----------
>  3 files changed, 71 insertions(+), 154 deletions(-)
<snip>

+1 for this change, not sure why data was added in these vectors.
In saying that, it seems to fail for QAT autotest....
Passing for AESNI_MB PMD though.

Will need to debug a little more for QAT failure, not sure why this is happening yet.

Thanks,
Ciara