From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D1B474389A; Fri, 12 Jan 2024 17:21:32 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5C214402CC; Fri, 12 Jan 2024 17:21:32 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.9]) by mails.dpdk.org (Postfix) with ESMTP id A2308402AD for ; Fri, 12 Jan 2024 17:21:30 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1705076490; x=1736612490; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=fyj4/zbX8IyKtXcUBHZislt468b2Mhe+ohL3Tf+OjVk=; b=TE0brk6yeMLeppGuIiODmoRQr7okZMABDfRxLeoXSRg+wVU8iPzm0wjO aHqZhBBg36pJQaxhhLvmbpckcQ7wKQiTfLzk1SlWhX2OP5hrvZKjsdLBq XveZrRKaLCM/HE+NhLpvzzfXWtMIFvh4Ju6y701vcYZzQytbVoUD3GnrN QRaR0Jr2Py5YoFxlG0SGfmXDlZyZvVRbxi0KfpO5VhaIVrDVdLF+nMsqJ 1P+kadLO63Qw7MK4SGIXjE/DVlbNtzmuUyv1/X3VTljUl2e7Hh/Iu+lE5 UizFtlNGGAlPckC+2GjJ1h9nPSrwNv1a0QnlV4aQgZXDUqRRdS/1/SN2b A==; X-IronPort-AV: E=McAfee;i="6600,9927,10951"; a="17820787" X-IronPort-AV: E=Sophos;i="6.04,190,1695711600"; d="scan'208";a="17820787" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jan 2024 08:21:27 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.04,190,1695711600"; d="scan'208";a="31437869" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orviesa001.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 12 Jan 2024 08:21:27 -0800 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Fri, 12 Jan 2024 08:21:26 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Fri, 12 Jan 2024 08:21:25 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Fri, 12 Jan 2024 08:21:25 -0800 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.168) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Fri, 12 Jan 2024 08:21:25 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oek2P4fKz+O53wODpsfzHMkHk4f5IATWCM1d6iw6gwyz3p0yaiiV9a55comJZc9SY0ns5QT5Y1GPtbpkgITAO43QDYs3MxHG2dlCsc4fry2tRF2hnaX2796dCqabPfsKMrW0lE/YhdJghubgxmfSxcJ78nLwrVfYj771RRw1RIHTH+Xl1arF8AUA4itWrbTyGICsQwBcK0/Jb00b+IF5vwBuwY9QaToDr3sSsu08UqQN3SZhJS0R9zcYTIQhRNHEauCQVuSgfMUV3onVxrlpmZNAfh+A36AO0hA8gN+X7ph2ODDfYglHYDYeHm9B42pnf9ApWtAPuNAt5lDWhzKo7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5uvHaOnKzcjWNc6QdGfyN0bnLi0T9QVRquLcZ8afBHI=; b=mEaGMEx3jVtUZQKdXcO9MiMyqzmnyZ/Ueac6xFw7rtj7luEmzXmgLsaloEUJ3VLOu0oPzF3mMOr8xNNOZ1HYeeUPz9GRcyLEEUz+jR+5WJWQ488RLbkSNhRKlABmu5VXAYdRgJoC+HlJZFB+LD6uXDOCHANm2NpiMNM/m71albCUfhiKhA/nlCnATF1pApC/+H08dFCpmooUF7pmwEbv7aSq/EzRCYmdQgGaK6jg+51cAvfZc1a3s715scnWjQk7TcRa82H1/tKfUdEK2fS1DWGx3eRle2Bd/44aGMWt+xyDu6O3AKQyDO0XAcJDn9lDEL/Gty8qtUgNji/Iv6/E2g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SN7PR11MB7639.namprd11.prod.outlook.com (2603:10b6:806:32a::14) by CY8PR11MB7193.namprd11.prod.outlook.com (2603:10b6:930:91::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7181.17; Fri, 12 Jan 2024 16:21:23 +0000 Received: from SN7PR11MB7639.namprd11.prod.outlook.com ([fe80::8a06:eadf:e98b:23ad]) by SN7PR11MB7639.namprd11.prod.outlook.com ([fe80::8a06:eadf:e98b:23ad%2]) with mapi id 15.20.7181.015; Fri, 12 Jan 2024 16:21:23 +0000 From: "Power, Ciara" To: Suanming Mou , "anoobj@marvell.com" CC: "dev@dpdk.org" Subject: RE: [PATCH v2 1/2] app/test-crypto-perf: fix invalid memcmp results Thread-Topic: [PATCH v2 1/2] app/test-crypto-perf: fix invalid memcmp results Thread-Index: AQHaP2rBhPPGzveeu06na2SDktv+T7DWZ9Hg Date: Fri, 12 Jan 2024 16:21:23 +0000 Message-ID: References: <20240103035605.720256-1-suanmingm@nvidia.com> <20240105000323.903764-1-suanmingm@nvidia.com> In-Reply-To: <20240105000323.903764-1-suanmingm@nvidia.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SN7PR11MB7639:EE_|CY8PR11MB7193:EE_ x-ms-office365-filtering-correlation-id: 54ce8942-f991-4781-467f-08dc138a84fc x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: osBfM7MR6Ql5f07+ESMg5BJv2/jmHUosLP80wJyhAyikt+kYxZLiv9jMyLR5QlVXglHd0AG57mOJGJbeX9bZ9Nq+Ya5rPK7PCc4f5seudixc27QHdtBEG2MDuzJfLgYo+FHaPLmZ0w7j/0gTZpUigpADFDDgti/pRZacgpDTStKEY1+duhMEvtMZMXZnafiFJnXVPcrqdl5d3fA9JXM2MjW9HR9w+ACot12QnzpcYUWTNh1fwfAcskNnkKZDGcEl3IR3hnb1UWGeS1B2IE6rMOniIxf/J8g5EfgjgjOxxjViby/9GRCi01VkGZz2/zJUKuJ7geideU2BMQE6X/4mX4lPKpR78WbDCsZBfuoGfzX51ryF7NfrB7RZ/BSmmr550/gXZaTUfKUjoPwtosEcon5bjDyIJaQ2BMWwvl6puc/M5lzd9s0lWolDWY+j0sO/4rFTGipKxV0R0sDUICiaiG4q5dXs8dti1mig3YP4UgFwPvKC3LsXPpRYUJY1zHlQO0rKNeGLR1lm7fevVV2ureosHtK7AbYpYvyKGlUa/CFrcmDx2aku1pFSU3CbS21ilrVKRl/adalQ1sJxat1yUC2K2NOUhT6SMvyZQPGMQCkyVz14w9TAmYaOQhE2eTDI x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN7PR11MB7639.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(366004)(39860400002)(136003)(376002)(346002)(396003)(230922051799003)(64100799003)(451199024)(1800799012)(186009)(2906002)(4744005)(5660300002)(38070700009)(41300700001)(53546011)(26005)(71200400001)(83380400001)(33656002)(7696005)(6506007)(9686003)(478600001)(82960400001)(55016003)(122000001)(86362001)(66476007)(38100700002)(8676002)(8936002)(66446008)(52536014)(110136005)(76116006)(66556008)(64756008)(4326008)(316002)(66946007); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?GJ/Rjn0hJE/O11QDobUySFTRafuLmnFUgVSKaiILuLY+yCpQIHJkFupm10+u?= =?us-ascii?Q?bQ2WSwj/raFVSD229TjJsnE1rlbLXCF4CfcWvBdgpe4rgLfJYj1VxS4amYNY?= =?us-ascii?Q?d0tKMgJqsGjsyRvFcZ3XWN5KUzL40mKSlUle+cSbcP4xkVQyo4DVg/bc4Nhi?= =?us-ascii?Q?CzZ5twROpM3Y8a7EDiIyoLzDkTfOKYnlLZF09YlIAx3AduwYsHja5DnWypjx?= =?us-ascii?Q?044WUlXV+ETB/f8/2TLiPycLoKj7bxC8VrYU84NCmhPJ6iBgu2pmJJsv+Yhy?= =?us-ascii?Q?bZpCr+3OAQFMDPrcxVm/6TRTZv54V+Q+85Be42H4EinaEuKndoq5vMHlBCEE?= =?us-ascii?Q?UnxyOG9tRIARTtLCnSRVpXPh+yIo/fHIoEMCLuHj9nVG80FrmfUv4hRhyYpS?= =?us-ascii?Q?3zEg7vMyFEGBwiueNoj19pqemqSFe6TWz97yymU2nwLjDgyid0A5QlSP6VzU?= =?us-ascii?Q?u8oODloJ7Cv3FPIU+6HoLBfaAHVnCL7K5BX7kC9UnzTd55695JrtYe8ghSct?= =?us-ascii?Q?m6p4P5Vptz1s2LCC0lOGFR0mPbct2qPj43+r5u5d5rDwV95SO26jw2XQMHT1?= =?us-ascii?Q?lzNzWTD1e0q4Sa8ijLDbjzJGndcdVLUlxb/O1XAueuyciDPhTIgaovWS2uvl?= =?us-ascii?Q?CnoeXdZOplu3Epnh3hwzXcZrdC5QJSTVqPR7IAqAbylOJ9wOjffbDANliQTI?= =?us-ascii?Q?XahDxRIbpLteyGj9+vde9i4p2GqqwtTXyYk36ouL6sLe1JOejiAn2mFHbSoM?= =?us-ascii?Q?yinVlcPJz3lDR09E2xoMaW92zO2sj5jEd5Avs6mkXpcfUlsAM9pm5ZmwzDSm?= =?us-ascii?Q?W37gQ1dJfHFPkyVfpoGVlO5pF62yP/mbbP0EoCSadt+abasgdd5ab3dPV9Y6?= =?us-ascii?Q?GkdPBDDWj3dznlzexGHNlB4XmrI2Ydc/wTmg4bpdFUWWQlepdn327K/ylD6n?= =?us-ascii?Q?OfyMFZLFNbnfQoH+tJtW1RhQ2CHZIWWuDMNmNieF/4g3nNyUj3nP1diqFfG+?= =?us-ascii?Q?nvK+rQ0u/02JXzjW6JZsL2eDbyOl5/Q+GxtDFTTRbe4pB8ztsU9BWfrMh1OH?= =?us-ascii?Q?pBqCKu3lLar6HanYSIc5Z3nXZKbgBdaEshBBdd+fBBT0GiSHm0M/UEZvaQb3?= =?us-ascii?Q?Px2gV2o1Onq2x1RF3ENPGl6M/H9Bj939N3WlEHDxZg4NhAxO+uEXgz4A6QCO?= =?us-ascii?Q?U9vXGzhx3c9oXeMkBBqVCFYIgalw23BPyR3r/odtkNTr81AXxw+5mJNkkyLO?= =?us-ascii?Q?Tt7vly4gebnYPVRrYJ3x3rYbXftCJCe285T8P3FNy+7GvDVeaeQuj+PoDdcZ?= =?us-ascii?Q?pLVlu1Sc7S/l2IW22a9eNgpCnvZqXTlVaAJOQyquuSjJMa7WXSKnmKcgy5Vg?= =?us-ascii?Q?E+Aqr8b5jIxs4HiBf3OggJUrs243oJOSw3gSwUiC7bp35VpN+bbt687v5mqw?= =?us-ascii?Q?KMhdI/Tx3OUockHzgCL29wB0dUU+bXeGklyS3uLltqN9VY9/o6fYbhavCzI9?= =?us-ascii?Q?fF6FlZsyVNXSRBiaOifQArFVsQ1OgJOwKHBCFViEpEyxC68hOMaQvZrUae3N?= =?us-ascii?Q?H1PoK+Zj2P82T7ODoI6HKSFfFvdtMKs9acW8FSgi?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN7PR11MB7639.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 54ce8942-f991-4781-467f-08dc138a84fc X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Jan 2024 16:21:23.7290 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ZAim+BVFBqAlZPJhaxjryG7zUAgMR92IyyNWnSr2WVLw+TgG7c4N+HxnJq+AEEdjrepPhWAZHyF4/1pkzjJnEQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR11MB7193 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Suanming Mou > Sent: Friday, January 5, 2024 12:03 AM > To: anoobj@marvell.com; Power, Ciara > Cc: dev@dpdk.org > Subject: [PATCH v2 1/2] app/test-crypto-perf: fix invalid memcmp results >=20 > The function memcmp() returns an integer less than, equal to, or greater = than > zero. In current code, if the first memcmp() returns less than zero and t= he > second memcmp() returns greater than zero, the sum of results may still b= e 0 > and indicates verify succussed. >=20 > This commit converts the return value to be zero or greater than zero. Th= at will > make sure the sum of results be correct. >=20 > Fixes: df52cb3b6e13 ("app/crypto-perf: move verify as single test type") >=20 > Signed-off-by: Suanming Mou > Acked-by: Anoob Joseph > --- > app/test-crypto-perf/cperf_test_verify.c | 6 +++--- Acked-by: Ciara Power