From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2DA3943382; Wed, 22 Nov 2023 18:00:31 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0371C402C7; Wed, 22 Nov 2023 18:00:31 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id 5DF70402BE for ; Wed, 22 Nov 2023 18:00:29 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1700672429; x=1732208429; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=OMZNUDnhxSfNisNLmG5ssponlFSjKnZR9j3qLMSS/rg=; b=JF/DDR7d7C27pfjibwMlU0TYR29rEEJM2vQFWYSHxxUeTkpbJGcx/qcL HttygCDkR9KzyWGs/jgNPuYZl31INktIqqLkVFu088uHvUueinPnOZYt5 wYrtTpAHIzMjhpENsCE74hJhvIjwAfs9YjxwJMYMlaS3gB1lDNotscPPH dKJU9nqAcQB0kovV/8QStlnQmUPT4TY2n6lWomKNINHqIf5EP94dP40Mf yQ6t7ZcgOlf6nLmHdgUYhntQmJcIEJ34vDcvF3CCZpf3yHCj/9YW6nQvM HyDB9+VoMUVG0Gfse3myTr9sZcIi6Fa47DtfgLLoyqIkz6wOOwPPKpsYq Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10902"; a="377126551" X-IronPort-AV: E=Sophos;i="6.04,219,1695711600"; d="scan'208";a="377126551" Received: from orviesa002.jf.intel.com ([10.64.159.142]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Nov 2023 09:00:28 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.04,219,1695711600"; d="scan'208";a="8358786" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orviesa002.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 22 Nov 2023 09:00:27 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Wed, 22 Nov 2023 09:00:25 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34 via Frontend Transport; Wed, 22 Nov 2023 09:00:25 -0800 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.168) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.34; Wed, 22 Nov 2023 09:00:25 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LmW4n54lLOhAR0R67L9YN7cVpYZTNSkGtSst5dFMv4YZIXarThS5w3kvGR/citSzrkIDeMVccdNFQAmjHmByg7W2KKu20EVbGv1pTyzW58pflCuvNJbW/ymy5UfDNMpwgHJDXy70TYJ2xCVH0+x51xX4Zrvu1lFZLVYG6Vpx0bp39PaiZ+hJ9Jc4J/KACR8QECg6vhjxHIX5/Y/zd+VebylMfzA4+hn5NnKHem4UyNoMtzSS7D+C5BBQLR8oMXOSXf0PN0JBxxg9h99JwrfaSUAJdE6NzWEdDtXz6uBgnIUPED73Hf3DfYZrYIjuSBleWnNtRAyUsTow/QwTSTz8cw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4c/e3w3gqkcYJ1+RWmLGL9WeSelyaxzZDIAW52J3n24=; b=J4J9PPAS55YxZIxw9AwPISYM3WveUjladzaU3qKlg8h3rKomd8KN24kH68hd19VVMo8Tgj68bw07Gdpcjo9JyBxgv4l0DVZS5ykMKD6rCJck9fgTsAGCvvpgwd48yE5QW+UguLm6/4A0Zu/yBLG0dVevPYIsNntxwoEqAv9gVN5xw77PIOzd0SELV9GSqmSzdC1IILUv8WdxxOc/+ccVgTeLLBN7qwp7l2e3f8sUshegTbHxRSNRqO0fl+tUhGUog5j41+n3io0K8XaHWs+8x0hMaTLcWIxBF/9nPk/g5FTBxxWWqMlTRsaZqI5Wt9kbspxaiXkIkh1o6tPhPbLoNw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SN7PR11MB7639.namprd11.prod.outlook.com (2603:10b6:806:32a::14) by CH0PR11MB5281.namprd11.prod.outlook.com (2603:10b6:610:bc::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7025.18; Wed, 22 Nov 2023 17:00:23 +0000 Received: from SN7PR11MB7639.namprd11.prod.outlook.com ([fe80::809d:52ab:dc3b:8a10]) by SN7PR11MB7639.namprd11.prod.outlook.com ([fe80::809d:52ab:dc3b:8a10%6]) with mapi id 15.20.7002.028; Wed, 22 Nov 2023 17:00:22 +0000 From: "Power, Ciara" To: "Richardson, Bruce" , "dev@dpdk.org" CC: "Dooley, Brian" , "Ji, Kai" , "De Lara Guarch, Pablo" Subject: RE: [PATCH] common/qat: fix build errors with incompatible IPSec lib Thread-Topic: [PATCH] common/qat: fix build errors with incompatible IPSec lib Thread-Index: AQHaHWOSqyJZmaBhik+er+L3bJ1bHrCGjwQg Date: Wed, 22 Nov 2023 17:00:22 +0000 Message-ID: References: <20231122164651.1320497-1-bruce.richardson@intel.com> In-Reply-To: <20231122164651.1320497-1-bruce.richardson@intel.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SN7PR11MB7639:EE_|CH0PR11MB5281:EE_ x-ms-office365-filtering-correlation-id: cd81a118-a980-4ca2-553e-08dbeb7c8429 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: eZYdej5NyYXYYeID5ltjgE0cGSl1TzC5Mx3LtZCdos1DFdm8Cq0tMbvA3JMNyg4UOrCUKuvTp6slkoDDNkouFSIu5PvuZjIvMYCH52HLFULG0Q5LJsKyUbRx9LIFSIyF5VfHBScD+QH2wafEIwGw8el4y1KwXMLszcsBDHVIFoaueMQ+3qwWFCoN30esq+yCj60r38tOQav65U43RWvmGsnPB892c5GUCLihmsgb0XBz1lIA82J/DmW8/Q8K9yHTQCamOZKrq1d6rc705J+GZljAGoh3ZAbT/XVngNJIyThDIrBhpHP/NQPnm6uB1x6suKib3JJKh4edQTaxseOfo5s1NpSaW/TPSF22g+yOHlQgRmy6h/O8rCrS3OU2dZhYcjcWo4c7t9PeqYFa4O3Fh6YI7qvFzF40qlmQdbnUzRaZWW8UWu17hqvmAQIXXLdoE+vEzRxFZMrWmvVT6NDtDmbXSC08uxmze3YV1Q0p6VQbSDQ5+Xn0qOzO7E7kqT/YZWM7q/m0f59svJloIy8PyLLFyWBS/1UMJwKJI+CRw+oK2aCZqQDMm/O3IkWzjcJIuQOA00VFzYY/ohEA+/IP26XgD3+XHQP9PdCda6KVE966H4VBjxflQHQ1xa4noH/o x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN7PR11MB7639.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(346002)(136003)(366004)(376002)(396003)(39860400002)(230922051799003)(451199024)(186009)(1800799012)(64100799003)(7696005)(6506007)(122000001)(71200400001)(107886003)(53546011)(26005)(9686003)(55016003)(316002)(478600001)(82960400001)(83380400001)(66476007)(76116006)(66556008)(64756008)(66446008)(110136005)(54906003)(66946007)(52536014)(8936002)(4326008)(86362001)(5660300002)(38100700002)(8676002)(2906002)(33656002)(41300700001)(38070700009); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?59Qljv46BL6vqTXB43dw+SXe+LR4bY0UbTYPtutRtfaa0KCQTX1mDN3F/wVw?= =?us-ascii?Q?DMPMOEVP+4aIHsyuaBbnjYipFDY+jrUUcRi0Mr3LKYYMU3LYN3nshFbGS12W?= =?us-ascii?Q?EtXwaaSta5+IWiJPqkI0Om0lSKKolBjGy2fPUqOEgfhCm1kN7eCQCzya6SFj?= =?us-ascii?Q?1pMXWAAoDMcGjDBpaF5KbgDVbH0acYwcqEd2kqc+L5UXACONSR3Se/bVXnJa?= =?us-ascii?Q?/Uu2SrvpgtWWghYlBhbcxLKcyaGrIQ948RfZvETNTOnGKyrPN99MeZwaNd1r?= =?us-ascii?Q?0gb4lEJ+EYX09P0o0x6gBrj00OaRzXTmCGPnJgsVNQle6eI2Sw//79lFvptS?= =?us-ascii?Q?g4V+s+PZN2OMdvqrrsswsAlIYZWGyRnqN4JcMQ1rDbGJTvWplHaq8ZB5vJef?= =?us-ascii?Q?0GOjK5+jlBgpi+ycKKFkfgQoWinwUHQ5zbgn2K1MFSe2olLBKBZyBlS4O2Rt?= =?us-ascii?Q?zRTDo13WbGiNeb4Y1WYFjQZgZC6XZTlyT5wm559d9WaJnEXLOVopooDoJKhl?= =?us-ascii?Q?6UFjqotKJDn7UAZbSnzsxs5yRMRHadvjd2sqbof6CUp/I3JD6JRgYA0CkKFr?= =?us-ascii?Q?+ROecWFIWgPKKg10ys2nWt+ARE1cWqcmKLOszUJfWNC4iGxIg4JIG14ClR19?= =?us-ascii?Q?o1VX0sFM178SamuRjdwZfN5AskoEqoWpKIEeKF39On+7CrNoQtSwFPP6Fg+K?= =?us-ascii?Q?tUzncLaofnHD18F0SkZNSbxo4rGRoR0FrXmBzFLzIgXqTiZU60uGcjWd3290?= =?us-ascii?Q?eUZZe1Sg96GP37XHriX4BOspVp8U/0y0miCXBd/MYbTDYkXwW+x8NXNhptZe?= =?us-ascii?Q?hh8gAgOoa17JROGJGXUm7TkEj9K2HIvatpx2Va5/8HMsMi01lAncEE/25FQs?= =?us-ascii?Q?W292OOVVwNNNgwxeKiX7/dvaTdVAChFxo9ee8uQX0SB4z2eAlHuNL5IzDeq0?= =?us-ascii?Q?Z5q6jh7xdoh/wFEkPTA2P2VtCNA1oJ7GMQLttMLS4T0I/nbpm1xE2yACoUm5?= =?us-ascii?Q?rSBnPakWT/Ii0jyW2egSNmCotIs7nBGngwJdC1Nyl/xJo7B3gg0m1FM4g4M/?= =?us-ascii?Q?gHKsi3E0mBIzWdnj25oWK2QvnQ3JuZjxHAO2mamXn9mgKRjh2EBXNhILuUaV?= =?us-ascii?Q?IMpKR38g9x4IJiZBpaNRWg8mljZSc5SC2Wu+oFNOD5kupVMRR/nPBIDtLgax?= =?us-ascii?Q?BJKKpZcbOpQmi/afxnOmc6jSwfSEjR1RDt8Ehm8BWUMsgC4/P29FIiA2APTF?= =?us-ascii?Q?64eVZww2Yithdqf33TyHBuxMJvbyzX9v8WxYDvA8z1W6tmu5V32L4uJ1SNWn?= =?us-ascii?Q?Tir2lLjNcImCOpivR/NlOAmKZazcFD4h1cod2S8FCdSxhJ6BESE4K4ytfyKj?= =?us-ascii?Q?mle/R6ItxD5KqedRc48Iuwa/v+RLk1YFz4keicyPjpReI2S/rlmSDQp4oyDm?= =?us-ascii?Q?i/+3gg4hWjQ07Lc63hX6AlM3XY8kvoA4c/rca1xq+XMdk3JQyY8A61uMUgPR?= =?us-ascii?Q?s/+PPA7xezRrB49iGoUUXiTia8ap1XWvTLfAfAEpWjQqWz/L+MQRNrYxf6E3?= =?us-ascii?Q?9WGqdPHknZ1DWGjp7MngMM9sfcd4hgHJFmvFPCrf?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN7PR11MB7639.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: cd81a118-a980-4ca2-553e-08dbeb7c8429 X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Nov 2023 17:00:22.8359 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: +3v8Esnw6IcazO+qvXHbtUZ5NI5kVW9i9gUmatJWfm0duWAPoISbY2doJBV74LHGe0cHls0OD1+osSKd/XyzsQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB5281 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Richardson, Bruce > Sent: Wednesday, November 22, 2023 4:47 PM > To: dev@dpdk.org > Cc: Richardson, Bruce ; Dooley, Brian > ; Ji, Kai ; De Lara Guarch, Pab= lo > ; Power, Ciara > Subject: [PATCH] common/qat: fix build errors with incompatible IPSec lib >=20 > Since "find_library()" is used to find the libipsec_mb library, there is = a chance > that an incompatible library will be found e.g. when doing cross-builds. = To fix > this, we copy the logic from the crypto/ipsec_mb driver to actually do a = link- > check on the library before deciding it can be used. >=20 > Fixes: ca0ba0e48129 ("crypto/qat: default to IPsec MB for computations") > Cc: brian.dooley@intel.com >=20 > Signed-off-by: Bruce Richardson > --- > drivers/common/qat/meson.build | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) >=20 > diff --git a/drivers/common/qat/meson.build > b/drivers/common/qat/meson.build index edc793ba95..5c36fbb270 100644 > --- a/drivers/common/qat/meson.build > +++ b/drivers/common/qat/meson.build > @@ -43,7 +43,8 @@ else > IMB_required_ver =3D '1.4.0' > IMB_header =3D '#include' > libipsecmb =3D cc.find_library('IPSec_MB', required: false) > - if libipsecmb.found() > + if libipsecmb.found() and meson.version().version_compare('>=3D0.60'= ) and > cc.links( > + 'int main(void) {return 0;}', dependencies: libipsecmb) > # version comes with quotes, so we split based on " and take the= middle > imb_ver =3D cc.get_define('IMB_VERSION_STR', > prefix : IMB_header).split('"')[1] > -- > 2.40.1 Thanks Bruce, Acked-by: Ciara Power