From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3819243C88; Mon, 11 Mar 2024 15:39:16 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BD3CA4027C; Mon, 11 Mar 2024 15:39:15 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.10]) by mails.dpdk.org (Postfix) with ESMTP id 39B644026B for ; Mon, 11 Mar 2024 15:39:13 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1710167953; x=1741703953; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=bE9SAFGoXB98NQVL6XFD/DULs98CAEW0nVNu+/BDUrE=; b=PTtDZQcIrUIqAkAZaQw+Tu1nE67RA9mUAaZZ6yKWlI8WBgDFx6Xi9pjt /CYAHi/4gQr3TNkV0JDnD4m6Khkb4xxNaiQrvdCqeZiahWi/YolrCcNh3 Y+rOsCrs4RTEMcEPjR76toHIUz3PayLYuujSQoS4VEjjvrSGlxv6fGsMR TDWkyjczBxlFaQYMZGWpm9MfgpoxbLbQY3iWuxFGgztcBZ1r9yYFDFUVx hoYjECkHdRtq7SWm9qFHYfwWG7luwKtsttwrfThPYy0sQZdFGudnb2iAO hAJIyASn2fBp1nArD5qi1XVbimoKUoUKKC5CKN4Qt0FmFmqyJ6jTK2VYb Q==; X-IronPort-AV: E=McAfee;i="6600,9927,11009"; a="16236908" X-IronPort-AV: E=Sophos;i="6.07,116,1708416000"; d="scan'208";a="16236908" Received: from fmviesa009.fm.intel.com ([10.60.135.149]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Mar 2024 07:39:12 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,116,1708416000"; d="scan'208";a="11068100" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmviesa009.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 11 Mar 2024 07:39:12 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Mon, 11 Mar 2024 07:39:10 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Mon, 11 Mar 2024 07:39:10 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Mon, 11 Mar 2024 07:39:10 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.169) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Mon, 11 Mar 2024 07:39:09 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RDgsBpMu63x5AQNT6FhIUf1P48lhH+xFzoohgP6lUYVwnqViB0a6Iqw6BM/YkqKZIof44mDUkMC2GinpWydMZRilcoP81/WLcnRAZvgNpRT2HXkhQHBTNnZYnOBznIj22JoyTCz6XPP+bgDKzjGXdIfY9NZlTK6V/xrS29JIp1YzmcSsY7xgxq9SvT7aS/2GcxgtkpfqrvkCg36NOww4c1nFWi1LGx147o3T95koKFuLTTqLVUNf5g8YinW44VMOLzhgYnI4OeeCH4/vMBv4Lj+xDFz0iK4HJBBP420iVnEmlV4UccEGe0V35kSQD2auJ8DWXYc23COAl2djw6jimA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UVxAqAEVU1fA5P9FDDM7NxH7uJH/SefXW8sPY+i2nm0=; b=eOjlTKKRdjH5SFqhugl9xBcgPZbY0HmWFD8xAA9TDh3gMd/5TuVgQ1Eoa7s7ucbOmRqi2Ocv26GpWkoBnNWAPnAPvrYUjwwE8DDLv7egD0Utfg28mfOILLaCTUWLuH0l/AWXi2Mtqj1+wnIbIwnAS5RbArdDTgZw9ffIF2jdooUjNJqR72TJN+JvYc1bTXeMi3uLiUu87aFlgWKIeOTiMDlXZibyPOqjAvEBcs/0QoGAVgKyiEcCA+f+LMFxhm2lHx92c1I/dzkGGIA3fS+6CN3VH2FOCekLLkuDW9qtuNPz1YjWGSOFlk0tROFQN7Xst09ACFKxTRLXJ3j9O2oFaw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SN7PR11MB7639.namprd11.prod.outlook.com (2603:10b6:806:32a::14) by DS7PR11MB7949.namprd11.prod.outlook.com (2603:10b6:8:eb::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.10; Mon, 11 Mar 2024 14:39:08 +0000 Received: from SN7PR11MB7639.namprd11.prod.outlook.com ([fe80::656e:3d48:9daa:7110]) by SN7PR11MB7639.namprd11.prod.outlook.com ([fe80::656e:3d48:9daa:7110%4]) with mapi id 15.20.7386.016; Mon, 11 Mar 2024 14:39:08 +0000 From: "Power, Ciara" To: "Kusztal, ArkadiuszX" , "dev@dpdk.org" CC: "gakhil@marvell.com" Subject: RE: [PATCH] common/qat: fix null dereference in release function Thread-Topic: [PATCH] common/qat: fix null dereference in release function Thread-Index: AQHacT04QyC0Pszb902RhcdZUj7aSLEyoSsA Date: Mon, 11 Mar 2024 14:39:08 +0000 Message-ID: References: <20240308094411.5467-1-arkadiuszx.kusztal@intel.com> In-Reply-To: <20240308094411.5467-1-arkadiuszx.kusztal@intel.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SN7PR11MB7639:EE_|DS7PR11MB7949:EE_ x-ms-office365-filtering-correlation-id: 2748a259-06ba-4074-5ea9-08dc41d9023b x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 5SL8xfbjgxvPlAxqfiyhHWL8y5SEUd22xLHF1+pELR9F7cgdRbZLtnHOLDtHfYQFm/buOtRac+KyXFuJEQ/vtk0yHWxLMnY4GVXXBatg5wIm2WmxLlJ1MZndjRoJcHIYDD6joCac8TJX0XVJzNJ97sPrTz3lt+Eg0LSoFlIIIsTp4QX0Rwwv1zFTiruCWlQO6Ov2jDSxSambjd8CnqLK3/zNQXB3yd5oU7RAHOyAAleiE9/JAvkmYvKO/db45pE8omaJ5D9piXNHfQugQWcSTxZD0Lv322rCCqqRBeDIbtbB9fY/xZYdKmHw1B4Lc4zj3kcvuaCYs5qAa9b4OS1Lr17dSHp7Vr7HunvcwYERhe5DnahJfZOvNKavahI9mfii47wJexnPHD9ot0DCdUdUTet/4u/ZTE3GITURn6yEZgi4Y9wnUrpt9x4jAgFvaXph+KWvEGddiR62q8jwBZVIB752x/QJ3oWo/zg5cEckQh4MAwm7+tVJDDdTF662rjURxsAoNYKmFNNT3opMdi2GprKddQgAQMAjBiseeiLXB3lypjbRfWsG4w40ua8J1rpHVW1liY3QvfJR2Tb3yGhTTihPAWYPG3nGvGedmHPxborAcPxPkDQj357kWnk0+OjIi6ggv07iW/S/UBdUrQGcApfytUmwnR641Y3S/HgyB015VMXkLH2PUsrFQ2EdwXRFD4kwoXxJT/MGzXbx3CQX2Q== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN7PR11MB7639.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(1800799015)(376005)(38070700009); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?PCXYunwBlYyGoakNM9BpFZui68yvjj35FoqkOgp8CYWiG7tncV8N1caNdSvc?= =?us-ascii?Q?qv1LDyE3egrOATzLbCdsBf6zFO0TmF4rw9KvsuvhQOe+ZFvTzgqx8hVZTWUH?= =?us-ascii?Q?cGQYtOoRe9QXqipLc29mYO20R2h1z4xu7tutOagX/jP+AoEq7+myCP7SFmPY?= =?us-ascii?Q?uS0fWeqTZG9uu91hRxLh9v4Q5uPJ9ZigW8tXpA38Qvq5nsmTaiEGaCjx40Fz?= =?us-ascii?Q?K9FOPrXmHx11GOnqaBtkn+QMpO/m5Vie2GNCWgDX9bv1C5aOwqM/H4u5sJhv?= =?us-ascii?Q?OINgBeSKEYvPAqe0QLgfM5CD8syfXFCgOXljw6jbQ91oTxbfqVsGs/HkABXP?= =?us-ascii?Q?Onm92+beome6O1/KPsFamGoD/nL8/Is/0/iE3dd68dewY4fMLEqwcuGANxcv?= =?us-ascii?Q?WnfhtfbXB/+YQKCkWppBpEKit9PQuD9bxXcMJJFSzie7qTmjiCyOiktDg7k3?= =?us-ascii?Q?On5U6A9XsoNQZXex0EPHDsCWcOkWy73Lw2kWhZfEOgTG8ndzJ7ZuRaXuOaLm?= =?us-ascii?Q?RCEL2tqYx6JC26i0d06UlyXGKvVKfchSRAwAPhCgCUGTyYWgUVnaZfVOFThG?= =?us-ascii?Q?bayrOhUjW2rWNyeALKaTrhISzYP2KnG3YEEiHrWcLMS/c1lSQiGo3NEnttnL?= =?us-ascii?Q?nLS2IzMlVIuis3arEFzouOYXelCy67iQ8Zn+/DrPEzYN9748mZ28SvfIdQK/?= =?us-ascii?Q?2vBOcWd6Y1pvovOjtbbW+TcXy2PFdVWkqF6YUE8eUgJv+boIKbj/lhMTqEPZ?= =?us-ascii?Q?+egAzhckdGmhm1vOvcAJNn3PGXfjo7zLpfAimEhNr9ndMJ5YeZy1GINSrEhF?= =?us-ascii?Q?bxL/7Eht6A+oTrPS9QqVj+gLusXVclKsOckjL2+wSrjQkj6FJP0r5FcUwBlV?= =?us-ascii?Q?Y/Eym/2QaB5FATFsQmz4ygErrpuHn/pIu6fssRd6Acqbe3zigqsHAkCtgosq?= =?us-ascii?Q?ZlNnRsJjwbAdxipVJjiiVnPwJqu7MvpRD9N3d03JZr2eEJlWO/VXGbbmSWce?= =?us-ascii?Q?GLfHjT0WNXjr+dqGnKyU6xsHyR7kLSrkDNZpgEBfi5gDUfbPMCQPRTrej+Dk?= =?us-ascii?Q?iSuJcP9MEU3VNQEDlTtPziZBCk2IhQ4Mk3ovuaL6qRX6RQErjhffmGZsWJ49?= =?us-ascii?Q?2zeh9pKdeRm3GoxevttTLOhX9yJvyzdId9mGZ2vF43GiJVEG6YhJYnbMWGbv?= =?us-ascii?Q?obnMnLfDYngauK7B29ASY2oGTwkRC9m/YozHWfvCULF/KpQB6jPFFuPj+TkP?= =?us-ascii?Q?Z5+y9SuKZlU7hdxh1dSEXOzGJhxSnoNmHHmAH+JZ5eMwap3abJRq1rHRGkdW?= =?us-ascii?Q?2kVuVXdNO4DHwnq0r3h6wfAcQKVh659bHBMQrX/Zp6qqHCjdvK/mUVK7On92?= =?us-ascii?Q?6DTL41QpKLqX72ELn+pnlhXhn3KS3i2Ejqh6r5ybW5rTwJ8/vyjYiR7wwydY?= =?us-ascii?Q?hQYsYnSZbkV5Vk0pGSv0/pbHHM6AtENQYi8NKwTEV8qgqG4c2/ODBLlf58Sl?= =?us-ascii?Q?gDLQl6U9bwLreeIdielV70ig/1Og1CIr8YFRfuZR0dGu2PTfvLu5bDVkTaGr?= =?us-ascii?Q?iLBZi20t79Zx313JEe9MkmqMliOv4aJoB8EoOO8P?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN7PR11MB7639.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2748a259-06ba-4074-5ea9-08dc41d9023b X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Mar 2024 14:39:08.0534 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: MWxs+7xuU7wXGm5RbTZRYQK8gKERh83w/YrH9I4A/+wFmttGQD4Oqq8eZ1mIaFZkBGQ+UxIqSg6KoPUd6HxYPQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR11MB7949 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Kusztal, ArkadiuszX > Sent: Friday, March 8, 2024 9:44 AM > To: dev@dpdk.org > Cc: gakhil@marvell.com; Power, Ciara ; Kusztal, > ArkadiuszX > Subject: [PATCH] common/qat: fix null dereference in release function >=20 > This commit fixes NULL dereference in the release function, and three add= itional > coverity issues related to NULL check. >=20 > Coverity issue: 415038 > Coverity issue: 415050 > Coverity issue: 415052 > Coverity issue: 415053 > Fixes: 477d7d051211 ("common/qat: decouple drivers from common code") >=20 > Signed-off-by: Arkadiusz Kusztal > --- > drivers/common/qat/qat_device.c | 14 +++++++------- > drivers/compress/qat/qat_comp_pmd.c | 6 ++++-- > drivers/crypto/qat/qat_asym.c | 5 ++--- > drivers/crypto/qat/qat_sym.c | 4 ++-- > 4 files changed, 15 insertions(+), 14 deletions(-) >=20 Acked-by: Ciara Power