From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 71DF5A0524; Wed, 14 Apr 2021 09:28:19 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4E9B7161765; Wed, 14 Apr 2021 09:28:19 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id A43EE16174F for ; Wed, 14 Apr 2021 09:28:17 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 13E7Jw3x024735; Wed, 14 Apr 2021 00:28:16 -0700 Received: from nam10-dm6-obe.outbound.protection.outlook.com (mail-dm6nam10lp2107.outbound.protection.outlook.com [104.47.58.107]) by mx0b-0016f401.pphosted.com with ESMTP id 37wqtm0q9c-2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 14 Apr 2021 00:28:16 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YiAkqK2TCmOuYzyM9Ttml6E012ON4hyiApgKhoYv+y2JuopQYdMjWWOWB4rIFZ6r2LMyw9Tjwb1sPIAidC7PHxHQA97fL90proROVY82nJaLKl8wdE8XtQzo5r4HQjs6LiMsbgvyJQfSM3pOjACJjqKslfeVkNCm5lIpbtBeT0HRNuNQ7f4oGa3vgdzREtrJORVylnxvBa+tIzkvE1/XZbQlE8wnnxdqHZmK+V9qq2cNDOPaA32IdmJw3xJUlzJui6XeNp3r6Q99uZ0XDu3qIcKos01KqMbWho2ykyxF7+n+J0CQ0jiP4MI/EQGUEWOg0HFmScP+7np8gsGqr5cxjA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=I/NcqWseFv3GFvXaWxKnUtA764wJfb1FSIhH296VH8g=; b=g/IWVsg9gTtOhs3nKfkEtvJ6RvSXkaw55uHTk9ZN7KImsPSxSxP8iS+54HqgCTPUGmmnTkTNJyb8YDTPF5/4qARHbq36ltKKAj+4uf98SEuUJuy3aAonNGsHPJ5PNiYuwVL8lbGbfv7J799phmQQ3ANEkdzJOPwYxTQy1AikRxoc1Y/fkXXr5W+DDPm4od9J1Nk2RTgS8Xx8amG7YdNORPAOFUG+si6oldSPyJ+EJ2exye9S7NVEJmXD5t5Tdj4aNf+TzjguYsrwIM8qxtPJ5raVMhT7yV1H2hjLMbCFR4/tm2Je2RPHCC2T+rwRbyVEDYvonZFoGm2proG8NKBJuw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=I/NcqWseFv3GFvXaWxKnUtA764wJfb1FSIhH296VH8g=; b=Cp7zbkzYQyl3YX3S25TlYdaYP1g6YGEcuyH4mJTmycAiocbhMH1/r3XupjcrgcfofJOc1D+hyCS0YFRBfOPjXfXB4AOc9XgfDK4rIxxP79POYGYJ5J9tZBnqgh1kauA4nMSASsGJKMKNRsTEe/ApKRUrKQmxoH6OhR+N0YwsSfk= Received: from SN7PR18MB4398.namprd18.prod.outlook.com (20.182.100.74) by SN7PR18MB4397.namprd18.prod.outlook.com (20.182.101.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4020.18; Wed, 14 Apr 2021 07:28:03 +0000 Received: from SN7PR18MB4398.namprd18.prod.outlook.com ([fe80::7cf7:646:f9e8:8f08]) by SN7PR18MB4398.namprd18.prod.outlook.com ([fe80::7cf7:646:f9e8:8f08%6]) with mapi id 15.20.4020.023; Wed, 14 Apr 2021 07:28:03 +0000 From: Jerin Jacob Kollanukkaran To: Shijith Thotton , "dev@dpdk.org" CC: Akhil Goyal , "thomas@monjalon.net" , "abhinandan.gujjar@intel.com" , "hemant.agrawal@nxp.com" , "nipun.gupta@nxp.com" , "sachin.saxena@oss.nxp.com" , Anoob Joseph , "matan@nvidia.com" , "roy.fan.zhang@intel.com" , "g.singh@nxp.com" , "erik.g.carrillo@intel.com" , "jay.jayatheerthan@intel.com" , Pavan Nikhilesh Bhagavatula , "harry.van.haaren@intel.com" , Shijith Thotton , Ray Kinsella , David Marchand Thread-Topic: [PATCH v8 1/3] eventdev: introduce crypto adapter enqueue API Thread-Index: AQHXME/w7NZxcpxPpUCaqe4Yw/XWAKqznaGA Date: Wed, 14 Apr 2021 07:28:03 +0000 Message-ID: References: <561328fb16b18404a30a2401c6bfb3a7f373a0f4.1618309291.git.sthotton@marvell.com> In-Reply-To: <561328fb16b18404a30a2401c6bfb3a7f373a0f4.1618309291.git.sthotton@marvell.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [122.167.123.15] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 88712057-cfe5-44b7-f29b-08d8ff16d6f9 x-ms-traffictypediagnostic: SN7PR18MB4397: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: cJIeKcZyMn/jbuwMv6u4Hx+UsUx+DZp3HTVkkglvwczQq340FM1g1wtB7xmpshi0Q3aR2W6uDecS+MTDZ7MQHhwwECDyE13Jdb8vrs4fD0YQD72bJ5fEIW1exMNiT+4ujzhS16emIPMqOnVbF75Xj8wPXlVLDSNnFGeiTLX8MmxT1III7aedMQ4cCYOM8Dpi1e0xyqkH/XT5YyHrOfW3JvbP7aQ+PEIPVBGUBfZ6wPeD7DjrOYUvS3MVwSKouBrgddUWYunyWtYbX3U9tYInIMkcqTYV3F83GbfdiL3iom+4kyIedsNr/q9W4oiOvuAynJQLyTbPx9JkUkPTY/HoZ1BQSQlOwYGh+m+UtHZUTsG21V/PtHukbevS/ShQ17XSN1mfVCHdJ0z/XMFGdFDuUHCef558zpG8m4YG8HOxCkwBvwEToZzQsGCUdyfvZNsOPe+jm/r6x4ID2u96PIFYGLJ/fqs6ve8jnUB6hA1T+Dd3l5MgDRtsjz34gjgiWyq8+jv1pky5utr+Q2atf9IZRpHNFYsSY0rk75LUIwg6yFLehufbO5z/VXgFv8+5BXl9fdvWmhXP1kiohaq1LvhhryweZxCy2V+BkYj2NL28LMo= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN7PR18MB4398.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(346002)(376002)(366004)(396003)(39860400002)(7696005)(316002)(38100700002)(8676002)(2906002)(6506007)(33656002)(110136005)(478600001)(26005)(55016002)(4326008)(54906003)(186003)(66446008)(86362001)(66556008)(122000001)(76116006)(52536014)(66476007)(66946007)(5660300002)(71200400001)(83380400001)(9686003)(8936002)(7416002)(64756008); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?yZPeCTzxe0Fhjop9IjR0MzuV429ODJ7+SCd1vpZUtgWv1zC5ycXgfa1Hmevp?= =?us-ascii?Q?2U5Kih39gMqDaFsM/G2j5F3qERzV0hg+M6lY4sp1fcCVOyG+ApkaucGr+GI7?= =?us-ascii?Q?1kKe9pD+wMWusv5WMixa1S5JKBx1WMVW5LJZsZ6OL13tX2WFL7CuQvL0Q3Wk?= =?us-ascii?Q?w/iEDDtZ63DwGoCgIhNPSssl/uJ4cmyH9lltO0t/uzrDZ3bcEkCimcFHK38v?= =?us-ascii?Q?ISCfuORLTKEI39cL7HBkNZL4/dQs1zENw4Fm2V1X8RXzkwPvS5+lycE7YIMJ?= =?us-ascii?Q?Un078bIj8px4M92ttr2PH+2ClgsRR5iK12fkUsA7iOGzhX1diyDtg/c1oANN?= =?us-ascii?Q?HqWvHtg8EXiOg1HFsso2BeGHbbLegIp67VOTgIHPqg6FeHSnh1gl2ixGTB4h?= =?us-ascii?Q?rt2AbqSWLYspUNk3T43mQroANQaPJ8GbMyJgmn7B6RDHzCjAfUhW7TI9Kok4?= =?us-ascii?Q?KiTAfYD6kJf0SyZE5Kbmf9HSxyBLIpHmbfWqns4cv/R2GIWvA5stOcyhDyHl?= =?us-ascii?Q?XW10+zvChzOmtabQ5Vn5GDjvCkYHyPN93s3TVr632iD+t5U1FTfM1J4ln2M9?= =?us-ascii?Q?4jOouCsB/UNkr6c2FuCqjaYiRjurbdsjwU83Le/WEBdMIKEZqFRBH83/aZN7?= =?us-ascii?Q?4IqU781ZNXk0gsiIwu7Q87AYeDkg0F9n2AC1f3TTO8XvVEeYpjypW91reg/B?= =?us-ascii?Q?JeM1ORt0iMIf/N2DeNrolvchuqHnVYPLM+8z1ERq7uzXcfE3sdpHVhQKYsOE?= =?us-ascii?Q?nTb0xeA0I6P3q+4V2M4cbm5cYGHUxyibiFNDXTaE1TV/oW9RE/g9Xn6rv/r+?= =?us-ascii?Q?HGzwPIZVD/CDWzS6hUZKLot/FAJoOH0gcsrwRsYmwkNx+2NhL/jAkChOVbj7?= =?us-ascii?Q?tud5Pv9H46VVtwbUcPtHbkHp8dFsFnBi9Lmb6rJnxcu8zGzWt7OlVNlXYH0O?= =?us-ascii?Q?JqE9Jh4kDHhS+9xPoNEiCAVbi5T7R7+fRB04yKJ+a29LM3nMZa7GHzOlaerQ?= =?us-ascii?Q?rlpVv3PVsq+18a8fzBrLT1dgeUid55zR2CSP2O6EFZ0Jr4B8IVV6j1qHwreK?= =?us-ascii?Q?bDB4kVIMHwdFkYRZt6kHlKMhY660fcEj5A2s+I88db5iZWiE66Mn4gZboe42?= =?us-ascii?Q?vXn8X9XyTtAluaxYfs7rY5ljK+6cKnMoMUZ6xsXpF4dw0UFyK1L0V7/i/2fn?= =?us-ascii?Q?apfeWvHlA8IoUvdeZ0Y2GumYug/W5lmVt7nBM99I+Q2D1v3ywr/LAXzAk+7D?= =?us-ascii?Q?XPezA+wBvf6JgkQE4W8rOA/5qKqQlsyIlLgELFcHEiq1I4H0szNA4XrS48dH?= =?us-ascii?Q?rY3t9PfAbSQxCGSpEnF4J2nJ?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN7PR18MB4398.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 88712057-cfe5-44b7-f29b-08d8ff16d6f9 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Apr 2021 07:28:03.3465 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: xsMcnoX25hgi4cip8sQUVuGu9d52naASHYwMtwNhsFzJztmbsuRZUmZ9Pf2+WTsfrCDF75gKhLqEm9ftCrN6xg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR18MB4397 X-Proofpoint-ORIG-GUID: OJAgFuih-P3qvH9pwMslIhBQoapOvTSS X-Proofpoint-GUID: OJAgFuih-P3qvH9pwMslIhBQoapOvTSS X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391, 18.0.761 definitions=2021-04-14_03:2021-04-14, 2021-04-14 signatures=0 Subject: Re: [dpdk-dev] [PATCH v8 1/3] eventdev: introduce crypto adapter enqueue API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > + > #define RTE_EVENTDEV_NAME_MAX_LEN (64) > /**< @internal Max length of name of event PMD */ >=20 > @@ -1423,6 +1427,8 @@ struct rte_eventdev { > */ > event_tx_adapter_enqueue txa_enqueue; > /**< Pointer to PMD eth Tx adapter enqueue function. */ > + event_crypto_adapter_enqueue ca_enqueue; > + /**< Pointer to PMD crypto adapter enqueue function. */ > struct rte_eventdev_data *data; > /**< Pointer to device data */ > struct rte_eventdev_ops *dev_ops; > @@ -1435,7 +1441,7 @@ struct rte_eventdev { > /**< Flag indicating the device is attached */ >=20 > uint64_t reserved_64s[4]; /**< Reserved for future fields */ > - void *reserved_ptrs[4]; /**< Reserved for future fields */ > + void *reserved_ptrs[3]; /**< Reserved for future fields */ > } __rte_cache_aligned; This change has following ABI breakage[1]. Could you move ca_enqueue at end of struct to avoid the ABI breakage. Also,= please update depreciation notice to move ca_enqueue to above(to align wit= h function pointers) in 21.11 release. [1] [C]'function rte_eventdev* rte_event_pmd_allocate(const char*, int)' at r= te_eventdev.c:1467:1 has some indirect sub-type changes: return type changed: in pointed to type 'struct rte_eventdev' at rte_eventdev.h:1411:1: type size hasn't changed 1 data member insertion: 'event_crypto_adapter_enqueue rte_eventdev::ca_enqueue', at offse= t 512 (in bits) at rte_eventdev.h:1430:1 5 data member changes: 'rte_eventdev_data* rte_eventdev::data' offset changed from 512 to= 576 (in bits) (by +64 bits) 'rte_eventdev_ops* rte_eventdev::dev_ops' offset changed from 576 = to 640 (in bits) (by +64 bits) 'rte_device* rte_eventdev::dev' offset changed from 640 to 704 (in= bits) (by +64 bits) 'uint64_t rte_eventdev::reserved_64s[4]' offset changed from 768 t= o 832 (in bits) (by +64 bits) type of 'void* rte_eventdev::reserved_ptrs[4]' changed: type name changed from 'void*[4]' to 'void*[3]' array type size changed from 256 to 192 array type subrange 1 changed length from 4 to 3 and offset changed from 1024 to 1088 (in bits) (by +64 bits) =20 =09