From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from g9t5008.houston.hpe.com (g9t5008.houston.hpe.com [15.241.48.72]) by dpdk.org (Postfix) with ESMTP id D242F1F5 for ; Wed, 26 Jul 2017 06:40:06 +0200 (CEST) Received: from G9W8455.americas.hpqcorp.net (exchangepmrr1.us.hpecorp.net [16.216.161.94]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by g9t5008.houston.hpe.com (Postfix) with ESMTPS id D986377; Wed, 26 Jul 2017 04:40:05 +0000 (UTC) Received: from G1W8108.americas.hpqcorp.net (2002:10c1:483c::10c1:483c) by G9W8455.americas.hpqcorp.net (2002:10d8:a15e::10d8:a15e) with Microsoft SMTP Server (TLS) id 15.0.1178.4; Wed, 26 Jul 2017 04:40:05 +0000 Received: from NAM01-SN1-obe.outbound.protection.outlook.com (15.241.52.10) by G1W8108.americas.hpqcorp.net (16.193.72.60) with Microsoft SMTP Server (TLS) id 15.0.1178.4 via Frontend Transport; Wed, 26 Jul 2017 04:40:06 +0000 Received: from TU4PR84MB0254.NAMPRD84.PROD.OUTLOOK.COM (10.162.186.12) by TU4PR84MB0254.NAMPRD84.PROD.OUTLOOK.COM (10.162.186.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1282.10; Wed, 26 Jul 2017 04:40:04 +0000 Received: from TU4PR84MB0254.NAMPRD84.PROD.OUTLOOK.COM ([10.162.186.12]) by TU4PR84MB0254.NAMPRD84.PROD.OUTLOOK.COM ([10.162.186.12]) with mapi id 15.01.1282.020; Wed, 26 Jul 2017 04:40:04 +0000 From: "Roberts, Lee A." To: "Wiles, Keith" , Thomas Monjalon CC: "dev@dpdk.org" Thread-Topic: [pktgen PATCH 0/6] fix compilation Thread-Index: AQHTBcLyPjKIx5cB/EaDZ4iCaZpoVaJlg9HQ Date: Wed, 26 Jul 2017 04:40:03 +0000 Message-ID: References: <20170725222107.23203-1-thomas@monjalon.net> <4FFF6FD7-FAAB-4034-92DC-D1CF27294837@intel.com> In-Reply-To: <4FFF6FD7-FAAB-4034-92DC-D1CF27294837@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=lee.roberts@hpe.com; x-originating-ip: [67.217.12.105] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; TU4PR84MB0254; 7:Sn9SHhgRsE7/vYycdzoWzW5vXi10YGIyH+Tj8qnUTY1V837eNd8L11O6M7WmaoCZSteIxPBRAdyGJco4YQrvkafdYjGvJNqAv4290WTR28gqBsdJhn+O1gdRcddsda/koDkE9qTzvhIIE87BeIsB9ddX6i0EltesvA+lqANWo+TFnoUVqMn+7r4PEAbWAHcWDw11qiRmkBedsmPi85ifjK0YeWib7AhlS+oKuO5UHLkM9A1HA0lRz1pmXllWiHF0vdXxAJfK6BYhy1fG1ipYQkWv3RVvfyVIpqKiOrNSqMt2sH6DF8QfkRiHhOG5t5vmdP/buda0U/G9MPy7Em1v2mEfVwzzaZJGaODv+Nt24hfGWjphYYAqa3AclKQcpHxArm4ZoyY+wbhqxGdnBeAzdPPmiKaCZ982Tf6DjJBgmR5P1eVv6hBdNKEQ0sr1hNQGapsWseIALtx3PxLSXSiCdaW2wAxejWFlvX0+slOdyYDJgBXmHySnc0d0Opv5CI2R3qSh2U1QXyKKxJhXVG6AvaWFcbacB54xZQk1FFJtrqvqE0k7DsIRTsefwCgCXAJhFtdk2NSoXt4KtRi9pBsGRcPYYnx1ixYXIM4UAyq4juDSY24vxSZEwLmomHb6EQERYkss4h7S5rBqZgwHIe26XH96DlAcCUzAeEgLw7jw7J7iOWK7JP8ZEMv82StkN6p8CuAqaAErx1ndhPAvz1Z2Bf0djoVd2UfcdfOrHq79wCgVgQgKXu1HbZiQW4YQFKTegah+uCqh+2ICIxcjAn93wqZUTS/Ia0/b/kufYqAdxHM= x-ms-office365-filtering-correlation-id: 11c28ff6-68bf-4804-c9cc-08d4d3e06238 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254075)(48565401081)(300000503095)(300135400095)(2017052603031)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:TU4PR84MB0254; x-ms-traffictypediagnostic: TU4PR84MB0254: x-exchange-antispam-report-test: UriScan:(228905959029699); x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(8121501046)(5005006)(10201501046)(100000703101)(100105400095)(93006095)(93001095)(3002001)(6055026)(6041248)(20161123558100)(20161123562025)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(20161123560025)(6072148)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:TU4PR84MB0254; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:TU4PR84MB0254; x-forefront-prvs: 038002787A x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(6009001)(39860400002)(39450400003)(39840400002)(39850400002)(39400400002)(39410400002)(189002)(377454003)(199003)(13464003)(24454002)(50986999)(5660300001)(97736004)(54356999)(76176999)(68736007)(102836003)(14454004)(6116002)(101416001)(6506006)(77096006)(105586002)(3660700001)(4326008)(3280700002)(74316002)(33656002)(106356001)(3846002)(7696004)(6436002)(478600001)(7736002)(86362001)(55016002)(9686003)(25786009)(229853002)(66066001)(2900100001)(53546010)(53936002)(2950100002)(189998001)(81166006)(305945005)(8676002)(8936002)(38730400002)(2906002)(81156014)(6246003); DIR:OUT; SFP:1102; SCL:1; SRVR:TU4PR84MB0254; H:TU4PR84MB0254.NAMPRD84.PROD.OUTLOOK.COM; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; received-spf: None (protection.outlook.com: hpe.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Jul 2017 04:40:03.8856 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-Transport-CrossTenantHeadersStamped: TU4PR84MB0254 X-OriginatorOrg: hpe.com Subject: Re: [dpdk-dev] [pktgen PATCH 0/6] fix compilation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Jul 2017 04:40:07 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Wiles, Keith > Sent: Tuesday, July 25, 2017 9:54 PM > To: Thomas Monjalon > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [pktgen PATCH 0/6] fix compilation >=20 >=20 > > On Jul 25, 2017, at 5:21 PM, Thomas Monjalon wrot= e: > > > > Some errors were seen when trying to compile with gcc 7 or clang, > > for 32-bit, and with DPDK 17.08-rc2. > > > > Thomas Monjalon (6): > > remove unused functions > > fix screen type saving > > fix compilation of printf based functions > > fix compilation with gcc 7 > > fix 32-bit build > > fix build with dpdk-17.08-rc2 > > > > app/Makefile | 3 --- > > app/cli-functions.c | 2 +- > > app/lpktgenlib.c | 12 ++---------- > > app/pktgen-cmds.c | 18 +++++++++--------- > > app/pktgen-latency.c | 26 ++++++++++++++------------ > > app/pktgen-log.c | 1 + > > app/pktgen-port-cfg.h | 2 +- > > app/pktgen-stats.c | 47 ++++++++++++++++++++++++++++-------------= ------ > > lib/cli/cli.c | 2 +- > > lib/cli/cli_cmds.c | 6 +++--- > > lib/cli/cli_common.h | 1 + > > lib/cli/cli_map.c | 2 +- > > lib/cli/cli_scrn.c | 5 ++++- > > lib/cli/cli_scrn.h | 1 + > > lib/common/l2p.c | 34 ---------------------------------- > > lib/common/mbuf.h | 3 +++ > > lib/common/port_config.c | 10 +--------- > > 17 files changed, 71 insertions(+), 104 deletions(-) >=20 > Acked by: Keith Wiles >=20 > I did apply these changes and in testing with i40e Pktgen now only sends = a few thousand packets then > stops sending. I am sure these patches are not the problem, but did you t= ry out Pktgen to see if it > worked with 17.08-rc2? Which version of Pktgen did you use? >=20 > I tried with clang and gcc both behave the same. >=20 > I noticed a new message: > i40e_dev_start(): please call hierarchy_commit() before starting the port > i40e_dev_start(): please call hierarchy_commit() before starting the port > i40e_dev_start(): please call hierarchy_commit() before starting the port > i40e_dev_start(): please call hierarchy_commit() before starting the port >=20 > and I tried to add the call in pktgen, but it had no effect. To me the TM= API should be defaulted to > the original mode and just work unless someone needs to use the TM APIs. = The hierarchy_commit routine > could not need to be called in the normal case is my guess. >=20 > > > > -- > > 2.13.2 > > >=20 > Regards, > Keith I also noticed an issue with pktgen sending a limited number (many thousand= ) of packets when using smaller packet sizes (64B, 128B) while using the ixgbe driver with an= X550 (actually, HPE-branded X550). I had applied the "[dpdk-dev] [PATCH] net/ixgbe: add su= pport of 2.5G and 5G" patch from Wei Dai to dpdk-17.08-rc2 before building pktgen-3.3.7 on RHEL 7= .3. I was using pktgen to generate packets on both ports of the X550 at 2.5G an= d 5G rates, but noticed that transmission would stop after a few seconds for smaller packet= sizes. - Lee Roberts