From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 68148431F0; Tue, 24 Oct 2023 18:08:12 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3E68040A6B; Tue, 24 Oct 2023 18:08:12 +0200 (CEST) Received: from JPN01-OS0-obe.outbound.protection.outlook.com (mail-os0jpn01olkn2041.outbound.protection.outlook.com [40.92.98.41]) by mails.dpdk.org (Postfix) with ESMTP id 6AFF6402C5 for ; Tue, 24 Oct 2023 18:08:11 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hOSZWh4QGWGMkiiBKKlgCjysjpgsxEWiPI8jYXfPSBLWtA0RYhyHRhwGdme8i7vk+U7mKaNCE6p5kM8i00Hly/iqdwidukTAI6o5RSMRtS9d1u8vzx1RyvBoGpxfLp3xFMp6Rtbsie3OrBRK58MpZBS3C5I8j4vlQK7ujzkiDWRbDvoYiDZO0hz34lYpJUxY2IVBnVHcXePnyEW2YKINe6bdGHQKy1QOHc4K6hGshBBX+8oNpbZm+v1hetD1e+K35G9RoljTfe3qXGrP+Qf28XzwRZ6Kx76faeVJhfhQet0cXnGY63kVCW11OwPkE3b8PCr6chj9RwW1vmpVi7p+Dg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jQBsmVFRE00HUspRHte6dCutT7ZwaMepRA7mlW6hLkk=; b=IqIM892rW1+GHxGzrFhBNt42CH9RDy3RpHBdL4kzY00GTTqAB4uWGZx2RYe/vpMTcCKsyhHNtl2MJzQ3G5RJQQ0YaAHZT5wRnQN9tTdfsGPghG0DcMjTA3KVwTsObOyLMa+MuUWDbnGzeoRFL1DzBQvTrQj0f6Ldb9Nf2DAMl4qkjPlf6H1UdkL36GHmuEyJNW/+kCJ7HNEJRU30t3KIZbgPRr2b81ODPaoV8LVSnqegMYG74kSr9asD/aV0Ak3BAHqdLNz1TkpjlzN4P6XtntqeFoW0DGC/mtdN/SB2wiAIC+79i+3CsIbt7GJQt/TXgNFg0WsIp5UKWVHMku/Vdw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jQBsmVFRE00HUspRHte6dCutT7ZwaMepRA7mlW6hLkk=; b=uHxlY1zTXBzlTbfBzQvyVbMZ2xMFt59ciGP8TT6JLCfT6mLhX8nffzHjO4MNvF3ro1AjT1ZBlYZmGN52K1LBesiv46WHEZYC6u2bP9wVTh+yo1GLP2VuwS163obwXtOyuLSs3PTn9WBd0rM/cOgEQ5aPiQFDtRO6iQXKvTzaRT3rMlPxlRYjJO0+3ZsCEqvSXhXYsWS3CxqM33YvvdRLGoxflBGxjls/tozjAznQzPKZd6T65FsSU3dtZ58yINszPYPuuiqaTFpSaTDCWus6vFc7qB191rNzDKx6UIaqHG4+weca0Sc6Lk2P9eimZj6nfXBmUPTEPFCPA2/FbObp5A== Received: from TYAP286MB0300.JPNP286.PROD.OUTLOOK.COM (2603:1096:404:8039::14) by OS3P286MB1934.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:173::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6907.33; Tue, 24 Oct 2023 16:08:09 +0000 Received: from TYAP286MB0300.JPNP286.PROD.OUTLOOK.COM ([fe80::2a83:3c1d:1dbc:7de5]) by TYAP286MB0300.JPNP286.PROD.OUTLOOK.COM ([fe80::2a83:3c1d:1dbc:7de5%6]) with mapi id 15.20.6907.032; Tue, 24 Oct 2023 16:08:09 +0000 Message-ID: Date: Wed, 25 Oct 2023 00:08:04 +0800 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/2] build: fix list_dir_globs failure in MSYS2 To: Bruce Richardson , Thomas Monjalon Cc: dev@dpdk.org, david.marchand@redhat.com References: <2188661.NgBsaNRSFp@thomas> From: Ric Li In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-TMN: [09w3EW5e0EmBzzq3ZM2YVo3A06U/3o1A] X-ClientProxiedBy: TYCP286CA0338.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:38e::17) To TYAP286MB0300.JPNP286.PROD.OUTLOOK.COM (2603:1096:404:8039::14) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: TYAP286MB0300:EE_|OS3P286MB1934:EE_ X-MS-Office365-Filtering-Correlation-Id: 92b5a7ec-1310-413f-da13-08dbd4ab6a09 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: u+YDCANtG3thmEQjqLUEJISWwCKEGhvvchNxZyy4BUZfPkRlUsNylLL9JEQYeCAOW2NffX6Qb7KeMr7mmvk2Z1lWbIo8kK+uGDqZqhzFBOyhommmF9OcFM54e6mblES2Wzaobtqf55/8jY3nMAaXKx6wgU45fHT5CUJa6adUKyzwpb8VyYNz5dVTIqJwk678TAfxmt4HflzL/ZH/nKynakQSx59EyggFGIRnA86LTmsmprIVGPGjQLsJ+DRe06TSoH6HdHawGKifUvQUMaj50x24ZkoMGqhidsbAUJjygqnOqBsq0k4DOD7wFzWckh3UBZPQirnc9yfJs8uC53fT2sXmje/divFsOocTHHoyxK+fkNthNXB0HTM/u7oMPiujeSGaYf+begTPJsiQHty/lT8m+mT9ouICvE1fWiOg0P3GfktsbPVd2CAN9RU0/ujb8w2ZHo4hpglLs3vKz6WALIeZ0bzrUUjN4sIjyTwc/P44mEY2/qli3RFHGImMxQRhtMHWrfbJiKqVb7Wu66LTUEkLUHcknIiyE5xbfkCkhmZQVtlE3KPonbgiBRxIXp6+ X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cTBNTk93dUNIOG1qUVpGZlJWZk41Mm44T2JkK2k2bTdMeHMyaUI2SE9DenZr?= =?utf-8?B?blpRdmFzL3RXWDIyWWF5OE5WQ3daeCtISEVkNGM4RzF6b2cwZzRhVmRqQ1Y2?= =?utf-8?B?bFB4VGlIb1lUazFqYU1jVE9XUjM1bEZxTVlaRi9RUXZJZzcvbm95OGxwWnll?= =?utf-8?B?bmhLWG5IYTBFa21XNG9vSktMZkRkakhSOWRJMGVybnpNbDZ0VHhBS0F6R1VV?= =?utf-8?B?YXB5QXhWcmpJZVAybTVaRUt0Q2dFcWtHTTBITWh4b1V4L3NOLzQ1N1ZBLzdZ?= =?utf-8?B?dFdjek5kWGxHV3RlVnJsOXVCTTAwN1RGdmRHNXRpa0VZVnVZdmlWeXlCZW9i?= =?utf-8?B?QmJIajhNT1crMFFGTWMxUkhTcmgyaDN1YnI2eFY4M05jZnJvd2JiMGdJWkpu?= =?utf-8?B?a2ZyZW91TU5keGp2TnBONUZ4UE9jRUVOc3VsaFBHclgzaitnWTBmVFc4MlVE?= =?utf-8?B?OWNsRE9LZkJFVDFhOWdsTVZRK1RSY1ZhM1JzNmszN3ljcW83ZERxUEVKT05U?= =?utf-8?B?M2E5aWF3b3BNbXlYZWljLzQxTVV0R0VGY1E5ZEdYODV0OW95bGlPSXJpb0lK?= =?utf-8?B?Wkt5eGIvSytWeEI3UFhpUHVaUnlaLzkvRDZsWWpqNlhtQmhObmJmTEIySDhv?= =?utf-8?B?cXVTMlZjMDVGU2NpdThWTTltYjlTY0NHd2hSSmJBdGQybWJhdk5ST0Iwc1F3?= =?utf-8?B?eWJxYzA3d0JYSWV3NGQzczkrY25Mb2pFOW1ReEloV1FCeVVuWUZrb1RXanhZ?= =?utf-8?B?bStLckdjeng3a3IzRVlJOTUwS2hDNDZtdVEwNjFFR21PMkZuanlGYXZtVVpY?= =?utf-8?B?UVk5aU1GSEFlbUM5Q1J5azJrT0NrZzF1YmxZdGhYeEhGZ3ZLaTVJNUw1Vmlw?= =?utf-8?B?Um1pRXg2b2pMdEx4Q0Y4NjB3NmNXSmdzWlFMcno4M3o4TTRxVVFKVW95eVZC?= =?utf-8?B?Q0xrQTF1NGhHZUFEakdwcE81T2xpWEpjMWRnMzN0aklZK2ZMaXhWYmI0UjV1?= =?utf-8?B?QVdDMmxTRWRvcWRtM1YyNDA1UTdaMVh3eW9iRXc4aDZwbGR5TjExS2RKcm1u?= =?utf-8?B?VVJ4QmxpdHJlNkFMSGxsRTdYWk5GbGd2RVNKREhnbVBxaFBkNTVTMVBoWktu?= =?utf-8?B?TmN0QUxuYTdJRFBiL1BIelpPdnNsTS91U3JvZnJQUGI2YjRqVm1iZVdEUmt3?= =?utf-8?B?RjNhQWtURmluVFczQWlHdFRaVFBYbUJJclNOcDFiRWhEc0ZYU2dDN3ZBTi9Y?= =?utf-8?B?TW5BSkdSVXI2Yng1TFVPVUJYN2VGRnJ1K0VNYWFHWmhERTRMK09uV2FKV3dJ?= =?utf-8?B?RmE4cjRwaVFPbllXNmx1aGlmNTByd05SN0Vpd0RRaU1oTjZXbmpaLzRlM1Bx?= =?utf-8?B?MnZZN3VrcDNLTTJsOWlZYjJoY2tRNUdTM2IvOUJteFFicFdtS0JZVVhZZXpn?= =?utf-8?B?TjJzd2V2cFNDc3hhSnN1c1Fzb3d6ZHJWME5TdnVlNzBHRnl2TkhrV1BrVlhW?= =?utf-8?B?Wm1CSEIvOUpvaWd3bFZkMXV4Q3ZUaVJyNDBXSUQ1Y3AzVDBvWG9mLyt1aUdp?= =?utf-8?B?dE1QdXRDUlVmcWVaOVcyMXdiQWJRaXZiaGw1Nzl5SGpHVXpvdE1ER1NxT0xr?= =?utf-8?B?UVovQ3VXci9yeDNISzhFMU04czNYeEE9PQ==?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 92b5a7ec-1310-413f-da13-08dbd4ab6a09 X-MS-Exchange-CrossTenant-AuthSource: TYAP286MB0300.JPNP286.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Oct 2023 16:08:08.9656 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: OS3P286MB1934 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2023/10/11 23:34, Bruce Richardson wrote: > On Wed, Oct 11, 2023 at 05:27:22PM +0200, Thomas Monjalon wrote: >> 20/09/2023 16:18, Ric Li: >>> When running 'meson setup' on Windows with MSYS2, >>> "list-dir-globs.py * failed with status 1". >> >> We don't know why it is failing? >> What about other usages of list_dir_globs in drivers and lib? Looks lile MSYS2 shell expands this wildcard automatically before passing it to the child process. I print the args in list-dir-globs.py and found that args are the expanded dir names, so the len(sys.argv) is larger than 2, which makes this script fail. The '*/*' arg in drivers/meson.build works well just as expected, and no '*' used in lib. This is from MSYS2 documentation: "Windows programs parse the command line themselves, it isn't parsed for them by the calling process, as on Linux. This means that if wildcards (glob patterns) are to be accepted by the program, it has to be able to expand them somehow. MinGW-w64 supplies the correct start-up code, so it happens automatically, in a manner compatible with MSVC-compiled programs. If undesirable, the behavior can be disabled at program build." I think this fix is not needed if we can find a way to disable the auto-expanding behaviour of the MSYS2 program. I've tried the runtime way by setting "MSYS=noglob" envvar but not working here... >> >>> Avoid using globbing to get components for app build >>> since they are already listed in the meson file. >> >> I don't understand the logic. >> >>> +disable_apps = ',' + get_option('disable_apps') >>> +disable_apps = run_command(list_dir_globs, disable_apps, check: true).stdout().split() >> >> This could fail.>> >>> + >>> +enable_apps = ',' + get_option('enable_apps') >>> +enable_apps = run_command(list_dir_globs, enable_apps, check: true).stdout().split() >>> +if enable_apps.length() == 0 >>> + enable_apps = apps >>> +endif >> >> If nothing is enabled, we enable all? >> > Yes, if the enable_apps list is empty we should enable everything. > However, on reviewing the v2, I missed the fact that this patch is > removing the expansion of the disable_apps value.> > Given your comment, this check can probably also be improved by checking > the get_option('enable_apps') length, rather than the expanded version. > > /Bruce