From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 38663A0548; Thu, 11 Nov 2021 17:07:45 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B563240E28; Thu, 11 Nov 2021 17:07:44 +0100 (CET) Received: from JPN01-OS2-obe.outbound.protection.outlook.com (mail-eopbgr1410133.outbound.protection.outlook.com [40.107.141.133]) by mails.dpdk.org (Postfix) with ESMTP id 8863F40E03; Thu, 11 Nov 2021 17:07:42 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UweiIcp/r6aDqPgtMI8FqLGWH6MhL/oX+tNyWYbMt4pE5muNSCL7DmOEoemBx28L4Vo8rbuphj51BBlUxvCZWlie86QuwxG+siUG/JHb9mxhrQ0sCucXrmq33e0DAioyJCz1Ufdr5WiRkTFOqijEsLimi2PS7QJshbZtbhAX9YZS/1jkAau4po5H4ohSTBAQCN13J5GU+dXR5Yuw4kUmh22P4Big/kB8xobl4Gyh2qaUvNIXb8SFrvF0C7dgJq7t9sWS1+yEs7CFonuJIKHD15+8ZALnyCSI2qXzpxpcxxQhfZeNDroeogCz92jse2OQwH5xQ6GFwq2z++rUgRKIrQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ccOT0vWGEbAvBfUAVn9RR400yfWek0qiNxWAQ6/NoMQ=; b=Eq0lyFR5+5devetajCwlQ3UEocI9H9lfocwe2Ev0qG6G3pkYo7Tu7G+y+d+JxFw8plo9XsCFf+izlIDbFO2Bxc7dLiaLi4sgiuAMCc0z8FZCUM14MEh74BPXaxY+JAefyatpGCvH06J/tziDS6R1J8Nst424ipFnFbShakFp/qQnwqf8Fe2aW1XozjVyDO3Jdjz3qo05KWpGqWIpzBuqTKYyKkCCGWwjdRxEc7c8/cmmsnK3aHfYJJHOGB5hzb0DZHyn0rW6B30LNsJ8vfF2BJhee2cHlSBPnP4HBRoN6DIG5UZmOWtgf4qSg/Z8uMpCvqVrFjWpTZFH6vPzAOAtwQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=connect.ust.hk; dmarc=pass action=none header.from=connect.ust.hk; dkim=pass header.d=connect.ust.hk; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=connect.ust.hk; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ccOT0vWGEbAvBfUAVn9RR400yfWek0qiNxWAQ6/NoMQ=; b=eAfpMOBC6LTpfTumBLxdwI7+3Ih8lPFKsgQRB2+ld6jJ3qWSfBosledAwxDE+f9i2yXgXuCns0KwY8prp7GePCsQ+ZEKULXSsWfiytQfHLy/NSVfs6SbzOu3o3eIrhkvA/KiwiHXtk3JBvJPscp6du+3danDW6p4Dz1yT+CsJrs= Received: from TYCP286MB1188.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:b7::8) by TYCP286MB1395.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:c2::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4690.18; Thu, 11 Nov 2021 16:07:40 +0000 Received: from TYCP286MB1188.JPNP286.PROD.OUTLOOK.COM ([fe80::c0af:a534:cead:3a04]) by TYCP286MB1188.JPNP286.PROD.OUTLOOK.COM ([fe80::c0af:a534:cead:3a04%7]) with mapi id 15.20.4690.021; Thu, 11 Nov 2021 16:07:40 +0000 From: YE Chengfeng To: Slava Ovsiienko , Ferruh Yigit , "dev@dpdk.org" CC: Raslan Darawsheh , Matan Azrad , "stable@dpdk.org" Subject: Re: [PATCH] net/mlx5: remove redundant "set used" Thread-Topic: [PATCH] net/mlx5: remove redundant "set used" Thread-Index: AQHX1tjhBIiFFw1jBUWmmrCXbIuNuKv+BxeAgAA0xYCAAAVvAIAAPBcp Date: Thu, 11 Nov 2021 16:07:39 +0000 Message-ID: References: <20211111084751.26721-1-viacheslavo@nvidia.com> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=connect.ust.hk; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 5d5492d5-0dc7-4f25-3ea2-08d9a52d62de x-ms-traffictypediagnostic: TYCP286MB1395: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5797; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: A8PYizttWMYl7Md6uyNXRge8Bajooi2XmnUI7DsOx21pAinIW4OhJEtO6VXnnrQqVcDQEZF3vsm4yX+eRXsHQV3+ocMlnX4pVPsqlZ434zhtJoCx0Qmos/oOeQuRzlukyiF+J9f2rfGA5JYWJohG+qp+QYMdXUixWv4TCok67eFc+A5czjUdUBZT1e2nYpi2qdAONMEE2QmUPHDvBkeZPD7CuuuKae3jyKN5co2Er+72l2cQkMQ9h9tblDQYLJUNc5vyylWdd1cEjx7huQDOu4w5fGRqcJmLRqrYETULF+MtvSiEnVCL2Q7M6kIq25W7szSnA7kJzuLOhIvbBLO1BQQE4QFwRAbRgfCDTwi+0PWThwAlEhTOaubSOnu6Jo7wsKWXVjPU7xRq9AoWF/M0ipiOp+huwz6eMKoB//JsigYaG3jSwFZFAww+8tyno9Ka319eh9M7+HDLP2/DY4/+drVnE3CteBC7xjtl9NDXdWFAUfhjxZdqn3ONKr2ykn+o/0dwB9QVroEcQBKdyovY93V4iu+S7UMZGC4A3FKJAoW/yEg8o4K6GdH5tbbXdR56DKOOsydBX7l+Ot27XBbcPI1vo1xCw5GLeG4yQjG0CtjntA0B1652Ei+Om2w6piGufSv7feS9+abYLSBSL2vAdaYI5Krq758RUahFitbVH1YnvQLININfkBjdMkiTvXzJmchwUxDnirBq3rL60983+DNyYCxzQc4hcx8UntxbYX8WEheskt5/JI4TGmdNTNS2ftcDGwIfYDFNUqO46CIjYw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:TYCP286MB1188.JPNP286.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(4636009)(366004)(122000001)(166002)(66946007)(52536014)(71200400001)(26005)(316002)(33656002)(786003)(66446008)(9686003)(45080400002)(38070700005)(6506007)(91956017)(86362001)(53546011)(38100700002)(7696005)(76116006)(966005)(2906002)(186003)(5660300002)(8676002)(8936002)(54906003)(83380400001)(110136005)(66476007)(4326008)(55016002)(508600001)(64756008)(66556008); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?gb2312?B?NSs1ZmtrWkN1amtzdHdyejJPenhYelg0Nm1aN3gwVVppd0g0aUNXNlJSbW0v?= =?gb2312?B?OXYrdkFCN1ZVQ2U0ZnVMb1M3ZVIzeGZVMnBySkRSWUdJSlNYTzlaRHFTd1Q2?= =?gb2312?B?Zk9KTkE1LzFjU01wMUpTeWd3TVBjUloycXhiYTBVY1JndGVSczA2SlZaS3Vt?= =?gb2312?B?b2djOE5XeU95UG1qU3g1SkhlQUdFUDZJN2RFTTdhbVVSbUl6WjNJcHI5VHhY?= =?gb2312?B?Ukx3SVRPNjRyQXZ2RUpJQ0xUanJEdUl1bUhKVU9ueW5rTm9RWW9PbUVjb1ZP?= =?gb2312?B?ODZ3N2s0aWcvVGtGMUhsWXhMT0VPa284ZzUrVkhxdzM0Z3RpQU51Nll4cVRN?= =?gb2312?B?MGJ0NGprZGtIYjIzTkZwQzBzVzkxSVI2SlF3VFk1eURlSkEzN1RRMThHZGVV?= =?gb2312?B?emowYmx1VDkraUI2WlN5Q1ZCSWF6UDdOQnFqOGRWZXpiYVpXYzFOc0xYdkZw?= =?gb2312?B?ODN0eHNwYnhBTW9ZbnRRc1dWSk45M1ExaDRJYjRTeGF6QlFmdkJ6cisrYzQx?= =?gb2312?B?aEpPVlFGaldISUVOcldNQnFyd0xtYWIyb3NqVGxyakUwL0RCUTJ2a0pYbE4z?= =?gb2312?B?M2M4M0wyZThEWDNBYVVrdi9ZVTdQZDBCU3I3cDBLcGtvK3ZSL0JLams1bWk3?= =?gb2312?B?aUp1eFhGK1NtNGw1ZVVDNzA4QXRybUlwSFkwQXA5Mlg4eFNWelFqYjFxR2Mx?= =?gb2312?B?RC9lY3pjQ1pQT0Jxc2JjdDJQWG85WDBJOVhrVWdlaTBzZlNlT1lteFR0THRv?= =?gb2312?B?UjFYV2FFLzR4RXAwV3YvdCtwcXhDN1hOWTY2NmZQY2tGc0tqeGtXU25iQ2c1?= =?gb2312?B?eHFVMlpiL21jNHF2YytIV21rUDVLZ0d4bWVWYStib3hRV2FOUjRUY3QweVJk?= =?gb2312?B?K05IUkVJMmdlVFBUS2RCRVlHTXdhSkR0bnJSYlJ6dFhscS9jb1RES1BNdkRO?= =?gb2312?B?ZlFQNU1CSktHNVBCODRuVnVWdmk0aVJwYk1hNHF5clNiOG5ESXhLQjIvSDM2?= =?gb2312?B?bkhrREZOZ056UFdLV3ZRNDc1MVRXR3RhK0xKYUZHaS9DTU1UUDFmaVFacXM5?= =?gb2312?B?MWYzeTl0VFFBblpqUkw3WXU5QlJkNjI0R0IxYllzcUI1Sk05QXhZNG1LMU1S?= =?gb2312?B?eExSQXpBdll5dTdhOU02M3dOamlKaXVXWkVoMXFRQUNSZHFZbTVMbEZGQWN6?= =?gb2312?B?NUxtU2RRNDBpciszMUFwNzQyMkdNWHI4bkdBdUhNMWRMUmYyaldha3Q3TjVM?= =?gb2312?B?NGdObjRDV0ZBZUZhajJobDdBelAxZC9mOE9aUGRmVGhTMG8rREZyRHR2L0Jz?= =?gb2312?B?VmxNMFhldkZRUHpsWG5MUVhuZkRiSllPejF2ckVmeklPcjV5b0tJZUNZaUQ3?= =?gb2312?B?WWs0TmtYZlFyNWwvbUhEQ1JRV2RoSVhQczBIalNyaTBhNHdHVEM4YktLd0Nx?= =?gb2312?B?cTV3RXl1VFhFSFZ5YVZxd3MvKzYvWUkrMFdGTThxWkJmcWFjaXBPT3plRnFl?= =?gb2312?B?NGdaMWc1bHRqVmhUNnpSeWdRWTZOdThXVE5CSlZnTkIramdQaUFubUZlZGV6?= =?gb2312?B?QjN2VTVBWm56QkJHaWRacjd4MUhhc0IxQ0Y3NExvL0ZSaEFrNkxLYkVZL0lk?= =?gb2312?B?bElGZTRXZ2g2TnJCOVI1amNld3R3RDdQbzlISFBlRXdodlZCaE5aMXgvS1FX?= =?gb2312?B?ZWtnRmtTRlhEV0NmckpTN3V3bHRNZHlrTVFLZUlBWDAzbkhMYmNQN1NSWDlX?= =?gb2312?B?OWMyc3JKd1RFSTFQanozdHZNMDc1MmplVi8xbmRGVGtFVEZXRjhMUHZOWWI4?= =?gb2312?B?ZHpCbnRjMG03TUd0Wk9KTHdqYmFlNmE4UDY1UHExaEd6eVJYc0xCdXZkNTFs?= =?gb2312?B?TEc4cTUyRnM5aDVkWU8vL2Y4bldkVVJyQUlEcEhTdFRIM3NNVmhOblBZNWJj?= =?gb2312?B?dkpkenJsaFNtY2pEeXhGbU5oamhLc2VEcWE3dHErOW14RUV3MDM2OUp6ampQ?= =?gb2312?B?UlNiZGROVDZWanpXL3ZwL0RqeHpnMmhBeDNvVmhUSlYwK0ZXNHM0MTNxY3FP?= =?gb2312?B?enk5bW5PSHJ4ZDVLdzBDYkFieXhVRWJEck5zVkNObWNFbHBwcWplNW9uV0xa?= =?gb2312?B?SEhXRkYwdThXbFdXS0NUS0RxRjV3a2pSdnpHN0laT3RsWVNkUGNFZ2ZOV3pW?= =?gb2312?Q?IZkqGW1fu1ibDU3NzxcX+1PcW3QJ7myGxt+eOsz23o3r?= Content-Type: multipart/alternative; boundary="_000_TYCP286MB1188356A3DC08BFCEABE0A828A949TYCP286MB1188JPNP_" MIME-Version: 1.0 X-OriginatorOrg: connect.ust.hk X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TYCP286MB1188.JPNP286.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: 5d5492d5-0dc7-4f25-3ea2-08d9a52d62de X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Nov 2021 16:07:39.6944 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 6c1d4152-39d0-44ca-88d9-b8d6ddca0708 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: fYvPbwUTXGiqopRIyA00vmvDo5P3Tname9kOeZic4MZ8yUasJR0t/hrqJsu0hF/k+fqi6MZnnX5ie/pDbReqpA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYCP286MB1395 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --_000_TYCP286MB1188356A3DC08BFCEABE0A828A949TYCP286MB1188JPNP_ Content-Type: text/plain; charset="gb2312" Content-Transfer-Encoding: base64 Tm8gcHJvYmxlbSwgSSB3aWxsIHNlbmQgdGhlIG5ldyBwYXRjaC4NCg0KQnV0IHdoYXQgYWJvdXQg dGhlIGNvbW1pdCBtZXNzYWdlIGFuZCB0aXRsZSwgc2hvdWxkIEkgdXNlIHRoZSBwcmV2aW91cyBv bmU/DQoNCm5ldC9tbHg1OiBmaXggbXV0ZXggdW5sb2NrIGluIHR4cHAgY2xlYW51cA0KDQoNCrvx yKEgT3V0bG9vayBmb3IgaU9TPGh0dHBzOi8vYWthLm1zL28wdWtlZj4NCl9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fDQq3orz+yMs6IFNsYXZhIE92c2lpZW5rbyA8dmlhY2hlc2xhdm9A bnZpZGlhLmNvbT4NCreiy83KsbzkOiBUaHVyc2RheSwgTm92ZW1iZXIgMTEsIDIwMjEgODoyNzoz MCBQTQ0KytW8/sjLOiBGZXJydWggWWlnaXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+OyBkZXZA ZHBkay5vcmcgPGRldkBkcGRrLm9yZz4NCrOty806IFJhc2xhbiBEYXJhd3NoZWggPHJhc2xhbmRA bnZpZGlhLmNvbT47IE1hdGFuIEF6cmFkIDxtYXRhbkBudmlkaWEuY29tPjsgc3RhYmxlQGRwZGsu b3JnIDxzdGFibGVAZHBkay5vcmc+OyBZRSBDaGVuZ2ZlbmcgPGN5ZWFhQGNvbm5lY3QudXN0Lmhr Pg0K1vfM4jogUkU6IFtQQVRDSF0gbmV0L21seDU6IHJlbW92ZSByZWR1bmRhbnQgInNldCB1c2Vk Ig0KDQpIaSwgRmVycnVoDQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTog RmVycnVoIFlpZ2l0IDxmZXJydWgueWlnaXRAaW50ZWwuY29tPg0KPiBTZW50OiBUaHVyc2RheSwg Tm92ZW1iZXIgMTEsIDIwMjEgMTQ6MDgNCj4gVG86IFNsYXZhIE92c2lpZW5rbyA8dmlhY2hlc2xh dm9AbnZpZGlhLmNvbT47IGRldkBkcGRrLm9yZw0KPiBDYzogUmFzbGFuIERhcmF3c2hlaCA8cmFz bGFuZEBudmlkaWEuY29tPjsgTWF0YW4gQXpyYWQNCj4gPG1hdGFuQG52aWRpYS5jb20+OyBzdGFi bGVAZHBkay5vcmc7IENoZW5nZmVuZyBZZQ0KPiA8Y3llYWFAY29ubmVjdC51c3QuaGs+DQo+IFN1 YmplY3Q6IFJlOiBbUEFUQ0hdIG5ldC9tbHg1OiByZW1vdmUgcmVkdW5kYW50ICJzZXQgdXNlZCIN Cj4NCj4gT24gMTEvMTEvMjAyMSA4OjU5IEFNLCBTbGF2YSBPdnNpaWVua28gd3JvdGU6DQo+ID4g SGksIEZlcnJ1aA0KPiA+DQo+ID4gSSd2ZSBhbHNvIGluc3BlY3RlZCB0aGUgbWx4NSBQTUQgY29k ZSBmb3IgUlRFX1NFVF9VU0VEKCkgZm9yIHRoZQ0KPiA+IHNpbWlsYXIgaXNzdWVzIHJlbGF0ZWQg dG8gdGhlIE1MWDVfQVNTRVJUKCkuDQo+ID4NCj4gPiBUaGUgcGF0Y2gNCj4gPiBodHRwczovL2Fw YzAxLnNhZmVsaW5rcy5wcm90ZWN0aW9uLm91dGxvb2suY29tLz91cmw9aHR0cCUzQSUyRiUyRnBh dGNoZXMuZHBkay5vcmclMkZwcm9qZWN0JTJGZHBkayUyRnBhdGNoJTJGMjAyMTExMTEwODQ3NTEu MjY3MjEtMS0mYW1wO2RhdGE9MDQlN0MwMSU3Q2N5ZWFhJTQwY29ubmVjdC51c3QuaGslN0M4NzU1 M2E1Y2Q0MzY0N2RiNzA4MDA4ZDlhNTBlYTMyMSU3QzZjMWQ0MTUyMzlkMDQ0Y2E4OGQ5YjhkNmRk Y2EwNzA4JTdDMSU3QzAlN0M2Mzc3MjIzMDQ1NjY4MjgxODUlN0NVbmtub3duJTdDVFdGcGJHWnNi M2Q4ZXlKV0lqb2lNQzR3TGpBd01EQWlMQ0pRSWpvaVYybHVNeklpTENKQlRpSTZJazFoYVd3aUxD SlhWQ0k2TW4wJTNEJTdDMTAwMCZhbXA7c2RhdGE9d29UTWdoc0UwUzdja29vMEFJMDFZYmRXckpl THRiTUN1NEdlRThKRGlVYyUzRCZhbXA7cmVzZXJ2ZWQ9MA0KPiB2aWFjDQo+ID4gaGVzbGF2b0Bu dmlkaWEuY29tLw0KPiA+IHNob3VsZCByZWZpbmUgdGhlIGZldyBmb3VuZCBvbmVzLg0KPiA+DQo+ ID4gSSBkbyBub3QgbWluZCBhYm91dCBzcXVhc2hpbmcgd2l0aCAibmV0L21seDU6IGZpeCBtdXRl eCB1bmxvY2sgaW4gdHhwcA0KPiBjbGVhbnVwIg0KPiA+IEFmdGVyIGdldHRpbmcgdGhpcyBjb2Rl IGluIFVwc3RyZWFtIHdpbGwgY2FyZSBhYm91dCB0aGUgdmVyc2lvbiBmb3IgTFRTLg0KPiA+DQo+ DQo+IEl0IHdpbGwgY2F1c2UgYWRkaXRpb25hbCBjb21wbGV4aXR5IGZvciB0aGUgTFRTLCBzaW5j ZSBhIHNtYWxsIHBhcnQgb2YgdGhlIGJlbG93DQo+IGZpeCB3aWxsIGJlIG9yaWdpbmF0ZWQgZnJv bSBDaGVuZ2ZlbmcncyBjaGFuZ2UuIFRvIGhlbHAgTFRTLCB3aGF0IGRvIHlvdSB0aGluaw0KPiAt IEZpcnN0IGdldCB5b3VyIGZpeCBvbiB0b3Agb2YgY3VycmVudCB0YXNrDQo+IC0gSGF2ZSBhIG5l dyB2ZXJzaW9uIGZyb20gQ2hlbmdmZW5nIG9uIHRvcCBvZiBsYXRlc3QgaGVhZCwgd2l0aCAnY2xh aW1femVybycNCj4gdXNhZ2U/DQpXb3VsZCBiZSBuaWNlLCBJIGhhdmUgbm8gYW55IG9iamVjdGlv bnMuDQpDaGVuZ2ZlbmcsIGNvdWxkIHlvdSBwbGVhc2UsIHNxdWFzaCAob3Igd3JpdGUgYnkgeW91 cnNlbGYpIG15IHByb3Bvc2VkIHVwZGF0ZXMNCmFuZCBzZW5kIHRoZSBuZXh0IHZlcnNpb24gb2Yg eW91ciBwYXRjaCB3aXRoICJjbGFpbV96ZXJvKCkiPw0KDQo+IFNvIG9ubHkgeW91ciB1cGRhdGUg bmVlZCB0byBiZSBtZXJnZWQgdG8gTFRTIHJlbGVhc2VzLg0KWWVzLCBhZ3JlZSwgaXQgaXMgZXZl biBiZXR0ZXIgdGhhbiBteSBwcm9wb3NhbC4NCg0KV2l0aCBiZXN0IHJlZ2FyZHMsDQpTbGF2YQ0K DQo+ID4NCj4gPj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gPj4gRnJvbTogVmlhY2hl c2xhdiBPdnNpaWVua28gPHZpYWNoZXNsYXZvQG52aWRpYS5jb20+DQo+ID4+IFNlbnQ6IFRodXJz ZGF5LCBOb3ZlbWJlciAxMSwgMjAyMSAxMDo0OA0KPiA+PiBUbzogZGV2QGRwZGsub3JnDQo+ID4+ IENjOiBmZXJydWgueWlnaXRAaW50ZWwuY29tOyBSYXNsYW4gRGFyYXdzaGVoIDxyYXNsYW5kQG52 aWRpYS5jb20+Ow0KPiA+PiBNYXRhbiBBenJhZCA8bWF0YW5AbnZpZGlhLmNvbT47IHN0YWJsZUBk cGRrLm9yZw0KPiA+PiBTdWJqZWN0OiBbUEFUQ0hdIG5ldC9tbHg1OiByZW1vdmUgcmVkdW5kYW50 ICJzZXQgdXNlZCINCj4gPj4NCj4gPj4gVGhlIHBhdGNoIGp1c3QgcmVmaW5lcyB0aGUgY29kZSBh bmQgcmVwbGFjZXMgdGhlIHBhaXJzIG9mDQo+ID4+IE1MWDVfQVNTRVJUKCkgYW5kDQo+ID4+IFJU RV9TRVRfVVNFRCgpIHdpdGggZXF1aXZhbGVudCBjbGFpbV96ZXJvKCkuDQo+ID4+DQo+ID4+IENj OiBzdGFibGVAZHBkay5vcmcNCj4gPj4NCj4gPj4gU2lnbmVkLW9mZi1ieTogVmlhY2hlc2xhdiBP dnNpaWVua28gPHZpYWNoZXNsYXZvQG52aWRpYS5jb20+DQo+ID4+IC0tLQ0KPiA+PiAgIGRyaXZl cnMvbmV0L21seDUvbWx4NV90eHBwLmMgfCAzMCArKysrKysrKysrLS0tLS0tLS0tLS0tLS0tLS0t LS0NCj4gPj4gICAxIGZpbGUgY2hhbmdlZCwgMTAgaW5zZXJ0aW9ucygrKSwgMjAgZGVsZXRpb25z KC0pDQo+ID4+DQo+ID4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL25ldC9tbHg1L21seDVfdHhwcC5j DQo+ID4+IGIvZHJpdmVycy9uZXQvbWx4NS9tbHg1X3R4cHAuYyBpbmRleCA3MzYyNmYwZThmLi5h Zjc3ZTkxZTRjIDEwMDY0NA0KPiA+PiAtLS0gYS9kcml2ZXJzL25ldC9tbHg1L21seDVfdHhwcC5j DQo+ID4+ICsrKyBiL2RyaXZlcnMvbmV0L21seDUvbWx4NV90eHBwLmMNCj4gPj4gQEAgLTg5MCw3 ICs4OTAsNiBAQCBtbHg1X3R4cHBfc3RhcnQoc3RydWN0IHJ0ZV9ldGhfZGV2ICpkZXYpDQo+ID4+ ICAgICBzdHJ1Y3QgbWx4NV9wcml2ICpwcml2ID0gZGV2LT5kYXRhLT5kZXZfcHJpdmF0ZTsNCj4g Pj4gICAgIHN0cnVjdCBtbHg1X2Rldl9jdHhfc2hhcmVkICpzaCA9IHByaXYtPnNoOw0KPiA+PiAg ICAgaW50IGVyciA9IDA7DQo+ID4+IC0gIGludCByZXQ7DQo+ID4+DQo+ID4+ICAgICBpZiAoIXBy aXYtPmNvbmZpZy50eF9wcCkgew0KPiA+PiAgICAgICAgICAgICAvKiBQYWNrZXQgcGFjaW5nIGlz IG5vdCByZXF1ZXN0ZWQgZm9yIHRoZSBkZXZpY2UuICovIEBAIC0NCj4gPj4gOTAzLDE0ICs5MDIs MTQgQEAgbWx4NV90eHBwX3N0YXJ0KHN0cnVjdCBydGVfZXRoX2RldiAqZGV2KQ0KPiA+PiAgICAg ICAgICAgICByZXR1cm4gMDsNCj4gPj4gICAgIH0NCj4gPj4gICAgIGlmIChwcml2LT5jb25maWcu dHhfcHAgPiAwKSB7DQo+ID4+IC0gICAgICAgICAgcmV0ID0gcnRlX21idWZfZHluZmxhZ19sb29r dXANCj4gPj4gLQ0KPiA+PiAgICAgKFJURV9NQlVGX0RZTkZMQUdfVFhfVElNRVNUQU1QX05BTUUs IE5VTEwpOw0KPiA+PiAtICAgICAgICAgIGlmIChyZXQgPCAwKQ0KPiA+PiArICAgICAgICAgIGVy ciA9IHJ0ZV9tYnVmX2R5bmZsYWdfbG9va3VwDQo+ID4+ICsgICAgICAgICAgICAgICAgICAoUlRF X01CVUZfRFlORkxBR19UWF9USU1FU1RBTVBfTkFNRSwNCj4gPj4gTlVMTCk7DQo+ID4+ICsgICAg ICAgICAgLyogTm8gZmxhZyByZWdpc3RlcmVkIG1lYW5zIG5vIHNlcnZpY2UgbmVlZGVkLiAqLw0K PiA+PiArICAgICAgICAgIGlmIChlcnIgPCAwKQ0KPiA+PiAgICAgICAgICAgICAgICAgICAgIHJl dHVybiAwOw0KPiA+PiArICAgICAgICAgIGVyciA9IDA7DQo+ID4+ICAgICB9DQo+ID4+IC0gIHJl dCA9IHB0aHJlYWRfbXV0ZXhfbG9jaygmc2gtPnR4cHAubXV0ZXgpOw0KPiA+PiAtICBNTFg1X0FT U0VSVCghcmV0KTsNCj4gPj4gLSAgUlRFX1NFVF9VU0VEKHJldCk7DQo+ID4+ICsgIGNsYWltX3pl cm8ocHRocmVhZF9tdXRleF9sb2NrKCZzaC0+dHhwcC5tdXRleCkpOw0KPiA+PiAgICAgaWYgKHNo LT50eHBwLnJlZmNudCkgew0KPiA+PiAgICAgICAgICAgICBwcml2LT50eHBwX2VuID0gMTsNCj4g Pj4gICAgICAgICAgICAgKytzaC0+dHhwcC5yZWZjbnQ7DQo+ID4+IEBAIC05MjQsOSArOTIzLDcg QEAgbWx4NV90eHBwX3N0YXJ0KHN0cnVjdCBydGVfZXRoX2RldiAqZGV2KQ0KPiA+PiAgICAgICAg ICAgICAgICAgICAgIHJ0ZV9lcnJubyA9IC1lcnI7DQo+ID4+ICAgICAgICAgICAgIH0NCj4gPj4g ICAgIH0NCj4gPj4gLSAgcmV0ID0gcHRocmVhZF9tdXRleF91bmxvY2soJnNoLT50eHBwLm11dGV4 KTsNCj4gPj4gLSAgTUxYNV9BU1NFUlQoIXJldCk7DQo+ID4+IC0gIFJURV9TRVRfVVNFRChyZXQp Ow0KPiA+PiArICBjbGFpbV96ZXJvKHB0aHJlYWRfbXV0ZXhfdW5sb2NrKCZzaC0+dHhwcC5tdXRl eCkpOw0KPiA+PiAgICAgcmV0dXJuIGVycjsNCj4gPj4gICB9DQo+ID4+DQo+ID4+IEBAIC05NDQs MjggKzk0MSwyMSBAQCBtbHg1X3R4cHBfc3RvcChzdHJ1Y3QgcnRlX2V0aF9kZXYgKmRldikgIHsN Cj4gPj4gICAgIHN0cnVjdCBtbHg1X3ByaXYgKnByaXYgPSBkZXYtPmRhdGEtPmRldl9wcml2YXRl Ow0KPiA+PiAgICAgc3RydWN0IG1seDVfZGV2X2N0eF9zaGFyZWQgKnNoID0gcHJpdi0+c2g7DQo+ ID4+IC0gIGludCByZXQ7DQo+ID4+DQo+ID4+ICAgICBpZiAoIXByaXYtPnR4cHBfZW4pIHsNCj4g Pj4gICAgICAgICAgICAgLyogUGFja2V0IHBhY2luZyBpcyBhbHJlYWR5IGRpc2FibGVkIGZvciB0 aGUgZGV2aWNlLiAqLw0KPiA+PiAgICAgICAgICAgICByZXR1cm47DQo+ID4+ICAgICB9DQo+ID4+ ICAgICBwcml2LT50eHBwX2VuID0gMDsNCj4gPj4gLSAgcmV0ID0gcHRocmVhZF9tdXRleF9sb2Nr KCZzaC0+dHhwcC5tdXRleCk7DQo+ID4+IC0gIE1MWDVfQVNTRVJUKCFyZXQpOw0KPiA+PiAtICBS VEVfU0VUX1VTRUQocmV0KTsNCj4gPj4gKyAgY2xhaW1femVybyhwdGhyZWFkX211dGV4X2xvY2so JnNoLT50eHBwLm11dGV4KSk7DQo+ID4+ICAgICBNTFg1X0FTU0VSVChzaC0+dHhwcC5yZWZjbnQp Ow0KPiA+PiAgICAgaWYgKCFzaC0+dHhwcC5yZWZjbnQgfHwgLS1zaC0+dHhwcC5yZWZjbnQpIHsN Cj4gPj4gLSAgICAgICAgICByZXQgPSBwdGhyZWFkX211dGV4X3VubG9jaygmc2gtPnR4cHAubXV0 ZXgpOw0KPiA+PiAtICAgICAgICAgIE1MWDVfQVNTRVJUKCFyZXQpOw0KPiA+PiAtICAgICAgICAg IFJURV9TRVRfVVNFRChyZXQpOw0KPiA+PiArICAgICAgICAgIGNsYWltX3plcm8ocHRocmVhZF9t dXRleF91bmxvY2soJnNoLT50eHBwLm11dGV4KSk7DQo+ID4+ICAgICAgICAgICAgIHJldHVybjsN Cj4gPj4gICAgIH0NCj4gPj4gICAgIC8qIE5vIHJlZmVyZW5jZXMgYW55IG1vcmUsIGRvIGFjdHVh bCBkZXN0cm95LiAqLw0KPiA+PiAgICAgbWx4NV90eHBwX2Rlc3Ryb3koc2gpOw0KPiA+PiAtICBy ZXQgPSBwdGhyZWFkX211dGV4X3VubG9jaygmc2gtPnR4cHAubXV0ZXgpOw0KPiA+PiAtICBNTFg1 X0FTU0VSVCghcmV0KTsNCj4gPj4gLSAgUlRFX1NFVF9VU0VEKHJldCk7DQo+ID4+ICsgIGNsYWlt X3plcm8ocHRocmVhZF9tdXRleF91bmxvY2soJnNoLT50eHBwLm11dGV4KSk7DQo+ID4+ICAgfQ0K PiA+Pg0KPiA+PiAgIC8qDQo+ID4+IC0tDQo+ID4+IDIuMTguMQ0KPiA+DQoNCg== --_000_TYCP286MB1188356A3DC08BFCEABE0A828A949TYCP286MB1188JPNP_ Content-Type: text/html; charset="gb2312" Content-Transfer-Encoding: quoted-printable
No problem, I will send the new patch. 

But what about the commit message and title, should I use the previous one?
net/mlx5: fix mutex unlock in=
 txpp cleanup


=BB=F1=C8=A1 Outlook for iOS

=B7=A2=BC=FE=C8=CB: Slava O= vsiienko <viacheslavo@nvidia.com>
=B7=A2=CB=CD=CA=B1=BC=E4: Thursday, November 11, 2021 8:27:30 PM
=CA=D5=BC=FE=C8=CB: Ferruh Yigit <ferruh.yigit@intel.com>; dev= @dpdk.org <dev@dpdk.org>
=B3=AD=CB=CD: Raslan Darawsheh <rasland@nvidia.com>; Matan Azr= ad <matan@nvidia.com>; stable@dpdk.org <stable@dpdk.org>; YE Ch= engfeng <cyeaa@connect.ust.hk>
=D6=F7=CC=E2: RE: [PATCH] net/mlx5: remove redundant "set used&= quot;
 
Hi, Ferruh

> -----Original Message-----
> From: Ferruh Yigit <ferruh.yigit@intel.com>
> Sent: Thursday, November 11, 2021 14:08
> To: Slava Ovsiienko <viacheslavo@nvidia.com>; dev@dpdk.org
> Cc: Raslan Darawsheh <rasland@nvidia.com>; Matan Azrad
> <matan@nvidia.com>; stable@dpdk.org; Chengfeng Ye
> <cyeaa@connect.ust.hk>
> Subject: Re: [PATCH] net/mlx5: remove redundant "set used" >
> On 11/11/2021 8:59 AM, Slava Ovsiienko wrote:
> > Hi, Ferruh
> >
> > I've also inspected the mlx5 PMD code for RTE_SET_USED() for the<= br> > > similar issues related to the MLX5_ASSERT().
> >
> > The patch
> > https://apc01.safelinks.protection.outlook.com/?url=3Dhttp%3A%2F%2Fpatches.= dpdk.org%2Fproject%2Fdpdk%2Fpatch%2F20211111084751.26721-1-&amp;data=3D= 04%7C01%7Ccyeaa%40connect.ust.hk%7C87553a5cd43647db708008d9a50ea321%7C6c1d4= 15239d044ca88d9b8d6ddca0708%7C1%7C0%7C637722304566828185%7CUnknown%7CTWFpbG= Zsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C= 1000&amp;sdata=3DwoTMghsE0S7ckoo0AI01YbdWrJeLtbMCu4GeE8JDiUc%3D&amp= ;reserved=3D0
> viac
> > heslavo@nvidia.com/
> > should refine the few found ones.
> >
> > I do not mind about squashing with "net/mlx5: fix mutex unlo= ck in txpp
> cleanup"
> > After getting this code in Upstream will care about the version f= or LTS.
> >
>
> It will cause additional complexity for the LTS, since a small part of= the below
> fix will be originated from Chengfeng's change. To help LTS, what do y= ou think
> - First get your fix on top of current task
> - Have a new version from Chengfeng on top of latest head, with 'claim= _zero'
> usage?
Would be nice, I have no any objections.
Chengfeng, could you please, squash (or write by yourself) my proposed upda= tes
and send the next version of your patch with "claim_zero()"?

> So only your update need to be merged to LTS releases.
Yes, agree, it is even better than my proposal.

With best regards,
Slava

> >
> >> -----Original Message-----
> >> From: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
> >> Sent: Thursday, November 11, 2021 10:48
> >> To: dev@dpdk.org
> >> Cc: ferruh.yigit@intel.com; Raslan Darawsheh <rasland@nvid= ia.com>;
> >> Matan Azrad <matan@nvidia.com>; stable@dpdk.org
> >> Subject: [PATCH] net/mlx5: remove redundant "set used&qu= ot;
> >>
> >> The patch just refines the code and replaces the pairs of
> >> MLX5_ASSERT() and
> >> RTE_SET_USED() with equivalent claim_zero().
> >>
> >> Cc: stable@dpdk.org
> >>
> >> Signed-off-by: Viacheslav Ovsiienko <viacheslavo@nvidia.co= m>
> >> ---
> >>   drivers/net/mlx5/mlx5_txpp.c | 30 ++++++++++-----= ---------------
> >>   1 file changed, 10 insertions(+), 20 deletions(-)=
> >>
> >> diff --git a/drivers/net/mlx5/mlx5_txpp.c
> >> b/drivers/net/mlx5/mlx5_txpp.c index 73626f0e8f..af77e91e4c 1= 00644
> >> --- a/drivers/net/mlx5/mlx5_txpp.c
> >> +++ b/drivers/net/mlx5/mlx5_txpp.c
> >> @@ -890,7 +890,6 @@ mlx5_txpp_start(struct rte_eth_dev *dev)<= br> > >>     struct mlx5_priv *priv =3D dev->da= ta->dev_private;
> >>     struct mlx5_dev_ctx_shared *sh =3D pr= iv->sh;
> >>     int err =3D 0;
> >> -  int ret;
> >>
> >>     if (!priv->config.tx_pp) {
> >>          &n= bsp;  /* Packet pacing is not requested for the device. */ @@ -
> >> 903,14 +902,14 @@ mlx5_txpp_start(struct rte_eth_dev *dev) > >>          &n= bsp;  return 0;
> >>     }
> >>     if (priv->config.tx_pp > 0) { > >> -          ret = =3D rte_mbuf_dynflag_lookup
> >> -
> >>     (RTE_MBUF_DYNFLAG_TX_TIMESTAMP_NAME, = NULL);
> >> -          if (r= et < 0)
> >> +          err = =3D rte_mbuf_dynflag_lookup
> >> +          =         (RTE_MBUF_DYNFLAG_TX_TIMESTAMP_N= AME,
> >> NULL);
> >> +          /* No= flag registered means no service needed. */
> >> +          if (e= rr < 0)
> >>          &n= bsp;          return 0;
> >> +          err = =3D 0;
> >>     }
> >> -  ret =3D pthread_mutex_lock(&sh->txpp.mutex); > >> -  MLX5_ASSERT(!ret);
> >> -  RTE_SET_USED(ret);
> >> +  claim_zero(pthread_mutex_lock(&sh->txpp.mutex)= );
> >>     if (sh->txpp.refcnt) {
> >>          &n= bsp;  priv->txpp_en =3D 1;
> >>          &n= bsp;  ++sh->txpp.refcnt;
> >> @@ -924,9 +923,7 @@ mlx5_txpp_start(struct rte_eth_dev *dev)<= br> > >>          &n= bsp;          rte_errno =3D -e= rr;
> >>          &n= bsp;  }
> >>     }
> >> -  ret =3D pthread_mutex_unlock(&sh->txpp.mutex);=
> >> -  MLX5_ASSERT(!ret);
> >> -  RTE_SET_USED(ret);
> >> +  claim_zero(pthread_mutex_unlock(&sh->txpp.mute= x));
> >>     return err;
> >>   }
> >>
> >> @@ -944,28 +941,21 @@ mlx5_txpp_stop(struct rte_eth_dev *dev)=   {
> >>     struct mlx5_priv *priv =3D dev->da= ta->dev_private;
> >>     struct mlx5_dev_ctx_shared *sh =3D pr= iv->sh;
> >> -  int ret;
> >>
> >>     if (!priv->txpp_en) {
> >>          &n= bsp;  /* Packet pacing is already disabled for the device. */
> >>          &n= bsp;  return;
> >>     }
> >>     priv->txpp_en =3D 0;
> >> -  ret =3D pthread_mutex_lock(&sh->txpp.mutex); > >> -  MLX5_ASSERT(!ret);
> >> -  RTE_SET_USED(ret);
> >> +  claim_zero(pthread_mutex_lock(&sh->txpp.mutex)= );
> >>     MLX5_ASSERT(sh->txpp.refcnt);
> >>     if (!sh->txpp.refcnt || --sh->t= xpp.refcnt) {
> >> -          ret = =3D pthread_mutex_unlock(&sh->txpp.mutex);
> >> -          MLX5_= ASSERT(!ret);
> >> -          RTE_S= ET_USED(ret);
> >> +          claim= _zero(pthread_mutex_unlock(&sh->txpp.mutex));
> >>          &n= bsp;  return;
> >>     }
> >>     /* No references any more, do actual = destroy. */
> >>     mlx5_txpp_destroy(sh);
> >> -  ret =3D pthread_mutex_unlock(&sh->txpp.mutex);=
> >> -  MLX5_ASSERT(!ret);
> >> -  RTE_SET_USED(ret);
> >> +  claim_zero(pthread_mutex_unlock(&sh->txpp.mute= x));
> >>   }
> >>
> >>   /*
> >> --
> >> 2.18.1
> >

--_000_TYCP286MB1188356A3DC08BFCEABE0A828A949TYCP286MB1188JPNP_--