Re: [RFC 0/3] net/ntnic: prefix global symbols

[Serhii Iliushyk <sil-plv@napatech.com>]

[-- Attachment #1: Type: text/plain, Size: 1414 bytes --]

Great. I will add corresponding patch to the next patch series.

On 29.09.2025, 19:33, "Stephen Hemminger" <stephen@networkplumber.org> wrote:

On Mon, 29 Sep 2025 15:59:36 +0000
Serhii Iliushyk <sil-plv@napatech.com> wrote:

> Hi!
>
> The patch series looks good.
> Only one thought from my side is about consistency between prefixes for global symbols for variables and functions.
>
> For functions, we use the prefix "nthw_*"; however, the patch series uses the prefix "ntnic_" for global variables.
> Will it be better to keep the same prefix for functions and variables?
> If there is no strict rule, we may keep "ntnic_".
>
> On 26.09.2025, 19:25, "Stephen Hemminger" <stephen@networkplumber.org> wrote:
>
> The ntnic driver in next-net is not consitent in prefixing
> all global symbols.
>
> Stephen Hemminger (3):
>   net/ntnic: rename nt_log_ types
>   net/ntnic: rename hwlock
>   net/ntnic: make flow_lock local
>
>  drivers/net/ntnic/include/create_elements.h   |  2 --
>  .../ntnic/include/stream_binary_flow_api.h    |  2 +-
>  drivers/net/ntnic/ntlog/ntlog.h               | 16 +++++++-------
>  drivers/net/ntnic/ntnic_ethdev.c              | 22 +++++++++----------
>  drivers/net/ntnic/ntnic_filter/ntnic_filter.c | 10 ++++-----
>  5 files changed, 25 insertions(+), 27 deletions(-)
>
> --
> 2.47.3

Sure ntnic_ and nthw_ are both ok, you choose where needed.

[-- Attachment #2: Type: text/html, Size: 3742 bytes --]