From: Serhii Iliushyk <sil-plv@napatech.com>
To: Stephen Hemminger <stephen@networkplumber.org>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [RFC 0/3] net/ntnic: prefix global symbols
Date: Mon, 29 Sep 2025 15:59:36 +0000 [thread overview]
Message-ID: <VE1P190MB08308308E532B306FCBCAE3C801BA@VE1P190MB0830.EURP190.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <20250926162534.401577-1-stephen@networkplumber.org>
[-- Attachment #1: Type: text/plain, Size: 1069 bytes --]
Hi!
The patch series looks good.
Only one thought from my side is about consistency between prefixes for global symbols for variables and functions.
For functions, we use the prefix "nthw_*"; however, the patch series uses the prefix "ntnic_" for global variables.
Will it be better to keep the same prefix for functions and variables?
If there is no strict rule, we may keep "ntnic_".
On 26.09.2025, 19:25, "Stephen Hemminger" <stephen@networkplumber.org> wrote:
The ntnic driver in next-net is not consitent in prefixing
all global symbols.
Stephen Hemminger (3):
net/ntnic: rename nt_log_ types
net/ntnic: rename hwlock
net/ntnic: make flow_lock local
drivers/net/ntnic/include/create_elements.h | 2 --
.../ntnic/include/stream_binary_flow_api.h | 2 +-
drivers/net/ntnic/ntlog/ntlog.h | 16 +++++++-------
drivers/net/ntnic/ntnic_ethdev.c | 22 +++++++++----------
drivers/net/ntnic/ntnic_filter/ntnic_filter.c | 10 ++++-----
5 files changed, 25 insertions(+), 27 deletions(-)
--
2.47.3
[-- Attachment #2: Type: text/html, Size: 4290 bytes --]
next prev parent reply other threads:[~2025-09-29 15:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-26 16:24 Stephen Hemminger
2025-09-26 16:24 ` [RFC 1/3] net/ntnic: rename nt_log_ types Stephen Hemminger
2025-09-26 16:24 ` [RFC 2/3] net/ntnic: rename hwlock Stephen Hemminger
2025-09-26 16:24 ` [RFC 3/3] net/ntnic: make flow_lock local Stephen Hemminger
2025-09-29 15:59 ` Serhii Iliushyk [this message]
2025-09-29 16:33 ` [RFC 0/3] net/ntnic: prefix global symbols Stephen Hemminger
2025-09-30 11:48 ` Serhii Iliushyk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VE1P190MB08308308E532B306FCBCAE3C801BA@VE1P190MB0830.EURP190.PROD.OUTLOOK.COM \
--to=sil-plv@napatech.com \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).