From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 65236A00BE; Wed, 30 Oct 2019 06:46:47 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EDCDD1BEB5; Wed, 30 Oct 2019 06:46:46 +0100 (CET) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80058.outbound.protection.outlook.com [40.107.8.58]) by dpdk.org (Postfix) with ESMTP id 2AF7E2AB for ; Wed, 30 Oct 2019 06:46:46 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=E1It8uLjT2lKN9wScuZlcCccf7rLb5HJ5jG48eTzbm6XzWKH00hdNEsOcQ/Nn6JRsF1oixe9sCZMDXEM6KD4+kpudvV7xkIUgV2l2mOz0mrEdg8lQoY+adKMXRgTN6sDOcbdDfM7L6oe2tu11p3rVWK4nJy6gdptWYWTxs0EkBzUAradDFG3z638Zo6v3Xl/pjF7tfJa+bfN7/k4nOEbWWv03XBqJuQVGm5IumJVNXlg4Xnj6AoAHGVqZetf/3b3Ku2HoEnqlZK6/Gx0KvhdkqxqwoTC9gfwoqPEJWCfOKIxr8F4c1rPr0Ahn6dTfEXjjFLcKrYAZI9nLvtnjeZH8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xDkOZVkETSGdLNYf7pt4ubFG79ZcsrVDEYdCQVAw9FQ=; b=Ziu/eJaynYL3zgt6JSC2cq9gG1A6IhShUV5MSvEUo7v91+O7wlCNHLkBn7GAp24Y3mhVoez54ULsVv3TY/FpLAI/2dK5x+e/74qQruT72N+F7GWHEiblUiprETMqhoUhhkGk3ODhL7FXYK04Gorcup0qfRfXomsTjvIP6ap5Dof7ysQ3+B/YzuAvBAcB2uUCo6E0aaDyjms87fQZeUXMpQl/SfeeKD5N+LXp96ZsQS9wqlPmrpIT4+Tp97Nc0zF4d6oWtM6WVxGrvpvTbgbBwoEqxyEkWpDvNbSESbqHG28hy9DzP7xEAjfp8ulEoLq/zyNKCnsLC6+ZMkBMm41ZEg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xDkOZVkETSGdLNYf7pt4ubFG79ZcsrVDEYdCQVAw9FQ=; b=MXHDeTafx1V0Sl9BtQ75e5ToWvdE4uYkq14lkm2mvCXqFBEaUkyIxsFen33Sva0L7e/aCYcWzYNfe+lGXd+KgTmgdqa4I0k19miWUb/sBrw0Ayqb9TVTPgDJBm0kN1rgjDZpkudc3HkZcxyKXBBTuMld3ZOFJ54/kyDgVwoskjo= Received: from VE1PR04MB6365.eurprd04.prod.outlook.com (20.179.233.214) by VE1PR04MB6558.eurprd04.prod.outlook.com (20.179.232.159) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2387.22; Wed, 30 Oct 2019 05:46:45 +0000 Received: from VE1PR04MB6365.eurprd04.prod.outlook.com ([fe80::1d23:8775:5a22:ac42]) by VE1PR04MB6365.eurprd04.prod.outlook.com ([fe80::1d23:8775:5a22:ac42%7]) with mapi id 15.20.2387.027; Wed, 30 Oct 2019 05:46:45 +0000 From: Gagandeep Singh To: Thierry Herbelot , "dev@dpdk.org" CC: Thomas Monjalon Thread-Topic: [PATCH] drivers/net: only compile PFE and ENETC when DPAA was selected Thread-Index: AQHVjlkUojBd7YBtP06+KIj3FYOSO6dyrUiA Date: Wed, 30 Oct 2019 05:46:45 +0000 Message-ID: References: <20191029130151.29879-1-thierry.herbelot@6wind.com> In-Reply-To: <20191029130151.29879-1-thierry.herbelot@6wind.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=G.Singh@nxp.com; x-originating-ip: [92.121.36.197] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 9efd08a0-7d95-4346-56ec-08d75cfc8c80 x-ms-traffictypediagnostic: VE1PR04MB6558: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:983; x-forefront-prvs: 02065A9E77 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(39860400002)(376002)(366004)(396003)(346002)(136003)(13464003)(199004)(189003)(81166006)(14454004)(55016002)(8676002)(81156014)(8936002)(6436002)(53546011)(76116006)(4326008)(25786009)(66556008)(66476007)(64756008)(9686003)(6506007)(7696005)(102836004)(66946007)(229853002)(6246003)(186003)(66446008)(11346002)(446003)(66066001)(26005)(99286004)(2906002)(110136005)(52536014)(86362001)(3846002)(6116002)(7736002)(476003)(71200400001)(2501003)(5660300002)(76176011)(71190400001)(256004)(478600001)(316002)(33656002)(486006)(305945005)(74316002); DIR:OUT; SFP:1101; SCL:1; SRVR:VE1PR04MB6558; H:VE1PR04MB6365.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ZVohqX9OCSwXt3vXiH79pJ31QbWK1yrneFA9oFfkxt+DaEjpt68CKDfdj5Jv1XfbUkQ2ejPNHbV0advuc36sMsY2d3jASDJL+x/yC32n0RuZ8fej7bw6eUBPDHYkmVS/i9HQ4chxF4sPXowXPs+jTZv8HqVwBCU4piWPt1AMfPvJQupbwxm9IYUDwZ3ZjCk+glnltWM8E175VKmzGxtwTNoVPwa3DdDR2A+YVgCu7PMtqlBAFG3CBqd9piE7mln80EemMAtvuqQeJXxDhI+4VWXG7w5wOGq4+wipE9WRH2Vx2oG8UqP8KczTJk+WllrP7SbykiB1JFI9uWhEfJNgbHKs+SB/sVZyL6P9GJ/lXvKrDo2fTwc0gTzvS6Llj+ofhuInBkFLRx3lu3I2JbEo3X28XlO6OcNUJOh0tgIkHrBgH7J0pTV+OfgtccmbmC8S x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9efd08a0-7d95-4346-56ec-08d75cfc8c80 X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Oct 2019 05:46:45.4010 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: QETQEmBFlzo5t+FT36GACX2kPBvN4qYddLbkdfWWV7yT1JMFz0jQbMLtCDrUOSqp X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6558 Subject: Re: [dpdk-dev] [PATCH] drivers/net: only compile PFE and ENETC when DPAA was selected X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Thierry, > -----Original Message----- > From: Thierry Herbelot > Sent: Tuesday, October 29, 2019 6:32 PM > To: dev@dpdk.org > Cc: Thomas Monjalon ; Gagandeep Singh > > Subject: [PATCH] drivers/net: only compile PFE and ENETC when DPAA was > selected >=20 > PFE and ENETC depend on DPAA features. >=20 > Fixes: e56463ec47f0 ('net/enetc: enable dpaax library') > Fixes: 67fc3ff97c39 ('net/pfe: introduce basic functions') > Cc: Gagandeep Singh >=20 > Signed-off-by: Thierry Herbelot > --- > drivers/net/Makefile | 4 ++++ > mk/rte.app.mk | 4 ++++ > 2 files changed, 8 insertions(+) >=20 > diff --git a/drivers/net/Makefile b/drivers/net/Makefile > index cee30367a1c3..966133427276 100644 > --- a/drivers/net/Makefile > +++ b/drivers/net/Makefile > @@ -25,7 +25,9 @@ DIRS-$(CONFIG_RTE_LIBRTE_DPAA2_PMD) +=3D dpaa2 > endif > DIRS-$(CONFIG_RTE_LIBRTE_E1000_PMD) +=3D e1000 > DIRS-$(CONFIG_RTE_LIBRTE_ENA_PMD) +=3D ena > +ifeq ($(CONFIG_RTE_LIBRTE_DPAA_BUS),y) > DIRS-$(CONFIG_RTE_LIBRTE_ENETC_PMD) +=3D enetc > +endif > DIRS-$(CONFIG_RTE_LIBRTE_ENIC_PMD) +=3D enic > DIRS-$(CONFIG_RTE_LIBRTE_PMD_FAILSAFE) +=3D failsafe > DIRS-$(CONFIG_RTE_LIBRTE_FM10K_PMD) +=3D fm10k > @@ -50,7 +52,9 @@ DIRS-$(CONFIG_RTE_LIBRTE_PMD_NULL) +=3D null > DIRS-$(CONFIG_RTE_LIBRTE_OCTEONTX_PMD) +=3D octeontx > DIRS-$(CONFIG_RTE_LIBRTE_OCTEONTX2_PMD) +=3D octeontx2 > DIRS-$(CONFIG_RTE_LIBRTE_PMD_PCAP) +=3D pcap > +ifeq ($(CONFIG_RTE_LIBRTE_DPAA_BUS),y) > DIRS-$(CONFIG_RTE_LIBRTE_PFE_PMD) +=3D pfe > +endif > DIRS-$(CONFIG_RTE_LIBRTE_QEDE_PMD) +=3D qede > DIRS-$(CONFIG_RTE_LIBRTE_PMD_RING) +=3D ring > DIRS-$(CONFIG_RTE_LIBRTE_SFC_EFX_PMD) +=3D sfc > diff --git a/mk/rte.app.mk b/mk/rte.app.mk > index 1f5c74841fb3..e440dffd7575 100644 > --- a/mk/rte.app.mk > +++ b/mk/rte.app.mk > @@ -170,7 +170,9 @@ _LDLIBS-$(CONFIG_RTE_LIBRTE_DPAA2_PMD) +=3D - > lrte_pmd_dpaa2 > endif > _LDLIBS-$(CONFIG_RTE_LIBRTE_E1000_PMD) +=3D -lrte_pmd_e1000 > _LDLIBS-$(CONFIG_RTE_LIBRTE_ENA_PMD) +=3D -lrte_pmd_ena > +ifeq ($(CONFIG_RTE_LIBRTE_DPAA_BUS),y) > _LDLIBS-$(CONFIG_RTE_LIBRTE_ENETC_PMD) +=3D -lrte_pmd_enetc > +endif > _LDLIBS-$(CONFIG_RTE_LIBRTE_ENIC_PMD) +=3D -lrte_pmd_enic > _LDLIBS-$(CONFIG_RTE_LIBRTE_FM10K_PMD) +=3D -lrte_pmd_fm10k > _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_FAILSAFE) +=3D -lrte_pmd_failsafe > @@ -204,7 +206,9 @@ _LDLIBS-$(CONFIG_RTE_LIBRTE_NFP_PMD) +=3D - > lrte_pmd_nfp > _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_NULL) +=3D -lrte_pmd_null > _LDLIBS-$(CONFIG_RTE_LIBRTE_OCTEONTX2_PMD) +=3D -lrte_pmd_octeontx2 - > lm > _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_PCAP) +=3D -lrte_pmd_pcap -lpcap > +ifeq ($(CONFIG_RTE_LIBRTE_DPAA_BUS),y) > _LDLIBS-$(CONFIG_RTE_LIBRTE_PFE_PMD) +=3D -lrte_pmd_pfe > +endif > _LDLIBS-$(CONFIG_RTE_LIBRTE_QEDE_PMD) +=3D -lrte_pmd_qede > _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_RING) +=3D -lrte_pmd_ring > ifeq ($(CONFIG_RTE_LIBRTE_SCHED),y) > -- > 2.20.1 I didn't see any compilation issue on '19.11-rc1' tag and also these both P= MDs are independent of DPAA_BUS, so we cannot accept these changes, can you= please share your exact steps of compilation? Thanks, Gagan