From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E3850A00E6 for ; Thu, 8 Aug 2019 11:00:48 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B9F6D4C91; Thu, 8 Aug 2019 11:00:48 +0200 (CEST) Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-eopbgr140051.outbound.protection.outlook.com [40.107.14.51]) by dpdk.org (Postfix) with ESMTP id 3B993DE3 for ; Thu, 8 Aug 2019 11:00:47 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ww+UZBa2VrUBGu8ZBvwlcY2IdAOcZYVOjo5vpU1AY8WZG37COaW+44AveeNNtxEkAZl4WkPWPtYJX39DUsC21pfJqtd1P4n+/kxWzZtUrb2IvjquiBiYYq47cQ5Nxk+eHM+5dIcR5+k1LZY725jYw+LLWIIh3Kg4ZWTxFoc3/m5lHMhnHy9J/Od08HK8LMmGsnVfKfvcBCJC8AHSZvYnBEhwHJuk5ovyjJCsrfnHus7ko07xVo8SdUl30hn7A6Am71b0F/eZsJKN1p0QG2tYchMDuTwJgXhsigrDSPP9nE9nU3wQ86sC3envTvgkaV0XKjKWqTjKs9abNtk2p5vlUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QzTVMtl2UisyL1vuS8oV026J73rw8v3eiwS7B78lTS8=; b=ZTU9HiwOpCScBy1WN0G7orKMh8RAraYOUNCRYobywGrIhlO2RVONw2TRjJA4CLPZOSZhbFwh99qtYkSiZPIADZs1muh7mTeLvmUc/BA7P5G5QeGDfr0SOl39/Ezzpg42/39+tnxjpQv0Usc74PyPxZOxIveDkOjeEvbaFOELjKPSbK1ffodimApYMfW3U0cYCsu7BbOsPzwCX6Kwlk5GNWjKwx0kcRh143gYD05+aV4WwapjLdOmYj1nmGTpqd/fFoUxbnzso9X1xEYYkDRorCki15YpJFFCyY/hKprAI+3wTUkrZZYYMGF6Hbn/ay2Xghq6yZolCM25c6tKCxekcQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=nxp.com;dmarc=pass action=none header.from=nxp.com;dkim=pass header.d=nxp.com;arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QzTVMtl2UisyL1vuS8oV026J73rw8v3eiwS7B78lTS8=; b=gf+3K3CPWwF9GHlLCuXtmkiCprVITSWfA5PKF3mtD0byB4AnY7R6Wwu8RDDl3Nd4C1P7WvHrH4bo9zIgBEeAOXpJqc0NQdPMDZDmz7cFIOkLcY2F1TGOlV9Jil/Lmx8EjGD82itQYFlRe/yt1o1QpeOVgMQPCYc6pengCiPemQY= Received: from VE1PR04MB6365.eurprd04.prod.outlook.com (10.255.118.78) by VE1PR04MB6733.eurprd04.prod.outlook.com (20.179.233.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2136.20; Thu, 8 Aug 2019 09:00:46 +0000 Received: from VE1PR04MB6365.eurprd04.prod.outlook.com ([fe80::894b:8cbd:9b55:ddbb]) by VE1PR04MB6365.eurprd04.prod.outlook.com ([fe80::894b:8cbd:9b55:ddbb%7]) with mapi id 15.20.2157.015; Thu, 8 Aug 2019 09:00:46 +0000 From: Gagandeep Singh To: Thomas Monjalon , Hemant Agrawal CC: "dev@dpdk.org" , David Marchand , "Burakov, Anatoly" , Olivier Matz , Andrew Rybchenko , Nipun Gupta , "honnappa.nagarahalli@arm.com" , Steve Capper , "jerinj@marvell.com" , "bruce.richardson@intel.com" , "gavin.hu@arm.com" , "konstantin.ananyev@intel.com" , "drc@linux.vnet.ibm.com" Thread-Topic: [dpdk-dev] [PATCH] eal: change max hugepage sizes to 4 Thread-Index: AdVNxf6L0S1ckj3RT0SqYHW/leAqTQ== Date: Thu, 8 Aug 2019 09:00:46 +0000 Message-ID: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=G.Singh@nxp.com; x-originating-ip: [92.120.0.6] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 3918f9f2-2b2b-4e30-a312-08d71bdee6ae x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020); SRVR:VE1PR04MB6733; x-ms-traffictypediagnostic: VE1PR04MB6733: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-forefront-prvs: 012349AD1C x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(376002)(366004)(39860400002)(136003)(396003)(346002)(189003)(199004)(476003)(52536014)(4326008)(86362001)(71190400001)(6506007)(486006)(5660300002)(14454004)(7736002)(66446008)(76116006)(74316002)(66556008)(14444005)(305945005)(64756008)(256004)(66946007)(6246003)(71200400001)(55016002)(81166006)(99286004)(316002)(6116002)(3846002)(81156014)(33656002)(9686003)(66066001)(7416002)(8676002)(7696005)(66476007)(186003)(25786009)(229853002)(26005)(8936002)(6636002)(110136005)(478600001)(54906003)(102836004)(2906002)(53936002)(6436002); DIR:OUT; SFP:1101; SCL:1; SRVR:VE1PR04MB6733; H:VE1PR04MB6365.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: SUOkBkakHN43JSi197iKZIEONXw29raF5zxHotEpJEF/UR5A1hcWK2puY4i5MwtZB40dL8MscDiDzOY9c2AHqU+d/MNwCvfBRlfLczxMCfKHmjXvsP5e849f3uyS25sbCqXtfgjX+uHpKaA+TZ6T1qNfMxQoO8iNokJdRLwP5/DZApCqFXUJ5uDlQe+5meJJDbVRyKiNmDYOThdJouJkHBotSDIANXJWEPoRmy6yTOErPElie9YIzoYznBqN4hsOPvEpdGVGFQiejzMHUvzpPZMSL0+mxhneMkfIqJyrHAvwcDWgq/kMaSWcjqTUm1Cc1x/7CAQHS8goUtWCU62+YLe4nTgo0vRZmtUvnleYaCO5tJAS+DPsA0MH18xZSJqhBidfDv7qXPAptGofnS/QYo8X/ecZlji/1svxjzF4CEc= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3918f9f2-2b2b-4e30-a312-08d71bdee6ae X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Aug 2019 09:00:46.1719 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: dBr9Z0UCzaNIl1C39nltFu/bzRl+BPq6vfhVad3hg/qLh6uXJXxWivQmdWTPqJUd X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6733 Subject: Re: [dpdk-dev] [PATCH] eal: change max hugepage sizes to 4 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > >HI Thomas, > > > > > DPDK currently is supporting maximum 3 hugepage, sizes whereas > > > > > system can support more than this e.g. > > > > > 64K, 2M, 32M and 1G. > > > > > > > > You can mention ARM platform here, and that this issue starts with > > > > kernel 5.2 (and I would try to mention this in the title as well). > > > > This is better than an annotation that will be lost. > > > > > > > > > > > > > Having these four hugepage sizes available to use by DPDK, which = is > > > > > valid in case of '--in-memory' EAL option or using 4 separate mou= nt > > > > > points for each hugepage size; > > > > > hugepage_info_init() API reports an error. > > > > > > > > Can you describe what is the impact from a user point of view rathe= r > > > > than mentioning this internal function? > > > > > > Yes please, we need to understand how much it is critical. > > > Should we Cc stable@dpdk.org for backport? > > > Should it be merged at the last minute in 19.08? > > > > VPP usages in-memory option. So, VPP on ARM with kernel 5.2 wont' work > without this patch. >=20 > Do you want to send a v2 with a better explanation? >=20 > I would suggest to restrict the change to Arm only with an ifdef, > in order to limit the risk for this release. > We can think about a dynamic hugepage scan in the next release. >=20 Ok, I will send a v2 with better explanation and will also add an if check = to make this change for ARM specific only.