Re: [dpdk-dev] [PATCH 01/13] net/enetc: support physical addressing mode

Re: [dpdk-dev] [PATCH 01/13] net/enetc: support physical addressing mode

[Gagandeep Singh]

> -----Original Message-----
> From: Ferruh Yigit <ferruh.yigit@intel.com>
> Sent: Monday, April 8, 2019 6:47 PM
> To: Gagandeep Singh <G.Singh@nxp.com>; dev@dpdk.org
> Subject: [EXT] Re: [PATCH 01/13] net/enetc: support physical addressing mode
> 
> WARNING: This email was created outside of NXP. DO NOT CLICK links or
> attachments unless you recognize the sender and know the content is safe.
> 
> 
> 
> On 4/8/2019 12:22 PM, Gagandeep Singh wrote:
> > Support added for physical addressing mode and change driver flags to
> > don't care.
> >
> > Signed-off-by: Gagandeep Singh <g.singh@nxp.com>
> 
> Hi Gagandeep,
> 
> Since the patchset has been sent after RC1, I assume it is for 19.08. Can you
> please mark patch title as 19.08 to not confuse with current release?
> 
Hi Ferruh,

Yes, it was my mistake I was little late while pushing patches. Actually these patches are for 19.05 release.
If it not bother you, could you please merge these patches to 19.05? otherwise I'll mark title to 19.08.

Thanks,
Gagandeep Singh  

> Thanks,
> ferruh

Re: [dpdk-dev] [PATCH 01/13] net/enetc: support physical addressing mode

[Gagandeep Singh]

> -----Original Message-----
> From: Ferruh Yigit <ferruh.yigit@intel.com>
> Sent: Monday, April 8, 2019 6:47 PM
> To: Gagandeep Singh <G.Singh@nxp.com>; dev@dpdk.org
> Subject: [EXT] Re: [PATCH 01/13] net/enetc: support physical addressing mode
> 
> WARNING: This email was created outside of NXP. DO NOT CLICK links or
> attachments unless you recognize the sender and know the content is safe.
> 
> 
> 
> On 4/8/2019 12:22 PM, Gagandeep Singh wrote:
> > Support added for physical addressing mode and change driver flags to
> > don't care.
> >
> > Signed-off-by: Gagandeep Singh <g.singh@nxp.com>
> 
> Hi Gagandeep,
> 
> Since the patchset has been sent after RC1, I assume it is for 19.08. Can you
> please mark patch title as 19.08 to not confuse with current release?
> 
Hi Ferruh,

Yes, it was my mistake I was little late while pushing patches. Actually these patches are for 19.05 release.
If it not bother you, could you please merge these patches to 19.05? otherwise I'll mark title to 19.08.

Thanks,
Gagandeep Singh  

> Thanks,
> ferruh

Re: [dpdk-dev] [PATCH 01/13] net/enetc: support physical addressing mode

[Ferruh Yigit]

On 4/10/2019 12:12 PM, Gagandeep Singh wrote:
>> -----Original Message-----
>> From: Ferruh Yigit <ferruh.yigit@intel.com>
>> Sent: Monday, April 8, 2019 6:47 PM
>> To: Gagandeep Singh <G.Singh@nxp.com>; dev@dpdk.org
>> Subject: [EXT] Re: [PATCH 01/13] net/enetc: support physical addressing mode
>>
>> WARNING: This email was created outside of NXP. DO NOT CLICK links or
>> attachments unless you recognize the sender and know the content is safe.
>>
>>
>>
>> On 4/8/2019 12:22 PM, Gagandeep Singh wrote:
>>> Support added for physical addressing mode and change driver flags to
>>> don't care.
>>>
>>> Signed-off-by: Gagandeep Singh <g.singh@nxp.com>
>>
>> Hi Gagandeep,
>>
>> Since the patchset has been sent after RC1, I assume it is for 19.08. Can you
>> please mark patch title as 19.08 to not confuse with current release?
>>
> Hi Ferruh,
> 
> Yes, it was my mistake I was little late while pushing patches. Actually these patches are for 19.05 release.
> If it not bother you, could you please merge these patches to 19.05? otherwise I'll mark title to 19.08.

Got it, only there already patches on the backlog waiting from rc1 which sent
the patch on time, they will be the priority otherwise it will be unfair to
them, and I will work on this with best effort for 19.05.

Thanks,
ferruh

Re: [dpdk-dev] [PATCH 01/13] net/enetc: support physical addressing mode

[Ferruh Yigit]

On 4/10/2019 12:12 PM, Gagandeep Singh wrote:
>> -----Original Message-----
>> From: Ferruh Yigit <ferruh.yigit@intel.com>
>> Sent: Monday, April 8, 2019 6:47 PM
>> To: Gagandeep Singh <G.Singh@nxp.com>; dev@dpdk.org
>> Subject: [EXT] Re: [PATCH 01/13] net/enetc: support physical addressing mode
>>
>> WARNING: This email was created outside of NXP. DO NOT CLICK links or
>> attachments unless you recognize the sender and know the content is safe.
>>
>>
>>
>> On 4/8/2019 12:22 PM, Gagandeep Singh wrote:
>>> Support added for physical addressing mode and change driver flags to
>>> don't care.
>>>
>>> Signed-off-by: Gagandeep Singh <g.singh@nxp.com>
>>
>> Hi Gagandeep,
>>
>> Since the patchset has been sent after RC1, I assume it is for 19.08. Can you
>> please mark patch title as 19.08 to not confuse with current release?
>>
> Hi Ferruh,
> 
> Yes, it was my mistake I was little late while pushing patches. Actually these patches are for 19.05 release.
> If it not bother you, could you please merge these patches to 19.05? otherwise I'll mark title to 19.08.

Got it, only there already patches on the backlog waiting from rc1 which sent
the patch on time, they will be the priority otherwise it will be unfair to
them, and I will work on this with best effort for 19.05.

Thanks,
ferruh

Re: [dpdk-dev] [PATCH 01/13] net/enetc: support physical addressing mode

[Gagandeep Singh]

> 
> 
> On 4/10/2019 12:12 PM, Gagandeep Singh wrote:
> >> -----Original Message-----
> >> From: Ferruh Yigit <ferruh.yigit@intel.com>
> >> Sent: Monday, April 8, 2019 6:47 PM
> >> To: Gagandeep Singh <G.Singh@nxp.com>; dev@dpdk.org
> >> Subject: [EXT] Re: [PATCH 01/13] net/enetc: support physical addressing
> mode
> >>
> >> WARNING: This email was created outside of NXP. DO NOT CLICK links or
> >> attachments unless you recognize the sender and know the content is safe.
> >>
> >>
> >>
> >> On 4/8/2019 12:22 PM, Gagandeep Singh wrote:
> >>> Support added for physical addressing mode and change driver flags to
> >>> don't care.
> >>>
> >>> Signed-off-by: Gagandeep Singh <g.singh@nxp.com>
> >>
> >> Hi Gagandeep,
> >>
> >> Since the patchset has been sent after RC1, I assume it is for 19.08. Can you
> >> please mark patch title as 19.08 to not confuse with current release?
> >>
> > Hi Ferruh,
> >
> > Yes, it was my mistake I was little late while pushing patches. Actually these
> patches are for 19.05 release.
> > If it not bother you, could you please merge these patches to 19.05? otherwise
> I'll mark title to 19.08.
> 
> Got it, only there already patches on the backlog waiting from rc1 which sent
> the patch on time, they will be the priority otherwise it will be unfair to
> them, and I will work on this with best effort for 19.05.
> 
> Thanks,
> Ferruh

I understand, Thank you very much.

Thanks,
Gagan

Re: [dpdk-dev] [PATCH 01/13] net/enetc: support physical addressing mode

[Gagandeep Singh]

> 
> 
> On 4/10/2019 12:12 PM, Gagandeep Singh wrote:
> >> -----Original Message-----
> >> From: Ferruh Yigit <ferruh.yigit@intel.com>
> >> Sent: Monday, April 8, 2019 6:47 PM
> >> To: Gagandeep Singh <G.Singh@nxp.com>; dev@dpdk.org
> >> Subject: [EXT] Re: [PATCH 01/13] net/enetc: support physical addressing
> mode
> >>
> >> WARNING: This email was created outside of NXP. DO NOT CLICK links or
> >> attachments unless you recognize the sender and know the content is safe.
> >>
> >>
> >>
> >> On 4/8/2019 12:22 PM, Gagandeep Singh wrote:
> >>> Support added for physical addressing mode and change driver flags to
> >>> don't care.
> >>>
> >>> Signed-off-by: Gagandeep Singh <g.singh@nxp.com>
> >>
> >> Hi Gagandeep,
> >>
> >> Since the patchset has been sent after RC1, I assume it is for 19.08. Can you
> >> please mark patch title as 19.08 to not confuse with current release?
> >>
> > Hi Ferruh,
> >
> > Yes, it was my mistake I was little late while pushing patches. Actually these
> patches are for 19.05 release.
> > If it not bother you, could you please merge these patches to 19.05? otherwise
> I'll mark title to 19.08.
> 
> Got it, only there already patches on the backlog waiting from rc1 which sent
> the patch on time, they will be the priority otherwise it will be unfair to
> them, and I will work on this with best effort for 19.05.
> 
> Thanks,
> Ferruh

I understand, Thank you very much.

Thanks,
Gagan

[dpdk-dev] [PATCH 00/13] ENETC PMD basic features and bug fixes

[Gagandeep Singh]

* support added for MTU, jumbo frame, queue start/stop, promiscuous,
  multicast, crc offload, RX checksum validation and basic stats
* some bug fixes

Gagandeep Singh (13):
  net/enetc: support physical addressing mode
  net/enetc: fix SMMU unhandled context fault
  net/enetc: use correct buffer allocation API
  net/enetc: set interface mode for SXGMII
  net/enetc: add statistics APIs
  net/enetc: replace register read/write macros with functions
  net/enetc: remove forward declarations
  net/enetc: enable promiscuous and allmulticast feature
  net/enetc: add MTU update and jumbo frames support
  net/enetc: enable Rx-Tx queue start/stop feature
  net/enetc: enable CRC offload feature
  net/enetc: enable Rx checksum offload validation
  net/enetc: fix crash at high speed traffic

 doc/guides/nics/enetc.rst          |   7 +
 doc/guides/nics/features/enetc.ini |   9 +
 drivers/net/enetc/base/enetc_hw.h  |  53 ++-
 drivers/net/enetc/enetc.h          |  13 +-
 drivers/net/enetc/enetc_ethdev.c   | 739 +++++++++++++++++++++++++------------
 drivers/net/enetc/enetc_rxtx.c     | 128 ++++++-
 6 files changed, 685 insertions(+), 264 deletions(-)

-- 
1.9.1

[dpdk-dev] [PATCH 01/13] net/enetc: support physical addressing mode

[Gagandeep Singh]

Support added for physical addressing mode and
change driver flags to don't care.

Signed-off-by: Gagandeep Singh <g.singh@nxp.com>
---
 drivers/net/enetc/enetc_ethdev.c | 22 ++++++++++++----------
 drivers/net/enetc/enetc_rxtx.c   |  6 +++---
 2 files changed, 15 insertions(+), 13 deletions(-)

diff --git a/drivers/net/enetc/enetc_ethdev.c b/drivers/net/enetc/enetc_ethdev.c
index 023fe75..7a9a97d 100644
--- a/drivers/net/enetc/enetc_ethdev.c
+++ b/drivers/net/enetc/enetc_ethdev.c
@@ -1,5 +1,5 @@
 /* SPDX-License-Identifier: BSD-3-Clause
- * Copyright 2018 NXP
+ * Copyright 2018-2019 NXP
  */
 
 #include <stdbool.h>
@@ -334,14 +334,15 @@ static int enetc_tx_queue_setup(struct rte_eth_dev *dev, uint16_t tx_queue_id,
 enetc_setup_txbdr(struct enetc_hw *hw, struct enetc_bdr *tx_ring)
 {
 	int idx = tx_ring->index;
-	uintptr_t base_addr;
 	uint32_t tbmr;
+	phys_addr_t bd_address;
 
-	base_addr = (uintptr_t)tx_ring->bd_base;
+	bd_address = (phys_addr_t)
+		     rte_mem_virt2iova((const void *)tx_ring->bd_base);
 	enetc_txbdr_wr(hw, idx, ENETC_TBBAR0,
-		       lower_32_bits((uint64_t)base_addr));
+		       lower_32_bits((uint64_t)bd_address));
 	enetc_txbdr_wr(hw, idx, ENETC_TBBAR1,
-		       upper_32_bits((uint64_t)base_addr));
+		       upper_32_bits((uint64_t)bd_address));
 	enetc_txbdr_wr(hw, idx, ENETC_TBLENR,
 		       ENETC_RTBLENR_LEN(tx_ring->bd_count));
 
@@ -478,14 +479,15 @@ static int enetc_tx_queue_setup(struct rte_eth_dev *dev, uint16_t tx_queue_id,
 		  struct rte_mempool *mb_pool)
 {
 	int idx = rx_ring->index;
-	uintptr_t base_addr;
 	uint16_t buf_size;
+	phys_addr_t bd_address;
 
-	base_addr = (uintptr_t)rx_ring->bd_base;
+	bd_address = (phys_addr_t)
+		     rte_mem_virt2iova((const void *)rx_ring->bd_base);
 	enetc_rxbdr_wr(hw, idx, ENETC_RBBAR0,
-		       lower_32_bits((uint64_t)base_addr));
+		       lower_32_bits((uint64_t)bd_address));
 	enetc_rxbdr_wr(hw, idx, ENETC_RBBAR1,
-		       upper_32_bits((uint64_t)base_addr));
+		       upper_32_bits((uint64_t)bd_address));
 	enetc_rxbdr_wr(hw, idx, ENETC_RBLENR,
 		       ENETC_RTBLENR_LEN(rx_ring->bd_count));
 
@@ -612,7 +614,7 @@ static int enetc_tx_queue_setup(struct rte_eth_dev *dev, uint16_t tx_queue_id,
 
 static struct rte_pci_driver rte_enetc_pmd = {
 	.id_table = pci_id_enetc_map,
-	.drv_flags = RTE_PCI_DRV_NEED_MAPPING | RTE_PCI_DRV_IOVA_AS_VA,
+	.drv_flags = RTE_PCI_DRV_NEED_MAPPING,
 	.probe = enetc_pci_probe,
 	.remove = enetc_pci_remove,
 };
diff --git a/drivers/net/enetc/enetc_rxtx.c b/drivers/net/enetc/enetc_rxtx.c
index 631e243..a31a387 100644
--- a/drivers/net/enetc/enetc_rxtx.c
+++ b/drivers/net/enetc/enetc_rxtx.c
@@ -1,5 +1,5 @@
 /* SPDX-License-Identifier: BSD-3-Clause
- * Copyright 2018 NXP
+ * Copyright 2018-2019 NXP
  */
 
 #include <stdbool.h>
@@ -64,7 +64,7 @@
 		txbd->buf_len = txbd->frm_len;
 		txbd->flags = rte_cpu_to_le_16(ENETC_TXBD_FLAGS_F);
 		txbd->addr = (uint64_t)(uintptr_t)
-		rte_cpu_to_le_64((size_t)tx_swbd->buffer_addr->buf_addr +
+		rte_cpu_to_le_64((size_t)tx_swbd->buffer_addr->buf_iova +
 				 tx_swbd->buffer_addr->data_off);
 		i++;
 		start++;
@@ -91,7 +91,7 @@
 		rx_swbd->buffer_addr =
 			rte_cpu_to_le_64(rte_mbuf_raw_alloc(rx_ring->mb_pool));
 		rxbd->w.addr = (uint64_t)(uintptr_t)
-			       rx_swbd->buffer_addr->buf_addr +
+			       rx_swbd->buffer_addr->buf_iova +
 			       rx_swbd->buffer_addr->data_off;
 		/* clear 'R" as well */
 		rxbd->r.lstatus = 0;
-- 
1.9.1

[dpdk-dev] [PATCH 01/13] net/enetc: support physical addressing mode

[Gagandeep Singh]

Support added for physical addressing mode and
change driver flags to don't care.

Signed-off-by: Gagandeep Singh <g.singh@nxp.com>
---
 drivers/net/enetc/enetc_ethdev.c | 22 ++++++++++++----------
 drivers/net/enetc/enetc_rxtx.c   |  6 +++---
 2 files changed, 15 insertions(+), 13 deletions(-)

diff --git a/drivers/net/enetc/enetc_ethdev.c b/drivers/net/enetc/enetc_ethdev.c
index 023fe75..7a9a97d 100644
--- a/drivers/net/enetc/enetc_ethdev.c
+++ b/drivers/net/enetc/enetc_ethdev.c
@@ -1,5 +1,5 @@
 /* SPDX-License-Identifier: BSD-3-Clause
- * Copyright 2018 NXP
+ * Copyright 2018-2019 NXP
  */
 
 #include <stdbool.h>
@@ -334,14 +334,15 @@ static int enetc_tx_queue_setup(struct rte_eth_dev *dev, uint16_t tx_queue_id,
 enetc_setup_txbdr(struct enetc_hw *hw, struct enetc_bdr *tx_ring)
 {
 	int idx = tx_ring->index;
-	uintptr_t base_addr;
 	uint32_t tbmr;
+	phys_addr_t bd_address;
 
-	base_addr = (uintptr_t)tx_ring->bd_base;
+	bd_address = (phys_addr_t)
+		     rte_mem_virt2iova((const void *)tx_ring->bd_base);
 	enetc_txbdr_wr(hw, idx, ENETC_TBBAR0,
-		       lower_32_bits((uint64_t)base_addr));
+		       lower_32_bits((uint64_t)bd_address));
 	enetc_txbdr_wr(hw, idx, ENETC_TBBAR1,
-		       upper_32_bits((uint64_t)base_addr));
+		       upper_32_bits((uint64_t)bd_address));
 	enetc_txbdr_wr(hw, idx, ENETC_TBLENR,
 		       ENETC_RTBLENR_LEN(tx_ring->bd_count));
 
@@ -478,14 +479,15 @@ static int enetc_tx_queue_setup(struct rte_eth_dev *dev, uint16_t tx_queue_id,
 		  struct rte_mempool *mb_pool)
 {
 	int idx = rx_ring->index;
-	uintptr_t base_addr;
 	uint16_t buf_size;
+	phys_addr_t bd_address;
 
-	base_addr = (uintptr_t)rx_ring->bd_base;
+	bd_address = (phys_addr_t)
+		     rte_mem_virt2iova((const void *)rx_ring->bd_base);
 	enetc_rxbdr_wr(hw, idx, ENETC_RBBAR0,
-		       lower_32_bits((uint64_t)base_addr));
+		       lower_32_bits((uint64_t)bd_address));
 	enetc_rxbdr_wr(hw, idx, ENETC_RBBAR1,
-		       upper_32_bits((uint64_t)base_addr));
+		       upper_32_bits((uint64_t)bd_address));
 	enetc_rxbdr_wr(hw, idx, ENETC_RBLENR,
 		       ENETC_RTBLENR_LEN(rx_ring->bd_count));
 
@@ -612,7 +614,7 @@ static int enetc_tx_queue_setup(struct rte_eth_dev *dev, uint16_t tx_queue_id,
 
 static struct rte_pci_driver rte_enetc_pmd = {
 	.id_table = pci_id_enetc_map,
-	.drv_flags = RTE_PCI_DRV_NEED_MAPPING | RTE_PCI_DRV_IOVA_AS_VA,
+	.drv_flags = RTE_PCI_DRV_NEED_MAPPING,
 	.probe = enetc_pci_probe,
 	.remove = enetc_pci_remove,
 };
diff --git a/drivers/net/enetc/enetc_rxtx.c b/drivers/net/enetc/enetc_rxtx.c
index 631e243..a31a387 100644
--- a/drivers/net/enetc/enetc_rxtx.c
+++ b/drivers/net/enetc/enetc_rxtx.c
@@ -1,5 +1,5 @@
 /* SPDX-License-Identifier: BSD-3-Clause
- * Copyright 2018 NXP
+ * Copyright 2018-2019 NXP
  */
 
 #include <stdbool.h>
@@ -64,7 +64,7 @@
 		txbd->buf_len = txbd->frm_len;
 		txbd->flags = rte_cpu_to_le_16(ENETC_TXBD_FLAGS_F);
 		txbd->addr = (uint64_t)(uintptr_t)
-		rte_cpu_to_le_64((size_t)tx_swbd->buffer_addr->buf_addr +
+		rte_cpu_to_le_64((size_t)tx_swbd->buffer_addr->buf_iova +
 				 tx_swbd->buffer_addr->data_off);
 		i++;
 		start++;
@@ -91,7 +91,7 @@
 		rx_swbd->buffer_addr =
 			rte_cpu_to_le_64(rte_mbuf_raw_alloc(rx_ring->mb_pool));
 		rxbd->w.addr = (uint64_t)(uintptr_t)
-			       rx_swbd->buffer_addr->buf_addr +
+			       rx_swbd->buffer_addr->buf_iova +
 			       rx_swbd->buffer_addr->data_off;
 		/* clear 'R" as well */
 		rxbd->r.lstatus = 0;
-- 
1.9.1

Re: [dpdk-dev] [PATCH 01/13] net/enetc: support physical addressing mode

[Ferruh Yigit]

On 4/8/2019 12:22 PM, Gagandeep Singh wrote:
> Support added for physical addressing mode and
> change driver flags to don't care.
> 
> Signed-off-by: Gagandeep Singh <g.singh@nxp.com>

Hi Gagandeep,

Since the patchset has been sent after RC1, I assume it is for 19.08. Can you
please mark patch title as 19.08 to not confuse with current release?

Thanks,
ferruh

Re: [dpdk-dev] [PATCH 01/13] net/enetc: support physical addressing mode

[Ferruh Yigit]

On 4/8/2019 12:22 PM, Gagandeep Singh wrote:
> Support added for physical addressing mode and
> change driver flags to don't care.
> 
> Signed-off-by: Gagandeep Singh <g.singh@nxp.com>

Hi Gagandeep,

Since the patchset has been sent after RC1, I assume it is for 19.08. Can you
please mark patch title as 19.08 to not confuse with current release?

Thanks,
ferruh