Re: [dpdk-dev] [PATCH v3 02/14] net/ppfe: introduce ppfe net poll mode driver

[Gagandeep Singh <G.Singh@nxp.com>]

> <...>
> 
> > @@ -0,0 +1,28 @@
> > +# SPDX-License-Identifier: BSD-3-Clause
> > +# Copyright 2019 NXP
> > +#
> > +
> > +include $(RTE_SDK)/mk/rte.vars.mk
> > +
> > +#
> > +# library name
> > +#
> > +LIB = librte_pmd_ppfe.a
> > +
> > +CFLAGS += -O3 $(WERROR_FLAGS)
> > +CFLAGS += -I$(RTE_SDK)/drivers/bus/dpaa/include/
> 
> This driver is a virtual driver and using something like 'cbus', btw, out of
> curiosity would you mind giving some detail what cbus is?
cbus (crate bus) is a NXP PFE IP internal bus. To access other
IPs (mac, hif, bmu etc.) registers, we use base address of cbus and then
we use HIF (host interface) to create virtual interfaces, which then used
by the driver.

> 
> In that case why need to include 'bus/dpaa' files? Is this PMD depends on 'dpaa'
> bus? Or should some 'bus/dpaa' files indeed be in the 'common/dpaax'?
PFE driver shouldn't be dependent on dpaa bus. There are some common functions and macros
defined  in dpaa/compat.h and pfe driver is dependent on it.
I will remove the dependency on dpaa bus and move the compat.h to common/dpaax.