From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3481DA0C43; Tue, 16 Nov 2021 07:08:19 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 124314068C; Tue, 16 Nov 2021 07:08:19 +0100 (CET) Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2057.outbound.protection.outlook.com [40.107.22.57]) by mails.dpdk.org (Postfix) with ESMTP id AA49240040 for ; Tue, 16 Nov 2021 07:08:17 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FmkwD1xGY/M5oLBSEs3N+mNFpOapVIzH7R8P3RUZwrD7fsXWA+zToVafjysdJSoXZuRobHIr6joEsdmsqRn44Uu9AnhXeHRcOsRpJBkjgVES9fXDLtGG4ghxEx1DDbloPZrjE3yP5zx9nTGTCb15+UYPTYcmFSDBkSVKMGEKB1CKXfa8Sig+ucZL4LyuwyL1yQBz4/Za266s4x76jr9OclNldc2zZxBXzStIBXeeQHT9ZquynIxhUNWKb7d5tgUJgEswZhkz2jUZY0WSochZfpS58dD2FIwNFIQSoB795qV7FxbFsaeDIbiI6nRqZvRt9dIy2Gx0fBjmOsov5xWBHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zeg8aqAK1K0zAiKBH2Su7lgBUtpfincv1NgU6hBrey0=; b=T2ts0Vb6nXiGo3/+3xiq6RqV9oC0z7A08vYL14Wc2TTPTVxRu7n+C+aApXottw7Xu99Eggpw4tORgi8UBFNuQABtzCZQD/kezCusfqaaDDWGh+KmgkpNmu8GV/rp5hopKcADjJLp7msodmZjuVrEcxVFk5o/MqHYkY69mpaD5dveBVMh7aBn+DMoSDOZC3TyYJTVUEvmvtUp/zCMVdQOko65tzznKKBA1MQy64tuvdC4DjeFD8Q32JPR6daX1z/m6xxl0YCtj3+uTVJCi4Y60AoHv+CLgKJkRPGf9NsQDSCdsg0KC0c4ZAyRUP38rdpLwdZblnu+hB407vJE3GeCFQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zeg8aqAK1K0zAiKBH2Su7lgBUtpfincv1NgU6hBrey0=; b=sWYlSnioNhnmsc/W17h2hQEma7ktQ187Xj38Dre+jzTs7/uvJpD4Nv+z2p8U9XlhzjW4lgrsC1iJnwuSsawlZAUjss2ONtViNFRdtEorKyF2y8iqvWlliCkNiiNi7cug3J66ytxIdmen8OIlVL74RxXtaeT5mxdADVb4tH3iRZc= Received: from VE1PR04MB6509.eurprd04.prod.outlook.com (2603:10a6:803:125::11) by VI1PR0401MB2688.eurprd04.prod.outlook.com (2603:10a6:800:59::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4690.27; Tue, 16 Nov 2021 06:08:16 +0000 Received: from VE1PR04MB6509.eurprd04.prod.outlook.com ([fe80::30e0:bf32:c5a2:aebe]) by VE1PR04MB6509.eurprd04.prod.outlook.com ([fe80::30e0:bf32:c5a2:aebe%6]) with mapi id 15.20.4690.027; Tue, 16 Nov 2021 06:08:16 +0000 From: Rohit Raj To: "Ananyev, Konstantin" , "dev@dpdk.org" , "Yigit, Ferruh" CC: Nipun Gupta , Sachin Saxena , Vanshika Shukla Subject: RE: [EXT] RE: [PATCH v2] examples/l3fwd: fix jumbo packet drop issue Thread-Topic: [EXT] RE: [PATCH v2] examples/l3fwd: fix jumbo packet drop issue Thread-Index: AQHX13O6AFDZAfV8WUKdS6JM4h8hG6v/o9GAgAYNpIA= Date: Tue, 16 Nov 2021 06:08:16 +0000 Message-ID: References: <20210727092523.22718-1-rohit.raj@nxp.com> <20211112031635.11400-1-rohit.raj@nxp.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 50e34dab-182d-4922-5d12-08d9a8c77af6 x-ms-traffictypediagnostic: VI1PR0401MB2688: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4303; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: oD+wq9xlP2BHhCd8B0EnqJv19vUa/B2vOPt3ho31/IbDaXmTrX3LBZ9QjqIDS0+jSbRjBFHLuQx3uZTy2KvGUXCqe2zXHanyoQTN7UqrdWEh2gmHLlbxdqnxQ4G4GBoxXR6Lox1W5Ul1Xt6MPY4DHTFjRMhiCwF9RqSL5yYx/hSHQ9bgtNNDMwimh+EwABPh0zxNetCchuQMf9D9Zg4U0OMLS73Fl00dFOv8ozNrlc7wTjHJzzNFvs2/PlKo6bMWe2STZnN6pIYDLEZoAP3uZnJlcCbX/h6vPYvmhtuHs7ejn+X5ozp4L3H73zrFmnLKHUUdoehtXo+OyARRfzAW1uAjXNlsPMbgkK4xQqBU85Hm5ZSCQJqNe2z/IhIThlBrOJ+3v3jTaH35AzMRuIOMJFWbTkwQZdMzgt4U9QwZC+gtt1rhonAA0ygWT/BtES/4+ERDMQ2joO0ra4SAsowfWA8Dr/VMzEqbNnosqFqtL/GZWiaTOAUAKXLjH2YIjDZlV/befpGDeM+26GZY47chKHJhjJ7PYbQU7zxR3Wu/XQ+k1jJ1cFfTlF5wJG+4wg3eErYdhBGEQp1V3j1WLXoXzJ7dbilqSWQFSAfv+RfmSCGJugnuLP+VK5BPVxpCnYUblc3vR829PWEE6veVAUom7onZgnZUVPoN7T6K4GFCBKpv7uqx07eYZ/JjV+FdcvjK059fcvblbvNTyDpBUXCq8w== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VE1PR04MB6509.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(6506007)(122000001)(86362001)(55016002)(2906002)(53546011)(83380400001)(71200400001)(4326008)(7696005)(38070700005)(26005)(316002)(38100700002)(66446008)(66946007)(66476007)(66556008)(186003)(54906003)(110136005)(64756008)(76116006)(8936002)(5660300002)(8676002)(9686003)(33656002)(44832011)(52536014)(508600001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?r41MrlLuJFLXF8CM01kLcrrg8dC4JWDnTNdgmonfoBXxCNPp73pdUg3XFEre?= =?us-ascii?Q?xkMfXpTM/B7Y1tJYxwoZmPjz+thSZ8LLCYnACNDAIvuY2qybYo+xYYgJnDsF?= =?us-ascii?Q?VKXOKYekNQddhQGNUCR737+qVWOFa8PkL2WI8+H+kg9mo4fKcWm0lzJF9Jcr?= =?us-ascii?Q?vMQrjGeCQYS5/GknbOYrD5ok6GEtHUcHLKwQkzySdhYUWGxJCZrEz7dH9Tlj?= =?us-ascii?Q?2LaKNUYlcxRDqA4MJ+rsE2WELiVJNrQ8DIx1qoPL2ut1u/r/91IqBS9B0y3z?= =?us-ascii?Q?wH5WdCwYL0bkasZ5zh80nblOLZRaDBuzzXZ0FVgyHOnzZMrfRXgO8Ll5wHTb?= =?us-ascii?Q?kRgGZr7fNjatTagXSdfZif2RZJvM63arQBQcy47fNTNS4pgSd6UQW0BWED0v?= =?us-ascii?Q?5ID3MzNo4w9N1/Y7hJoyjxOpqbkkzcX9LUlB0CgQuYsejzjo8xaO/Bkehayn?= =?us-ascii?Q?cl7jvZH4EbfcttY/nmra3VKjPjes9WE4oqLeJArKaEFaZpqMczZlja7FyAW7?= =?us-ascii?Q?jJkLIugHlrxwnPZyHNibp5n3WAdW6JO3e38EpooxPltOAT5pO13FpY6QUnEG?= =?us-ascii?Q?wrvY24LRgbB6XHGzZC287OIhuMWg8EOw+HVI9lu5KWEqQ/u3LkLi+oqyMUlA?= =?us-ascii?Q?LreamLhFPxLCvJiDxrjRuYmyPfdAxnnNVhZ2lb2z/KXHlmesuucfe95kb+4J?= =?us-ascii?Q?rDi1DsKzdAV+yZRHZ6Ev1i5ixhqH0/ASxEYls0GqfVMu1leDgr7/l4lWedt0?= =?us-ascii?Q?HeMLwBijtUusZ8SWKxbCzeZcLQFanD8aegQ36aG+J49SVMZt2R3lqHWTy1c8?= =?us-ascii?Q?6f1KnJCJYsNH9sYpDF6sL9wjN4ZChH247esjovMvF7yD96Sr+noaPEcbSfqL?= =?us-ascii?Q?s+5I9bN5CENsreogj0t75At+l+5kEUYxvd5AyQmOjaVHEdXYplwuxkMNiCUn?= =?us-ascii?Q?YET8LvvUV4TYH2KuI+lOE4K8hZCFGfUQK8zjjbREJOPxnWHqFTtUkWBFihbm?= =?us-ascii?Q?BgAWUYN9gaQDxQQTNXKE/pRsIybeB5H7T888XUI84YdpCXpS9L0kTb0xef4g?= =?us-ascii?Q?vu08iiPwUeevsZtaZnpK2FLn4DnUZaaoCwS97BEQ/uGTeZgH59ffXVnSZBGG?= =?us-ascii?Q?1kB3UjRRjQeHm/XNrAcXHRqlU/OogUW/kZZmvVgEMiuN59h6yDfVRXurpfce?= =?us-ascii?Q?IAEs4XAPQoeiGQHbVUfYtIDS6D55ZxCCg7uOBKDI2u6RfyxSIMxUTulvlOXn?= =?us-ascii?Q?CulWGDgjbVk7FYAJ6roLvGFQgMkxee22wwxH4ZsTl22iWczzIqvzgzptLUK0?= =?us-ascii?Q?Eb60pD7l1wTuzuUcnI+Om7SyP6uM1sPRlWwnlodSOTwuuB/yflQaNHVVcK3M?= =?us-ascii?Q?9lYkk8TsYyFszZ7EGidO17WjSLisyfNQQ7fxjpycUyuk4kXZTO5d+/vdPt62?= =?us-ascii?Q?LHEJTnjxmeJkLekfEaR7f9hb3rqnZnkBztGA7neZEjpzAFba6KhLQmV3WqSP?= =?us-ascii?Q?X0m+71N/kOwhqefKNfeQ4zJh4xuI+/nmEvXU6kern7BAL0ZnlNdjssNww9bM?= =?us-ascii?Q?3bMxFaw/Frw/lRuRN9QaV7oBkveilFyRTMnni2RzG5tLKO9airVH0Ydig9Ow?= =?us-ascii?Q?q9s1PoTPCtml86wXvGkXZk0=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6509.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 50e34dab-182d-4922-5d12-08d9a8c77af6 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Nov 2021 06:08:16.2961 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: M1oFX+RilOJk4lCYnWupkOAN4p2UsJaJn3v0RLdygvPpRYC+ceTrTlhbbmBy6tJMQ7pjP9uKbhiPwxbe7ZD4AA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2688 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Ananyev, Konstantin > Sent: Friday, November 12, 2021 3:11 PM > To: Rohit Raj ; dev@dpdk.org; Yigit, Ferruh > > Cc: Nipun Gupta ; Sachin Saxena > ; Vanshika Shukla > Subject: [EXT] RE: [PATCH v2] examples/l3fwd: fix jumbo packet drop issue >=20 > Caution: EXT Email >=20 > > From: Rohit Raj > > > > l3fwd uses mbufs with 2KB data size. If we enable jumbo packets, it is > > not able to store packets with size greater than 2KB, hence these > > packets are dropped. > > > > This patch fixes this issue by enabling scatter for jumbo packet, if > > it is supported by NIC. > > > > If scatter is not supported by NIC and max packet length is greater > > than default mbuf data size, then application exits with proper error > > message. > > > > Fixes: f68aad7904f ("examples/l3fwd: update") > > > > Signed-off-by: Rohit Raj > > Signed-off-by: Sachin Saxena > > Signed-off-by: Vanshika Shukla > > --- > > > > v2: > > * Improved the check to not enable Rx scatter when packets fits into > > buffer. > > * Check if jumbo packet is enabled using max_rx_pktlen instead of > > jumbo packet flag. > > > > examples/l3fwd/main.c | 13 +++++++++++++ > > 1 file changed, 13 insertions(+) > > > > diff --git a/examples/l3fwd/main.c b/examples/l3fwd/main.c index > > d69373f881..61448c759c 100644 > > --- a/examples/l3fwd/main.c > > +++ b/examples/l3fwd/main.c > > @@ -1109,6 +1109,19 @@ l3fwd_poll_resource_setup(void) > > "Invalid max packet length: %u (port %u)\= n", > > max_pkt_len, portid); > > > > + /* Enable Receive side SCATTER, if supported by NIC, > > + * when jumbo packet is enabled. > > + */ >=20 >=20 > From the code below, it looks like you always enable scatter if HW suppor= ts it. > Without paying attention to max_pkt_len provided by user. You are right. I will fix this check in next updated version of patch. >=20 > > + if (dev_info.max_rx_pktlen > RTE_MBUF_DEFAULT_DATAROOM) { > > + if (dev_info.rx_offload_capa & > > + RTE_ETH_RX_OFFLOAD_SCATTER) > > + local_port_conf.rxmode.offloads |=3D > > + RTE_ETH_RX_OFFLOAD_SCATTE= R; > > + else > > + rte_exit(EXIT_FAILURE, > > + "Max packet length greater than = default MBUF size\n"); > > + } > > + > > if (dev_info.tx_offload_capa & > RTE_ETH_TX_OFFLOAD_MBUF_FAST_FREE) > > local_port_conf.txmode.offloads |=3D > > RTE_ETH_TX_OFFLOAD_MBUF_FAST_FREE; > > -- > > 2.17.1