From: Akhil Goyal <akhil.goyal@nxp.com> To: Nicolas Chautru <nicolas.chautru@intel.com>, "thomas@monjalon.net" <thomas@monjalon.net>, "dev@dpdk.org" <dev@dpdk.org> Cc: "ferruh.yigit@intel.com" <ferruh.yigit@intel.com> Subject: Re: [dpdk-dev] [PATCH v3 06/14] test-bbdev: support HARQ validation Date: Wed, 25 Mar 2020 13:23:27 +0000 Message-ID: <VE1PR04MB66390B8D2CB2DC321CACD996E6CE0@VE1PR04MB6639.eurprd04.prod.outlook.com> (raw) In-Reply-To: <1583348102-13253-7-git-send-email-nicolas.chautru@intel.com> rte_bbdev_dec_op *op, > unsigned int order_idx, const int expected_status) > { > - TEST_ASSERT(op->status == expected_status, > + int status = op->status; > + /* ignore parity mismatch false alarms for long iterations */ > + { > + if (!(expected_status & (1 << RTE_BBDEV_SYNDROME_ERROR)) > && > + (status & (1 << > RTE_BBDEV_SYNDROME_ERROR))) { > + printf("WARNING: Ignore Syndrome Check > mismatch\n"); > + status -= (1 << RTE_BBDEV_SYNDROME_ERROR); > + } > + if ((expected_status & (1 << RTE_BBDEV_SYNDROME_ERROR)) > && > + !(status & (1 << > RTE_BBDEV_SYNDROME_ERROR))) { > + printf("WARNING: Ignore Syndrome Check > mismatch\n"); > + status += (1 << RTE_BBDEV_SYNDROME_ERROR); > + } > + } What is the need of these extra braces. > + > + TEST_ASSERT(status == expected_status, > "op_status (%d) != expected_status (%d)", > op->status, expected_status); > > @@ -1236,9 +1333,10 @@ typedef int (test_case_function)(struct active_device > *ad, > "op_status (%d) != expected_status (%d)", > op->status, expected_status); > > - TEST_ASSERT((void *)(uintptr_t)order_idx == op->opaque_data, > - "Ordering error, expected %p, got %p", > - (void *)(uintptr_t)order_idx, op->opaque_data); > + if (op->opaque_data != (void *)(uintptr_t)INVALID_OPAQUE) > + TEST_ASSERT((void *)(uintptr_t)order_idx == op->opaque_data, > + "Ordering error, expected %p, got %p", > + (void *)(uintptr_t)order_idx, op->opaque_data); > > return TEST_SUCCESS; > } > @@ -1282,6 +1380,170 @@ typedef int (test_case_function)(struct > active_device *ad, > return TEST_SUCCESS; > } > > + > +/* Compute K0 for a given configuration for HARQ output length computation > */ > +static inline uint16_t > +get_k0(uint16_t n_cb, uint16_t z_c, uint8_t basegraph, uint8_t rv_index) > +{ > + if (rv_index == 0) > + return 0; > + uint16_t n = (basegraph == 1 ? 66 : 50) * z_c; > + if (n_cb == n) { > + if (rv_index == 1) > + return (basegraph == 1 ? 17 : 13) * z_c; > + else if (rv_index == 2) > + return (basegraph == 1 ? 33 : 25) * z_c; > + else > + return (basegraph == 1 ? 56 : 43) * z_c; > + } > + /* LBRM case - includes a division by N */ > + if (rv_index == 1) > + return (((basegraph == 1 ? 17 : 13) * n_cb) > + / n) * z_c; > + else if (rv_index == 2) > + return (((basegraph == 1 ? 33 : 25) * n_cb) > + / n) * z_c; > + else > + return (((basegraph == 1 ? 56 : 43) * n_cb) > + / n) * z_c; > +} Please add comments for the logic behind these calculations. It would be better to remove these hard codings and define some macros. There are some other hard codings in the patch. Please fix those as well. > + > +/* HARQ output length including the Filler bits */ > +static inline uint16_t > +compute_Harq_Len(struct rte_bbdev_op_ldpc_dec *ops_ld) { Camel Casing? One generic comment on the patches. I can see that the name of MACROS Is quite big. It would be better to rename them with a shorter logical name.
next prev parent reply other threads:[~2020-03-25 13:23 UTC|newest] Thread overview: 115+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-02-27 4:38 [dpdk-dev] [PATCH v1 00/14] bbdev new features Nicolas Chautru 2020-02-27 4:38 ` [dpdk-dev] [PATCH v1 01/14] bbdev: add capability flag for filler bits inclusion in HARQ Nicolas Chautru 2020-02-27 4:38 ` [dpdk-dev] [PATCH v1 02/14] bbdev: expose device HARQ buffer size at device level Nicolas Chautru 2020-02-27 4:38 ` [dpdk-dev] [PATCH v1 03/14] baseband/turbo_sw: fix the exposed LLR decimals assumption Nicolas Chautru 2020-02-27 4:38 ` [dpdk-dev] [PATCH v1 04/14] baseband/turbo_sw: support large size code block Nicolas Chautru 2020-02-27 4:38 ` [dpdk-dev] [PATCH v1 05/14] test-bbdev: rename FPGA LTE macros to be more explicit Nicolas Chautru 2020-02-27 4:39 ` [dpdk-dev] [PATCH v1 06/14] test-bbdev: support HARQ validation Nicolas Chautru 2020-02-27 4:39 ` [dpdk-dev] [PATCH v1 07/14] test-bbdev: support for performance tests Nicolas Chautru 2020-02-27 4:39 ` [dpdk-dev] [PATCH v1 08/14] test-bbdev: support for LDPC interrupt test Nicolas Chautru 2020-02-27 4:39 ` [dpdk-dev] [PATCH v1 09/14] test-bbdev: support for offload test for LDPC Nicolas Chautru 2020-02-27 4:39 ` [dpdk-dev] [PATCH v1 10/14] test-bbdev: vectors update Nicolas Chautru 2020-02-27 4:39 ` [dpdk-dev] [PATCH v1 11/14] doc: update of testbbdev documentation Nicolas Chautru 2020-02-27 4:39 ` [dpdk-dev] [PATCH v1 12/14] drivers/baseband: add PMD for FPGA 5GNR FEC Nicolas Chautru 2020-02-27 4:39 ` [dpdk-dev] [PATCH v1 13/14] test-bbdev: add support for FPGA driver initialization Nicolas Chautru 2020-02-27 4:39 ` [dpdk-dev] [PATCH v1 14/14] doc: add feature matrix table for bbdev devices Nicolas Chautru 2020-03-04 18:22 ` [dpdk-dev] [PATCH v2 00/15] bbdev new features Nicolas Chautru 2020-03-04 18:22 ` [dpdk-dev] [PATCH v2 01/15] bbdev: add capability flag for filler bits inclusion in HARQ Nicolas Chautru 2020-03-04 18:22 ` [dpdk-dev] [PATCH v2 02/15] bbdev: expose device HARQ buffer size at device level Nicolas Chautru 2020-03-04 18:22 ` [dpdk-dev] [PATCH v2 03/15] baseband/turbo_sw: fix the exposed LLR decimals assumption Nicolas Chautru 2020-03-04 18:22 ` [dpdk-dev] [PATCH v2 04/15] baseband/turbo_sw: support large size code block Nicolas Chautru 2020-03-04 18:22 ` [dpdk-dev] [PATCH v2 05/15] test-bbdev: rename FPGA LTE macros to be more explicit Nicolas Chautru 2020-03-04 18:22 ` [dpdk-dev] [PATCH v2 06/15] test-bbdev: support HARQ validation Nicolas Chautru 2020-03-04 18:22 ` [dpdk-dev] [PATCH v2 07/15] test-bbdev: support for performance tests Nicolas Chautru 2020-03-04 18:22 ` [dpdk-dev] [PATCH v2 08/15] test-bbdev: support for LDPC interrupt test Nicolas Chautru 2020-03-04 18:22 ` [dpdk-dev] [PATCH v2 09/15] test-bbdev: support for offload test for LDPC Nicolas Chautru 2020-03-04 18:22 ` [dpdk-dev] [PATCH v2 10/15] test-bbdev: vectors update Nicolas Chautru 2020-03-04 18:22 ` [dpdk-dev] [PATCH v2 11/15] doc: update of testbbdev documentation Nicolas Chautru 2020-03-04 18:22 ` [dpdk-dev] [PATCH v2 12/15] drivers/baseband: add PMD for FPGA 5GNR FEC Nicolas Chautru 2020-03-04 18:22 ` [dpdk-dev] [PATCH v2 13/15] test-bbdev: add support for FPGA driver initialization Nicolas Chautru 2020-03-04 18:22 ` [dpdk-dev] [PATCH v2 14/15] doc: add feature matrix table for bbdev devices Nicolas Chautru 2020-03-04 18:22 ` [dpdk-dev] [PATCH v2 15/15] doc: add release note for bbdev PMD update Nicolas Chautru 2020-03-04 18:54 ` [dpdk-dev] [PATCH v3 00/14] bbdev new features Nicolas Chautru 2020-03-04 18:54 ` [dpdk-dev] [PATCH v3 01/14] bbdev: add capability flag for filler bits inclusion in HARQ Nicolas Chautru 2020-03-13 10:42 ` Dave Burley 2020-03-25 9:53 ` Akhil Goyal 2020-03-26 2:47 ` Chautru, Nicolas 2020-03-04 18:54 ` [dpdk-dev] [PATCH v3 02/14] bbdev: expose device HARQ buffer size at device level Nicolas Chautru 2020-03-13 10:47 ` Dave Burley 2020-03-04 18:54 ` [dpdk-dev] [PATCH v3 03/14] baseband/turbo_sw: fix the exposed LLR decimals assumption Nicolas Chautru 2020-03-04 18:54 ` [dpdk-dev] [PATCH v3 04/14] baseband/turbo_sw: support large size code block Nicolas Chautru 2020-03-13 16:10 ` Dave Burley 2020-03-25 10:18 ` Akhil Goyal 2020-03-26 2:50 ` Chautru, Nicolas 2020-03-04 18:54 ` [dpdk-dev] [PATCH v3 05/14] test-bbdev: rename FPGA LTE macros to be more explicit Nicolas Chautru 2020-03-13 10:55 ` Dave Burley 2020-03-04 18:54 ` [dpdk-dev] [PATCH v3 06/14] test-bbdev: support HARQ validation Nicolas Chautru 2020-03-25 13:23 ` Akhil Goyal [this message] 2020-03-26 2:53 ` Chautru, Nicolas 2020-03-04 18:54 ` [dpdk-dev] [PATCH v3 07/14] test-bbdev: support for performance tests Nicolas Chautru 2020-03-13 10:58 ` Dave Burley 2020-03-25 13:47 ` Akhil Goyal 2020-03-26 2:56 ` Chautru, Nicolas 2020-03-04 18:54 ` [dpdk-dev] [PATCH v3 08/14] test-bbdev: support for LDPC interrupt test Nicolas Chautru 2020-03-13 10:59 ` Dave Burley 2020-03-04 18:54 ` [dpdk-dev] [PATCH v3 09/14] test-bbdev: support for offload test for LDPC Nicolas Chautru 2020-03-25 13:54 ` Akhil Goyal 2020-03-26 2:57 ` Chautru, Nicolas 2020-03-04 18:54 ` [dpdk-dev] [PATCH v3 10/14] test-bbdev: vectors update Nicolas Chautru 2020-03-13 11:02 ` Dave Burley 2020-03-25 13:58 ` Akhil Goyal 2020-03-26 2:59 ` Chautru, Nicolas 2020-03-04 18:54 ` [dpdk-dev] [PATCH v3 11/14] doc: update of testbbdev documentation Nicolas Chautru 2020-03-13 11:03 ` Dave Burley 2020-03-25 14:48 ` Akhil Goyal 2020-03-26 3:02 ` Chautru, Nicolas 2020-03-04 18:55 ` [dpdk-dev] [PATCH v3 12/14] drivers/baseband: add PMD for FPGA 5GNR FEC Nicolas Chautru 2020-03-13 11:03 ` Dave Burley 2020-03-25 14:59 ` Akhil Goyal 2020-03-26 3:16 ` Chautru, Nicolas 2020-03-26 5:27 ` Akhil Goyal 2020-03-30 0:09 ` Chautru, Nicolas 2020-03-04 18:55 ` [dpdk-dev] [PATCH v3 13/14] test-bbdev: add support for FPGA driver initialization Nicolas Chautru 2020-03-13 11:05 ` Dave Burley 2020-03-04 18:55 ` [dpdk-dev] [PATCH v3 14/14] doc: add feature matrix table for bbdev devices Nicolas Chautru 2020-03-13 11:05 ` Dave Burley 2020-03-12 20:10 ` [dpdk-dev] [PATCH v3 00/14] bbdev new features Chautru, Nicolas 2020-03-13 7:15 ` Akhil Goyal 2020-03-24 23:47 ` Chautru, Nicolas 2020-03-26 2:45 ` [dpdk-dev] [PATCH v4 00/10] " Nicolas Chautru 2020-03-26 2:45 ` [dpdk-dev] [PATCH v4 01/10] bbdev: add capability flag for filler bits inclusion in HARQ Nicolas Chautru 2020-03-26 2:45 ` [dpdk-dev] [PATCH v4 02/10] bbdev: expose device HARQ buffer size at device level Nicolas Chautru 2020-03-26 2:45 ` [dpdk-dev] [PATCH v4 03/10] baseband/turbo_sw: fix the exposed LLR decimals assumption Nicolas Chautru 2020-03-26 2:45 ` [dpdk-dev] [PATCH v4 04/10] baseband/turbo_sw: support large size code block Nicolas Chautru 2020-03-26 2:45 ` [dpdk-dev] [PATCH v4 05/10] test-bbdev: rename FPGA LTE macros to be more explicit Nicolas Chautru 2020-03-26 2:45 ` [dpdk-dev] [PATCH v4 06/10] test-bbdev: support HARQ validation Nicolas Chautru 2020-03-26 2:45 ` [dpdk-dev] [PATCH v4 07/10] test-bbdev: support for performance tests Nicolas Chautru 2020-03-26 2:45 ` [dpdk-dev] [PATCH v4 08/10] test-bbdev: support for LDPC interrupt test Nicolas Chautru 2020-03-26 2:45 ` [dpdk-dev] [PATCH v4 09/10] test-bbdev: support for offload test for LDPC Nicolas Chautru 2020-03-26 2:45 ` [dpdk-dev] [PATCH v4 10/10] test-bbdev: vectors update Nicolas Chautru 2020-03-26 3:27 ` [dpdk-dev] [PATCH v5 00/10] bbdev new features Nicolas Chautru 2020-03-26 3:27 ` [dpdk-dev] [PATCH v5 01/10] bbdev: add capability flag for filler bits inclusion in HARQ Nicolas Chautru 2020-03-27 11:44 ` Dave Burley 2020-03-26 3:27 ` [dpdk-dev] [PATCH v5 02/10] bbdev: expose device HARQ buffer size at device level Nicolas Chautru 2020-03-27 11:45 ` Dave Burley 2020-03-26 3:27 ` [dpdk-dev] [PATCH v5 03/10] baseband/turbo_sw: fix the exposed LLR decimals assumption Nicolas Chautru 2020-03-27 11:45 ` Dave Burley 2020-03-26 3:27 ` [dpdk-dev] [PATCH v5 04/10] baseband/turbo_sw: support large size code block Nicolas Chautru 2020-03-27 11:45 ` Dave Burley 2020-03-26 3:27 ` [dpdk-dev] [PATCH v5 05/10] test-bbdev: rename FPGA LTE macros to be more explicit Nicolas Chautru 2020-03-27 11:45 ` Dave Burley 2020-03-26 3:27 ` [dpdk-dev] [PATCH v5 06/10] test-bbdev: support HARQ validation Nicolas Chautru 2020-03-27 11:47 ` Dave Burley 2020-03-26 3:27 ` [dpdk-dev] [PATCH v5 07/10] test-bbdev: support for performance tests Nicolas Chautru 2020-03-27 11:47 ` Dave Burley 2020-03-26 3:27 ` [dpdk-dev] [PATCH v5 08/10] test-bbdev: support for LDPC interrupt test Nicolas Chautru 2020-03-27 11:47 ` Dave Burley 2020-03-26 3:27 ` [dpdk-dev] [PATCH v5 09/10] test-bbdev: support for offload test for LDPC Nicolas Chautru 2020-03-27 11:47 ` Dave Burley 2020-03-26 3:27 ` [dpdk-dev] [PATCH v5 10/10] test-bbdev: vectors update Nicolas Chautru 2020-03-27 11:47 ` Dave Burley 2020-03-27 11:43 ` [dpdk-dev] [PATCH v5 00/10] bbdev new features Dave Burley 2020-04-05 16:41 ` Akhil Goyal 2020-03-03 18:08 ` [dpdk-dev] [PATCH v1 00/14] " Chautru, Nicolas 2020-03-04 8:23 ` Thomas Monjalon 2020-03-04 18:28 ` Chautru, Nicolas
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=VE1PR04MB66390B8D2CB2DC321CACD996E6CE0@VE1PR04MB6639.eurprd04.prod.outlook.com \ --to=akhil.goyal@nxp.com \ --cc=dev@dpdk.org \ --cc=ferruh.yigit@intel.com \ --cc=nicolas.chautru@intel.com \ --cc=thomas@monjalon.net \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions This inbox may be cloned and mirrored by anyone: git clone --mirror http://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ http://inbox.dpdk.org/dev \ dev@dpdk.org public-inbox-index dev Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git