From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B01EAA3160 for ; Fri, 11 Oct 2019 12:42:24 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4622A1EA72; Fri, 11 Oct 2019 12:42:24 +0200 (CEST) Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-eopbgr30057.outbound.protection.outlook.com [40.107.3.57]) by dpdk.org (Postfix) with ESMTP id 08E5F1EA71 for ; Fri, 11 Oct 2019 12:42:22 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TyIj9hiBjTo/O4six5UqYJO8xQJAXRmHFfUuyvEoxdRxy++vy0fEW2c3Ivzy4iIouIbaFYeAuj7X9mHM1oTVq66S/gdcqbqRnbU00ZzO0jhOYoiCNytpR54zlwJDEBA0sFCPJzjGHznRgav8Eh1VIo4FWtgSem7cBDoJ17Dro5WFt60cPHHHbDFgCOGzPc3UELoi/na8kRis7ChkPPz1tmUgWhvULWt2L44GQmyKw/lWfbOq2R5fdS7HNq1wOIoxTgNUk0GndGWuilHGn2Zksk0TeHi466t8TKY863ykqh6RrZalkTfLfRlWubNZlCtAbXgU2W3GkV1zOW9XvQ98mQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8KTmMQe8/6ToC7PjDT33z/DWK18q8PaVf5t92hInpJo=; b=FkIIogZJeoxSByXvQoH2nOrbj1/FNupTK05+r/J6zc1bMIoS4Fn8GX4iSSoD8lyhSD8yGa7IBOROHd3UGd9YjRhdymLm8JsXZYL8qvsUT5T5T8O2f71s0+qUin3OHsWZuixhWThNipWEU7iFH++O9fhamT4wgPFPNdy2FP/bhWlR2w/5I5BiN1fipbKwXMulzlKjD+cQkLmFGgpif17Hky4fAL5Ca0RI7nr/NbBVoewRAjgMLBcR5HvbpJGgOVRgUEIlEVnu67fiBQ+lPdaYmB6X3QijPx+pcvxXtbm/IcGLoPhVmnimKge5zUR9by9qIzmR+cntsYoSdA1VlEl4iA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8KTmMQe8/6ToC7PjDT33z/DWK18q8PaVf5t92hInpJo=; b=DBAY5r1+TMW/Q0tTohbc7F5sHBiWrcigiFXnY0qLogxX9cveIhbfv+hRuPq2ml+WdEUCBaFcX7RmHuVJHmf88QDnOMbWJiuObDBF40s29VJRbBTx8m4gfz/LrbvmNk94dmICEwCh5GkdaLQYHFCLZvVQOFz11mcNO+5Yy8BOOCg= Received: from VE1PR04MB6639.eurprd04.prod.outlook.com (10.255.118.11) by VE1PR04MB6670.eurprd04.prod.outlook.com (20.179.233.213) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2347.17; Fri, 11 Oct 2019 10:42:22 +0000 Received: from VE1PR04MB6639.eurprd04.prod.outlook.com ([fe80::c045:5df2:ba1f:c3ee]) by VE1PR04MB6639.eurprd04.prod.outlook.com ([fe80::c045:5df2:ba1f:c3ee%5]) with mapi id 15.20.2347.021; Fri, 11 Oct 2019 10:42:21 +0000 From: Akhil Goyal To: Vladimir Medvedkin , "dev@dpdk.org" CC: "konstantin.ananyev@intel.com" , "bernard.iremonger@intel.com" Thread-Topic: [PATCH v5 3/5] ipsec: add SAD add/delete/lookup implementation Thread-Index: AQHVf4q0h+wZ8q/xBEyTRwcSBcoxOqdVQYig Date: Fri, 11 Oct 2019 10:42:21 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=akhil.goyal@nxp.com; x-originating-ip: [92.120.1.65] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 58300c78-f4ca-4837-a2b8-08d74e37b269 x-ms-office365-filtering-ht: Tenant x-ms-traffictypediagnostic: VE1PR04MB6670: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3173; x-forefront-prvs: 0187F3EA14 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(39860400002)(376002)(366004)(346002)(136003)(396003)(199004)(189003)(2906002)(4326008)(476003)(6246003)(229853002)(64756008)(66946007)(66446008)(446003)(76116006)(44832011)(11346002)(9686003)(55016002)(6436002)(99286004)(186003)(26005)(102836004)(66556008)(256004)(76176011)(6116002)(33656002)(3846002)(7696005)(6506007)(486006)(71200400001)(66476007)(71190400001)(316002)(8676002)(7736002)(74316002)(4744005)(8936002)(25786009)(305945005)(110136005)(478600001)(81156014)(2501003)(5660300002)(86362001)(66066001)(54906003)(14454004)(52536014)(81166006); DIR:OUT; SFP:1101; SCL:1; SRVR:VE1PR04MB6670; H:VE1PR04MB6639.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 1F9DD+9QeWRbmcZ9W285XuiBAyHZ0jGj95aIZZt8NlIhWMTjz3NeuufECZxAm9dxWhmyUWNsIeRzhFOD3bC1om5olSaPBJgivFffSUJ29dztuBqDMw5ov11PUwsmXxLLv26CAvwaQOW/ZQpKwfklDjB/uAMZ43QcvkzzT7E0G6GI3EJOpjDScS6IJQaGIAYhaMP8ypx73a08sn8vRMRHv0lLnID2YtqmCdAza7nSapsr9TqjQGWEcckYJ2qgpl4WBvOG3iXXrpL1C4u50YSs4ClLIBoKvR0TuKoAwmRGP2FvikepNB+zN/AD+6mirf8g28fOW5+PLVgBrKrUz4twcjao3wgRD4IV7omETKJEiMAY87aXApczUE4vC2BJiT3EMJSyw+X2sgl/B7nR4WuOvHII4r6VAzZA0+WyIu2fV5U= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 58300c78-f4ca-4837-a2b8-08d74e37b269 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Oct 2019 10:42:21.8330 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: tBSq2Vx1okFU2OYPSS+WtS0l7EbnR4ZrKV76ENP21FkRC9yqtszgeJpnge62CaTCGEZdVUfbzOix7I9iBU3OXA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6670 Subject: Re: [dpdk-dev] [PATCH v5 3/5] ipsec: add SAD add/delete/lookup implementation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > int > -rte_ipsec_sad_lookup(__rte_unused const struct rte_ipsec_sad *sad, > - __rte_unused const union rte_ipsec_sad_key *keys[], > - __rte_unused void *sa[], __rte_unused uint32_t n) > +rte_ipsec_sad_lookup(const struct rte_ipsec_sad *sad, > + const union rte_ipsec_sad_key *keys[], void *sa[], uint32_t n) > { > - return -ENOTSUP; > + uint32_t num, i =3D 0; > + int found =3D 0; > + > + if (unlikely((sad =3D=3D NULL) || (keys =3D=3D NULL) || (sa =3D=3D NULL= ))) > + return -EINVAL; > + > + do { > + num =3D RTE_MIN(n - i, > (uint32_t)RTE_HASH_LOOKUP_BULK_MAX); > + found +=3D __ipsec_sad_lookup(sad, > + &keys[i], &sa[i], num); > + i +=3D num; > + } while (i !=3D n); > + > + return found; > } rte_ipsec_sad_lookup should return 0 or a negative value as per the comment= s in the declaration. But here it is returning more than 0. Something is not correct here. > -- > 2.7.4