From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 25CA4A0531; Tue, 4 Feb 2020 11:36:57 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8C2351C00F; Tue, 4 Feb 2020 11:36:56 +0100 (CET) Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2062.outbound.protection.outlook.com [40.107.22.62]) by dpdk.org (Postfix) with ESMTP id B9D921C00E for ; Tue, 4 Feb 2020 11:36:54 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IDRn2cyCoBiZj1pAMJE7Knn06/Os5qD1sGvi3eJq8/zcn32s0/PsPl+8d8KlaIKeE1pEzknp0+++5/Hc3YWjBrPdBjBx904WskyRKMD1xwhVO9LuQ1ULTOSlz7RomWTlhHU8gSrhemo4c9RGjrdrdtoqka1KnB0TENq6s11TRhAlvXCZl95lCjGXw4PsaScKrKZIbBPEuvY/B2Qb5tnrVp36l3f/e4wE5mvCaqaI36OQPXYKF8sdeA73zv4ipUwrfV8R1kx16slReTiZl3dQesGkEieiln8cN7/XpsdjgHVBFyJ1Uq+hkctBLl+9nznO+mY4WoqgV3XWdoqcZ33+5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6OaP+f2+wV/lh1A4oFXN8QUF6Jb+FQYhMjYtYyGRydE=; b=kcEfPrDpt00xquvAsEbwba2OqeoYRLM7fratu2OVUphBl+5/X0ozGCjTJJebVz+P8BcfHit0o/zi9iWQ/Nx4sEkBomP/XPz+zJkkXWwxAEr1ZWfDwpxfJxprZ7PDZQaIv8BKIaLwZfvWuqDgN/aJW9zW0lNlXzBee1ZzU/IuPUev1MxyUinYbTUyxYq9XKXXZQb4WBUQUkEv9Eapw0PjGsAZdGRrhCCSJBMZ5BiAqxS2xXb2zG0WIwuREmls8QbTea2VUN+aqk24rYzuCRZ7sJNN+qUVeD38z5IcQ17LEcZn38PIeGst86mZ0dQMg/QhQbfNoiT/vk60sQcKwcJCcg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6OaP+f2+wV/lh1A4oFXN8QUF6Jb+FQYhMjYtYyGRydE=; b=aLHg+kzdnAs+w9m+cR1pEOHUu+iYhJllV1O53AdX4oCO4J/4T9GB6YlyaOMtxQLssCo4Libl8AoHU5kqHDWU+MxK2KzQTOngaEaLsdy12qBM/orJDZx42GksHx5yf5s6G7hNBZoFEGQ5o6IwI78j9GM4CMTXKVlxS1TZeKFpHKI= Received: from VE1PR04MB6639.eurprd04.prod.outlook.com (10.255.118.11) by VE1PR04MB6656.eurprd04.prod.outlook.com (20.179.235.95) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2686.30; Tue, 4 Feb 2020 10:36:53 +0000 Received: from VE1PR04MB6639.eurprd04.prod.outlook.com ([fe80::25b0:b1ac:aed0:63e1]) by VE1PR04MB6639.eurprd04.prod.outlook.com ([fe80::25b0:b1ac:aed0:63e1%7]) with mapi id 15.20.2686.031; Tue, 4 Feb 2020 10:36:53 +0000 From: Akhil Goyal To: Akhil Goyal , Marcin Smoczynski , "konstantin.ananyev@intel.com" , "roy.fan.zhang@intel.com" , "declan.doherty@intel.com" , "radu.nicolau@intel.com" , "pablo.de.lara.guarch@intel.com" CC: "dev@dpdk.org" Thread-Topic: [PATCH v5 4/8] security: add cpu crypto action type Thread-Index: AQHV1eZnKJuNj8bF4U+7pEmVvjUMgqgE1FOQgAYNrXA= Date: Tue, 4 Feb 2020 10:36:52 +0000 Message-ID: References: <20200128031642.15256-1-marcinx.smoczynski@intel.com> <20200128142220.16644-1-marcinx.smoczynski@intel.com> <20200128142220.16644-5-marcinx.smoczynski@intel.com> In-Reply-To: Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=akhil.goyal@nxp.com; x-originating-ip: [92.120.1.72] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 9091b8a9-6a5a-4e69-fe00-08d7a95e2653 x-ms-traffictypediagnostic: VE1PR04MB6656:|VE1PR04MB6656: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-forefront-prvs: 03030B9493 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(136003)(39860400002)(396003)(366004)(376002)(346002)(189003)(199004)(15650500001)(71200400001)(4326008)(81166006)(66946007)(66446008)(186003)(33656002)(81156014)(55016002)(9686003)(7696005)(5660300002)(86362001)(2906002)(8936002)(52536014)(6506007)(44832011)(110136005)(66556008)(66476007)(64756008)(76116006)(26005)(478600001)(316002)(8676002); DIR:OUT; SFP:1101; SCL:1; SRVR:VE1PR04MB6656; H:VE1PR04MB6639.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: /jKDF7npzsb3VsLPcL+cGZIJxPqGzL/iBgJq4PeyF0XTDvCbhPcClyy+a4J3367ovQtb46dTiZcEGCkkStP30GqczXO4rdI+4C+bigNNAlhAeXcYB7QwhHH6dlcoiB/JpYLnkYiOiU6QDasxMn2YnPV2thT+DxKqIRLzzoMutnJB5J2zS9E6ZJYgeuR9Uq08wd0+ndJHJ7ejri5gjEj3B7QMFtk4dddq+eDtdk77p3JdGHoaBRHhUua33vaEUJbWYt9+kC5pDnOQx6GUkNaZL9LCUqemgwVXxCrfqZuqQLYLxcZmYP1H4VHy797/JnuWdcEjWiQh4rvyZ4BAAwOO7HICjm/Lha7EHXbLBINLRt08DChBH5nom9qpqLRuzmwOKi/FMWrYFXepLyg/ZZbBNOjeLVHlXVqJ+TfSIxgm/uAMimA4yUWo/rtU+r/w4Bt7 x-ms-exchange-antispam-messagedata: fbb5DKG9ZcckJjg82kKrXSFG6pc5ynIHqH/9ccKlAgOuUT5dTCE5eVacmG/1i8440dpRy6pCYMf/5c5Py9ywoIXUWCC8afFD3NbdCDb9qFEYIZhQu9LMBKWHZIoWcjDNvlzK2tBnfbKYMLHViXy4mw== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9091b8a9-6a5a-4e69-fe00-08d7a95e2653 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Feb 2020 10:36:52.9814 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 1b2oAZc7C7LHnLe2hwvTq/wJAtVKuY52xXjA5WRJDvjRv7CFsFgqtlsNdGdrtFitaCEGtdmp16cYHpkwAz1ydw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6656 Subject: Re: [dpdk-dev] [PATCH v5 4/8] security: add cpu crypto action type X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > Hi Marcin/Konstantin, >=20 > > Introduce CPU crypto action type allowing to differentiate between > > regular async 'none security' and synchronous, CPU crypto accelerated > > sessions. > > > > Signed-off-by: Marcin Smoczynski > > Acked-by: Konstantin Ananyev > > Acked-by: Fan Zhang > > --- > > lib/librte_security/rte_security.h | 8 ++++++-- > > 1 file changed, 6 insertions(+), 2 deletions(-) > > > > diff --git a/lib/librte_security/rte_security.h b/lib/librte_security/r= te_security.h > > index 546779df2..c8b2dd5ed 100644 > > --- a/lib/librte_security/rte_security.h > > +++ b/lib/librte_security/rte_security.h > > @@ -1,6 +1,6 @@ > > /* SPDX-License-Identifier: BSD-3-Clause > > * Copyright 2017,2019 NXP > > - * Copyright(c) 2017 Intel Corporation. > > + * Copyright(c) 2017-2020 Intel Corporation. > > */ > > > > #ifndef _RTE_SECURITY_H_ > > @@ -307,10 +307,14 @@ enum rte_security_session_action_type { > > /**< All security protocol processing is performed inline during > > * transmission > > */ > > - RTE_SECURITY_ACTION_TYPE_LOOKASIDE_PROTOCOL > > + RTE_SECURITY_ACTION_TYPE_LOOKASIDE_PROTOCOL, > > /**< All security protocol processing including crypto is performed > > * on a lookaside accelerator > > */ > > + RTE_SECURITY_ACTION_TYPE_CPU_CRYPTO > > + /**< Crypto processing for security protocol is processed by CPU > > + * synchronously > > + */ > I am not able to see the need for this enum. >=20 > It is used by the app and ipsec library to identify the cpu-crypto codepa= th. >=20 > I don't see any security action been performed for this action_type. >=20 > This enum is just like NONE which is not used beyond the application/lib. > I think this needs to be documented properly in the description of the en= um. >=20 > It should be something like >=20 > Similar to ACTION_TYPE_NONE, but the crypto processing is done on CPU > Synchronously. >=20 > Also add documentation of this in the rte_security.rst in this patch only= . > There should not be any separate patch for documentation. >=20 Could you please send the update to the patches that I requested. I wanted to apply these today.