From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D902DA04F0; Mon, 13 Jan 2020 13:43:58 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9558D1D51B; Mon, 13 Jan 2020 13:43:58 +0100 (CET) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80073.outbound.protection.outlook.com [40.107.8.73]) by dpdk.org (Postfix) with ESMTP id D8FC41D515 for ; Mon, 13 Jan 2020 13:43:56 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WASqJ4piQ3t8sxtm2E2CdoYXsdawHXuFRrSkaT/fb1AdfB+cCBCPwXjFCKwrmZDWFYrbbm3Yr4+UojKBZLDQLkay95GgDQsn2zSwH5nMAo/zc7c5Mcph7S4qxwfk3aLaTj60uEpEfUKL4EFNtxm9zOUvr0hxWWtuIS4R0+1hnf7WV9WG8y6u1rMZ4gf3KcbtfBhCc9Gu9BNCeVLDyBZhAWnqI13Y2UB6zOqH8riEtGKsKqg4Cd3liv+pFlDESxHr8bk4JajZPoPmu1o3RCrPShQhcju5V1Jyo7eobZduFV7SH61G2SmXrlNHE357R/QJyK6pYaIwzSTkakuhk9yElA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3CmzVWnzSQu2H7zbr/KikaCkY0VjavGXOxRi32763A4=; b=NhK4nNAwl8nAXzbv3OR1EW16f2APPGBeQL86kQvvT0o4E165OGL4g5Qmb6uxAqeDZNymbN94FKxBPrpTIGSvxEGf+AuJdOTzlqD2/jUUSYCcZ8l/dUMlRd2/gGgnvwgQrCpPJFg2DV9iQKTvuDZvNmjrDONlmqdP5ZzcMqkLQtlXoqViA7PQrrc19UGqQTyh/jv19CvqBMfxMnNhItBYxEk/v+Rd5XOwxSbX6+AxuXGLqWaRKrcooeBfOvk5cQ4YdT7f82j6V/i3WQxF59d7/Du9vbFs/ts63bCXbLSeKKhYKtlYhApMnDI9VPFk1K8JyzD9lfCB9CH9aatz6fM7yQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3CmzVWnzSQu2H7zbr/KikaCkY0VjavGXOxRi32763A4=; b=rK/u8GKkv/VgsoLCNmfh+IMBMrBKcSGmnm7l1Mm/wEdmYzelxy3qGSQfWc16L/4HI7eYrWhccnltjuMvHGkLgh9oCZE+c3Hh7JLqtNikEWidhK0KZNqb/0G0CsnGRwNQ7CF7b8elVAO8tQgdXNiVkPdb41AsKpyzutJIVdwU+NU= Received: from VE1PR04MB6639.eurprd04.prod.outlook.com (10.255.118.11) by VE1PR04MB6368.eurprd04.prod.outlook.com (20.179.232.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2623.12; Mon, 13 Jan 2020 12:43:56 +0000 Received: from VE1PR04MB6639.eurprd04.prod.outlook.com ([fe80::25b0:b1ac:aed0:63e1]) by VE1PR04MB6639.eurprd04.prod.outlook.com ([fe80::25b0:b1ac:aed0:63e1%7]) with mapi id 15.20.2623.015; Mon, 13 Jan 2020 12:43:56 +0000 From: Akhil Goyal To: Anoob Joseph , Declan Doherty , Pablo de Lara CC: Balakrishna Bhamidipati , Fiona Trahe , Arek Kusztal , Jerin Jacob , Narayana Prasad , Shally Verma , Ankur Dwivedi , Sunila Sahu , "dev@dpdk.org" Thread-Topic: [PATCH 1/4] lib/crypto: add support for EC Point Multiplication Thread-Index: AQHVq4IwIeeVMHONyUKFdF/wLKWsZ6fow5SA Date: Mon, 13 Jan 2020 12:43:55 +0000 Message-ID: References: <1575560280-3261-1-git-send-email-anoobj@marvell.com> <1575560280-3261-2-git-send-email-anoobj@marvell.com> In-Reply-To: <1575560280-3261-2-git-send-email-anoobj@marvell.com> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=akhil.goyal@nxp.com; x-originating-ip: [92.120.1.68] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: fbac99e3-4516-4042-f204-08d7982640ec x-ms-traffictypediagnostic: VE1PR04MB6368: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6430; x-forefront-prvs: 028166BF91 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(39860400002)(346002)(366004)(396003)(136003)(376002)(189003)(199004)(316002)(66946007)(4326008)(7416002)(86362001)(186003)(71200400001)(26005)(52536014)(76116006)(64756008)(66446008)(66476007)(66556008)(478600001)(8676002)(54906003)(110136005)(44832011)(55016002)(81156014)(2906002)(8936002)(6506007)(33656002)(9686003)(81166006)(7696005)(5660300002); DIR:OUT; SFP:1101; SCL:1; SRVR:VE1PR04MB6368; H:VE1PR04MB6639.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: luK/rY8O2QGcC/UUVlnsA7zKONeZ3hscyGQnB3pKTZ8DXcKdsNHvF05DAXez2Ez46p2SjkuNgBf5y6QnY3gVrmyEgDaxEIejkphAUTpEPSJfSAbFy+PZ8bmq9hQG9JR8mMcH0Nvu53aYI48JB++uJVATT2Tz9Rsnk4r4I4ys2nyvdp0UmAUzD6MKqdPUiUP8x+rbrdu9wpvyA9Pm2fUI2nIjhtZnDVqo2aNGZ2YDdEjlMX+rCGTCdxpp9ASnBkBOE2BkeMKOyoidxLtqj23BuPyE08XDlWCLcj39+EaGYw9e8323y4/WzRsc6SYbEJxFIBtCJtHp//1K7e48IJ9zDxo5md3ZBS5P1RKHA05GACzpXuLT5wNyn/uV60m+MJn4Ngf17xSJyGuL/t/bbsVvdFKanOipQIZagyI/Lnh8+sVGK9AC/5YqeUGvznQFb1C1 x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: fbac99e3-4516-4042-f204-08d7982640ec X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Jan 2020 12:43:55.9935 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 95KiOL24tedB5whQXQbce77iliEh1CrZrIWL5iL5LbnrFM0Y35Q0JPlY2u4Q3EIrP3Y6ejmw0nnpaNhu/DHLWw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6368 Subject: Re: [dpdk-dev] [PATCH 1/4] lib/crypto: add support for EC Point Multiplication X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" >=20 > From: Balakrishna Bhamidipati >=20 > Elliptic Curve Point Multiplication xform type and op > parameters are added. Description should convey that it is an asymmetric crypto feature. >=20 > Signed-off-by: Anoob Joseph > Signed-off-by: Balakrishna Bhamidipati > Signed-off-by: Sunila Sahu Title should be cryptodev: support ECPM > --- > doc/guides/cryptodevs/features/default.ini | 1 + > lib/librte_cryptodev/rte_crypto_asym.h | 17 +++++++++++++++++ > lib/librte_cryptodev/rte_cryptodev.c | 1 + > 3 files changed, 19 insertions(+) >=20 > diff --git a/doc/guides/cryptodevs/features/default.ini > b/doc/guides/cryptodevs/features/default.ini > index 2f6c785..3a54b07 100644 > --- a/doc/guides/cryptodevs/features/default.ini > +++ b/doc/guides/cryptodevs/features/default.ini > @@ -109,3 +109,4 @@ Modular Exponentiation =3D > Modular Inversion =3D > Diffie-hellman =3D > ECDSA =3D > +EC Point Multiplication =3D I think it is better to have ECPM instead of EC Point Multiplication as it = is the case with ECDSA. > diff --git a/lib/librte_cryptodev/rte_crypto_asym.h > b/lib/librte_cryptodev/rte_crypto_asym.h > index dd5e6e3..b98ce6c 100644 > --- a/lib/librte_cryptodev/rte_crypto_asym.h > +++ b/lib/librte_cryptodev/rte_crypto_asym.h > @@ -85,6 +85,8 @@ enum rte_crypto_asym_xform_type { > /**< Elliptic Curve Digital Signature Algorithm > * Perform Signature Generation and Verification. > */ > + RTE_CRYPTO_ASYM_XFORM_EC_POINT_MUL, Should be RTE_CRYPTO_ASYM_XFORM_ECPM > + /**< Elliptic Curve Point Multiplication */ > RTE_CRYPTO_ASYM_XFORM_TYPE_LIST_END > /**< End of list */ > }; > @@ -598,6 +600,20 @@ struct rte_crypto_ecdsa_op_param { > }; >=20 > /** > + * Structure for EC point operation param > + */ > +struct rte_crypto_ec_point_mul_param { Better to have rte_crypto_ecpm_param > + struct rte_crypto_ec_point p; > + /**< x and y coordinates of input point */ > + > + struct rte_crypto_ec_point r; > + /**< x and y coordinates of resultant point */ > + > + rte_crypto_param scalar; > + /**< Scalar to multiply the input point */ > +}; > + > +/** > * Asymmetric Cryptographic Operation. > * > * Structure describing asymmetric crypto operation params. > @@ -620,6 +636,7 @@ struct rte_crypto_asym_op { > struct rte_crypto_dh_op_param dh; > struct rte_crypto_dsa_op_param dsa; > struct rte_crypto_ecdsa_op_param ecdsa; > + struct rte_crypto_ec_point_mul_param ecpm; > }; > }; >=20 > diff --git a/lib/librte_cryptodev/rte_cryptodev.c > b/lib/librte_cryptodev/rte_cryptodev.c > index 0d6babb..eea57c6 100644 > --- a/lib/librte_cryptodev/rte_cryptodev.c > +++ b/lib/librte_cryptodev/rte_cryptodev.c > @@ -174,6 +174,7 @@ const char *rte_crypto_asym_xform_strings[] =3D { > [RTE_CRYPTO_ASYM_XFORM_DH] =3D "dh", > [RTE_CRYPTO_ASYM_XFORM_DSA] =3D "dsa", > [RTE_CRYPTO_ASYM_XFORM_ECDSA] =3D "ecdsa", > + [RTE_CRYPTO_ASYM_XFORM_EC_POINT_MUL] =3D "ecpm", > }; >=20 > /** > -- > 2.7.4