From: Akhil Goyal <akhil.goyal@nxp.com>
To: Adam Dybkowski <adamx.dybkowski@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"fiona.trahe@intel.com" <fiona.trahe@intel.com>,
"arkadiuszx.kusztal@intel.com" <arkadiuszx.kusztal@intel.com>
Cc: 'Anoob Joseph' <anoobj@marvell.com>,
'Thomas Monjalon' <thomas@monjalon.net>
Subject: Re: [dpdk-dev] [PATCH v2 1/1] test/crypto: add tests for encrypted digest AES CTR+CMAC
Date: Mon, 21 Oct 2019 11:53:00 +0000 [thread overview]
Message-ID: <VE1PR04MB663922E561365CD0A42FB8F1E6690@VE1PR04MB6639.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <20191021112955.9579-2-adamx.dybkowski@intel.com>
Hi All,
The test_cryptodev.c is getting bloated with a lot of duplicated code.
We should plan to consolidate the code so that it is scalable and whenever
a new PMD is added, a new testsuite is built and the file gets bloated.
In this release we are allowing these type of changes but going forward(post 19.11)
No duplicate code will be accepted. We should develop a way to check PMDs
Capabilities and execute the test cases accordingly. I would request all the PMD owners
Who test their PMDs with this application to contribute and start a thread to clean up
this mess.
I also see that there is some common code while adding a new algorithm.
Thanks,
Akhil
>
> This patch adds tests for encrypted digest AES-CTR + AES CMAC using
> mixed auth-cipher algorithm functions. Tests allow easy
> extending with new cases, check in-place and
> out-of-place operations and use linear and sgl
> buffers as input/output.
>
> Signed-off-by: Adam Dybkowski <adamx.dybkowski@intel.com>
> ---
prev parent reply other threads:[~2019-10-21 11:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-18 13:02 [dpdk-dev] [PATCH] test/crypto: add unit tests for AES-CTR + AES CMAC Adam Dybkowski
2019-10-18 15:00 ` Kusztal, ArkadiuszX
2019-10-21 11:29 ` [dpdk-dev] [PATCH v2 0/1] test/crypto: add tests for encrypted digest AES CTR+CMAC Adam Dybkowski
2019-10-21 11:29 ` [dpdk-dev] [PATCH v2 1/1] " Adam Dybkowski
2019-10-21 11:32 ` Kusztal, ArkadiuszX
2019-10-23 14:03 ` Akhil Goyal
2019-10-21 11:53 ` Akhil Goyal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VE1PR04MB663922E561365CD0A42FB8F1E6690@VE1PR04MB6639.eurprd04.prod.outlook.com \
--to=akhil.goyal@nxp.com \
--cc=adamx.dybkowski@intel.com \
--cc=anoobj@marvell.com \
--cc=arkadiuszx.kusztal@intel.com \
--cc=dev@dpdk.org \
--cc=fiona.trahe@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).