From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 62282A2EDB for ; Tue, 1 Oct 2019 14:57:15 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id F0A0A1B994; Tue, 1 Oct 2019 14:57:09 +0200 (CEST) Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-eopbgr50054.outbound.protection.outlook.com [40.107.5.54]) by dpdk.org (Postfix) with ESMTP id D303A4C90 for ; Tue, 1 Oct 2019 14:57:07 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mvq2Ib7f0BsHWZcrX3QcK1Q/0PPiG4YeipC6uhwT4T0JjhWDoDSYT4gJE3JDgrXAWMNluiD3uPRedfmlc9pTuci0LSa1v0uUDgqXKW/x1YMsMoKhHLLSMiJaHCJ4OawPQleomsVZrfCz1Vfvsk+iGVB1M9hVm6gHXDtnfZiqGBdjrzMEJJ/V6/Fr0s6b4DvN3CNrq9xEp242JdeZDchM09MVRkSjtInget8Tj3uXuXP4XSKb2QCIopLjnRlbbUg68duLae6PTJWuwokRJ24JkxpAymc0uF9O6vwd76VNny4K5IwZXG8xgejJDJ49FOHvfjEdwAsxpF7Ly7EBPzSN1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gL2dSrDiHeq1ziZ7fG8xlxqYSvJqj7x8nCUUN5I/j2o=; b=CyaIG9Rm3Bxw+SwgFdYZErxxiMMUuIxsvN1wq99UDQofxMqyf/nYGr+QmjF73thwk43HssmRpkW8ivGZPG6+ibZFTftirfqTmglnBjTWds/7+iXFXMbqi3s7SAhX5eNRlwEhRAqoIltq5UW4qEF1pkzu9eoXwi0eDlQJoprIWxG7oLT3S6vBGKYT/GingQT3dKw9xAOaW6b4x3iRosMkdq7jVM+qtWtYsGfhsRVbLiTBSP5hpmiaanvgpZhMlX3uwB8PbY63loX6Ajw+q1fZG9B1FeUw1d2ProvgpmZpAAfxqJcltATxL/mdW6F+5ySvMzaCL62qyHRwi8wQIxcffw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gL2dSrDiHeq1ziZ7fG8xlxqYSvJqj7x8nCUUN5I/j2o=; b=mO6omAGSqkmPfXSsLKk7iMhpTobwoxwBjk48hUc7d6JwMwnWsFyy1JCdeE1HKk08IYB8pKZEnSOpa5pCZpCyWINJR/6zjS6Shgc0Y3c4ZzozB1Rvx+uNhfuuVF/I2OAHTLJtcTteVFwMsw6WABs9/c+KEfsyaddvWCKTUdQDnKQ= Received: from VE1PR04MB6639.eurprd04.prod.outlook.com (10.255.118.11) by VE1PR04MB6735.eurprd04.prod.outlook.com (20.179.234.203) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2305.15; Tue, 1 Oct 2019 12:57:07 +0000 Received: from VE1PR04MB6639.eurprd04.prod.outlook.com ([fe80::c045:5df2:ba1f:c3ee]) by VE1PR04MB6639.eurprd04.prod.outlook.com ([fe80::c045:5df2:ba1f:c3ee%5]) with mapi id 15.20.2305.022; Tue, 1 Oct 2019 12:57:07 +0000 From: Akhil Goyal To: Anoob Joseph , Pablo de Lara CC: Kanaka Durga Kotamarthy , Jerin Jacob , Narayana Prasad , Fiona Trahe , Shally Verma , Sunila Sahu , "dev@dpdk.org" Thread-Topic: [PATCH 3/8] crypto/octeontx: add asymmetric session operations Thread-Index: AQHVZxKTaHnYS9Jab0msGe2yUjZh06dF3RPA Date: Tue, 1 Oct 2019 12:57:07 +0000 Message-ID: References: <1568035687-25492-1-git-send-email-anoobj@marvell.com> <1568035687-25492-4-git-send-email-anoobj@marvell.com> In-Reply-To: <1568035687-25492-4-git-send-email-anoobj@marvell.com> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=akhil.goyal@nxp.com; x-originating-ip: [92.120.1.65] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 19dd3bf1-8030-4b64-9029-08d7466edd85 x-ms-office365-filtering-ht: Tenant x-ms-traffictypediagnostic: VE1PR04MB6735: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2331; x-forefront-prvs: 0177904E6B x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(376002)(346002)(39860400002)(396003)(366004)(136003)(199004)(189003)(7736002)(9686003)(25786009)(6246003)(186003)(11346002)(52536014)(5660300002)(71200400001)(86362001)(305945005)(446003)(71190400001)(74316002)(4744005)(33656002)(102836004)(55016002)(26005)(4326008)(6436002)(3846002)(44832011)(54906003)(6116002)(6506007)(486006)(8676002)(66556008)(8936002)(229853002)(2906002)(256004)(110136005)(99286004)(81166006)(81156014)(66476007)(76176011)(64756008)(66446008)(66946007)(316002)(76116006)(66066001)(478600001)(476003)(14454004)(7696005); DIR:OUT; SFP:1101; SCL:1; SRVR:VE1PR04MB6735; H:VE1PR04MB6639.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 4cLgdcdoUR7okhENevDukBV5jKVYYGBWBna9j0klYyfDebcAqRWWVvRpyPIycnYMcw40UCG42TOvcdIntftbgSWpDj9RJgb8DyLe1fHzpXM7pV+ucjU5pXlrcT3GAfBOdUUPCm26gnXPpNZ5ZqOwTQXmQgWZyM3GN5yAviIbjmkMGK3fS0rMSl4LowqyJQC6I8QcqW5ySVg1EBtM74bCmGUs2P9wON0HdpI6r70m+DfKKR2WeP43J7PvA7xhP4DCypHvtNgpMdeGnRBqmetuub9zmkGoWClqRh1aCbCcvJ0MDtdEk5dBJvdCowDySag3vQ3dUOvTBnkzND05QBGCOXFx0LgxVavVLcsEVUAkiTDoZOzD0dvrRcQzkK/oUE+w+ylxWhsSfvVgYIkCTumIYHgefyslhcZhz1vznMaKczQ= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 19dd3bf1-8030-4b64-9029-08d7466edd85 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Oct 2019 12:57:07.1830 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ypEQ0aDFKkV2TeuC50HDb8dojWLs4780KEOmeJUF9X5AgWtGCCjP/zVqa73ZhltxXXI3SOeI76DtsMswTEsoeQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6735 Subject: Re: [dpdk-dev] [PATCH 3/8] crypto/octeontx: add asymmetric session operations X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Anoob, Just a couple of nits > + > +static __rte_always_inline void > +cpt_modex_param_normalize(uint8_t **data, size_t *len) > +{ > + size_t i; > + > + /* Strip leading NUL bytes */ Typo NULL > + > + for (i =3D 0; i < *len; i++) { > + if ((*data)[i] !=3D 0) > + break; > + } > + > + *data +=3D i; > + *len -=3D i; > +} > + <.snip.> > +static __rte_always_inline void > +cpt_free_asym_session_parameters(struct cpt_asym_sess_misc *sess) > +{ > + struct rte_crypto_modex_xform *mod; > + struct rte_crypto_rsa_xform *rsa; > + > + switch (sess->xfrm_type) { > + case RTE_CRYPTO_ASYM_XFORM_RSA: > + rsa =3D &sess->rsa_ctx; > + if (rsa->n.data) > + rte_free(rsa->n.data); > + break; > + case RTE_CRYPTO_ASYM_XFORM_MODEX: > + mod =3D &sess->mod_ctx; > + if (mod->modulus.data) > + rte_free(mod->modulus.data); > + break; > + default: > + break; Do we need an error print here? > + } > +} > +