From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 7D4F0A0471 for ; Fri, 21 Jun 2019 14:23:02 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 598B81D5C3; Fri, 21 Jun 2019 14:23:01 +0200 (CEST) Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-eopbgr30080.outbound.protection.outlook.com [40.107.3.80]) by dpdk.org (Postfix) with ESMTP id 925621D5BF for ; Fri, 21 Jun 2019 14:23:00 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xYEluck0icIBB6iIkI6b4nHbNkbaRtbcYlKChu3SGlw=; b=OJOMtjxKc9euP43xAHP4O008RelhDgTWRUzSBWasbv5gwdVRL5F7O1wBwAPtiqxpqcLzHfS558XMEwR3YjsxFjXiTA8yb9yZ4OBcnEIf+t7V/yMVVn6D67DsXLKdccdcdCJNoKoiV/2FOoLoWoLeCDVnnND03NytPGZb4IL7zhI= Received: from VE1PR04MB6639.eurprd04.prod.outlook.com (20.179.235.82) by VE1PR04MB6640.eurprd04.prod.outlook.com (20.179.235.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2008.13; Fri, 21 Jun 2019 12:22:59 +0000 Received: from VE1PR04MB6639.eurprd04.prod.outlook.com ([fe80::a929:3d03:7bb7:d5e0]) by VE1PR04MB6639.eurprd04.prod.outlook.com ([fe80::a929:3d03:7bb7:d5e0%7]) with mapi id 15.20.1987.014; Fri, 21 Jun 2019 12:22:59 +0000 From: Akhil Goyal To: "Trahe, Fiona" , "Kusztal, ArkadiuszX" , "dev@dpdk.org" , "shally.verma@caviumnetworks.com" Thread-Topic: [PATCH] cryptodev: extend api of asymmetric crypto by sessionless Thread-Index: AQHVGkUG0vP5A2eKj0yqcmlq0uC1qKaksP4AgAFr3ICAAAMyUA== Date: Fri, 21 Jun 2019 12:22:59 +0000 Message-ID: References: <20190603194411.8352-1-arkadiuszx.kusztal@intel.com> <348A99DA5F5B7549AA880327E580B435897A26ED@IRSMSX101.ger.corp.intel.com> In-Reply-To: <348A99DA5F5B7549AA880327E580B435897A26ED@IRSMSX101.ger.corp.intel.com> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=akhil.goyal@nxp.com; x-originating-ip: [92.120.1.65] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e48aaf1a-53ef-4f28-f9e0-08d6f64332cf x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020); SRVR:VE1PR04MB6640; x-ms-traffictypediagnostic: VE1PR04MB6640: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-forefront-prvs: 0075CB064E x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(346002)(136003)(376002)(39860400002)(366004)(396003)(189003)(13464003)(199004)(486006)(102836004)(66066001)(6506007)(186003)(53546011)(25786009)(99286004)(76176011)(2906002)(7696005)(316002)(26005)(6246003)(6436002)(55016002)(53936002)(9686003)(256004)(14444005)(229853002)(476003)(446003)(11346002)(5660300002)(66446008)(2501003)(44832011)(74316002)(7736002)(305945005)(66946007)(73956011)(71200400001)(110136005)(68736007)(71190400001)(478600001)(76116006)(8936002)(86362001)(6116002)(3846002)(2201001)(81156014)(81166006)(8676002)(33656002)(66556008)(52536014)(14454004)(66476007)(64756008); DIR:OUT; SFP:1101; SCL:1; SRVR:VE1PR04MB6640; H:VE1PR04MB6639.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: sq1gokcKgyzOtYK1lDKNJOpiphKyikmdxU57sa6fUbSnpacUhQ4AnL/qxVLtnzZ//asCVmtGMlzpcUlG8Tx50B/b22hAgrONX4Z1KvIO7eQW51DD5Ro8Fexi/yTTx+xOXx5dNBdUKdGugLrmZbmR4J/NuTqtCE4lDWPLP2H4TEoeB5PFhxpzijXR9ZuxTiBukpv9D3l3q6WR7/foXS2RbnxY6xGm1vXyIPV30BPSqhBsqrMRo0/Hk6BUyrHhRcnOU8bxhMD2pRNOYgc6Hyp6Pxz16Qoty49q3kqFwq3dsnGbYyr7d3O0O3R9DXqEcdGlrcR4Ngj0gyGrrjZJPgxV4nr/ZYfBRAZI7Kr6kqqwf8dFVLgcLX3NAxrvH99WTy7M59WsJrRLtv2XMVRFdLEkgtXqtXR9I+F4LS4nUhRU3pU= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: e48aaf1a-53ef-4f28-f9e0-08d6f64332cf X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Jun 2019 12:22:59.3647 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: akhil.goyal@nxp.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6640 Subject: Re: [dpdk-dev] [PATCH] cryptodev: extend api of asymmetric crypto by sessionless X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Fiona, >=20 > Hi Akhil, Arek, Shally, >=20 > > -----Original Message----- > > From: Akhil Goyal [mailto:akhil.goyal@nxp.com] > > Sent: Thursday, June 20, 2019 3:17 PM > > To: Kusztal, ArkadiuszX ; dev@dpdk.org > > Cc: Trahe, Fiona ; > shally.verma@caviumnetworks.com > > Subject: RE: [PATCH] cryptodev: extend api of asymmetric crypto by > sessionless > > > > > > Asymmetric cryptography algorithms may more likely use > > > sessionless API so there is need to extend API. > > > > > > Signed-off-by: Arek Kusztal > > > --- > > Acked-by: Akhil Goyal >=20 > [Fiona] The code is ok but I think a little more is needed. > As all PMDs don't support sessionless, this needs to be handled as an opt= ional > capability. > And in future some PMDs may only support SESSIONLESS and some only suppor= t > WITH_SESSION. I believe this holds true for symmetric crypto as well. But adding a featur= e flag for everything may beat the purpose Of adding a feature flag. Sessionless crypto operations in symmetric crypto= is being used without any issue for a long And nobody feel the need of that as of today. So my question is how asymmet= ric crypto pmds are different that they=20 Need feature flag? If the driver does not support sessionless, then it may give an error while= creating it. I don't think that is an issue. It is Already being handled in the rte_crypto_op by an enum which denote that the= 'op' need to be processed with some Session or with xform. > So I propose adding 2 feature flags to the API > RTE_CRYPTODEV_FF_ASYM_WTH_SESSION > RTE_CRYPTODEV_FF_ASYM_SESSIONLESS > and including in this patch the PMD and UT changes to set and test the fi= rst flag. > We'll follow up with SESSIONLESS QAT implementation and UTs in a separate > patchset. >=20 > Also documentation updates should go with this API patch, i.e. > - update section 16.7.2 in the cryptodev programmers guide - and review = that > doc in case other sections need updating. Yes this needs to be updated if the implementation is complete and we have = some PMD supporting that. > - fix comment in rte_crypto.h under STATUS_INVALID_SESSION > - release note >=20 >=20 -Akhil