From: Akhil Goyal <akhil.goyal@nxp.com>
To: Bruce Richardson <bruce.richardson@intel.com>,
Thierry Herbelot <thierry.herbelot@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, Anoob Joseph <anoobj@marvell.com>
Subject: Re: [dpdk-dev] drivers/octeontx2: compilation fails without RTE_LIBRTE_SECURITY
Date: Thu, 6 Feb 2020 14:54:35 +0000 [thread overview]
Message-ID: <VE1PR04MB6639258DC50D15B727BAE718E61D0@VE1PR04MB6639.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <20200206142749.GA777@bricha3-MOBL.ger.corp.intel.com>
Hi Bruce/Thierry,
> On Thu, Feb 06, 2020 at 02:39:28PM +0100, Thierry Herbelot wrote:
> > Hello,
> >
> > When RTE_LIBRTE_SECURITY is disabled, compilation fails for octeontx2 (on
> an
> > Intel machine):
> >
> > git clone git://dpdk.org/dpdk
> > cd dpdk
> > make config T=x86_64-native-linux-gcc
> > cd build
> > vi .config
> > => disable RTE_LIBRTE_IPSEC and RTE_LIBRTE_SECURITY
> > make
> > ...
> > == Build drivers/net/octeontx2
> > CC otx2_rx.o
> > In file included from .../dpdk/drivers/net/octeontx2/otx2_ethdev_sec.h:10,
> > from .../dpdk/drivers/net/octeontx2/otx2_rx.h:11,
> > from .../dpdk/drivers/net/octeontx2/otx2_ethdev.h:24,
> > from .../dpdk/drivers/net/octeontx2/otx2_rx.c:7:
> > .../dpdk/drivers/crypto/octeontx2/otx2_ipsec_fp.h:9:10: fatal error:
> > rte_security.h: No such file or directory
> > #include <rte_security.h>
> > ^~~~~~~~~~~~~~~~
> > compilation terminated.
> >
> > This seems cause by f44e7163775537 ('net/octeontx2: add security session
> > operations').
> >
> Disabling parts of the build, particularly libraries, is always likely to
> cause other build failures. I'm not sure we should, or even need to,
> support the disabling of arbitrary libs in DPDK.
>
This was followed in the past when rte_security was experimental
And we made sure that compilation should work even after disabling the
Lib. Now since the lib has been removed with the experimental tag, shall we
Follow the same in future as well. It depends on the community and the users
Of the code. If there is a valid use case, we can continue test compilation without
Rte_security.
-Akhil
prev parent reply other threads:[~2020-02-06 14:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-06 13:39 Thierry Herbelot
2020-02-06 14:27 ` Bruce Richardson
2020-02-06 14:36 ` Thierry Herbelot
2020-02-06 14:48 ` Jerin Jacob
2020-02-06 14:56 ` Thierry Herbelot
2020-02-06 15:06 ` Jerin Jacob
2020-02-06 15:18 ` Thierry Herbelot
2020-02-06 15:38 ` Jerin Jacob
2020-02-06 14:54 ` Akhil Goyal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VE1PR04MB6639258DC50D15B727BAE718E61D0@VE1PR04MB6639.eurprd04.prod.outlook.com \
--to=akhil.goyal@nxp.com \
--cc=anoobj@marvell.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=thierry.herbelot@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).