DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] examples/ipsec-secgw: fix SHA256-HMAC digest length
@ 2019-11-06  9:53 Akhil Goyal
  2019-11-06 13:17 ` Akhil Goyal
  0 siblings, 1 reply; 2+ messages in thread
From: Akhil Goyal @ 2019-11-06  9:53 UTC (permalink / raw)
  To: dev; +Cc: stable, konstantin.ananyev, radu.nicolau, Vakul Garg

From: Vakul Garg <vakul.garg@nxp.com>

As per RFC4868, SHA-256 should use 128 bits of ICV.
Fixes: b5350285ce6e ("examples/ipsec-secgw: support SHA256 HMAC")
Cc: stable@dpdk.org

Signed-off-by: Vakul Garg <vakul.garg@nxp.com>
Acked-by: Akhil Goyal <akhil.goyal@nxp.com>
---
 examples/ipsec-secgw/sa.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/examples/ipsec-secgw/sa.c b/examples/ipsec-secgw/sa.c
index 4cb90857c..d0ae8ac9a 100644
--- a/examples/ipsec-secgw/sa.c
+++ b/examples/ipsec-secgw/sa.c
@@ -115,7 +115,7 @@ const struct supported_auth_algo auth_algos[] = {
 	{
 		.keyword = "sha256-hmac",
 		.algo = RTE_CRYPTO_AUTH_SHA256_HMAC,
-		.digest_len = 12,
+		.digest_len = 16,
 		.key_len = 32
 	}
 };
-- 
2.17.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dpdk-dev] [PATCH] examples/ipsec-secgw: fix SHA256-HMAC digest length
  2019-11-06  9:53 [dpdk-dev] [PATCH] examples/ipsec-secgw: fix SHA256-HMAC digest length Akhil Goyal
@ 2019-11-06 13:17 ` Akhil Goyal
  0 siblings, 0 replies; 2+ messages in thread
From: Akhil Goyal @ 2019-11-06 13:17 UTC (permalink / raw)
  To: Akhil Goyal, dev; +Cc: stable, konstantin.ananyev, radu.nicolau, Vakul Garg


> 
> From: Vakul Garg <vakul.garg@nxp.com>
> 
> As per RFC4868, SHA-256 should use 128 bits of ICV.
> Fixes: b5350285ce6e ("examples/ipsec-secgw: support SHA256 HMAC")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Vakul Garg <vakul.garg@nxp.com>
> Acked-by: Akhil Goyal <akhil.goyal@nxp.com>
> ---
Applied to dpdk-next-crypto



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-11-06 13:17 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-06  9:53 [dpdk-dev] [PATCH] examples/ipsec-secgw: fix SHA256-HMAC digest length Akhil Goyal
2019-11-06 13:17 ` Akhil Goyal

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).