* [dpdk-dev] [PATCH v1 4/6] crypto/ccp: updating ccp crypto capabilities ops
@ 2019-10-15 7:02 asomalap
2019-10-15 11:06 ` Akhil Goyal
0 siblings, 1 reply; 2+ messages in thread
From: asomalap @ 2019-10-15 7:02 UTC (permalink / raw)
To: dev; +Cc: stable
From: Amaranath Somalapuram <asomalap@amd.com>
crypto capabilities ops for ccp initilzed incorrectly.
changing the correct values for the capabilities ops
Cc: stable@dpdk.org
Signed-off-by: Amaranath Somalapuram <asomalap@amd.com>
---
drivers/crypto/ccp/ccp_pmd_ops.c | 44 ++++++++++++++++----------------
1 file changed, 22 insertions(+), 22 deletions(-)
diff --git a/drivers/crypto/ccp/ccp_pmd_ops.c b/drivers/crypto/ccp/ccp_pmd_ops.c
index d5041f0ec..768378033 100644
--- a/drivers/crypto/ccp/ccp_pmd_ops.c
+++ b/drivers/crypto/ccp/ccp_pmd_ops.c
@@ -47,7 +47,7 @@
.increment = 1 \
}, \
.digest_size = { \
- .min = 20, \
+ .min = 1, \
.max = 20, \
.increment = 0 \
}, \
@@ -68,9 +68,9 @@
.increment = 0 \
}, \
.digest_size = { \
- .min = 28, \
+ .min = 1, \
.max = 28, \
- .increment = 0 \
+ .increment = 1 \
}, \
.aad_size = { 0 } \
}, } \
@@ -89,9 +89,9 @@
.increment = 1 \
}, \
.digest_size = { \
- .min = 28, \
+ .min = 1, \
.max = 28, \
- .increment = 0 \
+ .increment = 1 \
}, \
.aad_size = { 0 } \
}, } \
@@ -110,9 +110,9 @@
.increment = 0 \
}, \
.digest_size = { \
- .min = 28, \
+ .min = 1, \
.max = 28, \
- .increment = 0 \
+ .increment = 1 \
}, \
.aad_size = { 0 } \
}, } \
@@ -131,9 +131,9 @@
.increment = 1 \
}, \
.digest_size = { \
- .min = 28, \
+ .min = 1, \
.max = 28, \
- .increment = 0 \
+ .increment = 1 \
}, \
.aad_size = { 0 } \
}, } \
@@ -173,9 +173,9 @@
.increment = 1 \
}, \
.digest_size = { \
- .min = 32, \
+ .min = 1, \
.max = 32, \
- .increment = 0 \
+ .increment = 1 \
}, \
.aad_size = { 0 } \
}, } \
@@ -215,9 +215,9 @@
.increment = 1 \
}, \
.digest_size = { \
- .min = 32, \
+ .min = 1, \
.max = 32, \
- .increment = 0 \
+ .increment = 1 \
}, \
.aad_size = { 0 } \
}, } \
@@ -257,9 +257,9 @@
.increment = 1 \
}, \
.digest_size = { \
- .min = 48, \
+ .min = 1, \
.max = 48, \
- .increment = 0 \
+ .increment = 1 \
}, \
.aad_size = { 0 } \
}, } \
@@ -299,9 +299,9 @@
.increment = 1 \
}, \
.digest_size = { \
- .min = 48, \
+ .min = 1, \
.max = 48, \
- .increment = 0 \
+ .increment = 1 \
}, \
.aad_size = { 0 } \
}, } \
@@ -341,9 +341,9 @@
.increment = 1 \
}, \
.digest_size = { \
- .min = 64, \
+ .min = 1, \
.max = 64, \
- .increment = 0 \
+ .increment = 1 \
}, \
.aad_size = { 0 } \
}, } \
@@ -383,9 +383,9 @@
.increment = 1 \
}, \
.digest_size = { \
- .min = 64, \
+ .min = 1, \
.max = 64, \
- .increment = 0 \
+ .increment = 1 \
}, \
.aad_size = { 0 } \
}, } \
@@ -536,7 +536,7 @@
.increment = 1 \
}, \
.digest_size = { \
- .min = 16, \
+ .min = 1, \
.max = 16, \
.increment = 0 \
}, \
--
2.17.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [dpdk-dev] [PATCH v1 4/6] crypto/ccp: updating ccp crypto capabilities ops
2019-10-15 7:02 [dpdk-dev] [PATCH v1 4/6] crypto/ccp: updating ccp crypto capabilities ops asomalap
@ 2019-10-15 11:06 ` Akhil Goyal
0 siblings, 0 replies; 2+ messages in thread
From: Akhil Goyal @ 2019-10-15 11:06 UTC (permalink / raw)
To: asomalap, dev; +Cc: stable
Title: crypto/ccp: fix capabilities for digest size
>
> From: Amaranath Somalapuram <asomalap@amd.com>
>
> crypto capabilities ops for ccp initilzed incorrectly.
> changing the correct values for the capabilities ops
You are changing digest size only in this patch.
You can rephrase this as:
CCP can support varied digest sizes ranging from 1 to some max value
But the current code support only fixed max values.
This patch updates the minimum digest sizes to 1.
Also a Fixes line is missing
> Cc: stable@dpdk.org
>
> Signed-off-by: Amaranath Somalapuram <asomalap@amd.com>
> ---
> drivers/crypto/ccp/ccp_pmd_ops.c | 44 ++++++++++++++++----------------
> 1 file changed, 22 insertions(+), 22 deletions(-)
>
> diff --git a/drivers/crypto/ccp/ccp_pmd_ops.c
> b/drivers/crypto/ccp/ccp_pmd_ops.c
> index d5041f0ec..768378033 100644
> --- a/drivers/crypto/ccp/ccp_pmd_ops.c
> +++ b/drivers/crypto/ccp/ccp_pmd_ops.c
> @@ -47,7 +47,7 @@
> .increment = 1 \
> }, \
> .digest_size = { \
> - .min = 20, \
> + .min = 1, \
> .max = 20, \
> .increment = 0 \
> }, \
> @@ -68,9 +68,9 @@
> .increment = 0 \
> }, \
> .digest_size = { \
> - .min = 28, \
> + .min = 1, \
> .max = 28, \
> - .increment = 0 \
> + .increment = 1 \
> }, \
> .aad_size = { 0 } \
> }, } \
> @@ -89,9 +89,9 @@
> .increment = 1 \
> }, \
> .digest_size = { \
> - .min = 28, \
> + .min = 1, \
> .max = 28, \
> - .increment = 0 \
> + .increment = 1 \
> }, \
> .aad_size = { 0 } \
> }, } \
> @@ -110,9 +110,9 @@
> .increment = 0 \
> }, \
> .digest_size = { \
> - .min = 28, \
> + .min = 1, \
> .max = 28, \
> - .increment = 0 \
> + .increment = 1 \
> }, \
> .aad_size = { 0 } \
> }, } \
> @@ -131,9 +131,9 @@
> .increment = 1 \
> }, \
> .digest_size = { \
> - .min = 28, \
> + .min = 1, \
> .max = 28, \
> - .increment = 0 \
> + .increment = 1 \
> }, \
> .aad_size = { 0 } \
> }, } \
> @@ -173,9 +173,9 @@
> .increment = 1 \
> }, \
> .digest_size = { \
> - .min = 32, \
> + .min = 1, \
> .max = 32, \
> - .increment = 0 \
> + .increment = 1 \
> }, \
> .aad_size = { 0 } \
> }, } \
> @@ -215,9 +215,9 @@
> .increment = 1 \
> }, \
> .digest_size = { \
> - .min = 32, \
> + .min = 1, \
> .max = 32, \
> - .increment = 0 \
> + .increment = 1 \
> }, \
> .aad_size = { 0 } \
> }, } \
> @@ -257,9 +257,9 @@
> .increment = 1 \
> }, \
> .digest_size = { \
> - .min = 48, \
> + .min = 1, \
> .max = 48, \
> - .increment = 0 \
> + .increment = 1 \
> }, \
> .aad_size = { 0 } \
> }, } \
> @@ -299,9 +299,9 @@
> .increment = 1 \
> }, \
> .digest_size = { \
> - .min = 48, \
> + .min = 1, \
> .max = 48, \
> - .increment = 0 \
> + .increment = 1 \
> }, \
> .aad_size = { 0 } \
> }, } \
> @@ -341,9 +341,9 @@
> .increment = 1 \
> }, \
> .digest_size = { \
> - .min = 64, \
> + .min = 1, \
> .max = 64, \
> - .increment = 0 \
> + .increment = 1 \
> }, \
> .aad_size = { 0 } \
> }, } \
> @@ -383,9 +383,9 @@
> .increment = 1 \
> }, \
> .digest_size = { \
> - .min = 64, \
> + .min = 1, \
> .max = 64, \
> - .increment = 0 \
> + .increment = 1 \
> }, \
> .aad_size = { 0 } \
> }, } \
> @@ -536,7 +536,7 @@
> .increment = 1 \
> }, \
> .digest_size = { \
> - .min = 16, \
> + .min = 1, \
> .max = 16, \
> .increment = 0 \
> }, \
> --
> 2.17.1
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-10-15 11:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-15 7:02 [dpdk-dev] [PATCH v1 4/6] crypto/ccp: updating ccp crypto capabilities ops asomalap
2019-10-15 11:06 ` Akhil Goyal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).