Re: [dpdk-dev] [PATCH v2] cryptodev: clarify wireless inputs in digest-encrypted cases

[Akhil Goyal <akhil.goyal@nxp.com>]

> 
> Clarify constraints on fields specified in bits for wireless
> algorithms in digest-encrypted case.
> 
> v2 changes:
>  - added note on each of the affected parameter fields
> 
> Signed-off-by: Fiona Trahe <fiona.trahe@intel.com>
> ---
>  lib/librte_cryptodev/rte_crypto_sym.h |   23 +++++++++++++++++++----
>  1 files changed, 19 insertions(+), 4 deletions(-)
> 
//snip//

> @@ -703,6 +711,13 @@ struct rte_crypto_sym_op {
>  					 * auth.data.length and is typically
>  					 * equal to auth.data.offset +
>  					 * auth.data.length + digest_length.
> +					 * - for wireless algorithms, i.e.
> +					 * SNOW 3G, KASUMI and ZUC, as the
> +					 * cipher.data.length,
> +					 * cipher.data.offset,
> +					 * auth.data.length and
> +					 * auth.data.offset are in bits, they
> +					 * must be 8-bit multiples.

Why do you need this change? This is redundant information.
>  					 *
>  					 * Note, that for security reasons, it
>  					 * is PMDs' responsibility to not
> --
> 1.7.0.7