From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7A943A0528; Mon, 20 Jan 2020 11:02:10 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4F2D32C2B; Mon, 20 Jan 2020 11:02:09 +0100 (CET) Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00057.outbound.protection.outlook.com [40.107.0.57]) by dpdk.org (Postfix) with ESMTP id 83C162C23 for ; Mon, 20 Jan 2020 11:02:07 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HJAO/Ko5gijPbnguy4P9kpb3fWWZuKWptqnLnlMbeGvn7DyP6xBWj5wCVHA6y7jzL5FDfOh55IP0oX0n/v7tI2o6VXxqO2LNlSjDDv1P0Wo86/yFoidVcOhMnUQazYTOXtOo/9Mbi6vaQSTTR49kkpuKzNMr77AlXt2k7GO9v3yZMvD1xyVKCZd127M4c8C0y0A0eQUvE4HUbcBX7oOs20SUGxiTFvc4ZMwHyz9yKLEwGd13plBIdUqDF820H00xwfMkKQctMiIZPsL8EjPnscfY8R5eCBmyRAP2AXrR7OL3mr9UL51zExIrHEKJS/MpLUJsAhVaRaavkjA+U/3pkA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZGYk/IM0wNCSJLf8mFhGBtkDE6XXD0Pr9iF2m1wp06s=; b=Ix5uX9K3lEeOaHXk8Y+72ZYTp/ShLsZnnim+nFWghYuccqSFkq2ZJfSf3n+12Q+uYJEe6CVY/KwvxpC+5hgtaT7UrM51Kc+PvcrJ7f7k4y5mNqKrTQDfLK5akn4HuMw9WPIIgYw1omhawPMSIi77ZARP0fJYckfFsp3bph0TIRDOzXZuC7DMWSVQYIxCOA0EPQ2kUzxTtlqyvq2ito0b2Na7sIGg79IdA+x+MHVstgEupPT4vCvZm6XFHZv2w1rrG4xieRIYDSgY3X8LpP4DrumJuTI4tfNj4J3mkmcciw0QC+NpEHiW9KjHfu8k7+VVrI3yLkFXFOIqOGsEj8iG3A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZGYk/IM0wNCSJLf8mFhGBtkDE6XXD0Pr9iF2m1wp06s=; b=CM+BDwCgVqNB0TpWyaKQXIrvLWFqwVLByUneqZa9F25rQFN7fWdtS15FHkBjUZjw52tmDGyyl3uCyubK7qYUkufxIXGUKU53hqx7QLm9mcUmz0S2AHjEX5DLK3c11hOAVlJJajZ2he5FXIhxS401LFuqPXxD+H8T0x5UkVh18eQ= Received: from VE1PR04MB6639.eurprd04.prod.outlook.com (10.255.118.11) by VE1PR04MB6608.eurprd04.prod.outlook.com (20.179.235.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2644.18; Mon, 20 Jan 2020 10:02:06 +0000 Received: from VE1PR04MB6639.eurprd04.prod.outlook.com ([fe80::25b0:b1ac:aed0:63e1]) by VE1PR04MB6639.eurprd04.prod.outlook.com ([fe80::25b0:b1ac:aed0:63e1%7]) with mapi id 15.20.2644.024; Mon, 20 Jan 2020 10:02:06 +0000 From: Akhil Goyal To: Adam Dybkowski , "dev@dpdk.org" , "fiona.trahe@intel.com" Thread-Topic: [PATCH v6 0/3] Refactor crypto unit tests. Thread-Index: AQHVzUT4gNpAQP521EShvyMdgik6GKfzVn9g Date: Mon, 20 Jan 2020 10:02:06 +0000 Message-ID: References: <20200116124232.22282-1-adamx.dybkowski@intel.com> <20200117144651.26804-1-adamx.dybkowski@intel.com> In-Reply-To: <20200117144651.26804-1-adamx.dybkowski@intel.com> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=akhil.goyal@nxp.com; x-originating-ip: [92.120.1.66] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 555e4deb-73fd-479a-c12a-08d79d8fce91 x-ms-traffictypediagnostic: VE1PR04MB6608: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2449; x-forefront-prvs: 0288CD37D9 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(366004)(39860400002)(136003)(346002)(396003)(376002)(199004)(189003)(2906002)(76116006)(64756008)(66446008)(66476007)(66556008)(66946007)(52536014)(33656002)(86362001)(7696005)(110136005)(5660300002)(9686003)(8676002)(186003)(81166006)(26005)(55016002)(316002)(478600001)(6506007)(44832011)(71200400001)(81156014)(8936002); DIR:OUT; SFP:1101; SCL:1; SRVR:VE1PR04MB6608; H:VE1PR04MB6639.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: B//u2TIVg5PbUCQvrYnfjZKEl44IPIWVD3sU/YHQWJES5qeh8PDr7H8ItTdoiO1wkA9ocaLqURJIrOuX++fAB+rw7rJMv9VDnvRNv2x+M+uCCGgJH/PCAKECHqCFBsR+Kwg4AfOuFvrbKMoqYINx2nvKPeRODPlERbgJfFi0usb8RDL546sXa1OMeE2TX0fykIXRY2au1l/j0JMQskioU8j++g3ASZB8hl7Qx6Zs0Oke0/FKpLQjnH8eruN0yXS+noI8u2xr6SiEt/wo0irZbDVJy+fSXD6tnMGOwamqHw8KsKZndPPo3HMHXCTYp7cHln7JaTddsFVOKinKssW/MXIARAocRmuKPDSslj9pNrQ4Qx0IjbUbWwFJofnFPnUBT/fk7isOTiGQz9cgvpxZ+I+jTEY/vvIeUyDwMNW9NTC5dPzcOZrSRB05NlcgBMqu x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 555e4deb-73fd-479a-c12a-08d79d8fce91 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Jan 2020 10:02:06.6388 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: OJtEoPRNidietIRG1A/VruO6NoSsG7pTMZyjZ4SqNJdQtMCQSQR5SfWd6rPxfgDMop5MeVqAwDpPlab9EMTEJw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6608 Subject: Re: [dpdk-dev] [PATCH v6 0/3] Refactor crypto unit tests. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Adam, >=20 > This patch set is a first step to refactor the overly complex symmetric > crypto unit tests. It merges many separate arrays of the tests > for these PMDs: null, aesni_mb, aesni_gcm, openssl, qat, sw_snow3g, > sw_kasumi, sw_zuc into one big array that's then used when running > unit tests on these PMDs. >=20 > Individual test functions check the capabilities and execute the rest > of the test or skip (return -ENOTSUP) based on the particular test > requirements - e.g. test if PMD supports ZUC algo or even a particular > key length in few cases. Few edge cases required to check the PMD > itself (e.g. run on QAT only, or skip on AES NI / AES GCM). >=20 > It's the first step of bigger refactoring. Maintainers of other PMDs > are encouraged to add their PMD unit tests also into this big central > array and remove individual test macro arrays. >=20 > This patch doesn't address next refactoring steps to be done in the > future: geting rid of many small (usually 1-2 line) test functions, > created separately for every test case; and simplifying many bigger > functions that currently do similar things but work on different > test vector structures. >=20 > A simple script to check if symmetric crypto unit tests work properly > on multiple PMDs at once, update the PMDs list to your needs: >=20 > for PMD in null aesni_mb aesni_gcm openssl qat scheduler sw_snow3g > sw_kasumi sw_zuc > do > echo +++++ $PMD +++++ > echo cryptodev_${PMD}_autotest | build/app/test -c7 -n1 --log-level= =3D7 | grep > ' Tests [Failed|Passed]' > done >=20 > --- > v2: > * Update the cover letter, regenerate the patch file. > v3: > * Break very large commit into four smaller commits, easier to review. > * Show in the cover letter how to run unit tests on multiple PMDs at once= . > v4: > * Rebase. > v5: > * Fix a test failing on SW ZUC PMD. > v6: > * Rebase again, squash first two commits to allow building individual pat= ches. >=20 > Adam Dybkowski (3): > test/crypto: refactor unit tests > test/crypto: add capability checks > test/crypto: refactor unit tests into one combined array >=20 > app/test/test_cryptodev.c | 15975 +++++++++---------- > app/test/test_cryptodev_blockcipher.c | 2 +- > app/test/test_cryptodev_des_test_vectors.h | 6 +- > 3 files changed, 7335 insertions(+), 8648 deletions(-) >=20 > -- > 2.17.1 This patchset is breaking the AES integrity cases.