From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id DC445A0471 for ; Fri, 21 Jun 2019 15:10:23 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 113751D5BB; Fri, 21 Jun 2019 15:10:23 +0200 (CEST) Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-eopbgr50078.outbound.protection.outlook.com [40.107.5.78]) by dpdk.org (Postfix) with ESMTP id D017F1D5B9 for ; Fri, 21 Jun 2019 15:10:21 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VgUsWC88H5uA8RrWOnTyyk/BzkCoe95XyCMeIoziXTw=; b=g2eOHCssswE9ceIQtrpV7ae9r54z5D0bq7YBw99xk61nIxUr3pkOD8zdaUjcrsTnkejYp+MS3h8E4OupkKbH+L3rpRCibzekpjydGyeokUi+IU2vwHkESopY0DSIA1YG9/jRAqIWNaf1a+jhTPC3oa+geOdvZsyi0VNkau5gw8Q= Received: from VE1PR04MB6639.eurprd04.prod.outlook.com (20.179.235.82) by VE1PR04MB6717.eurprd04.prod.outlook.com (20.179.235.206) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1987.13; Fri, 21 Jun 2019 13:10:20 +0000 Received: from VE1PR04MB6639.eurprd04.prod.outlook.com ([fe80::a929:3d03:7bb7:d5e0]) by VE1PR04MB6639.eurprd04.prod.outlook.com ([fe80::a929:3d03:7bb7:d5e0%7]) with mapi id 15.20.1987.014; Fri, 21 Jun 2019 13:10:20 +0000 From: Akhil Goyal To: Anoob Joseph , Declan Doherty , Fiona Trahe , Pablo de Lara , "dev@dpdk.org" CC: Jerin Jacob , Narayana Prasad Thread-Topic: [PATCH] cryptodev: add ff_disable field in cryptodev config Thread-Index: AQHVGiC4iZdkIRDqH0uw6cx0UXNstKamMHEg Date: Fri, 21 Jun 2019 13:10:20 +0000 Message-ID: References: <1559575528-5363-1-git-send-email-anoobj@marvell.com> In-Reply-To: <1559575528-5363-1-git-send-email-anoobj@marvell.com> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=akhil.goyal@nxp.com; x-originating-ip: [92.120.1.65] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 9f819c12-3091-42ca-8621-08d6f649d06b x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020); SRVR:VE1PR04MB6717; x-ms-traffictypediagnostic: VE1PR04MB6717: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7219; x-forefront-prvs: 0075CB064E x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(396003)(39860400002)(366004)(346002)(136003)(376002)(189003)(199004)(44832011)(9686003)(86362001)(73956011)(2906002)(74316002)(478600001)(4326008)(7736002)(52536014)(305945005)(25786009)(64756008)(71190400001)(5660300002)(71200400001)(33656002)(6246003)(256004)(66556008)(66446008)(6506007)(66066001)(66476007)(68736007)(99286004)(54906003)(66946007)(6436002)(476003)(7696005)(110136005)(3846002)(76116006)(81166006)(55016002)(229853002)(446003)(14454004)(8676002)(81156014)(53936002)(2501003)(8936002)(26005)(186003)(76176011)(486006)(316002)(102836004)(6116002)(11346002); DIR:OUT; SFP:1101; SCL:1; SRVR:VE1PR04MB6717; H:VE1PR04MB6639.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: uMP3w2A9jpfMvDLi/7ZKxJtae66MKHjk7mpDoucep1AXT0PHytuy2CNmyXG2ptBK1PT/4RAXnCgTgQYAWKcYBR424fDELnUQnP5+4yFTYLfSc+vwSGCmRhNHZWTyZ7GjnJI0j1d4+tiT1q27DFVFxmzXwKKaBOdLRqTGs4xc7QZrGzQ831JbqhE0NzHWkxGiicH5MB6BbFv6gQUFWYEit2CEJht2bxF7CtURrUKI6Elwcr3rRT2PxG+LY9MGaHuSZMvo4hlTnNQ1bE8NtvBTHycQ9CSsqil5hZNWp6SAosJL61ES+Ll1WHW4A8RlaGG6PTHOGN8VdBCfGJf78gXqeNcjj84q1OZvwr9ycweeFHs+qdN3yteThlOsIm+/VAvrFXhuF8Stt4EiVM3C7XQ5AzduOELK/Gh0YstEkZLiURA= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9f819c12-3091-42ca-8621-08d6f649d06b X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Jun 2019 13:10:20.7527 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: akhil.goyal@nxp.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6717 Subject: Re: [dpdk-dev] [PATCH] cryptodev: add ff_disable field in cryptodev config X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Anoob, >=20 > Adding a new field, ff_disable, to allow applications to control the > features enabled on the crypto device. This would allow for efficient > usage of HW/SW offloads by disabling the features not required by the > application. >=20 > Signed-off-by: Anoob Joseph I see a compilation issue with this change.=20 /home/akhil/up/dpdk-next-crypto/examples/fips_validation/fips_dev_self_test= .c: In function 'fips_dev_auto_test_init': /home/akhil/up/dpdk-next-crypto/examples/fips_validation/fips_dev_self_test= .c:1560:9: error: missing initializer for field 'ff_disable' of 'struct rte= _cryptodev_config' [-Werror=3Dmissing-field-initializers] struct rte_cryptodev_config conf =3D {rte_cryptodev_socket_id(dev_id), 1}= ; ^~~~~~~~~~~~~~~~~~~~ In file included from /home/akhil/up/dpdk-next-crypto/examples/fips_validat= ion/fips_dev_self_test.c:5:0: /home/akhil/up/dpdk-next-crypto/arm64-dpaa-linuxapp-gcc/include/rte_cryptod= ev.h:615:11: note: 'ff_disable' declared here uint64_t ff_disable; ^~~~~~~~~~ Please add a patch for all applications which use struct rte_cryptodev_conf= ig and set the default values of its parameters. > --- > doc/guides/rel_notes/deprecation.rst | 14 -------------- > doc/guides/rel_notes/release_19_08.rst | 11 ++++++++++- > lib/librte_cryptodev/Makefile | 2 +- > lib/librte_cryptodev/meson.build | 2 +- > lib/librte_cryptodev/rte_cryptodev.h | 7 +++++++ > 5 files changed, 19 insertions(+), 17 deletions(-) >=20