From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 41FE2A328D for ; Tue, 22 Oct 2019 13:48:50 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 71A111BEB8; Tue, 22 Oct 2019 13:48:49 +0200 (CEST) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80074.outbound.protection.outlook.com [40.107.8.74]) by dpdk.org (Postfix) with ESMTP id 65E941BEB4 for ; Tue, 22 Oct 2019 13:48:47 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=U4kSQaRcQall0ocltIehurAKY00nNeG03qk3qcPbjN5hwr9zhttQfmYswLhQlwoowotLRLbvad2FA0u/gNRbErBtye5j9ZGtq8Wx3YSSWcexv8Dtw8IxVoZUmn4PKWrHH0MvhRSzer0KXBTTsHulA/8DZ1j9NgevSb+l5M7nlkzzGWuaaJX+OukoAX9Tri7cwOvKsg9wWOkFySxiG9lskFhedkHHhhtmZU4ySQOsMqydoMbR9MhxlwE6lTZ9DKKIOQc0oz2R7hBwNdzhQC/opYKLP0FtMch1KJ2SI56w85RAkQvhQaqKv0LrLSkbDJErMz+yu74zO/baZIlJ55fuJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Mb2MTcAKgCnrZETxxLkhyALJv8WJ5VkYC7J1NxOifEA=; b=PXZYnxCVBx+jFe/qchgKr15hanCxtuO7wZHotQA1UaSkj8ionK0MXM80KH9RvElm8LhVjX3TomwFQ8SDJT+iKvTMq8D+eW7/gnNRz0AZUtPz3U57q6xqAOf4SlrLsK/iY77ySPT0HpFSCH+KaloUmWfmX1vDjIBlWJxDsY3W+jr7I4c9ud7l7gHcW72WGvqrb3QULBnD/I84nD7+CHZxccML5xg/MuBG4Ion75FZZLqttz/NzvnS/PzuHwcOiCXIfWnlLF5kOayNsM1IzIfeeTzFIPwSsNx/AGwSwgJJHyl3u4YTf4wGbTp90iR18NzWup7LLNxftwWtq79OBwdlZQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Mb2MTcAKgCnrZETxxLkhyALJv8WJ5VkYC7J1NxOifEA=; b=OHFDWfjt9NrJPhZg7IzjWmh6zB+MeOm7Gpq+FCTJ0e2IfAI8I2K6En/1X2NcKq8AMvr4eznQQADRsJgVKMo2FfI32pF/ZnAKkEhnWEztnR15GKJqoySyMwoV1ELp6xDPECWaZc1/kDpjrYLF/q0P8I3+Xqra00gwAbUlMWewNMQ= Received: from VE1PR04MB6639.eurprd04.prod.outlook.com (10.255.118.11) by VE1PR04MB6384.eurprd04.prod.outlook.com (20.179.235.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2367.24; Tue, 22 Oct 2019 11:48:46 +0000 Received: from VE1PR04MB6639.eurprd04.prod.outlook.com ([fe80::9dc:aa5c:2bb8:b561]) by VE1PR04MB6639.eurprd04.prod.outlook.com ([fe80::9dc:aa5c:2bb8:b561%6]) with mapi id 15.20.2367.022; Tue, 22 Oct 2019 11:48:46 +0000 From: Akhil Goyal To: Fiona Trahe , "dev@dpdk.org" CC: "arkadiuszx.kusztal@intel.com" , "adamx.dybkowski@intel.com" Thread-Topic: [PATCH] cryptodev: clarify wireless inputs in digest-encrypted cases Thread-Index: AQHViMy2P6rriDFipkOHIvzS90RmUadmiuyw Date: Tue, 22 Oct 2019 11:48:46 +0000 Message-ID: References: <1571744076-7623-1-git-send-email-fiona.trahe@intel.com> In-Reply-To: <1571744076-7623-1-git-send-email-fiona.trahe@intel.com> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=akhil.goyal@nxp.com; x-originating-ip: [92.120.1.65] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: d5ca6011-afe2-4c48-3c3a-08d756e5cc09 x-ms-traffictypediagnostic: VE1PR04MB6384: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-forefront-prvs: 01986AE76B x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(136003)(366004)(376002)(396003)(39860400002)(346002)(189003)(199004)(18543002)(8936002)(14444005)(52536014)(256004)(71200400001)(14454004)(476003)(44832011)(486006)(76176011)(9686003)(478600001)(99286004)(6436002)(25786009)(11346002)(446003)(26005)(3846002)(6116002)(5660300002)(7696005)(8676002)(229853002)(2906002)(71190400001)(186003)(4326008)(81166006)(81156014)(33656002)(2501003)(76116006)(74316002)(66556008)(86362001)(64756008)(66476007)(66446008)(66946007)(6246003)(6506007)(55016002)(66066001)(54906003)(316002)(110136005)(7736002)(102836004)(305945005); DIR:OUT; SFP:1101; SCL:1; SRVR:VE1PR04MB6384; H:VE1PR04MB6639.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: IVoXIm9HxonClaAr1tucNJfrBI9h7SnHj4i7acJV+wEowbVFLP38X1WrukjhS/xwdALalJPx+dXcKhubk8y+h9p1dA15N5ppKQHiKosne42bqGj8nttJpaB2bsLfIGEBQespZw4ViNqmEwEDXLInMe3/rIXBEw8lLYPnafjWCHuHJQPlEmJtgSlkMIsev7/sXjOGod/lQG2Q3JhDKtxj5GvjrVaOfW9d7lWXD4/P2hLmzgQOz22IGenb/cNwU+BfdetRFXnUAREEvhARn9dx08o5ezk3QAQxDtJNufrhEd8fTfGX2O2EYNYkSH8WLCTbAISZReaWxdqLsc43Sp/j/B/T2BSB++bDXDG95/Kp80Twv5RXiNNASmjhw2w8LjtliiRHJf+Uiel4Ual8zmhcTSSshkzZu7cEDA1jFIhKB1RUWYVq6SM+WMV6ZP+t5i6V x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: d5ca6011-afe2-4c48-3c3a-08d756e5cc09 X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Oct 2019 11:48:46.4922 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: tqVYuG+N+GLPulsPYsXh2y6vikLGK1o9eP0G89YX8h6rYnO31y4nqaPd4XnMGlR/8usKYTDtEkZ0Mpfv6JMivw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6384 Subject: Re: [dpdk-dev] [PATCH] cryptodev: clarify wireless inputs in digest-encrypted cases X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Fiona, >=20 > Clarify constraints on fields specified in bits for wireless > algorithms in digest-encrypted case. >=20 > Signed-off-by: Fiona Trahe > --- > lib/librte_cryptodev/rte_crypto_sym.h | 7 +++++++ > 1 files changed, 7 insertions(+), 0 deletions(-) >=20 > diff --git a/lib/librte_cryptodev/rte_crypto_sym.h > b/lib/librte_cryptodev/rte_crypto_sym.h > index bc8da24..0204d37 100644 > --- a/lib/librte_cryptodev/rte_crypto_sym.h > +++ b/lib/librte_cryptodev/rte_crypto_sym.h > @@ -703,6 +703,13 @@ struct rte_crypto_sym_op { > * auth.data.length and is typically > * equal to auth.data.offset + > * auth.data.length + digest_length. > + * - for wireless algorithms, i.e. > + * SNOW 3G, KASUMI and ZUC, as the > + * cipher.data.length, > + * cipher.data.offset, > + * auth.data.length and > + * auth.data.offset are in bits, they > + * must be 8-bit multiples. What is the meaning of 'they' here?=20 cipher.data.length, cipher.data.offset, auth.data.length and auth.data.offs= et are in bits and may or may not be multiple of 8bits. This is documented in their commen= ts. > * > * Note, that for security reasons, it > * is PMDs' responsibility to not > -- > 1.7.0.7