From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 61B9DA0487 for ; Wed, 3 Jul 2019 12:18:17 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 307621B942; Wed, 3 Jul 2019 12:18:17 +0200 (CEST) Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-eopbgr140073.outbound.protection.outlook.com [40.107.14.73]) by dpdk.org (Postfix) with ESMTP id 3F7D21B203; Wed, 3 Jul 2019 12:18:15 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aXoLJ0Ijq4UpyDsDGKuYj7JMumiSgWPjIK7LD1BkkFk=; b=PcLhE67kYJD2RUmJxqZv9JjpaEvrRmLJglV1rbJWPtQ2xZqqkeLNegCg2C74cYG/vR3ZU/hbiYPgDeVjWArJ5DRFrdpm0tAMwUrXg45lAOqlHCxD4BORIAffsc9ZbV105USvU0eUMgjKCwsgSyoYv1dmZgTY+St3T7w696r3RS8= Received: from VE1PR04MB6639.eurprd04.prod.outlook.com (20.179.235.82) by VE1PR04MB6623.eurprd04.prod.outlook.com (20.179.235.29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2032.20; Wed, 3 Jul 2019 10:18:11 +0000 Received: from VE1PR04MB6639.eurprd04.prod.outlook.com ([fe80::a929:3d03:7bb7:d5e0]) by VE1PR04MB6639.eurprd04.prod.outlook.com ([fe80::a929:3d03:7bb7:d5e0%7]) with mapi id 15.20.2032.019; Wed, 3 Jul 2019 10:18:11 +0000 From: Akhil Goyal To: "Iremonger, Bernard" , "Ananyev, Konstantin" , "dev@dpdk.org" CC: "stable@dpdk.org" Thread-Topic: [PATCH v6 1/2] examples/ipsec-secgw: fix 1st pkt dropped for inline crypto Thread-Index: AQHVIS5r8sG9YVSumkyzkOG5VMHLPqaZhjuAgB9EOiCAAAMMAIAAACwA Date: Wed, 3 Jul 2019 10:18:11 +0000 Message-ID: References: <1559819547-20742-1-git-send-email-bernard.iremonger@intel.com> <1560351121-21234-2-git-send-email-bernard.iremonger@intel.com> <2601191342CEEE43887BDE71AB97725801688E4E2C@IRSMSX104.ger.corp.intel.com> <8CEF83825BEC744B83065625E567D7C260DC128E@IRSMSX108.ger.corp.intel.com> In-Reply-To: <8CEF83825BEC744B83065625E567D7C260DC128E@IRSMSX108.ger.corp.intel.com> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=akhil.goyal@nxp.com; x-originating-ip: [92.120.1.65] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 521af5c8-0675-42e1-ca05-08d6ff9fc09b x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020); SRVR:VE1PR04MB6623; x-ms-traffictypediagnostic: VE1PR04MB6623: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-forefront-prvs: 00872B689F x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(366004)(376002)(136003)(346002)(396003)(39860400002)(199004)(189003)(25786009)(44832011)(4326008)(99286004)(9686003)(256004)(26005)(14444005)(102836004)(6506007)(3846002)(186003)(6116002)(14454004)(446003)(229853002)(6436002)(66476007)(476003)(11346002)(66066001)(64756008)(66446008)(66556008)(76116006)(71200400001)(2501003)(71190400001)(76176011)(316002)(73956011)(66946007)(33656002)(55016002)(7696005)(486006)(5660300002)(81166006)(86362001)(52536014)(8936002)(6246003)(110136005)(305945005)(2906002)(7736002)(478600001)(74316002)(8676002)(53936002)(81156014)(68736007); DIR:OUT; SFP:1101; SCL:1; SRVR:VE1PR04MB6623; H:VE1PR04MB6639.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: 6YyenDtsFRy13n6NVkXWljGW+tnQH3IC/FFCXCM7rCjD5Y2tiB3ANhuota5Pjvru0YepO37wJ3ksQ60j/GuAMuG9s531GWngI2qKY/EPWUjiYUyqgtCt84yY16N+wYekSuPqgp/R0kh1G4aQW5JwVYP47EJ3LM6R3Sry/eMNfTRAxSr55TrpfbWEWzb3fFsv4nlutWD9yWfS12zb5xODkMSZBLgCiOu4UXSvtEBmHhlTNN5fUdlLgVShl50FZK8r596Ig5HMgs9/YOoOZ/TifmT6SWCbcu45ZeAYajZ2lRYi5anZE/SLqdm/eWiUrKvWsX9Fx5Gw6uVQ9b8zllOafKyA0/B5Qe6dQq81SB+FLDFXaY3rMiXMZ/yyPZYzukgnZEbcnF7vCOEaaIft8B6NIUll7ROZUPVoNGaUWfI+ZRg= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 521af5c8-0675-42e1-ca05-08d6ff9fc09b X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Jul 2019 10:18:11.4482 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: akhil.goyal@nxp.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6623 Subject: Re: [dpdk-dev] [PATCH v6 1/2] examples/ipsec-secgw: fix 1st pkt dropped for inline crypto X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" >=20 > Hi Akhil, >=20 > > > > Hi Bernard, > > > > > > > > > > Inline crypto installs a flow rule in the NIC. This flow rule must > > > > be installed before the first inbound packet is received. > > > > > > > > The create_session() function installs the flow rule, > > > > create_session() has been refactored into create_inline_session() > > > > and create_lookaside_session(). The create_inline_session() functio= n > > > > uses the socket_ctx data and is now called at initialisation in > > > > sa_add_rules(). > > > > > > > > The max_session_size() function has been added to calculate memory > > > > requirements. > > > > > > > > The cryprodev_init() function has been refactored to drop calls to > > > > rte_mempool_create() and to drop calculation of memory requirements= . > > > > > > > > The main() function has been refactored to call max_session_size() > > > > and to call session_pool_init() and session_priv_pool_init() earlie= r. > > > > The ports are started now before adding a flow rule in main(). > > > > The sa_init(), sp4_init(), sp6_init() and rt_init() functions are > > > > now called after the ports have been started. > > > > > > > > The rte_ipsec_session_prepare() function is called in > > > > fill_ipsec_session() for inline which is called from the ipsec_sa_i= nit() > > function. > > > > > > > > Fixes: ec17993a145a ("examples/ipsec-secgw: support security > > > > offload") > > > > Fixes: d299106e8e31 ("examples/ipsec-secgw: add IPsec sample > > > > application") > > > > Cc: stable@dpdk.org > > > > > > > > Signed-off-by: Bernard Iremonger > > > > --- > > > > > > Acked-by: Konstantin Ananyev > > > Tested-by: Konstantin Ananyev > > > > > > > This patch need to be rebased. > > > > However, I will try to work on your v5 in next few days if I get time. = If I don't > > get time to fix that, will need you to send a rebased version of this p= atch. > > > > Thanks, > > Akhil > > >=20 > v6 is the latest version > I will send a v7 rebased on 19.08.rc1 I was talking about your previous which was for both lookaside and inline c= ases to create sessions at init time. If I get time, I will fix that or will ask you to rebase this one. >=20 > Regards, >=20 > Bernard >=20