From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 494CCA2EDB for ; Tue, 1 Oct 2019 16:11:39 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id F224744C3; Tue, 1 Oct 2019 16:11:38 +0200 (CEST) Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00068.outbound.protection.outlook.com [40.107.0.68]) by dpdk.org (Postfix) with ESMTP id 4D2C437B0 for ; Tue, 1 Oct 2019 16:11:37 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TISvPfl4QtGWfsTcKwbK0qiNaGVktNpDNmdMd3Ge1lhav550LyWwS9bTEqwEuw82qBTKsW9O7mTLBPRyBaN5vzzDOH0OglC+CDtDF49ECvxr/5gHEk1KjsQzJ5fxhmHJbvkw6amnNkrIxo4wkbgC4oULwImKT3bdl55OXYe0jn+3P4w5dsWOymBGmSQXC4zK23h3DIfJmsaKiw487J4mWjEfMGZBxLjK77Eb5asRWN6soxka252WHTsfbJfwVjME/CgAEyte7lCAm6eRzTYq7VUhJSBZPg1iwJyxB1uBkFC80Zi1kNPNNsLnPSezMGkWuqLc6Q3dkacieTSxWhBRpw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=K1eiwI7g3VrMGYohR02FveaCUufNt3x0XMx6GhIlrqg=; b=cMoLKC6kX8NVIwTW1Jtlfl+8gwPNCDUdSBobdtXUCwJz90c0iJLk9IiokCapGPpHoA7fGlL+Ihd//AXUUHZAl8y0sCrn5+J513s6tJ/U7ZJf7N/X7tHXj5Pies+QE2PYL/h0gm8wcLzIg4WtCT5ARFPgdxMh7RaSznyJAyd3675aZjL0hSngaeT4PX49x4rXUTx54Hk9CGpcvvlUsKR4093zZ+pfH1+NfHeL8dZj4VXqAzc+pevc2NWt6ot0AYV4Kjq8cmYlT10gs3anq57/Xd/Qe0RC23t0AWf0Lw4un5NbUL1BDDKWu9FX6v37QOi6Eu1asXJK1pk6uHQNYFStRw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=K1eiwI7g3VrMGYohR02FveaCUufNt3x0XMx6GhIlrqg=; b=iDpDUb+k73RW/8OlCQDpd+nnD+DS5zO24O//RUXR1LRyDg3pf8v/r2D9lJPMLuCKNWtCt3rGCVLB/goPJKcuyx3A9vOtIfgGauSm9gA1CoxJWmgMZwjzpDDwxkl2QSTXd2iZEX05gdIuwTa2XwNyMcZkHAuyt0wSM8EFb1xm2mQ= Received: from VE1PR04MB6639.eurprd04.prod.outlook.com (10.255.118.11) by VE1PR04MB6557.eurprd04.prod.outlook.com (10.255.118.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2305.20; Tue, 1 Oct 2019 14:11:36 +0000 Received: from VE1PR04MB6639.eurprd04.prod.outlook.com ([fe80::c045:5df2:ba1f:c3ee]) by VE1PR04MB6639.eurprd04.prod.outlook.com ([fe80::c045:5df2:ba1f:c3ee%5]) with mapi id 15.20.2305.022; Tue, 1 Oct 2019 14:11:36 +0000 From: Akhil Goyal To: Anoob Joseph , Pablo de Lara , Thomas Monjalon CC: Sunila Sahu , Jerin Jacob , Narayana Prasad , Fiona Trahe , Kanaka Durga Kotamarthy , Shally Verma , "dev@dpdk.org" Thread-Topic: [PATCH 4/6] crypto/octeontx2: add asymmetric in enqueue/dequeue ops Thread-Index: AQHVZyMVIPQBpD2Ev0C4PPJmz0naXqdF9VrA Date: Tue, 1 Oct 2019 14:11:36 +0000 Message-ID: References: <1568042799-25982-1-git-send-email-anoobj@marvell.com> <1568042799-25982-5-git-send-email-anoobj@marvell.com> In-Reply-To: <1568042799-25982-5-git-send-email-anoobj@marvell.com> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=akhil.goyal@nxp.com; x-originating-ip: [92.120.1.65] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e53feb1e-8392-47f4-885d-08d746794533 x-ms-office365-filtering-ht: Tenant x-ms-traffictypediagnostic: VE1PR04MB6557: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2887; x-forefront-prvs: 0177904E6B x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(136003)(39860400002)(396003)(346002)(376002)(366004)(189003)(199004)(4326008)(99286004)(486006)(6246003)(25786009)(6116002)(3846002)(14454004)(44832011)(26005)(7416002)(6506007)(2906002)(186003)(5660300002)(66066001)(9686003)(55016002)(102836004)(6436002)(305945005)(11346002)(4744005)(76176011)(7696005)(7736002)(446003)(478600001)(476003)(52536014)(74316002)(14444005)(64756008)(86362001)(66476007)(66556008)(66946007)(8936002)(71190400001)(256004)(33656002)(76116006)(316002)(81156014)(8676002)(81166006)(229853002)(54906003)(66446008)(110136005)(71200400001); DIR:OUT; SFP:1101; SCL:1; SRVR:VE1PR04MB6557; H:VE1PR04MB6639.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: CYJJyQ+u4+Yr9eSORK4YkCgh0SC0xKdyWYM7vWRs3DJFBYbQ2Gq9BEnXml441lB5Hl417wPcDhewp2RC5G49g8EBieIywtCzV7ZqDfn/qLT/MG6xb4rwD9sqJdQvobWMKPRWAnwtd9G7VvVikLo5eH49NXpQ0kd3tIScUiHl6Oc6YbUX6VFUjCWcPQCQhbX8cnuDudb3K+U0ex8BCUvrgfASeWZp40WSZbWL3HpRKYXuWbwR0Wn87bbp8v5cvAl/NAr3e3Si5pitI0byo59mfVAhg2mxN8Whul8G/VBFGyUekq1GuzKSsIPy9V0hJJGKGHegXuiHPHKjVRgm6TKyD0V8QILN1I4UXQjjppsi3NB1R2oGZvBvLiutyChWnfoKuB/awOE0LwJrg8Pb8IA0yTCFJCOCv8Ed8IZJiR0NlzI= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: e53feb1e-8392-47f4-885d-08d746794533 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Oct 2019 14:11:36.0987 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: wWFpvPYOjHOWr9fUWFcdWLqfY455PYEarwPy3c9EW6YAZWUruckIHEH8G7Q7zj2f1EpWhyy25+1crzrkNSNFRQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6557 Subject: Re: [dpdk-dev] [PATCH 4/6] crypto/octeontx2: add asymmetric in enqueue/dequeue ops X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Anoob, > static __rte_always_inline int __hot > otx2_cpt_enqueue_sym(struct otx2_cpt_qp *qp, struct rte_crypto_op *op, > struct pending_queue *pend_q) > @@ -488,7 +560,9 @@ otx2_cpt_enqueue_burst(void *qptr, struct > rte_crypto_op **ops, uint16_t nb_ops) >=20 > for (count =3D 0; count < nb_ops; count++) { > op =3D ops[count]; > - if (op->sess_type =3D=3D RTE_CRYPTO_OP_WITH_SESSION) > + if (op->type =3D=3D RTE_CRYPTO_OP_TYPE_ASYMMETRIC) > + ret =3D otx2_cpt_enqueue_asym(qp, op, pend_q); > + else if (op->sess_type =3D=3D RTE_CRYPTO_OP_WITH_SESSION) > ret =3D otx2_cpt_enqueue_sym(qp, op, pend_q); > else if (op->sess_type =3D=3D RTE_CRYPTO_OP_SESSIONLESS) > ret =3D otx2_cpt_enqueue_sym_sessless(qp, op, pend_q); Do you support session less in asym case? If not, can we add a check here.