Re: [dpdk-dev] [PATCH] test/compress: fix coverity warnings

[Akhil Goyal <akhil.goyal@nxp.com>]

> > > >
> > > > CID 340857: Null pointer dereferences (NULL_RETURNS)
> > > >
> > > > CID 340856: (CONSTANT_EXPRESSION_RESULT)
> > > >
> > > > Fixes: 3be12ea52ad8 ("test/compress: improve debug trace setup")
> > > >
> > > > Signed-off-by: Adam Dybkowski <adamx.dybkowski@intel.com>
> > > > ---
> > > >  app/test/test_compressdev.c | 10 ++++++++--
> > > >  1 file changed, 8 insertions(+), 2 deletions(-)
> > > >
> > > > diff --git a/app/test/test_compressdev.c b/app/test/test_compressdev.c
> > > > index 65889c242..992eac8e0 100644
> > > > --- a/app/test/test_compressdev.c
> > > > +++ b/app/test/test_compressdev.c
> > > > @@ -755,6 +755,12 @@ test_deflate_comp_decomp(const struct
> > > interim_data_params *int_data,
> > > >  	char *contig_buf = NULL;
> > > >  	uint64_t compress_checksum[num_bufs];
> > > >
> > > > +	if (capa == NULL) {
> > > > +		RTE_LOG(ERR, USER1,
> > > > +			"Compress device does not support DEFLATE\n");
> > > > +		return -1;
> > > [Fiona] shouldn't you return -ENOTSUP?
> > [Adam] All other errors end with returning -1 (see the ret_status variable which
> is initialized to -1).
> > That's why I handle the error case the same way. This is inside the test suite,
> not a PMD.
> [Fiona] ok, can see in the code that the capability is already checked at the
> higher level
> for this case, so no need to return ENOTSUP here. -1 is ok
> Acked-by: Fiona Trahe <fiona.trahe@intel.com>

Applied to dpdk-next-crypto

Thanks.