Re: [dpdk-dev] [PATCH] crypto/armv8: enable meson build

[Akhil Goyal <akhil.goyal@nxp.com>]

Hi Dharmik,

As per the recent communication with Honnappa on a separate mail chain, ARM has agreed to 
Host the armv8_crypto library. If it is happening in 19.11 timeframe, we should rebase this patch
And add documentation for changed location of the repo and if it is not in 19.11 timeframe we should have a patch to disable the PMD.

Could you please send patches as are applicable?

Regards,
Akhil

> Add new meson.build file for crypto/armv8
> 
> Signed-off-by: Dharmik Thakkar <dharmik.thakkar@arm.com>
> ---
>  drivers/crypto/armv8/meson.build | 25 +++++++++++++++++++++++++
>  drivers/crypto/meson.build       |  6 +++---
>  meson_options.txt                |  2 ++
>  3 files changed, 30 insertions(+), 3 deletions(-)
>  create mode 100644 drivers/crypto/armv8/meson.build
> 
> diff --git a/drivers/crypto/armv8/meson.build
> b/drivers/crypto/armv8/meson.build
> new file mode 100644
> index 000000000000..1ef78fa5d8c7
> --- /dev/null
> +++ b/drivers/crypto/armv8/meson.build
> @@ -0,0 +1,25 @@
> +# SPDX-License-Identifier: BSD-3-Clause
> +# Copyright(c) 2019 Arm Limited
> +
> +path = get_option('armv8_crypto_dir')
> +if path == ''
> +	build = false
> +	reason = 'missing dependency, "armv8_crypto"'
> +	subdir_done()
> +endif
> +
> +inc_dir = path + '/asm/include'
> +
> +lib = cc.find_library('libarmv8_crypto', dirs: [path], required: false)
> +if not lib.found()
> +	build = false
> +	reason = 'missing dependency, "armv8_crypto"'
> +	subdir_done()
> +else
> +	ext_deps += lib
> +	includes += include_directories(inc_dir)
> +endif
> +
> +deps += ['bus_vdev']
> +sources = files('rte_armv8_pmd.c', 'rte_armv8_pmd_ops.c')
> +allow_experimental_apis = true
> diff --git a/drivers/crypto/meson.build b/drivers/crypto/meson.build
> index 83e78860ebee..605dcdd5f4d6 100644
> --- a/drivers/crypto/meson.build
> +++ b/drivers/crypto/meson.build
> @@ -1,9 +1,9 @@
>  # SPDX-License-Identifier: BSD-3-Clause
>  # Copyright(c) 2017 Intel Corporation
> 
> -drivers = ['aesni_gcm', 'aesni_mb', 'caam_jr', 'ccp', 'dpaa_sec', 'dpaa2_sec',
> -	'kasumi', 'mvsam', 'null', 'octeontx', 'openssl', 'qat', 'scheduler',
> -	'snow3g', 'virtio', 'zuc']
> +drivers = ['aesni_gcm', 'aesni_mb', 'armv8', 'caam_jr', 'ccp', 'dpaa_sec',
> +	'dpaa2_sec', 'kasumi', 'mvsam', 'null', 'octeontx', 'openssl', 'qat',
> +	'scheduler', 'snow3g', 'virtio', 'zuc']
> 
>  std_deps = ['cryptodev'] # cryptodev pulls in all other needed deps
>  config_flag_fmt = 'RTE_LIBRTE_@0@_PMD'
> diff --git a/meson_options.txt b/meson_options.txt
> index 448f3e63dcf2..4c0413918a34 100644
> --- a/meson_options.txt
> +++ b/meson_options.txt
> @@ -2,6 +2,8 @@
> 
>  option('allow_invalid_socket_id', type: 'boolean', value: false,
>  	description: 'allow out-of-range NUMA socket id\'s for platforms that
> don\'t report the value correctly')
> +option('armv8_crypto_dir', type: 'string', value: '',
> +	description: 'path to the armv8_crypto library installation directory')
>  option('drivers_install_subdir', type: 'string', value: 'dpdk/pmds-<VERSION>',
>  	description: 'Subdirectory of libdir where to install PMDs. Defaults to
> using a versioned subdirectory.')
>  option('enable_docs', type: 'boolean', value: false,
> --
> 2.17.1