[dpdk-dev] [PATCH] compress/zlib: fix coverity warning

[dpdk-dev] [PATCH] compress/zlib: fix coverity warning

[Adam Dybkowski]

Add missing return after setting the error status in case of
invalid flush_flag in the operation.
The issue was found by the coverity scan as the fin_flush variable,
not initialized in such case, was used later in the flow.

CID 340859:  Uninitialized variables  (UNINIT)

Fixes: c7b436ec95fd ("compress/zlib: support burst enqueue/dequeue")

Signed-off-by: Adam Dybkowski <adamx.dybkowski@intel.com>
---
 drivers/compress/zlib/zlib_pmd.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/compress/zlib/zlib_pmd.c b/drivers/compress/zlib/zlib_pmd.c
index 5a4d47d4d..19f9200c2 100644
--- a/drivers/compress/zlib/zlib_pmd.c
+++ b/drivers/compress/zlib/zlib_pmd.c
@@ -30,6 +30,7 @@ process_zlib_deflate(struct rte_comp_op *op, z_stream *strm)
 	default:
 		op->status = RTE_COMP_OP_STATUS_INVALID_ARGS;
 		ZLIB_PMD_ERR("Invalid flush value\n");
+		return;
 	}
 
 	if (unlikely(!strm)) {
-- 
2.17.1

Re: [dpdk-dev] [PATCH] compress/zlib: fix coverity warning

[Trahe, Fiona]

Including Sunila, the zlib PMD maintainer.

> -----Original Message-----
> From: Dybkowski, AdamX
> Sent: Wednesday, July 24, 2019 9:43 AM
> To: dev@dpdk.org; Trahe, Fiona <fiona.trahe@intel.com>; shally.verma@caviumnetworks.com
> Cc: Dybkowski, AdamX <adamx.dybkowski@intel.com>
> Subject: [PATCH] compress/zlib: fix coverity warning
> 
> Add missing return after setting the error status in case of
> invalid flush_flag in the operation.
> The issue was found by the coverity scan as the fin_flush variable,
> not initialized in such case, was used later in the flow.
> 
> CID 340859:  Uninitialized variables  (UNINIT)
> 
> Fixes: c7b436ec95fd ("compress/zlib: support burst enqueue/dequeue")
> 
> Signed-off-by: Adam Dybkowski <adamx.dybkowski@intel.com>
> ---
>  drivers/compress/zlib/zlib_pmd.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/compress/zlib/zlib_pmd.c b/drivers/compress/zlib/zlib_pmd.c
> index 5a4d47d4d..19f9200c2 100644
> --- a/drivers/compress/zlib/zlib_pmd.c
> +++ b/drivers/compress/zlib/zlib_pmd.c
> @@ -30,6 +30,7 @@ process_zlib_deflate(struct rte_comp_op *op, z_stream *strm)
>  	default:
>  		op->status = RTE_COMP_OP_STATUS_INVALID_ARGS;
>  		ZLIB_PMD_ERR("Invalid flush value\n");
> +		return;
>  	}
> 
>  	if (unlikely(!strm)) {
> --
> 2.17.1

Re: [dpdk-dev] [PATCH] compress/zlib: fix coverity warning

[Akhil Goyal]

> Add missing return after setting the error status in case of
> invalid flush_flag in the operation.
> The issue was found by the coverity scan as the fin_flush variable,
> not initialized in such case, was used later in the flow.
> 
> CID 340859:  Uninitialized variables  (UNINIT)
> 
> Fixes: c7b436ec95fd ("compress/zlib: support burst enqueue/dequeue")
> 
> Signed-off-by: Adam Dybkowski <adamx.dybkowski@intel.com>
> ---
Applied to dpdk-next-crypto

Thanks.