DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] compress/zlib: fix coverity warning
@ 2019-07-24  8:42 Adam Dybkowski
  2019-07-25 13:14 ` Trahe, Fiona
  2019-07-26 13:59 ` Akhil Goyal
  0 siblings, 2 replies; 3+ messages in thread
From: Adam Dybkowski @ 2019-07-24  8:42 UTC (permalink / raw)
  To: dev, fiona.trahe, shally.verma; +Cc: Adam Dybkowski

Add missing return after setting the error status in case of
invalid flush_flag in the operation.
The issue was found by the coverity scan as the fin_flush variable,
not initialized in such case, was used later in the flow.

CID 340859:  Uninitialized variables  (UNINIT)

Fixes: c7b436ec95fd ("compress/zlib: support burst enqueue/dequeue")

Signed-off-by: Adam Dybkowski <adamx.dybkowski@intel.com>
---
 drivers/compress/zlib/zlib_pmd.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/compress/zlib/zlib_pmd.c b/drivers/compress/zlib/zlib_pmd.c
index 5a4d47d4d..19f9200c2 100644
--- a/drivers/compress/zlib/zlib_pmd.c
+++ b/drivers/compress/zlib/zlib_pmd.c
@@ -30,6 +30,7 @@ process_zlib_deflate(struct rte_comp_op *op, z_stream *strm)
 	default:
 		op->status = RTE_COMP_OP_STATUS_INVALID_ARGS;
 		ZLIB_PMD_ERR("Invalid flush value\n");
+		return;
 	}
 
 	if (unlikely(!strm)) {
-- 
2.17.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-07-26 13:59 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-24  8:42 [dpdk-dev] [PATCH] compress/zlib: fix coverity warning Adam Dybkowski
2019-07-25 13:14 ` Trahe, Fiona
2019-07-26 13:59 ` Akhil Goyal

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).