From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 478CEA0528; Mon, 20 Jan 2020 14:30:23 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EE8241515; Mon, 20 Jan 2020 14:30:21 +0100 (CET) Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2083.outbound.protection.outlook.com [40.107.21.83]) by dpdk.org (Postfix) with ESMTP id 7587811A4 for ; Mon, 20 Jan 2020 14:30:20 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HeTsQ4A++0Q0q+sWkWi1yo9q7Ru/fj2K/icJcz9K6Z74mf/CPxmzaCK3ggCUcIu8HqCbhZkhD/kzW7NFonGWURTs+HMHZYlOCiY7r9aOrYu92F2AqlTEGQXkrLC43CdlDTe6qzYhBttlRRdCihuf+vcn9gkkcVhp7igAsfkztsxCLB1wthVPp8m0KhTkn/Ofdnsqz32h3632m86sjdhtbRwCX0iAVCtd/K5toqWWILvsRlqDuJxr5ao8XqmKMdRJokVSbC2YNufEgico3PLFxFbIKk5yroXPmNPxwhCzpMeaEIyfIaFgTji8r2KQaipUAHE2hcfSBjc1+TPzXb8Qcg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TNrDqXpFWiNp6zdt5H7io/iAH+YJxP5lEWASyqQk1L4=; b=haiSvIfhC5KFOh3Uvi+R+IHONRxq4d/ycLSTKWXYHaZzGyHW8le7lXT39yCFngdeuItHoqp6T9hY2RrmCIRm+jdjbcMvEkq2FKc96R0tBz2yyEvTCMVjJVqoiEhaGp841CnexP4px8nvc78+tUhpTBXlU47ZjBUwHaPVqy6+QdiqOPviy2hsuen8uc66yCFVhx1Cr+71dIOmHm972L8O+6EI9y/Rj8LCp7Iq9L7d1hMD61cW5oDRYG8/Cyoe0XlRxvl4H/TQ9xB+aORIxp3iCWEeAY/mRA/ku034tp10pYClJHtii+C13Y8lG1uAz6MB4cU0ynnaMlQn2UkRd98n2g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TNrDqXpFWiNp6zdt5H7io/iAH+YJxP5lEWASyqQk1L4=; b=lxd4jbxI5SsTAhY1vAQUqFBGw5FWpX9D6gd/HIZ2kM/eSsCTuID14ZifNRkm6OvgghqlQEJWaRQhzc0cXynx7G86fdLQUWp21B/xonQ1VJwItvNq8XItf7EmN4fJgFCg2+zBi1IWxutlhieJM6L+iR9Wvv5ZrHdQfhojMQyZBqE= Received: from VE1PR04MB6639.eurprd04.prod.outlook.com (10.255.118.11) by VE1PR04MB6670.eurprd04.prod.outlook.com (20.179.233.213) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2644.23; Mon, 20 Jan 2020 13:30:19 +0000 Received: from VE1PR04MB6639.eurprd04.prod.outlook.com ([fe80::25b0:b1ac:aed0:63e1]) by VE1PR04MB6639.eurprd04.prod.outlook.com ([fe80::25b0:b1ac:aed0:63e1%7]) with mapi id 15.20.2644.024; Mon, 20 Jan 2020 13:30:19 +0000 From: Akhil Goyal To: Adam Dybkowski , "dev@dpdk.org" , "fiona.trahe@intel.com" CC: "Trahe, Fiona" , Akhil Goyal , "ravi1.kumar@amd.com" , "ruifeng.wang@arm.com" , "anoobj@marvell.com" , "Zhang, Roy Fan" , "Doherty, Declan" , "Griffin, John" , "De Lara Guarch, Pablo" , "michaelsh@marvell.com" , "lironh@marvell.com" , "jsrikanth@marvell.com" , "rnagadheeraj@marvell.com" , "adwivedi@marvell.com" , Gagandeep Singh , "Jain, Deepak K" , "jianjay.zhou@huawei.com" , Hemant Agrawal Thread-Topic: [PATCH v7 0/3] Refactor crypto unit tests. Thread-Index: AQHVz5MyM9ZPQz7CyEmoH5wGmv3gaKfziCKA Date: Mon, 20 Jan 2020 13:30:19 +0000 Message-ID: References: <20200117144651.26804-1-adamx.dybkowski@intel.com> <20200120131146.1135-1-adamx.dybkowski@intel.com> In-Reply-To: <20200120131146.1135-1-adamx.dybkowski@intel.com> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=akhil.goyal@nxp.com; x-originating-ip: [92.120.1.66] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 1de4cf96-e49d-4cd6-880a-08d79dace4e2 x-ms-traffictypediagnostic: VE1PR04MB6670:|VE1PR04MB6670: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4303; x-forefront-prvs: 0288CD37D9 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(366004)(346002)(396003)(376002)(39860400002)(136003)(199004)(189003)(6506007)(81166006)(81156014)(54906003)(110136005)(8676002)(52536014)(7696005)(71200400001)(316002)(86362001)(5660300002)(478600001)(7416002)(186003)(2906002)(55016002)(33656002)(64756008)(66556008)(66476007)(66446008)(76116006)(9686003)(26005)(4326008)(8936002)(66946007)(44832011); DIR:OUT; SFP:1101; SCL:1; SRVR:VE1PR04MB6670; H:VE1PR04MB6639.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: X0j5WOwQcoO/TWjBUAvKn2r7EN5N72ZGTkSAlnoKWxPOPb8quXl3TOrXOinwmGjKLqCunpjzwPm0At+H7XWwrZTE15mBk4daNx5I/ETxNNhvjBN9OlRgJm9sINnTSNPaOALdmIff1gJ/mwRgj0w6qmeyT9cMGudvu/QQc3mAzckRPsQJJQCxeS7Q1MbCy/3Vr1ePeFDHLtLwBqewkfamZK9T/xmczw/wNpW1RhYgu8CM25C1q9bYJOVPOtq4Am72k5hzMPimUPlztd8NkjXjl8q1E+YlJQB1J17JYv2mdKotPz6KTAYY8UPGkTqPx1beOWzCqbimQR3JwNnOG02clvmF/k69AzX3Fh/7se+PJrsQcMzRa2lmXTd2o37grYkzpw3O9p1k3PCXJAbdKNQ6RDtA8IITF4XFXo2iITqB75FX1o8raxhn/pchxIu8UQH0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1de4cf96-e49d-4cd6-880a-08d79dace4e2 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Jan 2020 13:30:19.4522 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: jSMCi+JMcaLr+Dni1T/PKjkoD3Y7ROKaEUxNWvO/XCuZlr5NDRpGX5e5KIR81r6opOJYzwYg6WrAvYp63Hjnog== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6670 Subject: Re: [dpdk-dev] [PATCH v7 0/3] Refactor crypto unit tests. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" >=20 > This patch set is a first step to refactor the overly complex symmetric > crypto unit tests. It merges many separate arrays of the tests > for these PMDs: null, aesni_mb, aesni_gcm, openssl, qat, sw_snow3g, > sw_kasumi, sw_zuc into one big array that's then used when running > unit tests on these PMDs. >=20 > Individual test functions check the capabilities and execute the rest > of the test or skip (return -ENOTSUP) based on the particular test > requirements - e.g. test if PMD supports ZUC algo or even a particular > key length in few cases. Few edge cases required to check the PMD > itself (e.g. run on QAT only, or skip on AES NI / AES GCM). >=20 > It's the first step of bigger refactoring. Maintainers of other PMDs > are encouraged to add their PMD unit tests also into this big central > array and remove individual test macro arrays. >=20 > This patch doesn't address next refactoring steps to be done in the > future: geting rid of many small (usually 1-2 line) test functions, > created separately for every test case; and simplifying many bigger > functions that currently do similar things but work on different > test vector structures. >=20 > A simple script to check if symmetric crypto unit tests work properly > on multiple PMDs at once, update the PMDs list to your needs: >=20 > for PMD in null aesni_mb aesni_gcm openssl qat scheduler sw_snow3g > sw_kasumi sw_zuc > do > echo +++++ $PMD +++++ > echo cryptodev_${PMD}_autotest | build/app/test -c7 -n1 --log-level= =3D7 | grep > ' Tests [Failed|Passed]' > done >=20 > --- > v2: > * Update the cover letter, regenerate the patch file. > v3: > * Break very large commit into four smaller commits, easier to review. > * Show in the cover letter how to run unit tests on multiple PMDs at once= . > v4: > * Rebase. > v5: > * Fix a test failing on SW ZUC PMD. > v6: > * Rebase again, squash first two commits to allow building individual pat= ches. > v7: > * Fix checking of the capabilities in the function test_pdcp_proto > used by dpaa/dpaa2 PMDs. Check security capabilities instead of crypto. >=20 > Adam Dybkowski (3): > test/crypto: refactor unit tests > test/crypto: add capability checks > test/crypto: refactor unit tests into one combined array >=20 > app/test/test_cryptodev.c | 15975 +++++++++---------- > app/test/test_cryptodev_blockcipher.c | 2 +- > app/test/test_cryptodev_des_test_vectors.h | 6 +- > 3 files changed, 7328 insertions(+), 8655 deletions(-) The cover letter seem to be outdated, as we don't have these many changes i= n the patchset. However, there is no issue. I will apply the patchset tomorrow if no object= ions raised. Adding other PMD owners.=20 Acked-by: Akhil Goyal Tested-by: Akhil Goyal