From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 24190A04DD; Tue, 21 Jan 2020 11:26:10 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3FA1F343C; Tue, 21 Jan 2020 11:26:09 +0100 (CET) Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-eopbgr150049.outbound.protection.outlook.com [40.107.15.49]) by dpdk.org (Postfix) with ESMTP id EB05F322C for ; Tue, 21 Jan 2020 11:26:07 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kO5NpwfA833O5xl9NPX1orhd7CdMKvbQGmzX5PH92zsYG894efzQwQ7d2F5S11rbjkNzxThs+iG++QamlGW9Y3MFuYnDJG3UjIoW2gZjY5belN1j8bzCqFLGeVxUAExlVbhjDj1GplGqQrdc4qXTXXc4fsgSVhNd+r++S+UV0UzXflfDpk5v59z50WS5LStwVavYdDNfjAc9dHBXXEL9VAD9mFy371Gg9ikBDUUmM859TaCNpEgsjHNCSeeK8RQHDFlppUgiEBhON9o8UhcbDIq76WVZlvVFE+GtXIhQLP8QC9Qkt/a8EQ2+3Xd25ChCZropO1RKC9oPU2GHjWcMBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EnXcEcZG+JfDxAfO1R4Iay8KvrXlV1t2YCzLtNOqzrg=; b=KlPu+ZzeBhTHQ5i+aNXT8YYX+l+DGtBMm5h6YRIz0cKO/hlC68752Gn3DfEqy6M4xY2UGIvuL6DK4wmVrMpRtreCIb1edL3ne4CXY589rDOGbx7APKY0sAAAlq/fnCE4NoCxHQTLx5+tXBdI3JLgxqeDERBjx/Yvbff/DTe8r0JXnC6rTRqhIlefSYuHsQqsc48+ykhCZcyTDMFzaGvY2J+PIhWX1LIVIyPCg2xhFOOFHE/RwY3pafNbQinS8FQojYV0SIog8C74S22QMbv0+yudAJw1oZCQbX8yTp1fA3KEpO0u4+Jy3ZtGkFhIYiAAXrRkwPJATcA0w1MTdQcZMw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EnXcEcZG+JfDxAfO1R4Iay8KvrXlV1t2YCzLtNOqzrg=; b=U3XR+XMIBRqYU3C0y4vBpodcf7bmsZbmuVAfU+1Zos2/HlvKFJiJc7DY5JGTvVOtIPS0vfxrgeaDyx6x45bL3y0wjrRLdLgfTMrAM3xziim8bLtBJC9ZzR/tO4nq+KgTNGBcXiQyJea0k/iMfB2YVIHy6xWTVq5cPJSYSK9i+ws= Received: from VE1PR04MB6639.eurprd04.prod.outlook.com (10.255.118.11) by VE1PR04MB6638.eurprd04.prod.outlook.com (20.179.232.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2644.19; Tue, 21 Jan 2020 10:26:07 +0000 Received: from VE1PR04MB6639.eurprd04.prod.outlook.com ([fe80::25b0:b1ac:aed0:63e1]) by VE1PR04MB6639.eurprd04.prod.outlook.com ([fe80::25b0:b1ac:aed0:63e1%7]) with mapi id 15.20.2644.024; Tue, 21 Jan 2020 10:26:07 +0000 From: Akhil Goyal To: Adam Dybkowski , "dev@dpdk.org" , "fiona.trahe@intel.com" CC: "Trahe, Fiona" , "ravi1.kumar@amd.com" , "ruifeng.wang@arm.com" , "anoobj@marvell.com" , "Zhang, Roy Fan" , "Doherty, Declan" , "Griffin, John" , "De Lara Guarch, Pablo" , "michaelsh@marvell.com" , "lironh@marvell.com" , "jsrikanth@marvell.com" , "rnagadheeraj@marvell.com" , "adwivedi@marvell.com" , Gagandeep Singh , "Jain, Deepak K" , "jianjay.zhou@huawei.com" , Hemant Agrawal Thread-Topic: [PATCH v7 0/3] Refactor crypto unit tests. Thread-Index: AQHVz5MyM9ZPQz7CyEmoH5wGmv3gaKfziCKAgAFi61A= Date: Tue, 21 Jan 2020 10:26:06 +0000 Message-ID: References: <20200117144651.26804-1-adamx.dybkowski@intel.com> <20200120131146.1135-1-adamx.dybkowski@intel.com> In-Reply-To: Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=akhil.goyal@nxp.com; x-originating-ip: [45.118.166.74] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 271ae139-09d0-4bd1-2927-08d79e5c538c x-ms-traffictypediagnostic: VE1PR04MB6638:|VE1PR04MB6638: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5516; x-forefront-prvs: 0289B6431E x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(366004)(136003)(346002)(376002)(396003)(39860400002)(199004)(189003)(55016002)(9686003)(52536014)(54906003)(316002)(5660300002)(110136005)(7416002)(71200400001)(81156014)(33656002)(81166006)(2906002)(8676002)(86362001)(478600001)(66476007)(44832011)(64756008)(66446008)(66556008)(4326008)(186003)(7696005)(8936002)(26005)(6506007)(76116006)(66946007); DIR:OUT; SFP:1101; SCL:1; SRVR:VE1PR04MB6638; H:VE1PR04MB6639.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 54JGLEve9E1UeE2I+KFm3gz7XTDXUlm67ahTgYYx+cuu/5TmFuYYoiXhsYbmc9H7vSRKGE/hK+vDc1xZ6PG3LcA+6x5VT2z/NGfT0EJrXLmUpTuT1jcGnNPiyQnRGWYcAl8uCqSVB8Z6UC8uGy29hGKW7rOqg83Iv0SUnd0MZzeA0qmtVA+4Jf3hWxW1ma4H7AWBQUW1sG9hFMB0wPBjYexlvMUBBXWvBR/LzjYL2TblAyZAEzUXJMiSLJkKZyu3KnHaZIWaSOfVN3/iFzbLOOZ2zw6epo7osCcQpgDdRErSQ7esyoE2F9BpDtu0auLYSkZibCWNorC+Z7tceHARZgQj6rsPlQZVwNrn3GnpFO5tqDfpFYp+HfL0L/hu/25mfpXv1Ek1J/0sljUvXnpMkc+KmO7qblXg0VhX3miWdozPetRXW1h4c5EHLkDq2XmT Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 271ae139-09d0-4bd1-2927-08d79e5c538c X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Jan 2020 10:26:07.0209 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ao8VKVH/BfBVdtJQxVvgCqVBOS5jrqzFMQSflytZ/bztlNlhPD78NLoX72CBBlrWngGmpjxFt0i7btQyv94+dg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6638 Subject: Re: [dpdk-dev] [PATCH v7 0/3] Refactor crypto unit tests. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" >=20 >=20 > > > > This patch set is a first step to refactor the overly complex symmetric > > crypto unit tests. It merges many separate arrays of the tests > > for these PMDs: null, aesni_mb, aesni_gcm, openssl, qat, sw_snow3g, > > sw_kasumi, sw_zuc into one big array that's then used when running > > unit tests on these PMDs. > > > > Individual test functions check the capabilities and execute the rest > > of the test or skip (return -ENOTSUP) based on the particular test > > requirements - e.g. test if PMD supports ZUC algo or even a particular > > key length in few cases. Few edge cases required to check the PMD > > itself (e.g. run on QAT only, or skip on AES NI / AES GCM). > > > > It's the first step of bigger refactoring. Maintainers of other PMDs > > are encouraged to add their PMD unit tests also into this big central > > array and remove individual test macro arrays. > > > > This patch doesn't address next refactoring steps to be done in the > > future: geting rid of many small (usually 1-2 line) test functions, > > created separately for every test case; and simplifying many bigger > > functions that currently do similar things but work on different > > test vector structures. > > > > A simple script to check if symmetric crypto unit tests work properly > > on multiple PMDs at once, update the PMDs list to your needs: > > > > for PMD in null aesni_mb aesni_gcm openssl qat scheduler sw_snow3g > > sw_kasumi sw_zuc > > do > > echo +++++ $PMD +++++ > > echo cryptodev_${PMD}_autotest | build/app/test -c7 -n1 --log-level= =3D7 | > grep > > ' Tests [Failed|Passed]' > > done > > > > --- > > v2: > > * Update the cover letter, regenerate the patch file. > > v3: > > * Break very large commit into four smaller commits, easier to review. > > * Show in the cover letter how to run unit tests on multiple PMDs at on= ce. > > v4: > > * Rebase. > > v5: > > * Fix a test failing on SW ZUC PMD. > > v6: > > * Rebase again, squash first two commits to allow building individual p= atches. > > v7: > > * Fix checking of the capabilities in the function test_pdcp_proto > > used by dpaa/dpaa2 PMDs. Check security capabilities instead of crypto. > > > > Adam Dybkowski (3): > > test/crypto: refactor unit tests > > test/crypto: add capability checks > > test/crypto: refactor unit tests into one combined array > > > > app/test/test_cryptodev.c | 15975 +++++++++---------- > > app/test/test_cryptodev_blockcipher.c | 2 +- > > app/test/test_cryptodev_des_test_vectors.h | 6 +- > > 3 files changed, 7328 insertions(+), 8655 deletions(-) >=20 > The cover letter seem to be outdated, as we don't have these many changes= in > the patchset. > However, there is no issue. I will apply the patchset tomorrow if no obje= ctions > raised. > Adding other PMD owners. >=20 > Acked-by: Akhil Goyal > Tested-by: Akhil Goyal Series Applied to dpdk-next-crypto Thanks.