From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 45D4AA058B; Wed, 25 Mar 2020 15:59:29 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D9AF02C15; Wed, 25 Mar 2020 15:59:27 +0100 (CET) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70044.outbound.protection.outlook.com [40.107.7.44]) by dpdk.org (Postfix) with ESMTP id E143C2BCE for ; Wed, 25 Mar 2020 15:59:25 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Q2I8so5i58gYsUUDyF8Y5uSbrxKzzmnK9fezZzkGw7Ug00YfnwaIBr8ScJNxU9oQF7KG6kYSfsOkPS+sLm9mSw49ZaeK7NlaWz6vRwGaPHLSOITeXxJDvZBQ4k76UjKqkLu3SLIrZqN6oYcOVkJUhFli69Ynui6LmmDoF6NPOXyLyzSMIW5HvcWN+iRn7ws6FY0Qrmg91Jz0JEAXj20e5ZI5sbrt8ufEZYhm3iCP2o4NaFO3coGkmDL5xTzPcLXWLKc5UatEQTZOZoiQQRRcbL1t1dSptYvwoDASrIaHzEmi1XgqwSA8M4JgmaZZMoyvrJ5MpDjTCMwXZ9oNZNu6Fw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bOAYv11HkXqdddkE4EQZ82T5n/RWCZC/iJ6kY5SjEGk=; b=arfyiSbbDnWFI+TGm9imEaj4u44OzYtcJbz6yqOoNoDNDRL1sAXLmmk9XRhRqaGdVTColTlFD5HfSdNqWhjt035NM19DAaUPh0AQW0xrpCR15a8jCg/H9vbpb5z8c7+lx+yraUWRbU/0DQ+Luz6uo3/TTn+sd7dhxNsg/5k7XHq/dIU113M+rivY4/SIF/x88McFC3+j/rINyBPCZV0r90RfK9epoYxzVG1F02D7jRA97lXv+GFBg+nqWO9UeaVMKuUN+/LU845OUB+7XUO3qJ5eCsdEvkTEUPnayWnR171FInO13FIhJBVUVbaSgY7feI5Wc3ldxBiwTLeIU6uh7g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bOAYv11HkXqdddkE4EQZ82T5n/RWCZC/iJ6kY5SjEGk=; b=SS7v93K9o6IuyM4na4mh39mLxJalxipa/n26siEXrRaNh622SCjeFwbFi6VmplXc1WjN/rXHTjItp7wRxcrZSS2PmZ9PKu/wzqATrw/bZOFjZcPPypCaUJYhX9PjgIREbqU5a9tY50lsj3BvnPmSh41Q720KY6wY+zXNleYAY6A= Received: from VE1PR04MB6639.eurprd04.prod.outlook.com (10.255.118.11) by VE1PR04MB6479.eurprd04.prod.outlook.com (20.179.232.225) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.18; Wed, 25 Mar 2020 14:59:24 +0000 Received: from VE1PR04MB6639.eurprd04.prod.outlook.com ([fe80::8060:a35c:4858:c490]) by VE1PR04MB6639.eurprd04.prod.outlook.com ([fe80::8060:a35c:4858:c490%7]) with mapi id 15.20.2835.023; Wed, 25 Mar 2020 14:59:24 +0000 From: Akhil Goyal To: Nicolas Chautru , "thomas@monjalon.net" , "dev@dpdk.org" CC: "ferruh.yigit@intel.com" Thread-Topic: [PATCH v3 12/14] drivers/baseband: add PMD for FPGA 5GNR FEC Thread-Index: AQHV8lZ1p2pW+1OVvESmAOKscJ4nBKhZhlBw Date: Wed, 25 Mar 2020 14:59:23 +0000 Message-ID: References: <1582778348-113547-15-git-send-email-nicolas.chautru@intel.com> <1583348102-13253-1-git-send-email-nicolas.chautru@intel.com> <1583348102-13253-13-git-send-email-nicolas.chautru@intel.com> In-Reply-To: <1583348102-13253-13-git-send-email-nicolas.chautru@intel.com> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=akhil.goyal@nxp.com; x-originating-ip: [45.118.166.74] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: aa36deac-07c2-4f97-032e-08d7d0cd1b7b x-ms-traffictypediagnostic: VE1PR04MB6479: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-forefront-prvs: 0353563E2B x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(396003)(376002)(39860400002)(346002)(366004)(136003)(478600001)(81156014)(9686003)(2906002)(316002)(33656002)(6506007)(64756008)(81166006)(66556008)(66476007)(66446008)(55016002)(86362001)(66946007)(7696005)(52536014)(4744005)(76116006)(44832011)(110136005)(8676002)(5660300002)(4326008)(186003)(8936002)(26005)(71200400001); DIR:OUT; SFP:1101; SCL:1; SRVR:VE1PR04MB6479; H:VE1PR04MB6639.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: QBxuXAQz8Ssqf666fQEKuwBEugAfm95dQ7UV5Uv+GMRiQXAAaFcQaQxOo4tXiAjeCB0d74Zmaw1XtJuwNUdVFJz37QuVVuqnn3XrMcDFQNXS5wcC2ILo1CB3FfAQofb6rXLUCWHN9XQbTey4VbJKYQAwtzLv8MC3/hzawdgMdbdxzBDUSfHttNdyqV60JtEmzGiY7tPQE2oPsbxijVj8znpgisfKKMRCmAG6qBpMIzbsMIcPWKhd+pGP0/a33MMWuiRgAS6wiPPov6Ekggka0tDjV5DLi0LYVby6cPofcU+RNzWrL2ZBK3rYpZCWs8SwSriDaBuWGANewrN333iLbDXzEkhuarWyOSDuIh6afLGtOjnFdI2a6BfDxseptAwqNpkymaKi2Z0ix65zf0hapQ1ROFFymrue8ZZleZGbi7aoJMQqoUF7Rdw0qTnklkfW x-ms-exchange-antispam-messagedata: 24ozh3W2LT/esUPxPRsmxFgL+CD9A7QDEZWV58AeUnGPmpFI92s5GQSvRT2WRebKnAAsrrFwFyOfBdQAV9UkIMetmvLucs1Zdla/o1GwBBW/PM+j1NsMY7MuLy0EJW0iFQ157Pwn+9J2ziomInYagg== x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: aa36deac-07c2-4f97-032e-08d7d0cd1b7b X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Mar 2020 14:59:24.2355 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: yRdlmMauOW8NmsmLc03ZMbOA0t/8MhRaip77mxb9Qm1bqIJxX1twtzeBahF4zmXSXmbpcFqag5e4ewmwwZRwdQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6479 Subject: Re: [dpdk-dev] [PATCH v3 12/14] drivers/baseband: add PMD for FPGA 5GNR FEC X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" >=20 > From: Nic Chautru >=20 > Supports for FEC 5G PMD Driver on FPGA card PAC N3000 >=20 > Signed-off-by: Nic Chautru > --- I cannot review this patch. This patch should be a separate series. This should be split into logical parts as a new PMD is submitted for revie= w. I can see that all the MACROS, enums, structures are defined in the .c file= which Is not correct. Please move the relevant code in .h files and split the who= le patch Along with documentation.