From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 23937A04F5; Thu, 12 Dec 2019 12:56:18 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B796D374C; Thu, 12 Dec 2019 12:56:17 +0100 (CET) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80041.outbound.protection.outlook.com [40.107.8.41]) by dpdk.org (Postfix) with ESMTP id 449002BD3 for ; Thu, 12 Dec 2019 12:56:16 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NeQPa6o4sSITcWsGPQRwlIPVObOIIqVfT8EsdM5Rcu+shTTJQTIjjMBOqaRLBT4WvlWf0L1kSJ1NER1nC5YcPsCterdyw50gLw7chgcmUQCmWJdR7stwYU5gHQ2QSIiQF9fzWwwVWi/EJkBmCy1oEG4hvLXSoy0rFbUmSyqGbXetqwWL5R+F6qdJ5m5zIFbTa7PqhX1n0TN/118O9ME8oS3qPKIKgEjuiGQkrs5DvpJJDHjxGpAiR6+4Hs8I2wOSG4p/pOA3LUUg9C+S/K1NkyUPutJo5R9rCsXkLBZJ/vS3Xf0DLABrVJvlt4E316lIIEPD2Ao3JQN9wdQ6TwMpyg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kZpxMhwsTjbIV+K1wWl6Fm2iVxtSyXnw+2AXluB+P+A=; b=J/7TMfS5CXVZIS+gN4KVTiOLpqGaOxq+waCPABFMteQRimZZqdTHNnlAo0H3MZCcpV5eVcENwce1ZKh0q77wt6TZi+c46p3sRqye0P4Vl2q2R6fu8fIn6Wy0UV3w9s61ChiQNnS5XhkxHCUCCqjOaJQ/2BJdGBjKNSMROs3I60loFjFDA4NZlfN6rhxf2pxbpcFbMhTXUtLVP4D6OOyQn1LInlXezd7hP0YWBGMYkIBOrPw9ClDF4O8oHqIQQyqqb/lXWdlbERlXfTs9JCai35KpROdDihejpDPjce6VZ3BDLKGrQgqUoCTThtHBebpWi2Vt1iNO81p16TkI5FSDyA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kZpxMhwsTjbIV+K1wWl6Fm2iVxtSyXnw+2AXluB+P+A=; b=KlsR11lhDvL5bI5Lb0Orr7Fnr6tkktgHahDpxMbbU1dGBED4i6Ica55U+QmVx3ppDL8XwKvqgUhINkr5IkCvamcOpkdVg7UAlsKcel6dAEgQs2TlDEU9Lib0N20+tLxhsgn41FUg1WfG7TmxQfs3IFjpFi905DwYm4U3tj04aeg= Received: from VE1PR04MB6639.eurprd04.prod.outlook.com (10.255.118.11) by VE1PR04MB6461.eurprd04.prod.outlook.com (20.179.233.215) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2538.14; Thu, 12 Dec 2019 11:56:14 +0000 Received: from VE1PR04MB6639.eurprd04.prod.outlook.com ([fe80::e5c7:57d2:c566:9a2d]) by VE1PR04MB6639.eurprd04.prod.outlook.com ([fe80::e5c7:57d2:c566:9a2d%7]) with mapi id 15.20.2538.016; Thu, 12 Dec 2019 11:56:14 +0000 From: Akhil Goyal To: Adam Dybkowski , "dev@dpdk.org" , "fiona.trahe@intel.com" , "arkadiuszx.kusztal@intel.com" Thread-Topic: [PATCH 0/1] Refactor crypto unit tests. Thread-Index: AQHVsD2k51abGpDmTkuBDet4tEVIoqe2ZQSg Date: Thu, 12 Dec 2019 11:56:14 +0000 Message-ID: References: <20191211161015.9845-1-adamx.dybkowski@intel.com> In-Reply-To: <20191211161015.9845-1-adamx.dybkowski@intel.com> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=akhil.goyal@nxp.com; x-originating-ip: [92.120.1.65] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 66a592cf-533e-4f94-f678-08d77efa4a33 x-ms-traffictypediagnostic: VE1PR04MB6461: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-forefront-prvs: 0249EFCB0B x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(39860400002)(376002)(136003)(346002)(366004)(396003)(13464003)(189003)(199004)(9686003)(186003)(52536014)(76116006)(316002)(8936002)(8676002)(81166006)(81156014)(2906002)(44832011)(86362001)(66556008)(64756008)(66476007)(66446008)(66946007)(110136005)(7696005)(71200400001)(33656002)(53546011)(6506007)(478600001)(5660300002)(26005)(55016002); DIR:OUT; SFP:1101; SCL:1; SRVR:VE1PR04MB6461; H:VE1PR04MB6639.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: n6DGlFhyXOZpHt9elFhZboa6YCHc4L55NxKkPCjqOqVw7xIuG/23vZ5+/iCyFwiHzBOdH8dz9/Q/wq0W+ZYg6r0vhVTA7V+ukO+cqNtNOvMO2W4S/iFaOnqCPIafDFF+y8SMeSkHC9AfzXRA7yFjNVdBRRbAnmTy+9aZO2wQJOpOq/GgvrPJOo83zcMGIPRuWGzbz6RTVvdhxqyySTqvLmAaCxQeLgxlY0E0oU+6wgJK1HeMsHQQ8ruLXSMfXYoFHgjgMI0KWqby1NicnenwPHvRfY9K8D0rC4Dk8QZJQo6fYerf6rz8YBSZPcybft97FNWzZ2VvuNiYtESOZ1Cp2WI9lHjAi3/KlWzUub9mfkuvXGP5D7yeBspDsZcJpsBxpkozDXkKdG0o+g6W0N085lZOWIv5MmXp34VtoYGWujCxdjKGblqmgmzrO++CCYPTlxrrE0hD20DptDWhU/70kPcRq14LduQyk8y1XYMLzk2kqpOU6R8uear+ctnfJZbZ x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 66a592cf-533e-4f94-f678-08d77efa4a33 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Dec 2019 11:56:14.6808 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: TX+cfaYzlxIfTWXbwebmmJlhmAnpiCPAiWWCD8GJdRoXEe5wQny4blyVakzpzjaMNGdqIjF0zjVniYyC9PkdcA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6461 Subject: Re: [dpdk-dev] [PATCH 0/1] Refactor crypto unit tests. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Adam, This patch doesn't apply on TOT. Could you please rebase or let us know if = some dependent patch is there? Also, it would be nice if this patch can be broken into smaller patches, as= it is blocked by patchworks due to its length and it would be easier to re= view it.=20 Also, please add all crypto PMD owners in CC when you send the next version= . This would impact all of them. Thanks, Akhil > -----Original Message----- > From: Adam Dybkowski > Sent: Wednesday, December 11, 2019 9:40 PM > To: dev@dpdk.org; fiona.trahe@intel.com; Akhil Goyal ; > arkadiuszx.kusztal@intel.com > Cc: Adam Dybkowski > Subject: [PATCH 0/1] Refactor crypto unit tests. >=20 > This patch is a first step to refactor the overly complex symmetric > crypto unit tests. It merges many separate arrays of the tests > for these PMDs: null, aesni_mb, aesni_gcm, openssl, qat, sw_snow3g, > sw_kasumi, sw_zuc into one big array that's then used when running > unit tests on these PMDs. >=20 > Individual test functions check the capabilities and execute the rest > of the rest or skip (return -ENOTSUP) based on the particular test > requirements - e.g. test if PMD supports ZUC algo or even a particular > key length in few cases. Few edge cases required to check the PMD > itself (e.g. run on QAT only, or skip on AES NI / AES GCM). >=20 > It's the first step of bigger refactoring. Maintainers of other PMDs > are encouraged to add their PMD unit tests also into this big central > array and remove individual test macro arrays. >=20 > This patch doesn't address next refactoring steps to be done in the > future: geting rid of many small (usually 1-2 line) test functions, > created separately for every test case; and simplifying many bigger > functions that currently do similar things but work on different > test vector structures. >=20 > Adam Dybkowski (1): > test/crypto: refactor unit tests into one combined array >=20 > app/test/test_cryptodev.c | 16113 +++++++++---------- > app/test/test_cryptodev_blockcipher.c | 2 +- > app/test/test_cryptodev_des_test_vectors.h | 6 +- > 3 files changed, 7430 insertions(+), 8691 deletions(-) >=20 > -- > 2.17.1